X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/8907154c1a8a6882c6797d1f16393ddfb23e7f3a..b00403b401b75f95b6984cf5d0f6d71492f0a1f9:/src/common/process.cpp diff --git a/src/common/process.cpp b/src/common/process.cpp index 2e32b8cd74..db5eb5efad 100644 --- a/src/common/process.cpp +++ b/src/common/process.cpp @@ -30,7 +30,7 @@ // event tables and such // ---------------------------------------------------------------------------- -DEFINE_EVENT_TYPE(wxEVT_END_PROCESS) +wxDEFINE_EVENT( wxEVT_END_PROCESS, wxProcessEvent ); IMPLEMENT_DYNAMIC_CLASS(wxProcess, wxEvtHandler) IMPLEMENT_DYNAMIC_CLASS(wxProcessEvent, wxEvent) @@ -43,21 +43,13 @@ IMPLEMENT_DYNAMIC_CLASS(wxProcessEvent, wxEvent) // wxProcess creation // ---------------------------------------------------------------------------- -#if WXWIN_COMPATIBILITY_2_2 - -wxProcess::wxProcess(wxEvtHandler *parent, bool redirect) -{ - Init(parent, wxID_ANY, redirect ? wxPROCESS_REDIRECT : wxPROCESS_DEFAULT); -} - -#endif // WXWIN_COMPATIBILITY_2_2 - void wxProcess::Init(wxEvtHandler *parent, int id, int flags) { if ( parent ) SetNextHandler(parent); m_id = id; + m_pid = 0; m_redirect = (flags & wxPROCESS_REDIRECT) != 0; #if wxUSE_STREAMS @@ -72,13 +64,16 @@ wxProcess *wxProcess::Open(const wxString& cmd, int flags) { wxASSERT_MSG( !(flags & wxEXEC_SYNC), wxT("wxEXEC_SYNC should not be used." )); wxProcess *process = new wxProcess(wxPROCESS_REDIRECT); - if ( !wxExecute(cmd, flags, process) ) + long pid = wxExecute(cmd, flags, process); + if( !pid ) { // couldn't launch the process delete process; return NULL; } + process->SetPid(pid); + return process; } @@ -107,7 +102,13 @@ void wxProcess::OnTerminate(int pid, int status) void wxProcess::Detach() { - SetNextHandler(NULL); + // we just detach from the next handler of the chain (i.e. our "parent" -- see ctor) + // not also from the previous handler like wxEvtHandler::Unlink() would do: + + if (m_nextHandler) + m_nextHandler->SetPreviousHandler(m_previousHandler); + + m_nextHandler = NULL; } // ---------------------------------------------------------------------------- @@ -167,7 +168,7 @@ bool wxProcess::Exists(int pid) default: case wxKILL_ERROR: case wxKILL_BAD_SIGNAL: - wxFAIL_MSG( _T("unexpected wxProcess::Kill() return code") ); + wxFAIL_MSG( wxT("unexpected wxProcess::Kill() return code") ); // fall through case wxKILL_NO_PROCESS: