X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/8907154c1a8a6882c6797d1f16393ddfb23e7f3a..0e05227246cc99b2f8133ae639f38c508351afa0:/src/mac/carbon/dcclient.cpp

diff --git a/src/mac/carbon/dcclient.cpp b/src/mac/carbon/dcclient.cpp
index 64b73c74f4..7f14f9b53a 100644
--- a/src/mac/carbon/dcclient.cpp
+++ b/src/mac/carbon/dcclient.cpp
@@ -47,14 +47,16 @@ IMPLEMENT_DYNAMIC_CLASS(wxPaintDC, wxWindowDC)
 static wxBrush MacGetBackgroundBrush( wxWindow* window )
 {
     wxBrush bkdBrush = window->MacGetBackgroundBrush() ;
+
 #if !TARGET_API_MAC_OSX
     // transparency cannot be handled by the OS when not using composited windows
     wxWindow* parent = window->GetParent() ;
+
     // if we have some 'pseudo' transparency
     if ( ! bkdBrush.Ok() || bkdBrush.GetStyle() == wxTRANSPARENT || window->GetBackgroundColour() == wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE ) )
     {
         // walk up until we find something
-        while( parent != NULL )
+        while ( parent != NULL )
         {
             if ( parent->GetBackgroundColour() != wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE ) )
             {
@@ -62,11 +64,13 @@ static wxBrush MacGetBackgroundBrush( wxWindow* window )
                 bkdBrush.SetColour( parent->GetBackgroundColour() ) ;
                 break ;
             }
+
             if ( parent->IsKindOf( CLASSINFO(wxTopLevelWindow) ) )
             {
                 bkdBrush = parent->MacGetBackgroundBrush() ;
                 break ;
             }
+
             if ( parent->IsKindOf( CLASSINFO( wxNotebook ) ) || parent->IsKindOf( CLASSINFO( wxTabCtrl ) ) )
             {
                 Rect extent = { 0 , 0 , 0 , 0 } ;
@@ -86,16 +90,17 @@ static wxBrush MacGetBackgroundBrush( wxWindow* window )
             parent = parent->GetParent() ;  
         }
     }
+
     if ( !bkdBrush.Ok() || bkdBrush.GetStyle() == wxTRANSPARENT )
     {
         // if we did not find something, use a default
         bkdBrush.MacSetTheme( kThemeBrushDialogBackgroundActive ) ;
     }
-#endif    
+#endif
+
     return bkdBrush ;
 }    
 
-
 wxWindowDC::wxWindowDC() 
 {
     m_window = NULL ;
@@ -107,13 +112,15 @@ wxWindowDC::wxWindowDC(wxWindow *window)
     wxTopLevelWindowMac* rootwindow = window->MacGetTopLevelWindow() ;
     if (!rootwindow)
         return;
+
     WindowRef windowref = (WindowRef) rootwindow->MacGetWindowRef() ;
     int x , y ;
     x = y = 0 ;
     wxSize size = window->GetSize() ;
     window->MacWindowToRootWindow( &x , &y ) ;
     m_macPort = UMAGetWindowPort( windowref ) ;
-    
+    m_ok = true ;
+
 #if wxMAC_USE_CORE_GRAPHICS
     m_macLocalOriginInPort.x = x ;
     m_macLocalOriginInPort.y = y ;
@@ -123,7 +130,6 @@ wxWindowDC::wxWindowDC(wxWindow *window)
         m_graphicContext = new wxMacCGContext( (CGContextRef) window->MacGetCGContextRef() ) ;
         m_graphicContext->SetPen( m_pen ) ;
         m_graphicContext->SetBrush( m_brush ) ;
-        SetBackground(MacGetBackgroundBrush(window));        
     }
     else
     {
@@ -135,7 +141,6 @@ wxWindowDC::wxWindowDC(wxWindow *window)
         m_graphicContext = new wxMacCGContext( (CGrafPtr) m_macPort ) ;
         m_graphicContext->SetPen( m_pen ) ;
         m_graphicContext->SetBrush( m_brush ) ;
-        SetBackground(MacGetBackgroundBrush(window));
     }
     // there is no out-of-order drawing on OSX
 #else
@@ -144,9 +149,9 @@ wxWindowDC::wxWindowDC(wxWindow *window)
     CopyRgn( (RgnHandle) window->MacGetVisibleRegion(true).GetWXHRGN() , (RgnHandle) m_macBoundaryClipRgn ) ;
     OffsetRgn( (RgnHandle) m_macBoundaryClipRgn , m_macLocalOrigin.x , m_macLocalOrigin.y ) ;
     CopyRgn( (RgnHandle) m_macBoundaryClipRgn , (RgnHandle) m_macCurrentClipRgn ) ;
-    SetBackground(MacGetBackgroundBrush(window));
 #endif
-    m_ok = TRUE ;
+    SetBackground(MacGetBackgroundBrush(window));
+
     SetFont( window->GetFont() ) ;
 }
 
@@ -176,6 +181,7 @@ wxClientDC::wxClientDC(wxWindow *window)
     wxTopLevelWindowMac* rootwindow = window->MacGetTopLevelWindow() ;
     if (!rootwindow)
         return;
+
     WindowRef windowref = (WindowRef) rootwindow->MacGetWindowRef() ;
     wxPoint origin = window->GetClientAreaOrigin() ;
     wxSize size = window->GetClientSize() ;
@@ -184,7 +190,8 @@ wxClientDC::wxClientDC(wxWindow *window)
     y = origin.y ;
     window->MacWindowToRootWindow( &x , &y ) ;
     m_macPort = UMAGetWindowPort( windowref ) ;
-    
+    m_ok = true ;
+
 #if wxMAC_USE_CORE_GRAPHICS
     m_macLocalOriginInPort.x = x ;
     m_macLocalOriginInPort.y = y ;
@@ -193,20 +200,17 @@ wxClientDC::wxClientDC(wxWindow *window)
         m_graphicContext = new wxMacCGContext( (CGContextRef) window->MacGetCGContextRef() ) ;
         m_graphicContext->SetPen( m_pen ) ;
         m_graphicContext->SetBrush( m_brush ) ;
-        m_ok = TRUE ;    
         SetClippingRegion( 0 , 0 , size.x , size.y ) ;
-        SetBackground(MacGetBackgroundBrush(window));
     }
     else
     {
-        // as out of order redraw is not supported under CQ, we have to create a qd port for these
-        // situations
+        // as out of order redraw is not supported under CQ,
+        // we have to create a QD port for these situations
         m_macLocalOrigin.x = x ;
         m_macLocalOrigin.y = y ;
         m_graphicContext = new wxMacCGContext( (CGrafPtr) m_macPort ) ;
         m_graphicContext->SetPen( m_pen ) ;
         m_graphicContext->SetBrush( m_brush ) ;
-        m_ok = TRUE ;    
      }
 #else
     m_macLocalOrigin.x = x ;
@@ -216,8 +220,8 @@ wxClientDC::wxClientDC(wxWindow *window)
     OffsetRgn( (RgnHandle) m_macBoundaryClipRgn , -origin.x , -origin.y ) ;
     OffsetRgn( (RgnHandle) m_macBoundaryClipRgn , m_macLocalOrigin.x , m_macLocalOrigin.y ) ;
     CopyRgn( (RgnHandle) m_macBoundaryClipRgn ,(RgnHandle)  m_macCurrentClipRgn ) ;
-    m_ok = TRUE ;
 #endif
+
     SetBackground(MacGetBackgroundBrush(window));
     SetFont( window->GetFont() ) ;
 }
@@ -242,7 +246,6 @@ void wxClientDC::DoGetSize(int *width, int *height) const
     m_window->GetClientSize( width, height );
 }
 
-
 /*
  * wxPaintDC
  */
@@ -264,6 +267,8 @@ wxPaintDC::wxPaintDC(wxWindow *window)
     y = origin.y ;
     window->MacWindowToRootWindow( &x , &y ) ;
     m_macPort = UMAGetWindowPort( windowref ) ;
+    m_ok = true ;
+
 #if wxMAC_USE_CORE_GRAPHICS
     m_macLocalOriginInPort.x = x ;
     m_macLocalOriginInPort.y = y ;
@@ -272,7 +277,6 @@ wxPaintDC::wxPaintDC(wxWindow *window)
         m_graphicContext = new wxMacCGContext( (CGContextRef) window->MacGetCGContextRef() ) ;
         m_graphicContext->SetPen( m_pen ) ;
         m_graphicContext->SetBrush( m_brush ) ;
-        m_ok = TRUE ;
         SetClippingRegion( 0 , 0 , size.x , size.y ) ;
         SetBackground(MacGetBackgroundBrush(window));
     }
@@ -280,7 +284,6 @@ wxPaintDC::wxPaintDC(wxWindow *window)
     {
         wxLogDebug(wxT("You cannot create a wxPaintDC outside an OS-draw event") ) ;
         m_graphicContext = NULL ;
-        m_ok = TRUE ;
     }
     // there is no out-of-order drawing on OSX
 #else
@@ -293,8 +296,8 @@ wxPaintDC::wxPaintDC(wxWindow *window)
     OffsetRgn( (RgnHandle) m_macBoundaryClipRgn , m_macLocalOrigin.x , m_macLocalOrigin.y ) ;
     CopyRgn( (RgnHandle) m_macBoundaryClipRgn , (RgnHandle) m_macCurrentClipRgn ) ;
     SetBackground(MacGetBackgroundBrush(window));
-    m_ok = TRUE ;
 #endif
+
     SetFont( window->GetFont() ) ;
 }
 
@@ -308,5 +311,3 @@ void wxPaintDC::DoGetSize(int *width, int *height) const
 
     m_window->GetClientSize( width, height );
 }
-
-