X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/889f0b7c67f207f230d8bf9f558ae35445d57e10..d21d2e5adf7a5acf3b496a9c4e87eab220bd75d8:/src/msw/combobox.cpp?ds=inline diff --git a/src/msw/combobox.cpp b/src/msw/combobox.cpp index fafda5dd76..470a02654c 100644 --- a/src/msw/combobox.cpp +++ b/src/msw/combobox.cpp @@ -41,7 +41,7 @@ #include "wx/msw/private.h" #if wxUSE_TOOLTIPS - #ifndef __GNUWIN32_OLD__ + #if !defined(__GNUWIN32_OLD__) || defined(__CYGWIN10__) #include #endif #include "wx/tooltip.h" @@ -115,7 +115,7 @@ LRESULT APIENTRY _EXPORT wxComboEditWndProc(HWND hWnd, #endif // 0 // deal with tooltips here -#if wxUSE_TOOLTIPS +#if wxUSE_TOOLTIPS && defined(TTN_NEEDTEXT) case WM_NOTIFY: { wxCHECK_MSG( win, 0, _T("should have a parent") ); @@ -230,11 +230,24 @@ bool wxComboBox::MSWCommand(WXUINT param, WXWORD WXUNUSED(id)) case CBN_EDITCHANGE: { + wxCommandEvent event(wxEVT_COMMAND_TEXT_UPDATED, GetId()); + // if sel != -1, value was initialized above (and we can't use // GetValue() here as it would return the old selection and we // want the new one) - wxCommandEvent event(wxEVT_COMMAND_TEXT_UPDATED, GetId()); - event.SetString(sel == -1 ? GetValue() : value); + if ( sel == -1 ) + { + value = GetValue(); + } + else // we're synthesizing text updated event from sel change + { + // we need to do this because the user code expects + // wxComboBox::GetValue() to return the new value from + // "text updated" handler but it hadn't been updated yet + SetValue(value); + } + + event.SetString(value); event.SetEventObject(this); ProcessCommand(event); }