X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/83c865f51868366fcf48b4188144e26c648cbc7c..9f4de6b2cf06f53a98b28f53640f3b9ec8cf4182:/src/common/containr.cpp?ds=sidebyside

diff --git a/src/common/containr.cpp b/src/common/containr.cpp
index 5ad3a7f006..90a20eb833 100644
--- a/src/common/containr.cpp
+++ b/src/common/containr.cpp
@@ -50,6 +50,12 @@ wxControlContainer::wxControlContainer(wxWindow *winParent)
 
 void wxControlContainer::SetLastFocus(wxWindow *win)
 {
+    // the panel itself should never get the focus at all but if it does happen
+    // temporarily (as it seems to do under wxGTK), at the very least don't
+    // forget our previous m_winLastFocused
+    if ( win == m_winParent )
+        return;
+
     // if we're setting the focus
     if ( win )
     {
@@ -60,12 +66,27 @@ void wxControlContainer::SetLastFocus(wxWindow *win)
         {
             win = winParent;
             winParent = win->GetParent();
-        }
 
-        wxASSERT_MSG( win, _T("attempt to set last focus to not a child?") );
+            // Yes, this can happen, though in a totally pathological case.
+            // like when detaching a menubar from a frame with a child which
+            // has pushed itself as an event handler for the menubar.  (wxGtk)
+
+            wxASSERT_MSG( winParent, _T("Setting last-focus for a window that is not our child?") );
+        }
     }
 
     m_winLastFocused = win;
+
+    if ( win )
+    {
+        wxLogTrace(_T("focus"), _T("Set last focus to %s(%s)"),
+                   win->GetClassInfo()->GetClassName(),
+                   win->GetLabel().c_str());
+    }
+    else
+    {
+        wxLogTrace(_T("focus"), _T("No more last focus"));
+    }
 }
 
 // ----------------------------------------------------------------------------
@@ -216,7 +237,7 @@ void wxControlContainer::HandleOnNavigationKey( wxNavigationKeyEvent& event )
             if ( !child->GetEventHandler()->ProcessEvent(event) )
             {
                 // everything is simple: just give focus to it
-                child->SetFocus();
+                child->SetFocusFromKbd();
 
                 m_winLastFocused = child;
             }
@@ -339,7 +360,7 @@ bool wxSetFocusToChild(wxWindow *win, wxWindow **childLastFocused)
                        _T("SetFocusToChild() => last child (0x%08x)."),
                        (*childLastFocused)->GetHandle());
 
-            (*childLastFocused)->SetFocus();
+            (*childLastFocused)->SetFocusFromKbd();
             return TRUE;
         }
         else
@@ -362,7 +383,7 @@ bool wxSetFocusToChild(wxWindow *win, wxWindow **childLastFocused)
                        child->GetHandle());
 
             *childLastFocused = child;  // should be redundant, but it is not
-            child->SetFocus();
+            child->SetFocusFromKbd();
             return TRUE;
         }