X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/83141d3a74bc3ce6b97632dec8b28b7569c480a2..757cc9def70e4685054f4a24238e2df111f6c9fd:/src/common/mstream.cpp?ds=sidebyside

diff --git a/src/common/mstream.cpp b/src/common/mstream.cpp
index b0f1ab6a1a..9226ce4461 100644
--- a/src/common/mstream.cpp
+++ b/src/common/mstream.cpp
@@ -1,14 +1,22 @@
 /////////////////////////////////////////////////////////////////////////////
-// Name:        mstream.cpp
+// Name:        src/common/mstream.cpp
 // Purpose:     "Memory stream" classes
 // Author:      Guilhem Lavaux
-// Modified by:
+// Modified by: VZ (23.11.00): general code review
 // Created:     04/01/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Guilhem Lavaux
 // Licence:     wxWindows license
 /////////////////////////////////////////////////////////////////////////////
 
+// ============================================================================
+// declarations
+// ============================================================================
+
+// ----------------------------------------------------------------------------
+// headers
+// ----------------------------------------------------------------------------
+
 #ifdef __GNUG__
 #pragma implementation "mstream.h"
 #endif
@@ -26,34 +34,39 @@
 #include "wx/stream.h"
 #include "wx/mstream.h"
 
+// ============================================================================
+// implementation
+// ============================================================================
+
 // ----------------------------------------------------------------------------
 // wxMemoryInputStream
 // ----------------------------------------------------------------------------
 
-wxMemoryInputStream::wxMemoryInputStream(const char *data, size_t len)
-  : wxInputStream()
+wxMemoryInputStream::wxMemoryInputStream(const void *data, size_t len)
 {
-  m_i_streambuf = new wxStreamBuffer(wxStreamBuffer::read);
-  m_i_streambuf->SetBufferIO((char*) data, (char*) (data+len));
-  m_i_streambuf->SetIntPosition(0); // seek to start pos
-  m_i_streambuf->Fixed(TRUE);
+    m_i_streambuf = new wxStreamBuffer(wxStreamBuffer::read);
+    m_i_streambuf->SetBufferIO((void *)data, len); // const_cast
+    m_i_streambuf->SetIntPosition(0); // seek to start pos
+    m_i_streambuf->Fixed(TRUE);
 
-  m_length = len;
+    m_length = len;
 }
 
 wxMemoryInputStream::~wxMemoryInputStream()
 {
-  delete m_i_streambuf;
+    delete m_i_streambuf;
 }
 
 char wxMemoryInputStream::Peek()
 {
-  return m_i_streambuf->GetBufferStart()[m_i_streambuf->GetIntPosition()];
+    char *buf = (char *)m_i_streambuf->GetBufferStart();
+
+    return buf[m_i_streambuf->GetIntPosition()];
 }
 
 bool wxMemoryInputStream::Eof() const
 {
-    return m_i_streambuf->GetBufferPos() == m_i_streambuf->GetBufferEnd();
+    return !m_i_streambuf->GetBytesLeft();
 }
 
 size_t wxMemoryInputStream::OnSysRead(void *buffer, size_t nbytes)
@@ -74,63 +87,65 @@ size_t wxMemoryInputStream::OnSysRead(void *buffer, size_t nbytes)
 
 off_t wxMemoryInputStream::OnSysSeek(off_t pos, wxSeekMode mode)
 {
-  return m_i_streambuf->Seek(pos, mode);
+    return m_i_streambuf->Seek(pos, mode);
 }
 
 off_t wxMemoryInputStream::OnSysTell() const
 {
-  return m_i_streambuf->Tell();
+    return m_i_streambuf->Tell();
 }
 
 // ----------------------------------------------------------------------------
 // wxMemoryOutputStream
 // ----------------------------------------------------------------------------
 
-wxMemoryOutputStream::wxMemoryOutputStream(char *data, size_t len)
-  : wxOutputStream()
+wxMemoryOutputStream::wxMemoryOutputStream(void *data, size_t len)
 {
-  m_o_streambuf = new wxStreamBuffer(wxStreamBuffer::write);
-  if (data)
-    m_o_streambuf->SetBufferIO(data, data+len);
-  m_o_streambuf->Fixed(FALSE);
-  m_o_streambuf->Flushable(FALSE);
+    m_o_streambuf = new wxStreamBuffer(wxStreamBuffer::write);
+    if ( data )
+        m_o_streambuf->SetBufferIO(data, len);
+    m_o_streambuf->Fixed(FALSE);
+    m_o_streambuf->Flushable(FALSE);
 }
 
 wxMemoryOutputStream::~wxMemoryOutputStream()
 {
-  delete m_o_streambuf;
+    delete m_o_streambuf;
 }
 
 size_t wxMemoryOutputStream::OnSysWrite(const void *buffer, size_t nbytes)
 {
-  size_t bufsize = m_o_streambuf->GetBufferEnd() - m_o_streambuf->GetBufferStart();
-  size_t oldpos = m_o_streambuf->GetIntPosition();
-  m_o_streambuf->Write(buffer, nbytes);
-  size_t newpos = m_o_streambuf->GetIntPosition();
-  if (newpos == 0) return bufsize - oldpos;
-  else return newpos - oldpos;
+    size_t oldpos = m_o_streambuf->GetIntPosition();
+    m_o_streambuf->Write(buffer, nbytes);
+    size_t newpos = m_o_streambuf->GetIntPosition();
+
+    // FIXME can someone please explain what this does? (VZ)
+    if ( !newpos )
+        newpos = m_o_streambuf->GetBufferSize();
+
+    return newpos - oldpos;
 }
 
 off_t wxMemoryOutputStream::OnSysSeek(off_t pos, wxSeekMode mode)
 {
-  return m_o_streambuf->Seek(pos, mode);
+    return m_o_streambuf->Seek(pos, mode);
 }
 
 off_t wxMemoryOutputStream::OnSysTell() const
 {
-  return m_o_streambuf->Tell();
+    return m_o_streambuf->Tell();
 }
 
-size_t wxMemoryOutputStream::CopyTo(char *buffer, size_t len) const
+size_t wxMemoryOutputStream::CopyTo(void *buffer, size_t len) const
 {
-  if (!buffer)
-    return 0;
+    wxCHECK_MSG( buffer, 0, _T("must have buffer to CopyTo") );
 
-  if (len > GetSize())
-    len = GetSize();
+    if ( len > GetSize() )
+        len = GetSize();
 
-  memcpy(buffer, m_o_streambuf->GetBufferStart(), len);
-  return len;
+    memcpy(buffer, m_o_streambuf->GetBufferStart(), len);
+
+    return len;
 }
 
-#endif
+#endif // wxUSE_STREAMS