X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/805dd538bba63cac619b96710088652864627526..518b5d2ffbaf7422195537a5512e791be4497591:/src/gtk/textctrl.cpp diff --git a/src/gtk/textctrl.cpp b/src/gtk/textctrl.cpp index 28d27d198c..7c6817aa3e 100644 --- a/src/gtk/textctrl.cpp +++ b/src/gtk/textctrl.cpp @@ -127,6 +127,8 @@ bool wxTextCtrl::Create( wxWindow *parent, wxWindowID id, const wxString &value, // ... and put into the upper left hand corner of the table m_widget = gtk_table_new(bHasHScrollbar ? 2 : 1, 2, FALSE); + GTK_WIDGET_UNSET_FLAGS( m_widget, GTK_CAN_FOCUS ); + gtk_table_attach( GTK_TABLE(m_widget), m_text, 0, 1, 0, 1, (GtkAttachOptions)(GTK_FILL | GTK_EXPAND | GTK_SHRINK), (GtkAttachOptions)(GTK_FILL | GTK_EXPAND | GTK_SHRINK), @@ -136,6 +138,8 @@ bool wxTextCtrl::Create( wxWindow *parent, wxWindowID id, const wxString &value, if (bHasHScrollbar) { GtkWidget *hscrollbar = gtk_hscrollbar_new(GTK_TEXT(m_text)->hadj); + GTK_WIDGET_UNSET_FLAGS( hscrollbar, GTK_CAN_FOCUS ); + gtk_table_attach(GTK_TABLE(m_widget), hscrollbar, 0, 1, 1, 2, (GtkAttachOptions)(GTK_EXPAND | GTK_FILL), GTK_FILL, @@ -145,6 +149,8 @@ bool wxTextCtrl::Create( wxWindow *parent, wxWindowID id, const wxString &value, // finally, put the vertical scrollbar in the upper right corner m_vScrollbar = gtk_vscrollbar_new( GTK_TEXT(m_text)->vadj ); + GTK_WIDGET_UNSET_FLAGS( m_vScrollbar, GTK_CAN_FOCUS ); + gtk_table_attach(GTK_TABLE(m_widget), m_vScrollbar, 1, 2, 0, 1, GTK_FILL, (GtkAttachOptions)(GTK_EXPAND | GTK_FILL | GTK_SHRINK), @@ -182,11 +188,17 @@ bool wxTextCtrl::Create( wxWindow *parent, wxWindowID id, const wxString &value, gtk_signal_connect( GTK_OBJECT(m_text), "changed", GTK_SIGNAL_FUNC(gtk_text_changed_callback), (gpointer)this); - if (!value.IsNull()) + if (!value.IsEmpty()) { gint tmp = 0; gtk_editable_insert_text( GTK_EDITABLE(m_text), value, value.Length(), &tmp ); - SetInsertionPointEnd(); + + if (multi_line) + { + /* bring editable's cursor uptodate. bug in GTK. */ + + GTK_EDITABLE(m_text)->current_pos = gtk_text_get_point( GTK_TEXT(m_text) ); + } } if (style & wxTE_PASSWORD) @@ -286,8 +298,40 @@ void wxTextCtrl::WriteText( const wxString &text ) if (m_windowStyle & wxTE_MULTILINE) { + /* this moves the cursor pos to behind the inserted text */ + gint len = GTK_EDITABLE(m_text)->current_pos; + + gtk_editable_insert_text( GTK_EDITABLE(m_text), text, text.Length(), &len ); + + /* bring editable's cursor uptodate. bug in GTK. */ + GTK_EDITABLE(m_text)->current_pos = gtk_text_get_point( GTK_TEXT(m_text) ); + } + else + { + /* this moves the cursor pos to behind the inserted text */ + gint len = GTK_EDITABLE(m_text)->current_pos; + gtk_editable_insert_text( GTK_EDITABLE(m_text), text, text.Length(), &len ); + + /* bring editable's cursor uptodate. bug in GTK. */ + GTK_EDITABLE(m_text)->current_pos += text.Len(); + + /* bring entry's cursor uptodate. bug in GTK. */ + gtk_entry_set_position( GTK_ENTRY(m_text), GTK_EDITABLE(m_text)->current_pos ); + } +} + +void wxTextCtrl::AppendText( const wxString &text ) +{ + wxCHECK_RET( m_text != NULL, "invalid text ctrl" ); + + if (m_windowStyle & wxTE_MULTILINE) + { + /* we'll insert at the last position */ gint len = gtk_text_get_length( GTK_TEXT(m_text) ); gtk_editable_insert_text( GTK_EDITABLE(m_text), text, text.Length(), &len ); + + /* bring editable's cursor uptodate. bug in GTK. */ + GTK_EDITABLE(m_text)->current_pos = gtk_text_get_point( GTK_TEXT(m_text) ); } else { @@ -372,13 +416,13 @@ bool wxTextCtrl::SaveFile( const wxString &file ) } if (fwrite (text, sizeof (char), len, fp) != (size_t) len) - { - // Did not write whole file - } + { + // Did not write whole file + } // Make sure newline terminates the file if (text[len - 1] != '\n') - fputc ('\n', fp); + fputc ('\n', fp); fclose (fp); @@ -426,34 +470,51 @@ wxString wxTextCtrl::GetLineText( long lineNo ) const void wxTextCtrl::OnDropFiles( wxDropFilesEvent &WXUNUSED(event) ) { + /* If you implement this, don't forget to update the documentation! + * (file docs/latex/wx/text.tex) */ wxFAIL_MSG( "wxTextCtrl::OnDropFiles not implemented" ); } long wxTextCtrl::PositionToXY(long pos, long *x, long *y ) const { - if (!(m_windowStyle & wxTE_MULTILINE)) - return 0; - gint len = gtk_text_get_length( GTK_TEXT(m_text) ); - char *text = gtk_editable_get_chars( GTK_EDITABLE(m_text), 0, len ); - if(!text) - return 0; - if( pos >= len) - return pos=len-1; - - *x=1; // Col 1 - *y=1; // Line 1 - for (int i = 0; i < pos; i++ ) - { - if (text[i] == '\n') + if ( m_windowStyle & wxTE_MULTILINE ) { - (*y)++; - *x=1; + wxString text = GetValue(); + + // cast to prevent warning. But pos really should've been unsigned. + if( (unsigned long)pos > text.Len() ) + return FALSE; + + *x=0; // First Col + *y=0; // First Line + + const char* stop = text.c_str() + pos; + for ( const char *p = text.c_str(); p < stop; p++ ) + { + if (*p == '\n') + { + (*y)++; + *x=0; + } + else + (*x)++; + } } - else - (*x)++; + else // single line control + { + if ( pos <= GTK_ENTRY(m_text)->text_length ) + { + *y = 0; + *x = pos; + } + else + { + // index out of bounds + return FALSE; + } } - g_free( text ); - return 1; + + return TRUE; } long wxTextCtrl::XYToPosition(long x, long y ) const @@ -461,10 +522,9 @@ long wxTextCtrl::XYToPosition(long x, long y ) const if (!(m_windowStyle & wxTE_MULTILINE)) return 0; long pos=0; + for( int i=0; icurrent_pos = gtk_text_get_point( GTK_TEXT(m_text) ); + } else - gtk_entry_set_position( GTK_ENTRY(m_text), tmp ); + { + gtk_entry_set_position( GTK_ENTRY(m_text), (int)pos ); + + /* bring editable's cursor uptodate. bug in GTK. */ + + GTK_EDITABLE(m_text)->current_pos = pos; + } } void wxTextCtrl::SetInsertionPointEnd() { wxCHECK_RET( m_text != NULL, "invalid text ctrl" ); - SetInsertionPoint(-1); + if (m_windowStyle & wxTE_MULTILINE) + SetInsertionPoint(gtk_text_get_length(GTK_TEXT(m_text))); + else + gtk_entry_set_position( GTK_ENTRY(m_text), -1 ); } void wxTextCtrl::SetEditable( bool editable ) @@ -560,7 +651,7 @@ long wxTextCtrl::GetLastPosition() const else pos = GTK_ENTRY(m_text)->text_length; - return (long)pos-1; + return (long)pos; } void wxTextCtrl::Remove( long from, long to ) @@ -664,7 +755,7 @@ int wxTextCtrl::underflow() wxTextCtrl& wxTextCtrl::operator<<(const wxString& s) { - WriteText(s); + AppendText(s); return *this; } @@ -672,7 +763,7 @@ wxTextCtrl& wxTextCtrl::operator<<(float f) { static char buf[100]; sprintf(buf, "%.2f", f); - WriteText(buf); + AppendText(buf); return *this; } @@ -680,7 +771,7 @@ wxTextCtrl& wxTextCtrl::operator<<(double d) { static char buf[100]; sprintf(buf, "%.2f", d); - WriteText(buf); + AppendText(buf); return *this; } @@ -688,7 +779,7 @@ wxTextCtrl& wxTextCtrl::operator<<(int i) { static char buf[100]; sprintf(buf, "%i", i); - WriteText(buf); + AppendText(buf); return *this; } @@ -696,7 +787,7 @@ wxTextCtrl& wxTextCtrl::operator<<(long i) { static char buf[100]; sprintf(buf, "%ld", i); - WriteText(buf); + AppendText(buf); return *this; } @@ -706,7 +797,7 @@ wxTextCtrl& wxTextCtrl::operator<<(const char c) buf[0] = c; buf[1] = 0; - WriteText(buf); + AppendText(buf); return *this; } #endif