X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/7c74e7fe1de14f32dcd6f3c9cdd727de540bbd0e..0d6ae333cdbbc27b042ca728e5c06ec569af0731:/src/mac/dialog.cpp diff --git a/src/mac/dialog.cpp b/src/mac/dialog.cpp index d0068bc451..044002d970 100644 --- a/src/mac/dialog.cpp +++ b/src/mac/dialog.cpp @@ -44,8 +44,7 @@ END_EVENT_TABLE() wxDialog::wxDialog() { - m_isShown = FALSE; - m_modalShowing = FALSE; + m_isShown = FALSE; SetBackgroundColour(wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DFACE)); } @@ -56,15 +55,8 @@ bool wxDialog::Create(wxWindow *parent, wxWindowID id, long style, const wxString& name) { - m_windowStyle = style; - m_isShown = FALSE; - m_modalShowing = FALSE; -#if wxUSE_TOOLTIPS - m_hwndToolTip = 0; -#endif SetBackgroundColour(wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DFACE)); - SetName(name); if (!parent) wxTopLevelWindows.Append(this); @@ -76,59 +68,26 @@ bool wxDialog::Create(wxWindow *parent, wxWindowID id, else m_windowId = id; - Rect theBoundsRect; - - m_x = (int)pos.x; - m_y = (int)pos.y; - if ( m_y < 50 ) - m_y = 50 ; - if ( m_x < 20 ) - m_x = 20 ; - - m_width = size.x; - if (m_width == -1) - m_width = 20; - m_height = size.y; - if (m_height == -1) - m_height = 20; - - ::SetRect(&theBoundsRect, m_x, m_y, m_x + m_width, m_y + m_height); - m_macWindowData = new MacWindowData() ; - - WindowClass wclass = kMovableModalWindowClass ; - WindowAttributes attr = kWindowNoAttributes ; - - if ( ( m_windowStyle & wxMINIMIZE_BOX ) || ( m_windowStyle & wxMAXIMIZE_BOX ) ) - { - attr |= kWindowFullZoomAttribute ; - attr |= kWindowResizableAttribute ; - } + MacCreateRealWindow( title , pos , size , MacRemoveBordersFromStyle(style) , name ) ; - UMACreateNewWindow( wclass , attr , &theBoundsRect , &m_macWindowData->m_macWindow ) ; - wxAssociateWinWithMacWindow( m_macWindowData->m_macWindow , this ) ; - wxString label ; - if( wxApp::s_macDefaultEncodingIsPC ) - label = wxMacMakeMacStringFromPC( title ) ; - else - label = title ; - UMASetWTitleC( m_macWindowData->m_macWindow , label ) ; m_macWindowData->m_macWindowBackgroundTheme = kThemeBrushDialogBackgroundActive ; - UMACreateRootControl( m_macWindowData->m_macWindow , &m_macWindowData->m_macRootControl ) ; - m_macWindowData->m_macFocus = NULL ; return TRUE; } void wxDialog::SetModal(bool flag) { - if ( flag ) - m_windowStyle |= wxDIALOG_MODAL ; - else - if ( m_windowStyle & wxDIALOG_MODAL ) - m_windowStyle -= wxDIALOG_MODAL ; - - wxModelessWindows.DeleteObject(this); - if (!flag) - wxModelessWindows.Append(this); + if ( flag ) + { + m_windowStyle |= wxDIALOG_MODAL; + + wxModelessWindows.DeleteObject(this); + } + else + { + m_windowStyle &= ~wxDIALOG_MODAL; + + wxModelessWindows.Append(this); + } } wxDialog::~wxDialog() @@ -136,10 +95,10 @@ wxDialog::~wxDialog() m_isBeingDeleted = TRUE ; wxTopLevelWindows.DeleteObject(this); - m_modalShowing = FALSE; + Show(FALSE); - if ( (GetWindowStyleFlag() & wxDIALOG_MODAL) != wxDIALOG_MODAL ) - wxModelessWindows.DeleteObject(this); + if ( !IsModal() ) + wxModelessWindows.DeleteObject(this); // If this is the last top-level window, exit. if (wxTheApp && (wxTopLevelWindows.Number() == 0)) @@ -186,19 +145,20 @@ void wxDialog::DoSetClientSize(int width, int height) wxWindow::DoSetClientSize( width , height ) ; } -void wxDialog::GetPosition(int *x, int *y) const +void wxDialog::DoGetPosition(int *x, int *y) const { - DoGetPosition( x , y ) ; + wxWindow::DoGetPosition( x , y ) ; } -bool wxDialog::IsShown() const +bool wxDialog::IsModal() const { - return m_isShown; + return (GetWindowStyleFlag() & wxDIALOG_MODAL) != 0; } -bool wxDialog::IsModal() const + +bool wxDialog::IsModalShowing() const { - return wxModalDialogs.Find((wxDialog *)this) != 0; // const_cast + return wxModalDialogs.Find((wxDialog *)this) != NULL; // const_cast } @@ -206,122 +166,78 @@ extern bool s_macIsInModalLoop ; bool wxDialog::Show(bool show) { - m_isShown = show; - - if (show) - InitDialog(); + if ( !wxDialogBase::Show(show) ) + { + // nothing to do + return FALSE; + } - bool modal = ((GetWindowStyleFlag() & wxDIALOG_MODAL) == wxDIALOG_MODAL) ; + if ( show ) + { + // usually will result in TransferDataToWindow() being called + InitDialog(); + } -#if WXGARBAGE_COLLECTION_ON /* MATTHEW: GC */ - if (!modal) - { - if (show) + if ( IsModal() ) { - if (!wxModelessWindows.Find(this)) - wxModelessWindows.Append(this); - } - else - wxModelessWindows.DeleteObject(this); - } - if (show) - { - if (!wxTopLevelWindows.Find(this)) - wxTopLevelWindows.Append(this); - } - else - wxTopLevelWindows.DeleteObject(this); -#endif + if ( show ) + { + DoShowModal(); + } + else // end of modal dialog + { + // this will cause IsModalShowing() return FALSE and our local + // message loop will terminate + wxModalDialogs.DeleteObject(this); + } + } - if ( modal ) - { - s_macIsInModalLoop = true ; - if (show) - { - if (m_modalShowing) - { -// BringWindowToTop((HWND) GetHWND()); - return TRUE; - } - - m_modalShowing = TRUE; - // if we don't do it, some window might be deleted while we have pointers - // to them in our disabledWindows list and the program will crash when it - // will try to reenable them after the modal dialog end - wxTheApp->DeletePendingObjects(); - - UMAShowWindow( m_macWindowData->m_macWindow ) ; - UMASelectWindow( m_macWindowData->m_macWindow ) ; - - if (!wxModalDialogs.Member(this)) - wxModalDialogs.Append(this); - - while (wxModalDialogs.Member(this) ) - { - wxTheApp->MacDoOneEvent() ; - } - } - else - { - wxModalDialogs.DeleteObject(this); - UMAHideWindow( m_macWindowData->m_macWindow ) ; - } - s_macIsInModalLoop = false ; - } - else // !modal - { - if (show) - { - UMAShowWindow( m_macWindowData->m_macWindow ) ; - UMASelectWindow( m_macWindowData->m_macWindow ) ; - } - else - { - UMAHideWindow( m_macWindowData->m_macWindow ) ; - } - } - return TRUE ; + return TRUE; } -void wxDialog::SetTitle(const wxString& title) +void wxDialog::DoShowModal() { - wxWindow::SetTitle( title ) ; -} + wxCHECK_RET( !IsModalShowing(), _T("DoShowModal() called twice") ); -wxString wxDialog::GetTitle() const -{ - return wxWindow::GetTitle() ; -} + wxModalDialogs.Append(this); -void wxDialog::Centre(int direction) -{ - int x_offset,y_offset ; - int display_width, display_height; - int width, height, x, y; - wxWindow *parent = GetParent(); - if ((direction & wxCENTER_FRAME) && parent) - { - parent->GetPosition(&x_offset,&y_offset) ; - parent->GetSize(&display_width,&display_height) ; - } - else - { - wxDisplaySize(&display_width, &display_height); - x_offset = 0 ; - y_offset = 0 ; - } + wxWindow *parent = GetParent(); - GetSize(&width, &height); - GetPosition(&x, &y); + // remember where the focus was + wxWindow *winFocus = FindFocus(); + if ( !winFocus ) + { + winFocus = parent; + } + if ( !winFocus ) + { + winFocus = wxTheApp->GetTopWindow(); + } + // TODO : test whether parent gets disabled - if (direction & wxHORIZONTAL) - x = (int)((display_width - width)/2); - if (direction & wxVERTICAL) - y = (int)((display_height - height)/2); + bool formerModal = s_macIsInModalLoop ; + s_macIsInModalLoop = true ; - SetSize(x+x_offset, y+y_offset, width, height); + while ( IsModalShowing() ) + { + while ( !wxTheApp->Pending() && wxTheApp->ProcessIdle() ) + { + } + wxTheApp->MacDoOneEvent() ; + } + + s_macIsInModalLoop = formerModal ; + + // TODO probably reenable the parent window if any + + // and restore focus + if ( winFocus ) + { + winFocus->SetFocus(); + } } + // Replacement for Show(TRUE) for modal dialogs - returns return code int wxDialog::ShowModal() { @@ -330,6 +246,8 @@ int wxDialog::ShowModal() return GetReturnCode(); } +// NB: this function (surprizingly) may be called for both modal and modeless +// dialogs and should work for both of them void wxDialog::EndModal(int retCode) { SetReturnCode(retCode); @@ -341,13 +259,7 @@ void wxDialog::OnOK(wxCommandEvent& event) { if ( Validate() && TransferDataFromWindow() ) { - if ( IsModal() ) - EndModal(wxID_OK); - else - { - SetReturnCode(wxID_OK); - this->Show(FALSE); - } + EndModal(wxID_OK); } } @@ -360,20 +272,7 @@ void wxDialog::OnApply(wxCommandEvent& event) void wxDialog::OnCancel(wxCommandEvent& event) { - if ( IsModal() ) EndModal(wxID_CANCEL); - else - { - SetReturnCode(wxID_CANCEL); - this->Show(FALSE); - } -} - -void wxDialog::OnPaint(wxPaintEvent& event) -{ - // No: if you call the default procedure, it makes - // the following painting code not work. -// wxWindow::OnPaint(event); } void wxDialog::OnCloseWindow(wxCloseEvent& event) @@ -409,30 +308,16 @@ void wxDialog::OnCloseWindow(wxCloseEvent& event) // Destroy the window (delayed, if a managed window) bool wxDialog::Destroy() { - if (!wxPendingDelete.Member(this)) + wxCHECK_MSG( !wxPendingDelete.Member(this), FALSE, + _T("wxDialog destroyed twice") ); + wxPendingDelete.Append(this); return TRUE; } -void wxDialog::OnSize(wxSizeEvent& WXUNUSED(event)) -{ - // if we're using constraints - do use them - #if wxUSE_CONSTRAINTS - if ( GetAutoLayout() ) - { - Layout(); - } - #endif -} - void wxDialog::OnSysColourChanged(wxSysColourChangedEvent& event) { SetBackgroundColour(wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DFACE)); Refresh(); } -void wxDialog::Fit() -{ - wxWindow::Fit(); -} -