X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/7613582bcc61ea43892fb36bea8b2c2e9ee9b7ac..c74d8df09d0c0e182cb2063cc4cc546de3a00fae:/src/common/filename.cpp diff --git a/src/common/filename.cpp b/src/common/filename.cpp index 2bb2b0be19..df431a87a5 100644 --- a/src/common/filename.cpp +++ b/src/common/filename.cpp @@ -61,55 +61,56 @@ // ---------------------------------------------------------------------------- #ifdef __GNUG__ - #pragma implementation "filename.h" +#pragma implementation "filename.h" #endif // For compilers that support precompilation, includes "wx.h". #include "wx/wxprec.h" #ifdef __BORLANDC__ - #pragma hdrstop +#pragma hdrstop #endif #ifndef WX_PRECOMP - #include "wx/intl.h" - #include "wx/log.h" +#include "wx/intl.h" +#include "wx/log.h" +#include "wx/file.h" #endif #include "wx/filename.h" #include "wx/tokenzr.h" #include "wx/config.h" // for wxExpandEnvVars #include "wx/utils.h" +#include "wx/file.h" -#if wxUSE_DYNLIB_CLASS - #include "wx/dynlib.h" +#if wxUSE_DYNAMIC_LOADER || wxUSE_DYNLIB_CLASS +#include "wx/dynlib.h" #endif // For GetShort/LongPathName #ifdef __WIN32__ - #include - - #include "wx/msw/winundef.h" +#include +#include "wx/msw/winundef.h" #endif // utime() is POSIX so should normally be available on all Unices #ifdef __UNIX_LIKE__ - #include - #include - #include - #include +#include +#include +#include +#include #endif #ifdef __MWERKS__ - #include - #include - #include +#include +#include +#include #endif #ifdef __WATCOMC__ - #include - #include - #include +#include +#include +#include #endif #ifdef __VISAGECPP__ @@ -456,9 +457,9 @@ wxString wxFileName::GetHomeDir() return ::wxGetHomeDir(); } -void wxFileName::AssignTempFileName( const wxString& prefix ) +void wxFileName::AssignTempFileName(const wxString& prefix, wxFile *fileTemp) { - wxString tempname = CreateTempFileName(prefix); + wxString tempname = CreateTempFileName(prefix, fileTemp); if ( tempname.empty() ) { // error, failed to get temp file name @@ -471,7 +472,8 @@ void wxFileName::AssignTempFileName( const wxString& prefix ) } /* static */ -wxString wxFileName::CreateTempFileName(const wxString& prefix) +wxString +wxFileName::CreateTempFileName(const wxString& prefix, wxFile *fileTemp) { wxString path, dir, name; @@ -558,13 +560,25 @@ wxString wxFileName::CreateTempFileName(const wxString& prefix) // can use the cast here because the length doesn't change and the string // is not shared - if ( mkstemp((char *)path.mb_str()) == -1 ) + int fdTemp = mkstemp((char *)path.mb_str()); + if ( fdTemp == -1 ) { // this might be not necessary as mkstemp() on most systems should have // already done it but it doesn't hurt neither... path.clear(); } - //else: file already created + else // mkstemp() succeeded + { + // avoid leaking the fd + if ( fileTemp ) + { + fileTemp->Attach(fdTemp); + } + else + { + close(fdTemp); + } + } #else // !HAVE_MKSTEMP #ifdef HAVE_MKTEMP @@ -601,10 +615,20 @@ wxString wxFileName::CreateTempFileName(const wxString& prefix) if ( !path.empty() ) { - // create the file - of course, there is a race condition here, this is + } +#endif // HAVE_MKSTEMP/!HAVE_MKSTEMP + +#endif // Windows/!Windows + + if ( path.empty() ) + { + wxLogSysError(_("Failed to create a temporary file name")); + } + else if ( fileTemp && !fileTemp->IsOpened() ) + { + // open the file - of course, there is a race condition here, this is // why we always prefer using mkstemp()... - wxFile file; - if ( !file.Open(path, wxFile::write_excl, wxS_IRUSR | wxS_IWUSR) ) + if ( !fileTemp->Open(path, wxFile::write_excl, wxS_IRUSR | wxS_IWUSR) ) { // FIXME: If !ok here should we loop and try again with another // file name? That is the standard recourse if open(O_EXCL) @@ -616,14 +640,6 @@ wxString wxFileName::CreateTempFileName(const wxString& prefix) path.clear(); } } -#endif // HAVE_MKSTEMP/!HAVE_MKSTEMP - -#endif // Windows/!Windows - - if ( path.empty() ) - { - wxLogSysError(_("Failed to create a temporary file name")); - } return path; } @@ -728,6 +744,7 @@ bool wxFileName::Normalize(wxPathNormalize flags, } } #endif + m_relative = FALSE; } // handle ~ stuff under Unix only @@ -1090,18 +1107,18 @@ wxString wxFileName::GetFullPath( wxPathFormat format ) const // first put the volume if ( !m_volume.empty() ) { - { - // Special Windows UNC paths hack, part 2: undo what we did in - // SplitPath() and make an UNC path if we have a drive which is not a - // single letter (hopefully the network shares can't be one letter only - // although I didn't find any authoritative docs on this) - if ( format == wxPATH_DOS && m_volume.length() > 1 ) - { - fullpath << wxFILE_SEP_PATH_DOS << wxFILE_SEP_PATH_DOS << m_volume; - } - else if ( format == wxPATH_DOS || format == wxPATH_VMS ) - { - fullpath << m_volume << GetVolumeSeparator(format); + { + // Special Windows UNC paths hack, part 2: undo what we did in + // SplitPath() and make an UNC path if we have a drive which is not a + // single letter (hopefully the network shares can't be one letter only + // although I didn't find any authoritative docs on this) + if ( format == wxPATH_DOS && m_volume.length() > 1 ) + { + fullpath << wxFILE_SEP_PATH_DOS << wxFILE_SEP_PATH_DOS << m_volume; + } + else if ( format == wxPATH_DOS || format == wxPATH_VMS ) + { + fullpath << m_volume << GetVolumeSeparator(format); } // else ignore } @@ -1221,7 +1238,7 @@ wxString wxFileName::GetLongPath() const bool success = FALSE; // VZ: this code was disabled, why? -#if 0 // wxUSE_DYNLIB_CLASS +#if 0 // wxUSE_DYNAMIC_LOADER typedef DWORD (*GET_LONG_PATH_NAME)(const wxChar *, wxChar *, DWORD); static bool s_triedToLoad = FALSE; @@ -1269,7 +1286,7 @@ wxString wxFileName::GetLongPath() const } if (success) return pathOut; -#endif // wxUSE_DYNLIB_CLASS +#endif // wxUSE_DYNAMIC_LOADER if (!success) {