X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/716cd4107bb8a5f37dea34507453be6870aaef3a..a111f2b216a90bacb254644d3cae526eddc9f9f1:/src/common/image.cpp

diff --git a/src/common/image.cpp b/src/common/image.cpp
index 5045805f8b..fe48bf366a 100644
--- a/src/common/image.cpp
+++ b/src/common/image.cpp
@@ -28,7 +28,6 @@
 #include "wx/log.h"
 #include "wx/app.h"
 #include "wx/filefn.h"
-#include "wx/filesys.h"
 #include "wx/wfstream.h"
 #include "wx/intl.h"
 #include "wx/module.h"
@@ -59,7 +58,9 @@ public:
     unsigned char   m_maskRed,m_maskGreen,m_maskBlue;
     bool            m_ok;
     bool            m_static;
+#if wxUSE_PALETTE
     wxPalette       m_palette;
+#endif // wxUSE_PALETTE
     wxArrayString   m_optionNames;
     wxArrayString   m_optionValues;
 };
@@ -211,7 +212,14 @@ wxImage wxImage::Scale( int width, int height ) const
 
     wxCHECK_MSG( Ok(), image, wxT("invalid image") );
 
-    wxCHECK_MSG( (width > 0) && (height > 0), image, wxT("invalid image size") );
+    // can't scale to/from 0 size
+    wxCHECK_MSG( (width > 0) && (height > 0), image,
+                 wxT("invalid new image size") );
+
+    long old_height = M_IMGDATA->m_height,
+         old_width  = M_IMGDATA->m_width;
+    wxCHECK_MSG( (old_height > 0) && (old_width > 0), image,
+                 wxT("invalid old image size") );
 
     image.Create( width, height );
 
@@ -220,26 +228,52 @@ wxImage wxImage::Scale( int width, int height ) const
     wxCHECK_MSG( data, image, wxT("unable to create image") );
 
     if (M_IMGDATA->m_hasMask)
-        image.SetMaskColour( M_IMGDATA->m_maskRed, M_IMGDATA->m_maskGreen, M_IMGDATA->m_maskBlue );
-
-    long old_height = M_IMGDATA->m_height;
-    long old_width  = M_IMGDATA->m_width;
+    {
+        image.SetMaskColour( M_IMGDATA->m_maskRed,
+                             M_IMGDATA->m_maskGreen,
+                             M_IMGDATA->m_maskBlue );
+    }
 
     char unsigned *source_data = M_IMGDATA->m_data;
     char unsigned *target_data = data;
 
+#if 0
+    // This is nonsense, RR.
+
+    // We do (x, y) -> (x, y)*oldSize/newSize but the valid values of x and y
+    // are from 0 to size-1, hence all decrement the sizes
+    long old_old_width = old_width;
+    old_height--;
+    old_width--;
+    height--;
+    width--;
+    for ( long j = 0; j <= height; j++ )
+    {
+        // don't crash for images with height == 1
+        long y_offset = height ? (j * old_height / height)* old_old_width : 0;
+
+        for ( long i = 0; i <= width; i++ )
+        {
+            long x_offset = width ? (i * old_width) / width : 0;
+
+            memcpy( target_data, source_data + 3*(y_offset + x_offset), 3 );
+            target_data += 3;
+        }
+    }
+#else
     for (long j = 0; j < height; j++)
     {
-        long y_offset = (j * (old_height-1) / (height-1)) * old_width;
+        long y_offset = (j * old_height / height) * old_width;
 
         for (long i = 0; i < width; i++)
         {
             memcpy( target_data,
-                source_data + 3*(y_offset + ((i * (old_width-1) )/ (width-1))),
+                source_data + 3*(y_offset + ((i * old_width )/ width)),
                 3 );
             target_data += 3;
         }
     }
+#endif
 
     return image;
 }
@@ -686,6 +720,8 @@ int wxImage::GetHeight() const
     return M_IMGDATA->m_height;
 }
 
+#if wxUSE_PALETTE
+
 // Palette functions
 
 bool wxImage::HasPalette() const
@@ -710,6 +746,8 @@ void wxImage::SetPalette(const wxPalette& palette)
     M_IMGDATA->m_palette = palette;
 }
 
+#endif // wxUSE_PALETTE
+
 // Option functions (arbitrary name/value mapping)
 void wxImage::SetOption(const wxString& name, const wxString& value)
 {
@@ -763,19 +801,18 @@ bool wxImage::HasOption(const wxString& name) const
 bool wxImage::LoadFile( const wxString& filename, long type )
 {
 #if wxUSE_STREAMS
-    // We want to use wxFileSystem for virtual FS compatibility
-    wxFileSystem fsys;
-    wxFSFile *file = fsys.OpenFile(filename);
-    if (!file) {
-        wxLogError(_("Can't open file '%s'"), filename);
-        return FALSE;
-        }
-    wxInputStream *stream = file->GetStream();
-    if (!stream) {
-        wxLogError(_("Can't open stream for file '%s'"), filename);
+    if (wxFileExists(filename))
+    {
+        wxFileInputStream stream(filename);
+        wxBufferedInputStream bstream( stream );
+        return LoadFile(bstream, type);
+    }
+    else
+    {
+        wxLogError( _("Can't load image from file '%s': file does not exist."), filename.c_str() );
+
         return FALSE;
-        }
-    return LoadFile(*stream, type);
+    }
 #else // !wxUSE_STREAMS
     return FALSE;
 #endif // wxUSE_STREAMS
@@ -784,19 +821,18 @@ bool wxImage::LoadFile( const wxString& filename, long type )
 bool wxImage::LoadFile( const wxString& filename, const wxString& mimetype )
 {
 #if wxUSE_STREAMS
-    // We want to use wxFileSystem for virtual FS compatibility
-    wxFileSystem fsys;
-    wxFSFile *file = fsys.OpenFile(filename);
-    if (!file) {
-        wxLogError(_("Can't open file '%s'"), filename);
-        return FALSE;
-        }
-    wxInputStream *stream = file->GetStream();
-    if (!stream) {
-        wxLogError(_("Can't open stream for file '%s'"), filename);
+    if (wxFileExists(filename))
+    {
+        wxFileInputStream stream(filename);
+        wxBufferedInputStream bstream( stream );
+        return LoadFile(bstream, mimetype);
+    }
+    else
+    {
+        wxLogError( _("Can't load image from file '%s': file does not exist."), filename.c_str() );
+
         return FALSE;
-        }
-    return LoadFile(*stream, mimetype);
+    }
 #else // !wxUSE_STREAMS
     return FALSE;
 #endif // wxUSE_STREAMS
@@ -1027,7 +1063,7 @@ wxImageHandler *wxImage::FindHandlerMime( const wxString& mimetype )
 void wxImage::InitStandardHandlers()
 {
     AddHandler(new wxBMPHandler);
-#if !defined(__WXGTK__) && !defined(__WXMOTIF__)
+#if wxUSE_XPM && !defined(__WXGTK__) && !defined(__WXMOTIF__)
     AddHandler(new wxXPMHandler);
 #endif
 }