X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/6eae1f7d48196dea9968c8e478f28a4166bd0fe9..60b0c3b4c64a768bedb48b00477b7f6290d9fe23:/src/mac/carbon/combobox.cpp diff --git a/src/mac/carbon/combobox.cpp b/src/mac/carbon/combobox.cpp index 245bb7acd8..3f7ca169d5 100644 --- a/src/mac/carbon/combobox.cpp +++ b/src/mac/carbon/combobox.cpp @@ -14,18 +14,31 @@ #if wxUSE_COMBOBOX #include "wx/combobox.h" -#include "wx/button.h" -#include "wx/menu.h" + +#ifndef WX_PRECOMP + #include "wx/button.h" + #include "wx/menu.h" + #include "wx/containr.h" + #include "wx/toplevel.h" + #include "wx/textctrl.h" +#endif + #include "wx/mac/uma.h" IMPLEMENT_DYNAMIC_CLASS(wxComboBox, wxControl) +WX_DELEGATE_TO_CONTROL_CONTAINER(wxComboBox, wxControl) + +BEGIN_EVENT_TABLE(wxComboBox, wxControl) + WX_EVENT_TABLE_CONTROL_CONTAINER(wxComboBox) +END_EVENT_TABLE() + static int nextPopUpMenuId = 1000 ; MenuHandle NewUniqueMenu() { - MenuHandle handle = NewMenu( nextPopUpMenuId , "\pMenu" ) ; + MenuHandle handle = UMANewMenu(nextPopUpMenuId, wxString(wxT("Menu")), wxFont::GetDefaultEncoding() ); nextPopUpMenuId++ ; return handle ; @@ -37,17 +50,11 @@ MenuHandle NewUniqueMenu() // ---------------------------------------------------------------------------- // the margin between the text control and the choice -#if TARGET_API_MAC_OSX // margin should be bigger on OS X due to blue highlight // around text control. static const wxCoord MARGIN = 4; // this is the border a focus rect on OSX is needing static const int TEXTFOCUSBORDER = 3 ; -#else -static const wxCoord MARGIN = 2; -static const int TEXTFOCUSBORDER = 0 ; -#endif -static const int POPUPHEIGHT = 23; // ---------------------------------------------------------------------------- @@ -61,6 +68,7 @@ public: : wxTextCtrl( cb , 1 ) { m_cb = cb; + SetTriggerOnSetValue( false ); } protected: @@ -97,19 +105,16 @@ protected: // such as the clicking the default button. if (!m_cb->GetEventHandler()->ProcessEvent( event )) { - wxWindow *parent = GetParent(); - while ( parent && !parent->IsTopLevel() && parent->GetDefaultItem() == NULL ) - parent = parent->GetParent() ; - - if ( parent && parent->GetDefaultItem() ) + wxTopLevelWindow *tlw = wxDynamicCast(wxGetTopLevelParent(this), wxTopLevelWindow); + if ( tlw && tlw->GetDefaultItem() ) { - wxButton *def = wxDynamicCast(parent->GetDefaultItem(), wxButton); + wxButton *def = wxDynamicCast(tlw->GetDefaultItem(), wxButton); if ( def && def->IsEnabled() ) { wxCommandEvent event( wxEVT_COMMAND_BUTTON_CLICKED, def->GetId() ); event.SetEventObject(def); def->Command(event); - } + } } return; @@ -153,7 +158,7 @@ BEGIN_EVENT_TABLE(wxComboBoxText, wxTextCtrl) EVT_KEY_DOWN(wxComboBoxText::OnKeyDown) EVT_CHAR(wxComboBoxText::OnChar) EVT_KEY_UP(wxComboBoxText::OnKeyUp) - EVT_TEXT(-1, wxComboBoxText::OnText) + EVT_TEXT(wxID_ANY, wxComboBoxText::OnText) END_EVENT_TABLE() class wxComboBoxChoice : public wxChoice @@ -210,18 +215,17 @@ protected: private: wxComboBox *m_cb; + friend class wxComboBox; + DECLARE_EVENT_TABLE() }; BEGIN_EVENT_TABLE(wxComboBoxChoice, wxChoice) - EVT_CHOICE(-1, wxComboBoxChoice::OnChoice) + EVT_CHOICE(wxID_ANY, wxComboBoxChoice::OnChoice) END_EVENT_TABLE() wxComboBox::~wxComboBox() { - // delete client objects - FreeData(); - // delete the controls now, don't leave them alive even though they would // still be eventually deleted by our parent - but it will be too late, the // user code expects them to be gone now @@ -311,12 +315,6 @@ bool wxComboBox::Show(bool show) return true; } -void wxComboBox::SetFocus() -{ - if ( m_text != NULL) - m_text->SetFocus(); -} - void wxComboBox::DelegateTextChanged( const wxString& value ) { SetStringSelection( value ); @@ -327,6 +325,11 @@ void wxComboBox::DelegateChoice( const wxString& value ) SetStringSelection( value ); } +void wxComboBox::Init() +{ + WX_INIT_CONTROL_CONTAINER(); +} + bool wxComboBox::Create(wxWindow *parent, wxWindowID id, const wxString& value, @@ -337,10 +340,13 @@ bool wxComboBox::Create(wxWindow *parent, const wxValidator& validator, const wxString& name) { - wxCArrayString chs( choices ); + if ( !Create( parent, id, value, pos, size, 0, NULL, + style, validator, name ) ) + return false; - return Create( parent, id, value, pos, size, chs.GetCount(), - chs.GetStrings(), style, validator, name ); + Append(choices); + + return true; } bool wxComboBox::Create(wxWindow *parent, @@ -378,13 +384,10 @@ bool wxComboBox::Create(wxWindow *parent, DoSetSize(pos.x, pos.y, csize.x, csize.y); - for ( int i = 0 ; i < n ; i++ ) - { - m_choice->DoAppend( choices[ i ] ); - } + Append( n, choices ); // Needed because it is a wxControlWithItems - SetBestSize(size); + SetInitialSize(size); SetStringSelection(value); return true; @@ -402,7 +405,7 @@ wxString wxComboBox::GetValue() const return result; } -int wxComboBox::GetCount() const +unsigned int wxComboBox::GetCount() const { return m_choice->GetCount() ; } @@ -415,6 +418,16 @@ void wxComboBox::SetValue(const wxString& value) m_text->SetValue( value ); } +void wxComboBox::WriteText(const wxString& text) +{ + m_text->WriteText(text); +} + +void wxComboBox::GetSelection(long *from, long *to) const +{ + m_text->GetSelection(from, to); +} + // Clipboard operations void wxComboBox::Copy() @@ -458,95 +471,84 @@ void wxComboBox::SetEditable(bool editable) void wxComboBox::SetInsertionPoint(long pos) { - // TODO + if ( m_text ) + m_text->SetInsertionPoint(pos); } void wxComboBox::SetInsertionPointEnd() { - // TODO + if ( m_text ) + m_text->SetInsertionPointEnd(); } long wxComboBox::GetInsertionPoint() const { - // TODO + if ( m_text ) + return m_text->GetInsertionPoint(); return 0; } wxTextPos wxComboBox::GetLastPosition() const { - // TODO + if ( m_text ) + return m_text->GetLastPosition(); return 0; } void wxComboBox::Replace(long from, long to, const wxString& value) { - // TODO + if ( m_text ) + m_text->Replace(from,to,value); } void wxComboBox::Remove(long from, long to) { - // TODO + if ( m_text ) + m_text->Remove(from,to); } void wxComboBox::SetSelection(long from, long to) { - // TODO + if ( m_text ) + m_text->SetSelection(from,to); } -int wxComboBox::DoAppend(const wxString& item) +int wxComboBox::DoInsertItems(const wxArrayStringsAdapter& items, + unsigned int pos, + void **clientData, + wxClientDataType type) { - return m_choice->DoAppend( item ) ; + return m_choice->DoInsertItems(items, pos, clientData, type); } -int wxComboBox::DoInsert(const wxString& item, int pos) -{ - return m_choice->DoInsert( item , pos ) ; -} - -void wxComboBox::DoSetItemClientData(int n, void* clientData) +void wxComboBox::DoSetItemClientData(unsigned int n, void* clientData) { return m_choice->DoSetItemClientData( n , clientData ) ; } -void* wxComboBox::DoGetItemClientData(int n) const +void* wxComboBox::DoGetItemClientData(unsigned int n) const { return m_choice->DoGetItemClientData( n ) ; } -void wxComboBox::DoSetItemClientObject(int n, wxClientData* clientData) +wxClientDataType wxComboBox::GetClientDataType() const { - return m_choice->DoSetItemClientObject( n , clientData ) ; + return m_choice->GetClientDataType(); } -wxClientData* wxComboBox::DoGetItemClientObject(int n) const +void wxComboBox::SetClientDataType(wxClientDataType clientDataItemsType) { - return m_choice->DoGetItemClientObject( n ) ; + m_choice->SetClientDataType(clientDataItemsType); } -void wxComboBox::FreeData() +void wxComboBox::DoDeleteOneItem(unsigned int n) { - if ( HasClientObjectData() ) - { - size_t count = GetCount(); - for ( size_t n = 0; n < count; n++ ) - { - SetClientObject( n, NULL ); - } - } + m_choice->DoDeleteOneItem( n ); } -void wxComboBox::Delete(int n) +void wxComboBox::DoClear() { - // force client object deletion - if( HasClientObjectData() ) - SetClientObject( n, NULL ); - m_choice->Delete( n ); -} - -void wxComboBox::Clear() -{ - FreeData(); - m_choice->Clear(); + m_choice->DoClear(); } int wxComboBox::GetSelection() const @@ -559,7 +561,7 @@ void wxComboBox::SetSelection(int n) m_choice->SetSelection( n ); if ( m_text != NULL ) - m_text->SetValue( GetString( n ) ); + m_text->SetValue(n != wxNOT_FOUND ? GetString(n) : wxString(wxEmptyString)); } int wxComboBox::FindString(const wxString& s, bool bCase) const @@ -567,7 +569,7 @@ int wxComboBox::FindString(const wxString& s, bool bCase) const return m_choice->FindString( s, bCase ); } -wxString wxComboBox::GetString(int n) const +wxString wxComboBox::GetString(unsigned int n) const { return m_choice->GetString( n ); } @@ -575,15 +577,15 @@ wxString wxComboBox::GetString(int n) const wxString wxComboBox::GetStringSelection() const { int sel = GetSelection(); - if (sel > -1) - return wxString(this->GetString (sel)); + if (sel != wxNOT_FOUND) + return wxString(this->GetString((unsigned int)sel)); else return wxEmptyString; } -void wxComboBox::SetString(int n, const wxString& s) +void wxComboBox::SetString(unsigned int n, const wxString& s) { - m_choice->SetString( n , s ) ; + m_choice->SetString( n , s ); } bool wxComboBox::IsEditable() const @@ -663,4 +665,4 @@ wxInt32 wxComboBox::MacControlHit( WXEVENTHANDLERREF WXUNUSED(handler) , WXEVENT return noErr ; } -#endif +#endif // wxUSE_COMBOBOX