X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/6270539bcf24f2ec32150a09f8aad383f5de0671..3f4a2351e4c677c88c18ea812b609477adee7380:/src/msw/clipbrd.cpp?ds=inline diff --git a/src/msw/clipbrd.cpp b/src/msw/clipbrd.cpp index 044ef30db2..ee67b677fd 100644 --- a/src/msw/clipbrd.cpp +++ b/src/msw/clipbrd.cpp @@ -1,5 +1,5 @@ ///////////////////////////////////////////////////////////////////////////// -// Name: clipbrd.cpp +// Name: src/msw/clipbrd.cpp // Purpose: Clipboard functionality // Author: Julian Smart // Modified by: @@ -26,6 +26,8 @@ #if wxUSE_CLIPBOARD +#include "wx/clipbrd.h" + #ifndef WX_PRECOMP #include "wx/object.h" #include "wx/event.h" @@ -34,14 +36,14 @@ #include "wx/bitmap.h" #include "wx/utils.h" #include "wx/intl.h" + #include "wx/log.h" + #include "wx/dataobj.h" #endif #if wxUSE_METAFILE #include "wx/metafile.h" #endif -#include "wx/log.h" -#include "wx/clipbrd.h" #include @@ -56,10 +58,6 @@ // the functions using wxDataObject in wxClipboard //#define wxUSE_DATAOBJ wxUSE_DRAG_AND_DROP -#if wxUSE_DATAOBJ - #include "wx/dataobj.h" -#endif - #if wxUSE_OLE && !defined(__WXWINCE__) // use OLE clipboard #define wxUSE_OLE_CLIPBOARD 1 @@ -531,13 +529,13 @@ wxClipboard::wxClipboard() wxOleInitialize(); #endif - m_clearOnExit = false; + m_lastDataObject = NULL; m_isOpened = false; } wxClipboard::~wxClipboard() { - if ( m_clearOnExit ) + if ( m_lastDataObject ) { Clear(); } @@ -550,30 +548,44 @@ wxClipboard::~wxClipboard() void wxClipboard::Clear() { #if wxUSE_OLE_CLIPBOARD - HRESULT hr = OleSetClipboard(NULL); + if (m_lastDataObject) + { + // don't touch data set by other applications + HRESULT hr = OleIsCurrentClipboard(m_lastDataObject); + if (S_OK == hr) + { + hr = OleSetClipboard(NULL); if ( FAILED(hr) ) { wxLogApiError(wxT("OleSetClipboard(NULL)"), hr); } + } + m_lastDataObject = NULL; + } #endif // wxUSE_OLE_CLIPBOARD } bool wxClipboard::Flush() { #if wxUSE_OLE_CLIPBOARD - HRESULT hr = OleFlushClipboard(); + if (m_lastDataObject) + { + // don't touch data set by other applications + HRESULT hr = OleIsCurrentClipboard(m_lastDataObject); + m_lastDataObject = NULL; + if (S_OK == hr) + { + hr = OleFlushClipboard(); if ( FAILED(hr) ) { wxLogApiError(wxT("OleFlushClipboard"), hr); return false; } - else - { - m_clearOnExit = false; - return true; } + } + return false; #else // !wxUSE_OLE_CLIPBOARD return false; #endif // wxUSE_OLE_CLIPBOARD/!wxUSE_OLE_CLIPBOARD @@ -626,6 +638,12 @@ bool wxClipboard::AddData( wxDataObject *data ) return false; } + // we have to call either OleSetClipboard(NULL) or OleFlushClipboard() when + // using OLE clipboard when the app terminates - by default, we call + // OleSetClipboard(NULL) which won't waste RAM, but the app can call + // wxClipboard::Flush() to change this + m_lastDataObject = data->GetInterface(); + // we have a problem here because we should delete wxDataObject, but we // can't do it because IDataObject which we just gave to the clipboard // would try to use it when it will need the data. IDataObject is ref @@ -633,12 +651,6 @@ bool wxClipboard::AddData( wxDataObject *data ) // and tell it to delete wxDataObject when it is deleted itself. data->SetAutoDelete(); - // we have to call either OleSetClipboard(NULL) or OleFlushClipboard() when - // using OLE clipboard when the app terminates - by default, we call - // OleSetClipboard(NULL) which won't waste RAM, but the app can call - // wxClipboard::Flush() to chaneg this - m_clearOnExit = true; - return true; #elif wxUSE_DATAOBJ wxCHECK_MSG( wxIsClipboardOpened(), false, wxT("clipboard not open") ); @@ -917,4 +929,3 @@ bool wxClipboard::GetData( wxDataObject& data ) } #endif // wxUSE_CLIPBOARD -