X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/5ea105e0ba20c15e4d83f829e1c4faeb0a4952f0..a6ad3e89c6beee0a5936ca4585caa19373e0c287:/src/msw/filedlg.cpp diff --git a/src/msw/filedlg.cpp b/src/msw/filedlg.cpp index 1aeb326354..acdf6567db 100644 --- a/src/msw/filedlg.cpp +++ b/src/msw/filedlg.cpp @@ -28,6 +28,7 @@ #include "wx/dialog.h" #include "wx/filedlg.h" #include "wx/intl.h" + #include "wx/log.h" #endif #include @@ -46,11 +47,11 @@ IMPLEMENT_CLASS(wxFileDialog, wxDialog) #endif -wxString wxFileSelector(const char *title, - const char *defaultDir, - const char *defaultFileName, - const char *defaultExtension, - const char *filter, +wxString wxFileSelector(const wxChar *title, + const wxChar *defaultDir, + const wxChar *defaultFileName, + const wxChar *defaultExtension, + const wxChar *filter, int flags, wxWindow *parent, int x, int y) @@ -69,7 +70,7 @@ wxString wxFileSelector(const char *title, wxString filter2; if ( defaultExtension && !filter ) - filter2 = wxString("*.") + defaultExtension; + filter2 = wxString(wxT("*.")) + defaultExtension; else if ( filter ) filter2 = filter; @@ -84,14 +85,14 @@ wxString wxFileSelector(const char *title, wxFileDialog fileDialog(parent, title, defaultDirString, defaultFilenameString, filter2, flags, wxPoint(x, y)); - if( Strlen(defaultExtension) != 0 ) + if( wxStrlen(defaultExtension) != 0 ) { int filterFind = 1, filterIndex = 0; for( unsigned int i = 0; i < filter2.Len(); i++ ) { - if( filter2.GetChar(i) == '|' ) + if( filter2.GetChar(i) == wxT('|') ) { // save the start index of the new filter unsigned int is = i++; @@ -100,7 +101,7 @@ wxString wxFileSelector(const char *title, // find the end of the filter for( ; i < filter2.Len(); i++ ) { - if(filter2[i] == '|') + if(filter2[i] == wxT('|')) break; } @@ -121,7 +122,7 @@ wxString wxFileSelector(const char *title, if ( fileDialog.ShowModal() == wxID_OK ) { - strcpy(wxBuffer, (const char *)fileDialog.GetPath()); + wxStrcpy(wxBuffer, (const wxChar *)fileDialog.GetPath()); return wxBuffer; } else @@ -149,24 +150,24 @@ wxString wxFileSelector(const char *title, # endif -wxString wxFileSelectorEx(const char *title, - const char *defaultDir, - const char *defaultFileName, +wxString wxFileSelectorEx(const wxChar *title, + const wxChar *defaultDir, + const wxChar *defaultFileName, int* defaultFilterIndex, - const char *filter, + const wxChar *filter, int flags, wxWindow* parent, int x, int y) { - wxFileDialog fileDialog(parent, title ? title : "", defaultDir ? defaultDir : "", - defaultFileName ? defaultFileName : "", filter ? filter : "", flags, wxPoint(x, y)); + wxFileDialog fileDialog(parent, title ? title : wxT(""), defaultDir ? defaultDir : wxT(""), + defaultFileName ? defaultFileName : wxT(""), filter ? filter : wxT(""), flags, wxPoint(x, y)); if ( fileDialog.ShowModal() == wxID_OK ) { *defaultFilterIndex = fileDialog.GetFilterIndex(); - strcpy(wxBuffer, (const char *)fileDialog.GetPath()); + wxStrcpy(wxBuffer, (const wxChar *)fileDialog.GetPath()); return wxBuffer; } else @@ -180,11 +181,11 @@ wxFileDialog::wxFileDialog(wxWindow *parent, const wxString& message, m_message = message; m_dialogStyle = style; m_parent = parent; - m_path = ""; + m_path = wxT(""); m_fileName = defaultFileName; m_dir = defaultDir; m_wildCard = wildCard; - m_filterIndex = 1; + m_filterIndex = 0; } int wxFileDialog::ShowModal(void) @@ -192,11 +193,11 @@ int wxFileDialog::ShowModal(void) HWND hWnd = 0; if (m_parent) hWnd = (HWND) m_parent->GetHWND(); - static char fileNameBuffer [ MAXPATH ]; // the file-name - char titleBuffer [ MAXFILE+1+MAXEXT ]; // the file-name, without path + static wxChar fileNameBuffer [ MAXPATH ]; // the file-name + wxChar titleBuffer [ MAXFILE+1+MAXEXT ]; // the file-name, without path - *fileNameBuffer = '\0'; - *titleBuffer = '\0'; + *fileNameBuffer = wxT('\0'); + *titleBuffer = wxT('\0'); long msw_flags = 0; if ( (m_dialogStyle & wxHIDE_READONLY) || (m_dialogStyle & wxSAVE) ) @@ -216,7 +217,7 @@ int wxFileDialog::ShowModal(void) of.lStructSize = sizeof(OPENFILENAME); of.hwndOwner = hWnd; - of.lpstrTitle = (char *)(const char *)m_message; + of.lpstrTitle = WXSTRINGCAST m_message; of.lpstrFileTitle = titleBuffer; @@ -227,10 +228,10 @@ int wxFileDialog::ShowModal(void) size_t i = 0; size_t len = m_dir.Length(); for (i = 0; i < len; i++) - if (m_dir[i] == '/') - m_dir[i] = '\\'; + if (m_dir[i] == wxT('/')) + m_dir[i] = wxT('\\'); - of.lpstrInitialDir = (const char *) m_dir; + of.lpstrInitialDir = m_dir.c_str(); of.Flags = msw_flags; @@ -249,13 +250,13 @@ int wxFileDialog::ShowModal(void) //======================================================================= wxString theFilter; - if ( Strlen(m_wildCard) == 0 ) - theFilter = wxString("*.*"); + if ( wxStrlen(m_wildCard) == 0 ) + theFilter = wxString(wxT("*.*")); else theFilter = m_wildCard ; wxString filterBuffer; - if ( !strchr( theFilter, '|' ) ) { // only one filter ==> default text + if ( !wxStrchr( theFilter, wxT('|') ) ) { // only one filter ==> default text filterBuffer.Printf(_("Files (%s)|%s"), theFilter.c_str(), theFilter.c_str()); } @@ -264,21 +265,21 @@ int wxFileDialog::ShowModal(void) } - filterBuffer += "|"; + filterBuffer += wxT("|"); // Replace | with \0 for (i = 0; i < filterBuffer.Len(); i++ ) { - if ( filterBuffer.GetChar(i) == '|' ) { - filterBuffer[i] = '\0'; + if ( filterBuffer.GetChar(i) == wxT('|') ) { + filterBuffer[i] = wxT('\0'); } } - of.lpstrFilter = (LPSTR)(const char *)filterBuffer; - of.nFilterIndex = m_filterIndex; + of.lpstrFilter = (LPTSTR)(const wxChar *)filterBuffer; + of.nFilterIndex = m_filterIndex + 1; // m_filterIndex is zero-based, but nFilterIndex is 1-based //=== Setting defaultFileName >>========================================= - strncpy( fileNameBuffer, (const char *)m_fileName, MAXPATH-1 ); - fileNameBuffer[ MAXPATH-1 ] = '\0'; + wxStrncpy( fileNameBuffer, (const wxChar *)m_fileName, MAXPATH-1 ); + fileNameBuffer[ MAXPATH-1 ] = wxT('\0'); of.lpstrFile = fileNameBuffer; // holds returned filename of.nMaxFile = MAXPATH; @@ -290,13 +291,13 @@ int wxFileDialog::ShowModal(void) if ( success ) { - const char* extension = NULL; + const wxChar* extension = NULL; //=== Adding the correct extension >>================================= - m_filterIndex = (int)of.nFilterIndex; + m_filterIndex = wxMax((int)of.nFilterIndex - 1, 0); - if ( of.nFileExtension && fileNameBuffer[ of.nFileExtension-1] != '.' ) + if ( of.nFileExtension && fileNameBuffer[ of.nFileExtension-1] != wxT('.') ) { // user has typed an filename // without an extension: @@ -304,27 +305,28 @@ int wxFileDialog::ShowModal(void) extension = filterBuffer; for( int i = 0; i < maxFilter; i++ ) { // get extension - extension = extension + strlen( extension ) +1; + extension = extension + wxStrlen( extension ) +1; } - extension = strrchr( extension, '.' ); + extension = wxStrrchr( extension, wxT('.') ); if ( extension // != "blabla" - && !strrchr( extension, '*' ) // != "blabla.*" - && !strrchr( extension, '?' ) // != "blabla.?" + && !wxStrrchr( extension, wxT('*') ) // != "blabla.*" + && !wxStrrchr( extension, wxT('?') ) // != "blabla.?" && extension[1] // != "blabla." - && extension[1] != ' ' ) // != "blabla. " + && extension[1] != wxT(' ') ) // != "blabla. " { // now concat extension to the fileName: m_fileName = wxString(fileNameBuffer) + extension; - int len = strlen( fileNameBuffer ); - strncpy( fileNameBuffer + len, extension, MAXPATH - len ); - fileNameBuffer[ MAXPATH -1 ] = '\0'; + int len = wxStrlen( fileNameBuffer ); + wxStrncpy( fileNameBuffer + len, extension, MAXPATH - len ); + fileNameBuffer[ MAXPATH -1 ] = wxT('\0'); } } m_path = fileNameBuffer; m_fileName = wxFileNameFromPath(fileNameBuffer); + m_dir = wxPathOnly(fileNameBuffer); //=== Simulating the wxOVERWRITE_PROMPT >>============================ @@ -341,47 +343,63 @@ int wxFileDialog::ShowModal(void) } } - } // END: if ( success ) + } + else + { + // common dialog failed - why? +#ifdef __WXDEBUG__ + DWORD dwErr = CommDlgExtendedError(); + if ( dwErr != 0 ) + { + // this msg is only for developers + wxLogError(wxT("Common dialog failed with error code %0lx."), + dwErr); + } + //else: it was just cancelled +#endif + } - return (success ? wxID_OK : wxID_CANCEL) ; + return success ? wxID_OK : wxID_CANCEL; } // Generic file load/save dialog (for internal use only) static wxString wxDefaultFileSelector(bool load, - const char *what, - const char *extension, - const char *default_name, + const wxChar *what, + const wxChar *extension, + const wxChar *default_name, wxWindow *parent) { wxString prompt; - wxString str = load ? _("Load %s file") : _("Save %s file"); + wxString str; + if (load) str = _("Load %s file"); + else str = _("Save %s file"); prompt.Printf(str, what); - const char *ext = extension; - if (*ext == '.') + const wxChar *ext = extension; + if (*ext == wxT('.')) ext++; wxString wild; - wild.Printf("*.%s", ext); + wild.Printf(wxT("*.%s"), ext); return wxFileSelector (prompt, NULL, default_name, ext, wild, 0, parent); } // Generic file load dialog -WXDLLEXPORT wxString wxLoadFileSelector(const char *what, - const char *extension, - const char *default_name, +WXDLLEXPORT wxString wxLoadFileSelector(const wxChar *what, + const wxChar *extension, + const wxChar *default_name, wxWindow *parent) { return wxDefaultFileSelector(TRUE, what, extension, default_name, parent); } // Generic file save dialog -WXDLLEXPORT wxString wxSaveFileSelector(const char *what, - const char *extension, - const char *default_name, +WXDLLEXPORT wxString wxSaveFileSelector(const wxChar *what, + const wxChar *extension, + const wxChar *default_name, wxWindow *parent) { return wxDefaultFileSelector(FALSE, what, extension, default_name, parent);