X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/5b59df83150f65cf440553b11fcc839896d65cf7..64c1effefabacc175cf601ea4118f3b806a1fd65:/src/msw/tooltip.cpp diff --git a/src/msw/tooltip.cpp b/src/msw/tooltip.cpp index bdcd7478b4..8ca70b9ff3 100644 --- a/src/msw/tooltip.cpp +++ b/src/msw/tooltip.cpp @@ -32,9 +32,8 @@ #include "wx/tooltip.h" #include "wx/msw/private.h" -#if defined(__WIN95__) && !(defined(__GNUWIN32_OLD__) && !defined(__CYGWIN10__)) - #include -#endif +// include "properly" +#include "wx/msw/wrapcctl.h" // VZ: normally, the trick with subclassing the tooltip control and processing // TTM_WINDOWFROMPOINT should work but, somehow, it doesn't. I leave the @@ -104,23 +103,20 @@ public: // private functions // ---------------------------------------------------------------------------- -// send a message to the tooltip control -inline LRESULT SendTooltipMessage(WXHWND hwnd, - UINT msg, - WPARAM wParam, - void *lParam) +// send a message to the tooltip control if it exists +// +// NB: wParam is always 0 for the TTM_XXX messages we use +static inline LRESULT SendTooltipMessage(WXHWND hwnd, UINT msg, void *lParam) { - return hwnd ? ::SendMessage((HWND)hwnd, msg, wParam, (LPARAM)lParam) - : 0; + return hwnd ? ::SendMessage((HWND)hwnd, msg, 0, (LPARAM)lParam) : 0; } // send a message to all existing tooltip controls -static void SendTooltipMessageToAll(WXHWND hwnd, - UINT msg, - WPARAM wParam, - LPARAM lParam) +static inline void +SendTooltipMessageToAll(WXHWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) { - (void)SendTooltipMessage((WXHWND)hwnd, msg, wParam, (void *)lParam); + if ( hwnd ) + ::SendMessage((HWND)hwnd, msg, wParam, lParam); } // ============================================================================ @@ -142,13 +138,13 @@ LRESULT APIENTRY wxToolTipWndProc(HWND hwndTT, { LPPOINT ppt = (LPPOINT)lParam; - // the window on which event occured + // the window on which event occurred HWND hwnd = ::WindowFromPoint(*ppt); OutputDebugString("TTM_WINDOWFROMPOINT: "); OutputDebugString(wxString::Format("0x%08x => ", hwnd)); - // return a HWND corresponding to a wxWindow because only wxWindows are + // return a HWND corresponding to a wxWindow because only wxWidgets are // associated with tooltips using TTM_ADDTOOL wxWindow *win = wxGetWindowFromHWND((WXHWND)hwnd); @@ -198,13 +194,16 @@ void wxToolTip::SetDelay(long milliseconds) // --------------------------------------------------------------------------- // create the tooltip ctrl for our parent frame if it doesn't exist yet +/* static */ WXHWND wxToolTip::GetToolTipCtrl() { if ( !ms_hwndTT ) { + // we want to show the tooltips always (even when the window is not + // active) and we don't want to strip "&"s from them ms_hwndTT = (WXHWND)::CreateWindow(TOOLTIPS_CLASS, (LPCTSTR)NULL, - TTS_ALWAYSTIP, + TTS_ALWAYSTIP | TTS_NOPREFIX, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, NULL, (HMENU)NULL, @@ -218,8 +217,7 @@ WXHWND wxToolTip::GetToolTipCtrl() #if wxUSE_TTM_WINDOWFROMPOINT // subclass the newly created control - gs_wndprocToolTip = (WNDPROC)::GetWindowLong(hwnd, GWL_WNDPROC); - ::SetWindowLong(hwnd, GWL_WNDPROC, (long)wxToolTipWndProc); + gs_wndprocToolTip = wxSetWindowProc(hwnd, wxToolTipWndProc); #endif // wxUSE_TTM_WINDOWFROMPOINT } } @@ -227,9 +225,10 @@ WXHWND wxToolTip::GetToolTipCtrl() return ms_hwndTT; } +/* static */ void wxToolTip::RelayEvent(WXMSG *msg) { - (void)SendTooltipMessage(GetToolTipCtrl(), TTM_RELAYEVENT, 0, msg); + (void)SendTooltipMessage(GetToolTipCtrl(), TTM_RELAYEVENT, msg); } // ---------------------------------------------------------------------------- @@ -246,21 +245,27 @@ wxToolTip::wxToolTip(const wxString &tip) wxToolTip::~wxToolTip() { - // there is no need to Remove() this tool - it will be done automatically - // anyhow + // the tooltip has to be removed before deleting. Otherwise, if it is visible + // while being deleted, there will be a delay before it goes away. + Remove(); } // ---------------------------------------------------------------------------- // others // ---------------------------------------------------------------------------- +void wxToolTip::Remove(WXHWND hWnd) +{ + wxToolInfo ti((HWND)hWnd); + (void)SendTooltipMessage(GetToolTipCtrl(), TTM_DELTOOL, &ti); +} + void wxToolTip::Remove() { // remove this tool from the tooltip control if ( m_window ) { - wxToolInfo ti(GetHwndOf(m_window)); - (void)SendTooltipMessage(GetToolTipCtrl(), TTM_DELTOOL, 0, &ti); + Remove(m_window->GetHWND()); } } @@ -279,7 +284,7 @@ void wxToolTip::Add(WXHWND hWnd) ti.hwnd = hwnd; ti.lpszText = (wxChar *)m_text.c_str(); // const_cast - if ( !SendTooltipMessage(GetToolTipCtrl(), TTM_ADDTOOL, 0, &ti) ) + if ( !SendTooltipMessage(GetToolTipCtrl(), TTM_ADDTOOL, &ti) ) { wxLogDebug(_T("Failed to create the tooltip '%s'"), m_text.c_str()); } @@ -291,13 +296,13 @@ void wxToolTip::Add(WXHWND hWnd) if ( index != wxNOT_FOUND ) { #ifdef TTM_SETMAXTIPWIDTH - if ( wxTheApp->GetComCtl32Version() >= 470 ) + if ( wxApp::GetComCtl32Version() >= 470 ) { // use TTM_SETMAXTIPWIDTH to make tooltip multiline using the // extent of its first line as max value - HFONT hfont = (HFONT)SendTooltipMessage(GetToolTipCtrl(), - WM_GETFONT, - 0, 0); + HFONT hfont = (HFONT) + SendTooltipMessage(GetToolTipCtrl(), WM_GETFONT, 0); + if ( !hfont ) { hfont = (HFONT)GetStockObject(DEFAULT_GUI_FONT); @@ -319,19 +324,27 @@ void wxToolTip::Add(WXHWND hWnd) } SIZE sz; - if ( !GetTextExtentPoint(hdc, m_text, index, &sz) ) + if ( !::GetTextExtentPoint32(hdc, m_text, index, &sz) ) { - wxLogLastError(wxT("GetTextExtentPoint")); + wxLogLastError(wxT("GetTextExtentPoint32")); } SendTooltipMessage(GetToolTipCtrl(), TTM_SETMAXTIPWIDTH, - 0, (void *)sz.cx); + (void *)sz.cx); } + else #endif // comctl32.dll >= 4.70 + { + // replace the '\n's with spaces because otherwise they appear as + // unprintable characters in the tooltip string + m_text.Replace(_T("\n"), _T(" ")); + ti.lpszText = (wxChar *)m_text.c_str(); // const_cast - // replace the '\n's with spaces because otherwise they appear as - // unprintable characters in the tooltip string - m_text.Replace(_T("\n"), _T(" ")); + if ( !SendTooltipMessage(GetToolTipCtrl(), TTM_ADDTOOL, &ti) ) + { + wxLogDebug(_T("Failed to create the tooltip '%s'"), m_text.c_str()); + } + } } } } @@ -362,7 +375,7 @@ void wxToolTip::SetWindow(wxWindow *win) { // may be it's a child of parent of the control, in fact? // (radiobuttons are subcontrols, i.e. children of the radiobox - // for wxWindows but are its siblings at Windows level) + // for wxWidgets but are its siblings at Windows level) hwnd = GetDlgItem(GetHwndOf(m_window->GetParent()), id); } @@ -401,7 +414,7 @@ void wxToolTip::SetTip(const wxString& tip) wxToolInfo ti(GetHwndOf(m_window)); ti.lpszText = (wxChar *)m_text.c_str(); - (void)SendTooltipMessage(GetToolTipCtrl(), TTM_UPDATETIPTEXT, 0, &ti); + (void)SendTooltipMessage(GetToolTipCtrl(), TTM_UPDATETIPTEXT, &ti); } }