X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/58385af01650f2218cff7d64b58140a8aafdf8e0..908f91bce9bfe08204447ed7217a38625ecacc64:/src/msw/statbox.cpp diff --git a/src/msw/statbox.cpp b/src/msw/statbox.cpp index cd21abe857..e23f78abe1 100644 --- a/src/msw/statbox.cpp +++ b/src/msw/statbox.cpp @@ -38,14 +38,11 @@ #include "wx/statbox.h" #include "wx/notebook.h" #include "wx/sysopt.h" +#include "wx/image.h" +#include "wx/dcmemory.h" #include "wx/msw/private.h" - -// under CE this style is not defined but we don't need to make static boxes -// transparent there neither -#ifndef WS_EX_TRANSPARENT - #define WS_EX_TRANSPARENT 0 -#endif +#include "wx/msw/missing.h" // ---------------------------------------------------------------------------- // wxWin macros @@ -125,15 +122,46 @@ bool wxStaticBox::Create(wxWindow *parent, if ( !MSWCreateControl(wxT("BUTTON"), label, pos, size) ) return false; +#ifndef __WXWINCE__ + Connect(wxEVT_PAINT, wxPaintEventHandler(wxStaticBox::OnPaint)); +#endif // !__WXWINCE__ + return true; } +wxBorder wxStaticBox::GetDefaultBorder() const +{ + return wxBORDER_NONE; +} + WXDWORD wxStaticBox::MSWGetStyle(long style, WXDWORD *exstyle) const { long styleWin = wxStaticBoxBase::MSWGetStyle(style, exstyle); + // no need for it anymore, must be removed for wxRadioBox child + // buttons to be able to repaint themselves + styleWin &= ~WS_CLIPCHILDREN; + if ( exstyle ) - *exstyle = WS_EX_TRANSPARENT; + { + *exstyle = 0; + + // If any of the ancestors are scrolling windows, style has to be + // WS_EX_TRANSPARENT or the static box won't be painted when the window + // is scrolled. We try not to do this normally, because we get a lot of + // flicker. + for ( wxWindow *win = GetParent(); win; win = win->GetParent() ) + { + if ( win->HasFlag(wxVSCROLL) || win->HasFlag(wxHSCROLL) ) + { + *exstyle = WS_EX_TRANSPARENT; + break; + } + + if ( win->IsTopLevel() ) + break; + } + } return styleWin | BS_GROUPBOX; } @@ -152,9 +180,19 @@ wxSize wxStaticBox::DoGetBestSize() const return wxSize(wBox, hBox); } -WXLRESULT wxStaticBox::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lParam) +void wxStaticBox::GetBordersForSizer(int *borderTop, int *borderOther) const { + wxStaticBoxBase::GetBordersForSizer(borderTop, borderOther); + + // need extra space, don't know how much but this seems to be enough + *borderTop += GetCharHeight()/3; +} + +// all the hacks below are not necessary for WinCE #ifndef __WXWINCE__ + +WXLRESULT wxStaticBox::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lParam) +{ if ( nMsg == WM_NCHITTEST ) { // This code breaks some other processing such as enter/leave tracking @@ -165,8 +203,8 @@ WXLRESULT wxStaticBox::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lPar s_useHTClient = wxSystemOptions::GetOptionInt(wxT("msw.staticbox.htclient")); if (s_useHTClient == 1) { - int xPos = LOWORD(lParam); // horizontal position of cursor - int yPos = HIWORD(lParam); // vertical position of cursor + int xPos = GET_X_LPARAM(lParam); + int yPos = GET_Y_LPARAM(lParam); ScreenToClient(&xPos, &yPos); @@ -176,23 +214,189 @@ WXLRESULT wxStaticBox::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lPar return (long)HTCLIENT; } } -#endif // !__WXWINCE__ return wxControl::MSWWindowProc(nMsg, wParam, lParam); } -void wxStaticBox::GetBordersForSizer(int *borderTop, int *borderOther) const +// ---------------------------------------------------------------------------- +// static box drawing +// ---------------------------------------------------------------------------- + +/* + We draw the static box ourselves because it's the only way to prevent it + from flickering horribly on resize (because everything inside the box is + erased twice: once when the box itself is repainted and second time when + the control inside it is repainted) without using WS_EX_TRANSPARENT style as + we used to do and which resulted in other problems. + */ + +// MSWGetRegionWithoutSelf helper: removes the given rectangle from region +static inline void +SubtractRectFromRgn(HRGN hrgn, int left, int top, int right, int bottom) { - wxStaticBoxBase::GetBordersForSizer(borderTop, borderOther); + AutoHRGN hrgnRect(::CreateRectRgn(left, top, right, bottom)); + if ( !hrgnRect ) + { + wxLogLastError(_T("CreateRectRgn()")); + return; + } + + ::CombineRgn(hrgn, hrgn, hrgnRect, RGN_DIFF); +} + +void wxStaticBox::MSWGetRegionWithoutSelf(WXHRGN hRgn, int w, int h) +{ + HRGN hrgn = (HRGN)hRgn; + + // remove the area occupied by the static box borders from the region + int borderTop, border; + GetBordersForSizer(&borderTop, &border); + + // top + SubtractRectFromRgn(hrgn, 0, 0, w, borderTop); + + // bottom + SubtractRectFromRgn(hrgn, 0, h - border, w, h); + + // left + SubtractRectFromRgn(hrgn, 0, 0, border, h); + + // right + SubtractRectFromRgn(hrgn, w - border, 0, w, h); +} + +WXHRGN wxStaticBox::MSWGetRegionWithoutChildren() +{ + RECT rc; + ::GetWindowRect(GetHwnd(), &rc); + HRGN hrgn = ::CreateRectRgn(rc.left, rc.top, rc.right + 1, rc.bottom + 1); + + // iterate over all child windows (not just wxWindows but all windows) + for ( HWND child = ::GetWindow(GetHwndOf(GetParent()), GW_CHILD); + child; + child = ::GetWindow(child, GW_HWNDNEXT) ) + { + wxWindow *childWindow = wxGetWindowFromHWND((WXHWND) child); - // if not using correct (but backwards cojmpatible) text metrics - // calculations, we need to add some extra margin or otherwise static box - // title is clipped -#if !wxDIALOG_UNIT_COMPATIBILITY - if ( !GetLabel().empty() ) - *borderTop += GetCharHeight()/3; -#endif // !wxDIALOG_UNIT_COMPATIBILITY + // can't just test for (this != child) here since if a wxStaticBox + // overlaps another wxStaticBox then neither are drawn. The overlapping + // region will flicker but we shouldn't have overlapping windows anyway. + if ( !childWindow || !wxDynamicCast(childWindow, wxStaticBox) ) + { + ::GetWindowRect(child, &rc); + if ( ::RectInRegion(hrgn, &rc) ) + { + // need to remove WS_CLIPSIBLINGS from all sibling windows + // that are within this staticbox if set + LONG style = ::GetWindowLong(child, GWL_STYLE); + if ( style & WS_CLIPSIBLINGS ) + { + style &= ~WS_CLIPSIBLINGS; + ::SetWindowLong(child, GWL_STYLE, style); + + // MSDN: "If you have changed certain window data using + // SetWindowLong, you must call SetWindowPos to have the + // changes take effect." + ::SetWindowPos(child, NULL, 0, 0, 0, 0, + SWP_NOMOVE | SWP_NOSIZE | SWP_NOZORDER | + SWP_FRAMECHANGED); + } + + AutoHRGN hrgnChild(::CreateRectRgnIndirect(&rc)); + ::CombineRgn(hrgn, hrgn, hrgnChild, RGN_DIFF); + } + } + } + + return (WXHRGN)hrgn; } +// helper for OnPaint(): really erase the background, i.e. do it even if we +// don't have any non default brush for doing it (DoEraseBackground() doesn't +// do anything in such case) +void wxStaticBox::PaintBackground(wxDC& dc, const RECT& rc) +{ + // note that we do not use the box background colour here, it shouldn't + // apply to its interior for several reasons: + // 1. wxGTK doesn't do it + // 2. controls inside the box don't get correct bg colour because they + // are not our children so we'd have some really ugly colour mix if + // we did it + // 3. this is backwards compatible behaviour and some people rely on it, + // see http://groups.google.com/groups?selm=4252E932.3080801%40able.es + wxWindow *parent = GetParent(); + HBRUSH hbr = (HBRUSH)parent->MSWGetBgBrush(dc.GetHDC(), GetHWND()); + + // if there is no special brush for painting this control, just use the + // solid background colour + wxBrush brush; + if ( !hbr ) + { + brush = wxBrush(parent->GetBackgroundColour()); + hbr = GetHbrushOf(brush); + } + + ::FillRect(GetHdcOf(dc), &rc, hbr); +} + +void wxStaticBox::OnPaint(wxPaintEvent& WXUNUSED(event)) +{ + RECT rc; + ::GetClientRect(GetHwnd(), &rc); + + // draw the entire box in a memory DC + wxMemoryDC memdc; + wxBitmap bitmap(rc.right, rc.bottom); + memdc.SelectObject(bitmap); + + PaintBackground(memdc, rc); + + // NB: neither setting the text colour nor transparent background mode + // doesn't change anything: the static box def window proc still + // draws the label in its own colours, so if we want to have control + // over this we really have to draw everything ourselves + MSWDefWindowProc(WM_PAINT, (WPARAM)GetHdcOf(memdc), 0); + + + // now only blit the static box border itself, not the interior, to avoid + // flicker when background is drawn below + // + // note that it seems to be faster to do 4 small blits here and then paint + // directly into wxPaintDC than painting background in wxMemoryDC and then + // blitting everything at once to wxPaintDC, this is why we do it like this + wxPaintDC dc(this); + int borderTop, border; + GetBordersForSizer(&borderTop, &border); + + // top + dc.Blit(border, 0, rc.right - border, borderTop, + &memdc, border, 0); + // bottom + dc.Blit(border, rc.bottom - border, rc.right - border, rc.bottom, + &memdc, border, rc.bottom - border); + // left + dc.Blit(0, 0, border, rc.bottom, + &memdc, 0, 0); + // right + dc.Blit(rc.right - border, 0, rc.right, rc.bottom, + &memdc, rc.right - border, 0); + + + // create the region excluding box children + AutoHRGN hrgn((HRGN)MSWGetRegionWithoutChildren()); + RECT rcWin; + ::GetWindowRect(GetHwnd(), &rcWin); + ::OffsetRgn(hrgn, -rcWin.left, -rcWin.top); + + // and also the box itself + MSWGetRegionWithoutSelf((WXHRGN) hrgn, rc.right, rc.bottom); + HDCClipper clipToBg(GetHdcOf(dc), hrgn); + + // paint the inside of the box (excluding box itself and child controls) + PaintBackground(dc, rc); +} + +#endif // !__WXWINCE__ + #endif // wxUSE_STATBOX