X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/57c208c5759da71a637f0f0f5b7d3dc3eda09c02..8f20ea03912fa5bffc537230ce853ef15b77f1fa:/include/wx/msw/pen.h diff --git a/include/wx/msw/pen.h b/include/wx/msw/pen.h index d30a10ff83..07325f94a4 100644 --- a/include/wx/msw/pen.h +++ b/include/wx/msw/pen.h @@ -18,8 +18,9 @@ #include "wx/gdiobj.h" #include "wx/bitmap.h" +#include "wx/colour.h" -typedef WXDWORD wxDash ; +typedef WXDWORD wxMSWDash; class WXDLLEXPORT wxPen; @@ -41,9 +42,18 @@ protected: wxDash * m_dash ; wxColour m_colour; WXHPEN m_hPen; + +private: +// Cannot use +// DECLARE_NO_COPY_CLASS(wxPenRefData) +// because copy constructor is explicitly declared above; +// but no copy assignment operator is defined, so declare +// it private to prevent the compiler from defining it: + wxPenRefData& operator=(const wxPenRefData&); }; #define M_PENDATA ((wxPenRefData *)m_refData) +#define wxPENDATA(x) ((wxPenRefData *)(x).m_refData) // Pen class WXDLLEXPORT wxPen: public wxGDIObject @@ -57,8 +67,28 @@ public: ~wxPen(); inline wxPen& operator = (const wxPen& pen) { if (*this == pen) return (*this); Ref(pen); return *this; } - inline bool operator == (const wxPen& pen) { return m_refData == pen.m_refData; } - inline bool operator != (const wxPen& pen) { return m_refData != pen.m_refData; } + inline bool operator == (const wxPen& pen) const + { + // It is impossible to know if the user dashes have changed, + // so we must assume that they have + if ( m_refData && pen.m_refData ) + { + if ( M_PENDATA->m_nbDash != 0 || wxPENDATA(pen)->m_nbDash != 0 ) + return false; + } + return m_refData == pen.m_refData; + } + inline bool operator != (const wxPen& pen) const + { + // It is impossible to know if the user dashes have changed, + // so we must assume that they have + if ( m_refData && pen.m_refData ) + { + if ( M_PENDATA->m_nbDash != 0 || wxPENDATA(pen)->m_nbDash != 0 ) + return true; + } + return m_refData != pen.m_refData; + } virtual bool Ok() const { return (m_refData != NULL) ; } @@ -78,8 +108,10 @@ public: inline int GetStyle() const { return (M_PENDATA ? M_PENDATA->m_style : 0); }; inline int GetJoin() const { return (M_PENDATA ? M_PENDATA->m_join : 0); }; inline int GetCap() const { return (M_PENDATA ? M_PENDATA->m_cap : 0); }; - inline int GetDashes(wxDash **ptr) const { - *ptr = (M_PENDATA ? M_PENDATA->m_dash : (wxDash*) NULL); return (M_PENDATA ? M_PENDATA->m_nbDash : 0); + inline int GetDashes(wxDash **ptr) const + { + *ptr = (M_PENDATA ? (wxDash*)M_PENDATA->m_dash : (wxDash*) NULL); + return (M_PENDATA ? M_PENDATA->m_nbDash : 0); } inline wxBitmap *GetStipple() const { return (M_PENDATA ? (& M_PENDATA->m_stipple) : (wxBitmap*) NULL); }; @@ -87,7 +119,7 @@ public: // Internal bool RealizeResource(); bool FreeResource(bool force = FALSE); - WXHANDLE GetResourceHandle() ; + WXHANDLE GetResourceHandle() const; bool IsFree() const; void Unshare(); };