X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/573a2a4cbb155c2432f2e2b6d94859959d16c4a4..e413198572959f013fc2537a3c8cc184c9ac820d:/src/gtk/utilsgtk.cpp diff --git a/src/gtk/utilsgtk.cpp b/src/gtk/utilsgtk.cpp index 746bb0747d..19f3ffbe09 100644 --- a/src/gtk/utilsgtk.cpp +++ b/src/gtk/utilsgtk.cpp @@ -96,41 +96,6 @@ bool wxSetDetectableAutoRepeat( bool WXUNUSED(flag) ) } #endif -// Escapes string so that it is valid Pango markup XML string: -wxString wxEscapeStringForPangoMarkup(const wxString& str) -{ - size_t len = str.length(); - wxString out; - out.Alloc(len); - for (size_t i = 0; i < len; i++) - { - wxChar c = str[i]; - switch (c) - { - case _T('&'): - out << _T("&"); - break; - case _T('<'): - out << _T("<"); - break; - case _T('>'): - out << _T(">"); - break; - case _T('\''): - out << _T("'"); - break; - case _T('"'): - out << _T("""); - break; - default: - out << c; - break; - } - } - return out; -} - - // ---------------------------------------------------------------------------- // display characterstics // ---------------------------------------------------------------------------- @@ -248,38 +213,22 @@ const gchar *wx_pango_version_check (int major, int minor, int micro) extern "C" { static void GTK_EndProcessDetector(gpointer data, gint source, - GdkInputCondition WXUNUSED(condition) ) + GdkInputCondition WXUNUSED(condition)) { - wxEndProcessData *proc_data = (wxEndProcessData *)data; + wxEndProcessData * const + proc_data = static_cast(data); - // has the process really terminated? unfortunately GDK (or GLib) seem to - // generate G_IO_HUP notification even when it simply tries to read from a - // closed fd and hasn't terminated at all - int pid = (proc_data->pid > 0) ? proc_data->pid : -(proc_data->pid); - int status = 0; - int rc = waitpid(pid, &status, WNOHANG); + // child exited, end waiting + close(source); - if ( rc == 0 ) - { - // no, it didn't exit yet, continue waiting - return; - } + // don't call us again! + gdk_input_remove(proc_data->tag); - // set exit code to -1 if something bad happened - proc_data->exitcode = rc != -1 && WIFEXITED(status) ? WEXITSTATUS(status) - : -1; - - // child exited, end waiting - close(source); - - // don't call us again! - gdk_input_remove(proc_data->tag); - - wxHandleProcessTermination(proc_data); + wxHandleProcessTermination(proc_data); } } -int wxAddProcessCallback(wxEndProcessData *proc_data, int fd) +int wxGUIAppTraits::AddProcessCallback(wxEndProcessData *proc_data, int fd) { int tag = gdk_input_add(fd, GDK_INPUT_READ, @@ -341,7 +290,7 @@ static wxString GetSM() if ( !smc_conn ) { - wxLogWarning(_("Failed to connect to session manager: %s"), smerr); + wxLogDebug("Failed to connect to session manager: %s", smerr); return wxEmptyString; } @@ -499,7 +448,9 @@ wxString wxGUIAppTraits::GetDesktopEnvironment() const // see the hack below in wxCmdLineParser::GetUsageString(). // TODO: replace this hack with a g_option_group_get_entries() -// call as soon as such function exists +// call as soon as such function exists; +// see http://bugzilla.gnome.org/show_bug.cgi?id=431021 for the relative +// feature request struct _GOptionGroup { gchar *name; @@ -549,36 +500,40 @@ wxGUIAppTraits::GetStandardCmdLineOptions(wxArrayString& names, wxString usage; #ifdef __WXGTK26__ - // check whether GTK version is greater than 2.6 but also lower than 2.12 - // because, as we use the undocumented _GOptionGroup struct, we don't want - // to run this code with future versions which might change it (2.11 is the - // latest one at the time of this writing) - if (!gtk_check_version(2,6,0) && - gtk_check_version(2,12,0)) + if (!gtk_check_version(2,6,0)) { - usage << _("The following standard GTK+ options are also supported:\n"); + // since GTK>=2.6, we can use the glib_check_version() symbol... + + // check whether GLib version is greater than 2.6 but also lower than 2.19 + // because, as we use the undocumented _GOptionGroup struct, we don't want + // to run this code with future versions which might change it (2.19 is the + // latest one at the time of this writing) + if (!glib_check_version(2,6,0) && glib_check_version(2,19,0)) + { + usage << _("The following standard GTK+ options are also supported:\n"); - // passing true here means that the function can open the default - // display while parsing (not really used here anyhow) - GOptionGroup *gtkOpts = gtk_get_option_group(true); + // passing true here means that the function can open the default + // display while parsing (not really used here anyhow) + GOptionGroup *gtkOpts = gtk_get_option_group(true); - // WARNING: here we access the internals of GOptionGroup: - GOptionEntry *entries = ((_GOptionGroup*)gtkOpts)->entries; - unsigned int n_entries = ((_GOptionGroup*)gtkOpts)->n_entries; - wxArrayString namesOptions, descOptions; + // WARNING: here we access the internals of GOptionGroup: + GOptionEntry *entries = ((_GOptionGroup*)gtkOpts)->entries; + unsigned int n_entries = ((_GOptionGroup*)gtkOpts)->n_entries; + wxArrayString namesOptions, descOptions; - for ( size_t n = 0; n < n_entries; n++ ) - { - if ( entries[n].flags & G_OPTION_FLAG_HIDDEN ) - continue; // skip + for ( size_t n = 0; n < n_entries; n++ ) + { + if ( entries[n].flags & G_OPTION_FLAG_HIDDEN ) + continue; // skip - names.push_back(wxGetNameFromGtkOptionEntry(&entries[n])); + names.push_back(wxGetNameFromGtkOptionEntry(&entries[n])); - const gchar * const entryDesc = entries[n].description; - desc.push_back(entryDesc ? wxString(entryDesc) : _T("")); - } + const gchar * const entryDesc = entries[n].description; + desc.push_back(wxString(entryDesc)); + } - g_option_group_free (gtkOpts); + g_option_group_free (gtkOpts); + } } #else wxUnusedVar(names);