X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/55232d19fea544fd639d03eaed269e605821b85d..d0363d3d2d959f8ad86177de9179a284206ee615:/contrib/src/gizmos/editlbox.cpp diff --git a/contrib/src/gizmos/editlbox.cpp b/contrib/src/gizmos/editlbox.cpp index e7c065127d..5f73e15883 100644 --- a/contrib/src/gizmos/editlbox.cpp +++ b/contrib/src/gizmos/editlbox.cpp @@ -7,10 +7,6 @@ // Licence: wxWindows licence ///////////////////////////////////////////////////////////////////////////// -#ifdef __GNUG__ - #pragma implementation "editlbox.h" -#endif - // For compilers that support precompilation, includes "wx/wx.h". #include "wx/wxprec.h" @@ -19,7 +15,7 @@ #endif // for all others, include the necessary headers (this file is usually all you -// need because it includes almost all "standard" wxWindows headers) +// need because it includes almost all "standard" wxWidgets headers) #ifndef WX_PRECOMP #include "wx/wx.h" #endif @@ -36,12 +32,12 @@ class CleverListCtrl : public wxListCtrl { public: CleverListCtrl(wxWindow *parent, - wxWindowID id = -1, + wxWindowID id = wxID_ANY, const wxPoint &pos = wxDefaultPosition, const wxSize &size = wxDefaultSize, long style = wxLC_ICON, const wxValidator& validator = wxDefaultValidator, - const wxString &name = "listctrl") + const wxString &name = wxListCtrlNameStr) : wxListCtrl(parent, id, pos, size, style, validator, name) { CreateColumns(); @@ -85,21 +81,18 @@ END_EVENT_TABLE() IMPLEMENT_CLASS(wxEditableListBox, wxPanel) -enum -{ - // ID value doesn't matter, it won't propagate out of wxEditableListBox - // instance - wxID_ELB_DELETE = wxID_HIGHEST + 1, - wxID_ELB_NEW, - wxID_ELB_UP, - wxID_ELB_DOWN, - wxID_ELB_EDIT, - wxID_ELD_LISTCTRL -}; +// NB: generate the IDs at runtime to avoid conflict with XRCID values, +// they could cause XRCCTRL() failures in XRC-based dialogs +const int wxID_ELB_DELETE = wxNewId(); +const int wxID_ELB_EDIT = wxNewId(); +const int wxID_ELB_NEW = wxNewId(); +const int wxID_ELB_UP = wxNewId(); +const int wxID_ELB_DOWN = wxNewId(); +const int wxID_ELB_LISTCTRL = wxNewId(); BEGIN_EVENT_TABLE(wxEditableListBox, wxPanel) - EVT_LIST_ITEM_SELECTED(wxID_ELD_LISTCTRL, wxEditableListBox::OnItemSelected) - EVT_LIST_END_LABEL_EDIT(wxID_ELD_LISTCTRL, wxEditableListBox::OnEndLabelEdit) + EVT_LIST_ITEM_SELECTED(wxID_ELB_LISTCTRL, wxEditableListBox::OnItemSelected) + EVT_LIST_END_LABEL_EDIT(wxID_ELB_LISTCTRL, wxEditableListBox::OnEndLabelEdit) EVT_BUTTON(wxID_ELB_NEW, wxEditableListBox::OnNewItem) EVT_BUTTON(wxID_ELB_UP, wxEditableListBox::OnUpItem) EVT_BUTTON(wxID_ELB_DOWN, wxEditableListBox::OnDownItem) @@ -115,14 +108,14 @@ wxEditableListBox::wxEditableListBox(wxWindow *parent, wxWindowID id, : wxPanel(parent, id, pos, size, wxTAB_TRAVERSAL, name) { m_style = style; - m_bEdit = m_bNew = m_bDel = m_bUp = m_bDown = NULL; + m_bEdit = m_bNew = m_bDel = m_bUp = m_bDown = NULL; wxSizer *sizer = new wxBoxSizer(wxVERTICAL); - wxPanel *subp = new wxPanel(this, -1, wxDefaultPosition, wxDefaultSize, + wxPanel *subp = new wxPanel(this, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxSUNKEN_BORDER | wxTAB_TRAVERSAL); wxSizer *subsizer = new wxBoxSizer(wxHORIZONTAL); - subsizer->Add(new wxStaticText(subp, -1, label), 1, wxALIGN_CENTRE_VERTICAL | wxLEFT, 4); + subsizer->Add(new wxStaticText(subp, wxID_ANY, label), 1, wxALIGN_CENTRE_VERTICAL | wxLEFT, 4); #ifdef __WXMSW__ #define BTN_BORDER 4 @@ -158,14 +151,13 @@ wxEditableListBox::wxEditableListBox(wxWindow *parent, wxWindowID id, subsizer->Add(m_bDown, 0, wxALIGN_CENTRE_VERTICAL | wxTOP | wxBOTTOM, BTN_BORDER); #if wxUSE_TOOLTIPS - if ( m_bEdit ) m_bEdit->SetToolTip(wxT("Edit item")); - if ( m_bNew ) m_bNew->SetToolTip(wxT("New item")); - if ( m_bDel ) m_bDel->SetToolTip(wxT("Delete item")); - m_bUp->SetToolTip(wxT("Move up")); - m_bDown->SetToolTip(wxT("Move down")); + if ( m_bEdit ) m_bEdit->SetToolTip(_("Edit item")); + if ( m_bNew ) m_bNew->SetToolTip(_("New item")); + if ( m_bDel ) m_bDel->SetToolTip(_("Delete item")); + m_bUp->SetToolTip(_("Move up")); + m_bDown->SetToolTip(_("Move down")); #endif - subp->SetAutoLayout(TRUE); subp->SetSizer(subsizer); subsizer->Fit(subp); @@ -174,14 +166,13 @@ wxEditableListBox::wxEditableListBox(wxWindow *parent, wxWindowID id, long st = wxLC_REPORT | wxLC_NO_HEADER | wxLC_SINGLE_SEL | wxSUNKEN_BORDER; if ( style & wxEL_ALLOW_EDIT ) st |= wxLC_EDIT_LABELS; - m_listCtrl = new CleverListCtrl(this, wxID_ELD_LISTCTRL, + m_listCtrl = new CleverListCtrl(this, wxID_ELB_LISTCTRL, wxDefaultPosition, wxDefaultSize, st); wxArrayString empty_ar; SetStrings(empty_ar); sizer->Add(m_listCtrl, 1, wxEXPAND); - SetAutoLayout(TRUE); SetSizer(sizer); Layout(); } @@ -194,7 +185,7 @@ void wxEditableListBox::SetStrings(const wxArrayString& strings) for (i = 0; i < strings.GetCount(); i++) m_listCtrl->InsertItem(i, strings[i]); - m_listCtrl->InsertItem(strings.GetCount(), _T("")); + m_listCtrl->InsertItem(strings.GetCount(), wxEmptyString); m_listCtrl->SetItemState(0, wxLIST_STATE_SELECTED, wxLIST_STATE_SELECTED); } @@ -217,7 +208,7 @@ void wxEditableListBox::OnItemSelected(wxListEvent& event) m_bDel->Enable(m_selection < m_listCtrl->GetItemCount()-1); } -void wxEditableListBox::OnNewItem(wxCommandEvent& event) +void wxEditableListBox::OnNewItem(wxCommandEvent& WXUNUSED(event)) { m_listCtrl->SetItemState(m_listCtrl->GetItemCount()-1, wxLIST_STATE_SELECTED, wxLIST_STATE_SELECTED); @@ -226,29 +217,29 @@ void wxEditableListBox::OnNewItem(wxCommandEvent& event) void wxEditableListBox::OnEndLabelEdit(wxListEvent& event) { - if ( event.GetIndex() == m_listCtrl->GetItemCount()-1 && - !event.GetText().IsEmpty() ) + if ( event.GetIndex() == m_listCtrl->GetItemCount()-1 && + !event.GetText().empty() ) { // The user edited last (empty) line, i.e. added new entry. We have to // add new empty line here so that adding one more line is still // possible: - m_listCtrl->InsertItem(m_listCtrl->GetItemCount(), _T("")); + m_listCtrl->InsertItem(m_listCtrl->GetItemCount(), wxEmptyString); } } -void wxEditableListBox::OnDelItem(wxCommandEvent& event) +void wxEditableListBox::OnDelItem(wxCommandEvent& WXUNUSED(event)) { m_listCtrl->DeleteItem(m_selection); m_listCtrl->SetItemState(m_selection, wxLIST_STATE_SELECTED, wxLIST_STATE_SELECTED); } -void wxEditableListBox::OnEditItem(wxCommandEvent& event) +void wxEditableListBox::OnEditItem(wxCommandEvent& WXUNUSED(event)) { m_listCtrl->EditLabel(m_selection); } -void wxEditableListBox::OnUpItem(wxCommandEvent& event) +void wxEditableListBox::OnUpItem(wxCommandEvent& WXUNUSED(event)) { wxString t1, t2; @@ -260,7 +251,7 @@ void wxEditableListBox::OnUpItem(wxCommandEvent& event) wxLIST_STATE_SELECTED, wxLIST_STATE_SELECTED); } -void wxEditableListBox::OnDownItem(wxCommandEvent& event) +void wxEditableListBox::OnDownItem(wxCommandEvent& WXUNUSED(event)) { wxString t1, t2;