X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/53b88b545eecb4a975f0bdddd5f6a08f50e42209..344ed1f3861d5acdbc0e6486456136cbc47fc013:/src/gtk/combobox.cpp?ds=sidebyside

diff --git a/src/gtk/combobox.cpp b/src/gtk/combobox.cpp
index be9f51d5d4..e3feabd011 100644
--- a/src/gtk/combobox.cpp
+++ b/src/gtk/combobox.cpp
@@ -1,5 +1,5 @@
 /////////////////////////////////////////////////////////////////////////////
-// Name:        combobox.cpp
+// Name:        src/gtk/combobox.cpp
 // Purpose:
 // Author:      Robert Roebling
 // Id:          $Id$
@@ -7,73 +7,52 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
-#ifdef __GNUG__
-#pragma implementation "combobox.h"
-#endif
-
-#include "wx/combobox.h"
-#include "wx/settings.h"
-
-#include <wx/intl.h>
-
-#include "gdk/gdk.h"
-#include "gtk/gtk.h"
+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"
 
-//-----------------------------------------------------------------------------
-// idle system
-//-----------------------------------------------------------------------------
+#if wxUSE_COMBOBOX
 
-extern void wxapp_install_idle_handler();
-extern bool g_isIdle;
+#include "wx/combobox.h"
 
-//-----------------------------------------------------------------------------
-// data
-//-----------------------------------------------------------------------------
+#ifndef WX_PRECOMP
+    #include "wx/intl.h"
+    #include "wx/settings.h"
+    #include "wx/textctrl.h"    // for wxEVT_COMMAND_TEXT_UPDATED
+    #include "wx/arrstr.h"
+#endif
 
-extern bool   g_blockEventsOnDrag;
+#include "wx/gtk/private.h"
 
-//-----------------------------------------------------------------------------
-// "select"
-//-----------------------------------------------------------------------------
+// ----------------------------------------------------------------------------
+// GTK callbacks
+// ----------------------------------------------------------------------------
 
+extern "C" {
 static void
-gtk_combo_clicked_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )
+gtkcombobox_text_changed_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )
 {
-    if (g_isIdle) wxapp_install_idle_handler();
+    if (!combo->m_hasVMT) return;
 
-    if (!combo->HasVMT()) return;
+    wxCommandEvent event( wxEVT_COMMAND_TEXT_UPDATED, combo->GetId() );
+    event.SetString( combo->GetValue() );
+    event.SetEventObject( combo );
+    combo->HandleWindowEvent( event );
+}
 
-    if (g_blockEventsOnDrag) return;
+static void
+gtkcombobox_changed_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )
+{
+    if (!combo->m_hasVMT) return;
 
-    if (combo->m_alreadySent)
-    {
-        combo->m_alreadySent = FALSE;
+    if (combo->GetSelection() == -1)
         return;
-    }
-
-    combo->m_alreadySent = TRUE;
 
     wxCommandEvent event( wxEVT_COMMAND_COMBOBOX_SELECTED, combo->GetId() );
     event.SetInt( combo->GetSelection() );
     event.SetString( combo->GetStringSelection() );
     event.SetEventObject( combo );
-    
-    combo->GetEventHandler()->ProcessEvent( event );
+    combo->HandleWindowEvent( event );
 }
-
-//-----------------------------------------------------------------------------
-//  "changed"
-//-----------------------------------------------------------------------------
-
-static void
-gtk_text_changed_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )
-{
-    if (g_isIdle) wxapp_install_idle_handler();
-    
-    wxCommandEvent event( wxEVT_COMMAND_TEXT_UPDATED, combo->GetId() );
-    event.SetString( combo->GetValue() );
-    event.SetEventObject( combo );
-    combo->GetEventHandler()->ProcessEvent( event );
 }
 
 //-----------------------------------------------------------------------------
@@ -83,543 +62,474 @@ gtk_text_changed_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )
 IMPLEMENT_DYNAMIC_CLASS(wxComboBox,wxControl)
 
 BEGIN_EVENT_TABLE(wxComboBox, wxControl)
-    EVT_SIZE(wxComboBox::OnSize)
     EVT_CHAR(wxComboBox::OnChar)
+
+    EVT_MENU(wxID_CUT, wxComboBox::OnCut)
+    EVT_MENU(wxID_COPY, wxComboBox::OnCopy)
+    EVT_MENU(wxID_PASTE, wxComboBox::OnPaste)
+    EVT_MENU(wxID_UNDO, wxComboBox::OnUndo)
+    EVT_MENU(wxID_REDO, wxComboBox::OnRedo)
+    EVT_MENU(wxID_CLEAR, wxComboBox::OnDelete)
+    EVT_MENU(wxID_SELECTALL, wxComboBox::OnSelectAll)
+
+    EVT_UPDATE_UI(wxID_CUT, wxComboBox::OnUpdateCut)
+    EVT_UPDATE_UI(wxID_COPY, wxComboBox::OnUpdateCopy)
+    EVT_UPDATE_UI(wxID_PASTE, wxComboBox::OnUpdatePaste)
+    EVT_UPDATE_UI(wxID_UNDO, wxComboBox::OnUpdateUndo)
+    EVT_UPDATE_UI(wxID_REDO, wxComboBox::OnUpdateRedo)
+    EVT_UPDATE_UI(wxID_CLEAR, wxComboBox::OnUpdateDelete)
+    EVT_UPDATE_UI(wxID_SELECTALL, wxComboBox::OnUpdateSelectAll)
 END_EVENT_TABLE()
 
-bool wxComboBox::Create( wxWindow *parent, wxWindowID id, const wxString& value,
+bool wxComboBox::Create( wxWindow *parent, wxWindowID id,
+                         const wxString& value,
                          const wxPoint& pos, const wxSize& size,
-                         int n, const wxString choices[],
+                         const wxArrayString& choices,
                          long style, const wxValidator& validator,
                          const wxString& name )
 {
-    m_alreadySent = FALSE;
-    m_needParent = TRUE;
-    m_acceptsFocus = TRUE;
-
-    PreCreation( parent, id, pos, size, style, name );
+    wxCArrayString chs(choices);
 
-    SetValidator( validator );
+    return Create( parent, id, value, pos, size, chs.GetCount(),
+                   chs.GetStrings(), style, validator, name );
+}
 
-    m_widget = gtk_combo_new();
+bool wxComboBox::Create( wxWindow *parent, wxWindowID id, const wxString& value,
+                         const wxPoint& pos, const wxSize& size,
+                         int n, const wxString choices[],
+                         long style, const wxValidator& validator,
+                         const wxString& name )
+{
+    m_strings = NULL;
+    m_ignoreNextUpdate = false;
+    m_prevSelection = 0;
 
-    // make it more useable
-    gtk_combo_set_use_arrows_always(GTK_COMBO(m_widget), TRUE);
+    if (!PreCreation( parent, pos, size ) ||
+        !CreateBase( parent, id, pos, size, style, validator, name ))
+    {
+        wxFAIL_MSG( wxT("wxComboBox creation failed") );
+        return false;
+    }
 
-    wxSize newSize = size;
-    if (newSize.x == -1)
-        newSize.x = 100;
-    if (newSize.y == -1)
-        newSize.y = 26;
-    SetSize( newSize.x, newSize.y );
+    if (HasFlag(wxCB_SORT))
+        m_strings = new wxSortedArrayString();
 
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
+    m_widget = gtk_combo_box_entry_new_text();
 
-    for (int i = 0; i < n; i++)
-    {
-        /* don't send first event, which GTK sends aways when
-	   inserting the first item */
-        m_alreadySent = TRUE;
+    // Set it up to trigger default item on enter key press 
+    GtkWidget *widget = gtk_bin_get_child(GTK_BIN(m_widget));
+    gtk_entry_set_activates_default(GTK_ENTRY(widget),
+                                    !HasFlag(wxTE_PROCESS_ENTER));
     
-        GtkWidget *list_item = gtk_list_item_new_with_label( choices[i].mbc_str() );
-
-        m_clientDataList.Append( (wxObject*)NULL );
-        m_clientObjectList.Append( (wxObject*)NULL );
+    if (HasFlag(wxBORDER_NONE))
+    {
+        // Doesn't seem to work
+        // g_object_set (m_widget, "has-frame", FALSE, NULL);
+    }
 
-        gtk_container_add( GTK_CONTAINER(list), list_item );
+    GtkEntry * const entry = GetEntry();
 
-        gtk_signal_connect( GTK_OBJECT(list_item), "select",
-           GTK_SIGNAL_FUNC(gtk_combo_clicked_callback), (gpointer)this );
+    gtk_entry_set_editable( entry, TRUE );
 
-        gtk_widget_show( list_item );
-    }
+    Append(n, choices);
 
-    m_parent->AddChild( this );
+    m_parent->DoAddChild( this );
 
-    (m_parent->m_insertCallback)( m_parent, this );
+    m_focusWidget = GTK_WIDGET( entry );
 
-    PostCreation();
+    PostCreation(size);
 
-    ConnectWidget( GTK_COMBO(m_widget)->button );
+    ConnectWidget( m_widget );
 
-    if (!value.IsNull()) SetValue( value );
+    gtk_entry_set_text( entry, wxGTK_CONV(value) );
 
     if (style & wxCB_READONLY)
-        gtk_entry_set_editable( GTK_ENTRY( GTK_COMBO(m_widget)->entry ), FALSE );
+        gtk_entry_set_editable( entry, FALSE );
+
+    g_signal_connect_after (entry, "changed",
+                        G_CALLBACK (gtkcombobox_text_changed_callback), this);
 
-    gtk_signal_connect( GTK_OBJECT(GTK_COMBO(m_widget)->entry), "changed",
-      GTK_SIGNAL_FUNC(gtk_text_changed_callback), (gpointer)this);
+    g_signal_connect_after (m_widget, "changed",
+                        G_CALLBACK (gtkcombobox_changed_callback), this);
 
-    SetBackgroundColour( wxSystemSettings::GetSystemColour( wxSYS_COLOUR_WINDOW ) );
-    SetForegroundColour( parent->GetForegroundColour() );
-    SetFont( parent->GetFont() );
 
-    Show( TRUE );
+    SetInitialSize(size); // need this too because this is a wxControlWithItems
 
-    return TRUE;
+    return true;
 }
 
-wxComboBox::~wxComboBox()
+GtkEntry *wxComboBox::GetEntry() const
 {
-    wxNode *node = m_clientDataList.First();
-    while (node)
-    {
-        wxClientData *cd = (wxClientData*)node->Data();
-        if (cd) delete cd;
-        node = node->Next();
-    }
-    m_clientDataList.Clear();
+    return GTK_ENTRY(GTK_BIN(m_widget)->child);
 }
 
-void wxComboBox::AppendCommon( const wxString &item )
+GtkEditable *wxComboBox::GetEditable() const
 {
-    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
+    return GTK_EDITABLE( GTK_BIN(m_widget)->child );
+}
 
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
+wxComboBox::~wxComboBox()
+{
+    Clear();
 
-    GtkWidget *list_item = gtk_list_item_new_with_label( item.mbc_str() );
+    delete m_strings;
+}
 
-    gtk_container_add( GTK_CONTAINER(list), list_item );
+int wxComboBox::DoInsertItems(const wxArrayStringsAdapter & items,
+                              unsigned int pos,
+                              void **clientData, wxClientDataType type)
+{
+    wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid combobox") );
 
-    gtk_signal_connect( GTK_OBJECT(list_item), "select",
-      GTK_SIGNAL_FUNC(gtk_combo_clicked_callback), (gpointer)this );
+    wxASSERT_MSG( !IsSorted() || (pos == GetCount()),
+                 _T("In a sorted combobox data could only be appended"));
 
-    if (GTK_WIDGET_REALIZED(m_widget))
-    {
-        gtk_widget_realize( list_item );
-        gtk_widget_realize( GTK_BIN(list_item)->child );
+    const int count = items.GetCount();
 
-        if (m_widgetStyle) ApplyWidgetStyle();
-    }
+    int n = wxNOT_FOUND;
 
-    gtk_widget_show( list_item );
-}
+    GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+    for( int i = 0; i < count; ++i )
+    {
+        n = pos + i;
+        // If sorted, use this wxSortedArrayStrings to determine
+        // the right insertion point
+        if(m_strings)
+            n = m_strings->Add(items[i]);
 
-void wxComboBox::Append( const wxString &item )
-{
-    m_clientDataList.Append( (wxObject*) NULL );
-    m_clientObjectList.Append( (wxObject*) NULL );
+        gtk_combo_box_insert_text( combobox, n, wxGTK_CONV( items[i] ) );
 
-    AppendCommon( item );
-}
+        m_clientData.Insert( NULL, n );
+        AssignNewItemClientData(n, clientData, i, type);
+    }
 
-void wxComboBox::Append( const wxString &item, void *clientData )
-{
-    m_clientDataList.Append( (wxObject*) clientData );
-    m_clientObjectList.Append( (wxObject*)NULL );
+    InvalidateBestSize();
 
-    AppendCommon( item );
+    return n;
 }
 
-void wxComboBox::Append( const wxString &item, wxClientData *clientData )
+void wxComboBox::DoSetItemClientData(unsigned int n, void* clientData)
 {
-    m_clientDataList.Append( (wxObject*) NULL );
-    m_clientObjectList.Append( (wxObject*) clientData );
-
-    AppendCommon( item );
+    m_clientData[n] = clientData;
 }
 
-void wxComboBox::SetClientData( int n, void* clientData )
+void* wxComboBox::DoGetItemClientData(unsigned int n) const
 {
-    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
-
-    wxNode *node = m_clientDataList.Nth( n );
-    if (!node) return;
-
-    node->SetData( (wxObject*) clientData );
+    return m_clientData[n];
 }
 
-void* wxComboBox::GetClientData( int n )
+void wxComboBox::DoClear()
 {
-    wxCHECK_MSG( m_widget != NULL, NULL, _T("invalid combobox") );
+    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 
-    wxNode *node = m_clientDataList.Nth( n );
-    if (!node) return NULL;
+    DisableEvents();
 
-    return node->Data();
-}
+    GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+    const unsigned int count = GetCount();
+    for (unsigned int i = 0; i < count; i++)
+        gtk_combo_box_remove_text( combobox, 0 );
 
-void wxComboBox::SetClientObject( int n, wxClientData* clientData )
-{
-    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
+    m_clientData.Clear();
 
-    wxNode *node = m_clientObjectList.Nth( n );
-    if (!node) return;
+    if(m_strings)
+        m_strings->Clear();
 
-    wxClientData *cd = (wxClientData*) node->Data();
-    if (cd) delete cd;
+    EnableEvents();
 
-    node->SetData( (wxObject*) clientData );
+    InvalidateBestSize();
 }
 
-wxClientData* wxComboBox::GetClientObject( int n )
+void wxComboBox::DoDeleteOneItem(unsigned int n)
 {
-    wxCHECK_MSG( m_widget != NULL, (wxClientData*)NULL, _T("invalid combobox") );
+    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 
-    wxNode *node = m_clientDataList.Nth( n );
-    if (!node) return (wxClientData*) NULL;
+    wxCHECK_RET( IsValid(n), wxT("invalid index") );
 
-    return (wxClientData*) node->Data();
-}
+    GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+    gtk_combo_box_remove_text( combobox, n );
 
-void wxComboBox::Clear()
-{
-    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
-
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
-    gtk_list_clear_items( GTK_LIST(list), 0, Number() );
-
-    wxNode *node = m_clientObjectList.First();
-    while (node)
-    {
-        wxClientData *cd = (wxClientData*)node->Data();
-        if (cd) delete cd;
-        node = node->Next();
-    }
-    m_clientObjectList.Clear();
+    m_clientData.RemoveAt( n );
+    if(m_strings)
+        m_strings->RemoveAt( n );
 
-    m_clientDataList.Clear();
+    InvalidateBestSize();
 }
 
-void wxComboBox::Delete( int n )
+void wxComboBox::SetString(unsigned int n, const wxString &text)
 {
-    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
+    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 
-    GtkList *listbox = GTK_LIST( GTK_COMBO(m_widget)->list );
+    GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+    wxCHECK_RET( IsValid(n), wxT("invalid index") );
 
-    GList *child = g_list_nth( listbox->children, n );
-
-    if (!child)
-    {
-        wxFAIL_MSG(_T("wrong index"));
-        return;
-    }
-
-    GList *list = g_list_append( (GList*) NULL, child->data );
-    gtk_list_remove_items( listbox, list );
-    g_list_free( list );
-
-    wxNode *node = m_clientObjectList.Nth( n );
-    if (node)
+    GtkTreeModel *model = gtk_combo_box_get_model( combobox );
+    GtkTreeIter iter;
+    if (gtk_tree_model_iter_nth_child (model, &iter, NULL, n))
     {
-        wxClientData *cd = (wxClientData*)node->Data();
-        if (cd) delete cd;
-        m_clientObjectList.DeleteNode( node );
+        GValue value = { 0, };
+        g_value_init( &value, G_TYPE_STRING );
+        g_value_set_string( &value, wxGTK_CONV( text ) );
+        gtk_list_store_set_value( GTK_LIST_STORE(model), &iter, 0, &value );
+        g_value_unset( &value );
     }
 
-    node = m_clientDataList.Nth( n );
-    if (node)
-    {
-        m_clientDataList.DeleteNode( node );
-    }
+    InvalidateBestSize();
 }
 
-int wxComboBox::FindString( const wxString &item )
+int wxComboBox::FindString( const wxString &item, bool bCase ) const
 {
-    wxCHECK_MSG( m_widget != NULL, -1, _T("invalid combobox") );
+    wxCHECK_MSG( m_widget != NULL, wxNOT_FOUND, wxT("invalid combobox") );
 
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
-
-    GList *child = GTK_LIST(list)->children;
+    GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+    GtkTreeModel* model = gtk_combo_box_get_model( combobox );
+    GtkTreeIter iter;
+    gtk_tree_model_get_iter_first( model, &iter );
+    if (!gtk_list_store_iter_is_valid(GTK_LIST_STORE(model), &iter ))
+        return -1;
     int count = 0;
-    while (child)
+    do
     {
-        GtkBin *bin = GTK_BIN( child->data );
-        GtkLabel *label = GTK_LABEL( bin->child );
-        if (item == wxString(label->label,*wxConvCurrent))
+        GValue value = { 0, };
+        gtk_tree_model_get_value( model, &iter, 0, &value );
+        wxString str = wxGTK_CONV_BACK( g_value_get_string( &value ) );
+        g_value_unset( &value );
+
+        if (item.IsSameAs( str, bCase ) )
             return count;
+
         count++;
-        child = child->next;
     }
+    while ( gtk_tree_model_iter_next(model, &iter) );
 
     return wxNOT_FOUND;
 }
 
 int wxComboBox::GetSelection() const
 {
-    wxCHECK_MSG( m_widget != NULL, -1, _T("invalid combobox") );
-
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
-
-    GList *selection = GTK_LIST(list)->selection;
-    if (selection)
-    {
-        GList *child = GTK_LIST(list)->children;
-        int count = 0;
-        while (child)
-        {
-            if (child->data == selection->data) return count;
-            count++;
-            child = child->next;
-        }
-    }
+    GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+    return gtk_combo_box_get_active( combobox );
+}
 
-    wxFAIL_MSG( _T("wxComboBox: no selection") );
+int wxComboBox::GetCurrentSelection() const
+{
+    wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid combobox") );
 
-    return -1;
+    GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+    return gtk_combo_box_get_active( combobox );
 }
 
-wxString wxComboBox::GetString( int n ) const
+wxString wxComboBox::GetString(unsigned int n) const
 {
-    wxCHECK_MSG( m_widget != NULL, _T(""), _T("invalid combobox") );
-
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
+    wxCHECK_MSG( m_widget != NULL, wxEmptyString, wxT("invalid combobox") );
 
     wxString str;
-    GList *child = g_list_nth( GTK_LIST(list)->children, n );
-    if (child)
-    {
-        GtkBin *bin = GTK_BIN( child->data );
-        GtkLabel *label = GTK_LABEL( bin->child );
-        str = wxString(label->label,*wxConvCurrent);
-    }
-    else
+
+    GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+    GtkTreeModel *model = gtk_combo_box_get_model( combobox );
+    GtkTreeIter iter;
+    if (gtk_tree_model_iter_nth_child (model, &iter, NULL, n))
     {
-        wxFAIL_MSG( _T("wxComboBox: wrong index") );
+        GValue value = { 0, };
+        gtk_tree_model_get_value( model, &iter, 0, &value );
+        wxString tmp = wxGTK_CONV_BACK( g_value_get_string( &value ) );
+        g_value_unset( &value );
+        return tmp;
     }
 
     return str;
 }
 
-wxString wxComboBox::GetStringSelection() const
+unsigned int wxComboBox::GetCount() const
 {
-    wxCHECK_MSG( m_widget != NULL, _T(""), _T("invalid combobox") );
+    wxCHECK_MSG( m_widget != NULL, 0, wxT("invalid combobox") );
 
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
+    GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+    GtkTreeModel* model = gtk_combo_box_get_model( combobox );
+    GtkTreeIter iter;
+    gtk_tree_model_get_iter_first( model, &iter );
+    if (!gtk_list_store_iter_is_valid(GTK_LIST_STORE(model), &iter ))
+        return 0;
+    unsigned int ret = 1;
+    while (gtk_tree_model_iter_next( model, &iter ))
+        ret++;
+    return ret;
+}
 
-    GList *selection = GTK_LIST(list)->selection;
-    if (selection)
-    {
-        GtkBin *bin = GTK_BIN( selection->data );
-        wxString tmp = wxString(GTK_LABEL( bin->child )->label,*wxConvCurrent);
-        return tmp;
-    }
+void wxComboBox::SetSelection( int n )
+{
+    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 
-    wxFAIL_MSG( _T("wxComboBox: no selection") );
+    DisableEvents();
 
-    return _T("");
+    GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+    gtk_combo_box_set_active( combobox, n );
+
+    EnableEvents();
 }
 
-int wxComboBox::Number() const
+void wxComboBox::OnChar( wxKeyEvent &event )
 {
-    wxCHECK_MSG( m_widget != NULL, 0, _T("invalid combobox") );
-
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
+    switch ( event.GetKeyCode() )
+    {
+        case WXK_RETURN:
+            if ( HasFlag(wxTE_PROCESS_ENTER) )
+            {
+                // GTK automatically selects an item if its in the list
+                wxCommandEvent eventEnter(wxEVT_COMMAND_TEXT_ENTER, GetId());
+                eventEnter.SetString( GetValue() );
+                eventEnter.SetInt( GetSelection() );
+                eventEnter.SetEventObject( this );
+
+                if ( HandleWindowEvent(eventEnter) )
+                {
+                    // Catch GTK event so that GTK doesn't open the drop
+                    // down list upon RETURN.
+                    return;
+                }
+            }
+            break;
+    }
 
-    GList *child = GTK_LIST(list)->children;
-    int count = 0;
-    while (child) { count++; child = child->next; }
-    return count;
+    event.Skip();
 }
 
-void wxComboBox::SetSelection( int n )
+void wxComboBox::DisableEvents()
 {
-    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
+    g_signal_handlers_block_by_func(GTK_BIN(m_widget)->child,
+        (gpointer)gtkcombobox_text_changed_callback, this);
 
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
-    gtk_list_select_item( GTK_LIST(list), n );
+    g_signal_handlers_block_by_func(m_widget,
+        (gpointer)gtkcombobox_changed_callback, this);
 }
 
-void wxComboBox::SetStringSelection( const wxString &string )
+void wxComboBox::EnableEvents()
 {
-    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
+    g_signal_handlers_unblock_by_func(GTK_BIN(m_widget)->child,
+        (gpointer)gtkcombobox_text_changed_callback, this);
 
-    int res = FindString( string );
-    if (res == -1) return;
-    SetSelection( res );
+    g_signal_handlers_unblock_by_func(m_widget,
+        (gpointer)gtkcombobox_changed_callback, this);
 }
 
-wxString wxComboBox::GetValue() const
+GtkWidget* wxComboBox::GetConnectWidget()
 {
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    wxString tmp = wxString(gtk_entry_get_text( GTK_ENTRY(entry) ),*wxConvCurrent);
-    return tmp;
+    return GTK_WIDGET( GetEntry() );
 }
 
-void wxComboBox::SetValue( const wxString& value )
+GdkWindow *wxComboBox::GTKGetWindow(wxArrayGdkWindows& windows) const
 {
-    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
+    wxUnusedVar(windows);
 
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    wxString tmp = _T("");
-    if (!value.IsNull()) tmp = value;
-    gtk_entry_set_text( GTK_ENTRY(entry), tmp.mbc_str() );
+    return GetEntry()->text_area;
 }
 
-void wxComboBox::Copy()
+wxSize wxComboBox::DoGetBestSize() const
 {
-    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
+    // strangely, this returns a width of 188 pixels from GTK+ (?)
+    wxSize ret( wxControl::DoGetBestSize() );
 
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-#if (GTK_MINOR_VERSION > 0)
-    gtk_editable_copy_clipboard( GTK_EDITABLE(entry) );
-#else
-    gtk_editable_copy_clipboard( GTK_EDITABLE(entry), 0 );
-#endif
-}
+    // we know better our horizontal extent: it depends on the longest string
+    // in the combobox
+    if ( m_widget )
+    {
+        ret.x = 60;  // start with something "sensible"
+        int width;
+        unsigned int count = GetCount();
+        for ( unsigned int n = 0; n < count; n++ )
+        {
+            GetTextExtent(GetString(n), &width, NULL, NULL, NULL );
+            if ( width + 40 > ret.x ) // 40 for drop down arrow and space around text
+                ret.x = width + 40;
+        }
+    }
 
-void wxComboBox::Cut()
-{
-    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
+    // empty combobox should have some reasonable default size too
+    if ((GetCount() == 0) && (ret.x < 80))
+        ret.x = 80;
 
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-#if (GTK_MINOR_VERSION > 0)
-    gtk_editable_cut_clipboard( GTK_EDITABLE(entry) );
-#else
-    gtk_editable_cut_clipboard( GTK_EDITABLE(entry), 0 );
-#endif
+    CacheBestSize(ret);
+    return ret;
 }
 
-void wxComboBox::Paste()
+// static
+wxVisualAttributes
+wxComboBox::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant))
 {
-    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
-
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-#if (GTK_MINOR_VERSION > 0)
-    gtk_editable_paste_clipboard( GTK_EDITABLE(entry) );
-#else
-    gtk_editable_paste_clipboard( GTK_EDITABLE(entry), 0 );
-#endif
+    return GetDefaultAttributesFromGTKWidget(gtk_combo_box_entry_new, true);
 }
 
-void wxComboBox::SetInsertionPoint( long pos )
-{
-    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
+// ----------------------------------------------------------------------------
+// standard event handling
+// ----------------------------------------------------------------------------
 
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_entry_set_position( GTK_ENTRY(entry), (int)pos );
+void wxComboBox::OnCut(wxCommandEvent& WXUNUSED(event))
+{
+    Cut();
 }
 
-void wxComboBox::SetInsertionPointEnd()
+void wxComboBox::OnCopy(wxCommandEvent& WXUNUSED(event))
 {
-    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
-
-    SetInsertionPoint( -1 );
+    Copy();
 }
 
-long wxComboBox::GetInsertionPoint() const
+void wxComboBox::OnPaste(wxCommandEvent& WXUNUSED(event))
 {
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    return (long) GTK_EDITABLE(entry)->current_pos;
+    Paste();
 }
 
-long wxComboBox::GetLastPosition() const
+void wxComboBox::OnUndo(wxCommandEvent& WXUNUSED(event))
 {
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    int pos = GTK_ENTRY(entry)->text_length;
-    return (long) pos-1;
+    Undo();
 }
 
-void wxComboBox::Replace( long from, long to, const wxString& value )
+void wxComboBox::OnRedo(wxCommandEvent& WXUNUSED(event))
 {
-    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
-    // FIXME: not quite sure how to do this method right in multibyte mode
-
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_editable_delete_text( GTK_EDITABLE(entry), (gint)from, (gint)to );
-    if (value.IsNull()) return;
-    gint pos = (gint)to;
-    gtk_editable_insert_text( GTK_EDITABLE(entry), value.mbc_str(), value.Length(), &pos );
+    Redo();
 }
 
-void wxComboBox::Remove(long from, long to)
+void wxComboBox::OnDelete(wxCommandEvent& WXUNUSED(event))
 {
-    wxCHECK_RET( m_widget != NULL, _T("invalid combobox") );
-
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_editable_delete_text( GTK_EDITABLE(entry), (gint)from, (gint)to );
+    RemoveSelection();
 }
 
-void wxComboBox::SetSelection( long from, long to )
+void wxComboBox::OnSelectAll(wxCommandEvent& WXUNUSED(event))
 {
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_editable_select_region( GTK_EDITABLE(entry), (gint)from, (gint)to );
+    SelectAll();
 }
 
-void wxComboBox::SetEditable( bool editable )
+void wxComboBox::OnUpdateCut(wxUpdateUIEvent& event)
 {
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_entry_set_editable( GTK_ENTRY(entry), editable );
+    event.Enable( CanCut() );
 }
 
-void wxComboBox::OnChar( wxKeyEvent &event )
+void wxComboBox::OnUpdateCopy(wxUpdateUIEvent& event)
 {
-    if ( event.KeyCode() == WXK_RETURN )
-    {
-        wxString value = GetValue();
-
-        if ( Number() == 0 )
-        {
-            // make Enter generate "selected" event if there is only one item
-            // in the combobox - without it, it's impossible to select it at
-            // all!
-            wxCommandEvent event( wxEVT_COMMAND_COMBOBOX_SELECTED, GetId() );
-            event.SetInt( 0 );
-            event.SetString( value );
-            event.SetEventObject( this );
-            GetEventHandler()->ProcessEvent( event );
-        }
-        else
-        {
-            // add the item to the list if it's not there yet
-            if ( FindString(value) == wxNOT_FOUND )
-            {
-                Append(value);
-
-                // and generate the selected event for it
-                wxCommandEvent event( wxEVT_COMMAND_COMBOBOX_SELECTED, GetId() );
-                event.SetInt( Number() - 1 );
-                event.SetString( value );
-                event.SetEventObject( this );
-                GetEventHandler()->ProcessEvent( event );
-            }
-            //else: do nothing, this will open the listbox
-        }
-    }
-
-    event.Skip();
+    event.Enable( CanCopy() );
 }
 
-void wxComboBox::OnSize( wxSizeEvent &event )
+void wxComboBox::OnUpdatePaste(wxUpdateUIEvent& event)
 {
-    wxControl::OnSize( event );
-
-    int w = 21;
-    gtk_widget_set_usize( GTK_COMBO(m_widget)->entry, m_width-w-1, m_height );
-
-    gtk_widget_set_uposition( GTK_COMBO(m_widget)->button, m_x+m_width-w, m_y );
-    gtk_widget_set_usize( GTK_COMBO(m_widget)->button, w, m_height );
+    event.Enable( CanPaste() );
 }
 
-void wxComboBox::ApplyWidgetStyle()
+void wxComboBox::OnUpdateUndo(wxUpdateUIEvent& event)
 {
-    SetWidgetStyle();
-
-//    gtk_widget_set_style( GTK_COMBO(m_widget)->button, m_widgetStyle );
-    gtk_widget_set_style( GTK_COMBO(m_widget)->entry, m_widgetStyle );
-    gtk_widget_set_style( GTK_COMBO(m_widget)->list, m_widgetStyle );
-
-    GtkList *list = GTK_LIST( GTK_COMBO(m_widget)->list );
-    GList *child = list->children;
-    while (child)
-    {
-        gtk_widget_set_style( GTK_WIDGET(child->data), m_widgetStyle );
-
-        GtkBin *bin = GTK_BIN(child->data);
-        gtk_widget_set_style( bin->child, m_widgetStyle );
+    event.Enable( CanUndo() );
+}
 
-        child = child->next;
-    }
+void wxComboBox::OnUpdateRedo(wxUpdateUIEvent& event)
+{
+    event.Enable( CanRedo() );
 }
 
-GtkWidget* wxComboBox::GetConnectWidget()
+void wxComboBox::OnUpdateDelete(wxUpdateUIEvent& event)
 {
-    return GTK_COMBO(m_widget)->entry;
+    event.Enable(HasSelection() && IsEditable()) ;
 }
 
-bool wxComboBox::IsOwnGtkWindow( GdkWindow *window )
+void wxComboBox::OnUpdateSelectAll(wxUpdateUIEvent& event)
 {
-    return ( (window == GTK_ENTRY( GTK_COMBO(m_widget)->entry )->text_area) ||
-             (window == GTK_COMBO(m_widget)->button->window ) );
+    event.Enable(!wxTextEntry::IsEmpty());
 }
 
+#endif // wxUSE_COMBOBOX