X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/5159e01481609101d7bf20b3e32457346e631df6..cbeda384e51acb82e13994cb67ac1714669cae10:/include/wx/thread.h diff --git a/include/wx/thread.h b/include/wx/thread.h index f9751d23c1..64a62f17da 100644 --- a/include/wx/thread.h +++ b/include/wx/thread.h @@ -161,7 +161,7 @@ protected: friend class wxConditionInternal; - DECLARE_NO_COPY_CLASS(wxMutex) + wxDECLARE_NO_COPY_CLASS(wxMutex); }; // a helper class which locks the mutex in the ctor and unlocks it in the dtor: @@ -266,12 +266,12 @@ private: }; #endif // Unix&OS2/Win32 - DECLARE_NO_COPY_CLASS(wxCriticalSection) + wxDECLARE_NO_COPY_CLASS(wxCriticalSection); }; #if wxCRITSECT_IS_MUTEX // implement wxCriticalSection using mutexes - inline wxCriticalSection::wxCriticalSection( wxCriticalSectionType critSecType ) + inline wxCriticalSection::wxCriticalSection( wxCriticalSectionType critSecType ) : m_mutex( critSecType == wxCRITSEC_DEFAULT ? wxMUTEX_RECURSIVE : wxMUTEX_DEFAULT ) { } inline wxCriticalSection::~wxCriticalSection() { } @@ -301,7 +301,7 @@ public: private: wxCriticalSection& m_critsect; - DECLARE_NO_COPY_CLASS(wxCriticalSectionLocker) + wxDECLARE_NO_COPY_CLASS(wxCriticalSectionLocker); }; // ---------------------------------------------------------------------------- @@ -364,7 +364,7 @@ public: private: wxConditionInternal *m_internal; - DECLARE_NO_COPY_CLASS(wxCondition) + wxDECLARE_NO_COPY_CLASS(wxCondition); }; #if WXWIN_COMPATIBILITY_2_6 @@ -409,7 +409,7 @@ public: private: wxSemaphoreInternal *m_internal; - DECLARE_NO_COPY_CLASS(wxSemaphore) + wxDECLARE_NO_COPY_CLASS(wxSemaphore); }; // ---------------------------------------------------------------------------- @@ -506,7 +506,7 @@ public: // does it! // // will fill the rc pointer with the thread exit code if it's !NULL - wxThreadError Delete(ExitCode *rc = (ExitCode *)NULL); + wxThreadError Delete(ExitCode *rc = NULL); // waits for a joinable thread to finish and returns its exit code // @@ -558,11 +558,6 @@ public: wxThreadKind GetKind() const { return m_isDetached ? wxTHREAD_DETACHED : wxTHREAD_JOINABLE; } - // called when the thread exits - in the context of this thread - // - // NB: this function will not be called if the thread is Kill()ed - virtual void OnExit() { } - // Returns true if the thread was asked to terminate: this function should // be called by the thread from time to time, otherwise the main thread // will be left forever in Delete()! @@ -585,6 +580,11 @@ private: wxThread(const wxThread&); wxThread& operator=(const wxThread&); + // called when the thread exits - in the context of this thread + // + // NB: this function will not be called if the thread is Kill()ed + virtual void OnExit() { } + friend class wxThreadInternal; // the (platform-dependent) thread class implementation @@ -633,20 +633,19 @@ class WXDLLIMPEXP_BASE wxThreadHelper private: void KillThread() { - // If detached thread is about to finish, it will set - // m_thread to NULL so don't delete it then - // But if KillThread is called before detached thread - // sets it to NULL, then the thread object still - // exists and can be killed + // If wxThreadHelperThread is detached and is about to finish, it will + // set m_thread to NULL so don't delete it then. + // But if KillThread is called before wxThreadHelperThread (in detached mode) + // sets it to NULL, then the thread object still exists and can be killed wxCriticalSectionLocker locker(m_critSection); - + if ( m_thread ) { m_thread->Kill(); - + if ( m_kind == wxTHREAD_JOINABLE ) delete m_thread; - + m_thread = NULL; } } @@ -659,12 +658,18 @@ public: // destructor deletes m_thread virtual ~wxThreadHelper() { KillThread(); } +#if WXWIN_COMPATIBILITY_2_8 + wxDEPRECATED( wxThreadError Create(unsigned int stackSize = 0) ); +#endif + // create a new thread (and optionally set the stack size on platforms that // support/need that), call Run() to start it - wxThreadError Create(unsigned int stackSize = 0) + wxThreadError CreateThread(wxThreadKind kind = wxTHREAD_JOINABLE, + unsigned int stackSize = 0) { KillThread(); + m_kind = kind; m_thread = new wxThreadHelperThread(*this, m_kind); return m_thread->Create(stackSize); @@ -678,9 +683,9 @@ public: wxThread *GetThread() const { wxCriticalSectionLocker locker((wxCriticalSection&)m_critSection); - + wxThread* thread = m_thread; - + return thread; } @@ -688,24 +693,29 @@ protected: wxThread *m_thread; wxThreadKind m_kind; wxCriticalSection m_critSection; // To guard the m_thread variable - + friend class wxThreadHelperThread; }; +#if WXWIN_COMPATIBILITY_2_8 +inline wxThreadError wxThreadHelper::Create(unsigned int stackSize) +{ return CreateThread(m_kind, stackSize); } +#endif + // call Entry() in owner, put it down here to avoid circular declarations inline void *wxThreadHelperThread::Entry() { void * const result = m_owner.Entry(); - + wxCriticalSectionLocker locker(m_owner.m_critSection); - + // Detached thread will be deleted after returning, so make sure // wxThreadHelper::GetThread will not return an invalid pointer. // And that wxThreadHelper::KillThread will not try to kill // an already deleted thread if ( m_owner.m_kind == wxTHREAD_DETACHED ) m_owner.m_thread = NULL; - + return result; } @@ -737,11 +747,13 @@ inline void wxMutexGuiLeave() { } // macros for entering/leaving critical sections which may be used without // having to take them inside "#if wxUSE_THREADS" -// (the implementation uses dummy structs to force semicolon after the macro) +// (the implementation uses dummy structs to force semicolon after the macro; +// also notice that Watcom doesn't like declaring a struct as a member so we +// need to actually define it in wxCRIT_SECT_DECLARE_MEMBER) #define wxENTER_CRIT_SECT(cs) do {} while (0) #define wxLEAVE_CRIT_SECT(cs) do {} while (0) #define wxCRIT_SECT_DECLARE(cs) struct wxDummyCS##cs -#define wxCRIT_SECT_DECLARE_MEMBER(cs) struct wxDummyCSMember##cs +#define wxCRIT_SECT_DECLARE_MEMBER(cs) struct wxDummyCSMember##cs { } #define wxCRIT_SECT_LOCKER(name, cs) struct wxDummyCSLocker##name // if there is only one thread, it is always the main one