X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/4a04898fe048cc8281e051e42af926924e806b6e..a9fd42ccebb2534cfd3910bc7108171f4ee6d54b:/tests/controls/gridtest.cpp?ds=sidebyside diff --git a/tests/controls/gridtest.cpp b/tests/controls/gridtest.cpp index 6bde424215..8012b51429 100644 --- a/tests/controls/gridtest.cpp +++ b/tests/controls/gridtest.cpp @@ -24,6 +24,20 @@ #include "asserthelper.h" #include "wx/uiaction.h" +// FIXME: A lot of mouse-related tests sporadically fail in wxGTK. This happens +// almost all the time but sometimes the tests do pass and the failure +// doesn't happen when debugging so this looks like some kind of event +// dispatching/simulating problem rather than a real problem in wxGrid. +// +// Just disable these tests for now but it would be really great to +// really fix the problem. +#ifdef __WXGTK__ + #define NONGTK_TEST(test) +#else + #define NONGTK_TEST(test) WXUISIM_TEST(test) +#endif + + class GridTestCase : public CppUnit::TestCase { public: @@ -35,16 +49,17 @@ public: private: CPPUNIT_TEST_SUITE( GridTestCase ); WXUISIM_TEST( CellEdit ); - WXUISIM_TEST( CellClick ); - WXUISIM_TEST( CellSelect ); - WXUISIM_TEST( LabelClick ); - WXUISIM_TEST( SortClick ); + NONGTK_TEST( CellClick ); + NONGTK_TEST( CellSelect ); + NONGTK_TEST( LabelClick ); + NONGTK_TEST( SortClick ); WXUISIM_TEST( Size ); - WXUISIM_TEST( RangeSelect ); + NONGTK_TEST( RangeSelect ); CPPUNIT_TEST( Cursor ); CPPUNIT_TEST( Selection ); CPPUNIT_TEST( AddRowCol ); CPPUNIT_TEST( ColumnOrder ); + CPPUNIT_TEST( ColumnVisibility ); CPPUNIT_TEST( LineFormatting ); CPPUNIT_TEST( SortSupport ); CPPUNIT_TEST( Labels ); @@ -53,12 +68,12 @@ private: WXUISIM_TEST( Editable ); WXUISIM_TEST( ReadOnly ); CPPUNIT_TEST( PseudoTest_NativeHeader ); - WXUISIM_TEST( LabelClick ); - WXUISIM_TEST( SortClick ); + NONGTK_TEST( LabelClick ); + NONGTK_TEST( SortClick ); CPPUNIT_TEST( ColumnOrder ); CPPUNIT_TEST( PseudoTest_NativeLabels ); - WXUISIM_TEST( LabelClick ); - WXUISIM_TEST( SortClick ); + NONGTK_TEST( LabelClick ); + NONGTK_TEST( SortClick ); CPPUNIT_TEST( ColumnOrder ); CPPUNIT_TEST_SUITE_END(); @@ -73,6 +88,7 @@ private: void Selection(); void AddRowCol(); void ColumnOrder(); + void ColumnVisibility(); void LineFormatting(); void SortSupport(); void Labels(); @@ -120,18 +136,27 @@ void GridTestCase::setUp() void GridTestCase::tearDown() { + // This is just a hack to continue the rest of the tests to run: if we + // destroy the header control while it has capture, this results in an + // assert failure and while handling an exception from it more bad things + // happen (as it's thrown from a dtor), resulting in simply aborting + // everything. So ensure that it doesn't have capture in any case. + // + // Of course, the right thing to do would be to understand why does it + // still have capture when the grid is destroyed sometimes. + wxWindow* const win = wxWindow::GetCapture(); + if ( win ) + win->ReleaseMouse(); + wxDELETE(m_grid); } void GridTestCase::CellEdit() { #if wxUSE_UIACTIONSIMULATOR - wxTestableFrame* frame = wxStaticCast(wxTheApp->GetTopWindow(), - wxTestableFrame); - - EventCounter count(m_grid, wxEVT_GRID_CELL_CHANGING); - EventCounter count1(m_grid, wxEVT_GRID_CELL_CHANGED); - EventCounter count2(m_grid, wxEVT_GRID_EDITOR_CREATED); + EventCounter changing(m_grid, wxEVT_GRID_CELL_CHANGING); + EventCounter changed(m_grid, wxEVT_GRID_CELL_CHANGED); + EventCounter created(m_grid, wxEVT_GRID_EDITOR_CREATED); wxUIActionSimulator sim; @@ -144,31 +169,28 @@ void GridTestCase::CellEdit() wxYield(); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_EDITOR_CREATED)); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_CELL_CHANGING)); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_CELL_CHANGED)); + CPPUNIT_ASSERT_EQUAL(1, created.GetCount()); + CPPUNIT_ASSERT_EQUAL(1, changing.GetCount()); + CPPUNIT_ASSERT_EQUAL(1, changed.GetCount()); #endif } void GridTestCase::CellClick() { #if wxUSE_UIACTIONSIMULATOR - wxTestableFrame* frame = wxStaticCast(wxTheApp->GetTopWindow(), - wxTestableFrame); - - EventCounter count(m_grid, wxEVT_GRID_CELL_LEFT_CLICK); - EventCounter count1(m_grid, wxEVT_GRID_CELL_LEFT_DCLICK); - EventCounter count2(m_grid, wxEVT_GRID_CELL_RIGHT_CLICK); - EventCounter count3(m_grid, wxEVT_GRID_CELL_RIGHT_DCLICK); + EventCounter lclick(m_grid, wxEVT_GRID_CELL_LEFT_CLICK); + EventCounter ldclick(m_grid, wxEVT_GRID_CELL_LEFT_DCLICK); + EventCounter rclick(m_grid, wxEVT_GRID_CELL_RIGHT_CLICK); + EventCounter rdclick(m_grid, wxEVT_GRID_CELL_RIGHT_DCLICK); wxUIActionSimulator sim; wxRect rect = m_grid->CellToRect(0, 0); wxPoint point = m_grid->CalcScrolledPosition(rect.GetPosition()); - point = frame->ClientToScreen(point + wxPoint(m_grid->GetRowLabelSize(), - m_grid->GetColLabelSize()) - + wxPoint(2, 2)); + point = m_grid->ClientToScreen(point + wxPoint(m_grid->GetRowLabelSize(), + m_grid->GetColLabelSize()) + + wxPoint(2, 2)); sim.MouseMove(point); wxYield(); @@ -176,44 +198,43 @@ void GridTestCase::CellClick() sim.MouseClick(); wxYield(); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_CELL_LEFT_CLICK)); + CPPUNIT_ASSERT_EQUAL(1, lclick.GetCount()); + lclick.Clear(); sim.MouseDblClick(); wxYield(); //A double click event sends a single click event first //test to ensure this still happens in the future - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_CELL_LEFT_CLICK)); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_CELL_LEFT_DCLICK)); + CPPUNIT_ASSERT_EQUAL(1, lclick.GetCount()); + CPPUNIT_ASSERT_EQUAL(1, ldclick.GetCount()); sim.MouseClick(wxMOUSE_BTN_RIGHT); wxYield(); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_CELL_RIGHT_CLICK)); + CPPUNIT_ASSERT_EQUAL(1, rclick.GetCount()); + rclick.Clear(); sim.MouseDblClick(wxMOUSE_BTN_RIGHT); wxYield(); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_CELL_RIGHT_CLICK)); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_CELL_RIGHT_DCLICK)); + CPPUNIT_ASSERT_EQUAL(1, rclick.GetCount()); + CPPUNIT_ASSERT_EQUAL(1, rdclick.GetCount()); #endif } void GridTestCase::CellSelect() { #if wxUSE_UIACTIONSIMULATOR - wxTestableFrame* frame = wxStaticCast(wxTheApp->GetTopWindow(), - wxTestableFrame); - - EventCounter count(m_grid, wxEVT_GRID_SELECT_CELL); + EventCounter cell(m_grid, wxEVT_GRID_SELECT_CELL); wxUIActionSimulator sim; wxRect rect = m_grid->CellToRect(0, 0); wxPoint point = m_grid->CalcScrolledPosition(rect.GetPosition()); - point = frame->ClientToScreen(point + wxPoint(m_grid->GetRowLabelSize(), - m_grid->GetColLabelSize()) - + wxPoint(4, 4)); + point = m_grid->ClientToScreen(point + wxPoint(m_grid->GetRowLabelSize(), + m_grid->GetColLabelSize()) + + wxPoint(4, 4)); sim.MouseMove(point); wxYield(); @@ -221,7 +242,9 @@ void GridTestCase::CellSelect() sim.MouseClick(); wxYield(); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_SELECT_CELL)); + CPPUNIT_ASSERT_EQUAL(1, cell.GetCount()); + + cell.Clear(); m_grid->SetGridCursor(1, 1); m_grid->GoToCell(1, 0); @@ -232,20 +255,17 @@ void GridTestCase::CellSelect() sim.MouseDblClick(); wxYield(); - CPPUNIT_ASSERT_EQUAL(3, frame->GetEventCount(wxEVT_GRID_SELECT_CELL)); + CPPUNIT_ASSERT_EQUAL(3, cell.GetCount()); #endif } void GridTestCase::LabelClick() { #if wxUSE_UIACTIONSIMULATOR - wxTestableFrame* frame = wxStaticCast(wxTheApp->GetTopWindow(), - wxTestableFrame); - - EventCounter count(m_grid, wxEVT_GRID_LABEL_LEFT_CLICK); - EventCounter count1(m_grid, wxEVT_GRID_LABEL_LEFT_DCLICK); - EventCounter count2(m_grid, wxEVT_GRID_LABEL_RIGHT_CLICK); - EventCounter count3(m_grid, wxEVT_GRID_LABEL_RIGHT_DCLICK); + EventCounter lclick(m_grid, wxEVT_GRID_LABEL_LEFT_CLICK); + EventCounter ldclick(m_grid, wxEVT_GRID_LABEL_LEFT_DCLICK); + EventCounter rclick(m_grid, wxEVT_GRID_LABEL_RIGHT_CLICK); + EventCounter rdclick(m_grid, wxEVT_GRID_LABEL_RIGHT_DCLICK); wxUIActionSimulator sim; @@ -258,17 +278,18 @@ void GridTestCase::LabelClick() sim.MouseClick(); wxYield(); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_LABEL_LEFT_CLICK)); + CPPUNIT_ASSERT_EQUAL(1, lclick.GetCount()); sim.MouseDblClick(); wxYield(); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_LABEL_LEFT_DCLICK)); + CPPUNIT_ASSERT_EQUAL(1, ldclick.GetCount()); sim.MouseClick(wxMOUSE_BTN_RIGHT); wxYield(); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_LABEL_RIGHT_CLICK)); + CPPUNIT_ASSERT_EQUAL(1, rclick.GetCount()); + rclick.Clear(); sim.MouseDblClick(wxMOUSE_BTN_RIGHT); wxYield(); @@ -277,12 +298,12 @@ void GridTestCase::LabelClick() { //Right double click not supported with native headers so we get two //right click events - CPPUNIT_ASSERT_EQUAL(2, frame->GetEventCount(wxEVT_GRID_LABEL_RIGHT_CLICK)); + CPPUNIT_ASSERT_EQUAL(2, rclick.GetCount()); } else { - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_LABEL_RIGHT_CLICK)); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_LABEL_RIGHT_DCLICK)); + CPPUNIT_ASSERT_EQUAL(1, rclick.GetCount()); + CPPUNIT_ASSERT_EQUAL(1, rdclick.GetCount()); } #endif } @@ -292,10 +313,7 @@ void GridTestCase::SortClick() #if wxUSE_UIACTIONSIMULATOR m_grid->SetSortingColumn(0); - wxTestableFrame* frame = wxStaticCast(wxTheApp->GetTopWindow(), - wxTestableFrame); - - EventCounter count(m_grid, wxEVT_GRID_COL_SORT); + EventCounter sort(m_grid, wxEVT_GRID_COL_SORT); wxUIActionSimulator sim; @@ -308,18 +326,15 @@ void GridTestCase::SortClick() sim.MouseClick(); wxYield(); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount()); + CPPUNIT_ASSERT_EQUAL(1, sort.GetCount()); #endif } void GridTestCase::Size() { #if wxUSE_UIACTIONSIMULATOR && !defined(__WXGTK__) - wxTestableFrame* frame = wxStaticCast(wxTheApp->GetTopWindow(), - wxTestableFrame); - - EventCounter count(m_grid, wxEVT_GRID_COL_SIZE); - EventCounter count1(m_grid, wxEVT_GRID_ROW_SIZE); + EventCounter colsize(m_grid, wxEVT_GRID_COL_SIZE); + EventCounter rowsize(m_grid, wxEVT_GRID_ROW_SIZE); wxUIActionSimulator sim; @@ -338,7 +353,7 @@ void GridTestCase::Size() sim.MouseUp(); wxYield(); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_COL_SIZE)); + CPPUNIT_ASSERT_EQUAL(1, colsize.GetCount()); pt = m_grid->ClientToScreen(wxPoint(5, m_grid->GetColLabelSize() + m_grid->GetRowSize(0))); @@ -346,17 +361,14 @@ void GridTestCase::Size() sim.MouseDragDrop(pt.x, pt.y, pt.x, pt.y + 50); wxYield(); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_ROW_SIZE)); + CPPUNIT_ASSERT_EQUAL(1, rowsize.GetCount()); #endif } void GridTestCase::RangeSelect() { #if wxUSE_UIACTIONSIMULATOR - wxTestableFrame* frame = wxStaticCast(wxTheApp->GetTopWindow(), - wxTestableFrame); - - EventCounter count(m_grid, wxEVT_GRID_RANGE_SELECT); + EventCounter select(m_grid, wxEVT_GRID_RANGE_SELECT); wxUIActionSimulator sim; @@ -377,7 +389,7 @@ void GridTestCase::RangeSelect() sim.MouseUp(); wxYield(); - CPPUNIT_ASSERT_EQUAL(1, frame->GetEventCount(wxEVT_GRID_RANGE_SELECT)); + CPPUNIT_ASSERT_EQUAL(1, select.GetCount()); #endif } @@ -516,6 +528,19 @@ void GridTestCase::ColumnOrder() CPPUNIT_ASSERT_EQUAL(3, m_grid->GetColPos(3)); } +void GridTestCase::ColumnVisibility() +{ + m_grid->AppendCols(3); + CPPUNIT_ASSERT( m_grid->IsColShown(1) ); + + m_grid->HideCol(1); + CPPUNIT_ASSERT( !m_grid->IsColShown(1) ); + CPPUNIT_ASSERT( m_grid->IsColShown(2) ); + + m_grid->ShowCol(1); + CPPUNIT_ASSERT( m_grid->IsColShown(1) ); +} + void GridTestCase::LineFormatting() { CPPUNIT_ASSERT(m_grid->GridLinesEnabled()); @@ -587,16 +612,9 @@ void GridTestCase::SelectionMode() m_grid->SetSelectionMode(wxGrid::wxGridSelectRows); m_grid->SelectBlock(3, 1, 3, 1); - wxGridCellCoordsArray topleft = m_grid->GetSelectionBlockTopLeft(); - wxGridCellCoordsArray bottomright = m_grid->GetSelectionBlockBottomRight(); - - CPPUNIT_ASSERT_EQUAL(1, topleft.Count()); - CPPUNIT_ASSERT_EQUAL(1, bottomright.Count()); - - CPPUNIT_ASSERT_EQUAL(0, topleft.Item(0).GetCol()); - CPPUNIT_ASSERT_EQUAL(3, topleft.Item(0).GetRow()); - CPPUNIT_ASSERT_EQUAL(1, bottomright.Item(0).GetCol()); - CPPUNIT_ASSERT_EQUAL(3, bottomright.Item(0).GetRow()); + wxArrayInt selectedRows = m_grid->GetSelectedRows(); + CPPUNIT_ASSERT_EQUAL(1, selectedRows.Count()); + CPPUNIT_ASSERT_EQUAL(3, selectedRows[0]); CPPUNIT_ASSERT_EQUAL(wxGrid::wxGridSelectRows, m_grid->GetSelectionMode()); @@ -607,16 +625,9 @@ void GridTestCase::SelectionMode() m_grid->SetSelectionMode(wxGrid::wxGridSelectColumns); m_grid->SelectBlock(3, 1, 3, 1); - topleft = m_grid->GetSelectionBlockTopLeft(); - bottomright = m_grid->GetSelectionBlockBottomRight(); - - CPPUNIT_ASSERT_EQUAL(1, topleft.Count()); - CPPUNIT_ASSERT_EQUAL(1, bottomright.Count()); - - CPPUNIT_ASSERT_EQUAL(1, topleft.Item(0).GetCol()); - CPPUNIT_ASSERT_EQUAL(0, topleft.Item(0).GetRow()); - CPPUNIT_ASSERT_EQUAL(1, bottomright.Item(0).GetCol()); - CPPUNIT_ASSERT_EQUAL(9, bottomright.Item(0).GetRow()); + wxArrayInt selectedCols = m_grid->GetSelectedCols(); + CPPUNIT_ASSERT_EQUAL(1, selectedCols.Count()); + CPPUNIT_ASSERT_EQUAL(1, selectedCols[0]); CPPUNIT_ASSERT_EQUAL(wxGrid::wxGridSelectColumns, m_grid->GetSelectionMode()); @@ -670,11 +681,8 @@ void GridTestCase::CellFormatting() void GridTestCase::Editable() { #if wxUSE_UIACTIONSIMULATOR - wxTestableFrame* frame = wxStaticCast(wxTheApp->GetTopWindow(), - wxTestableFrame); - //As the grid is not editable we shouldn't create an editor - EventCounter count(m_grid, wxEVT_GRID_EDITOR_CREATED); + EventCounter created(m_grid, wxEVT_GRID_EDITOR_CREATED); wxUIActionSimulator sim; @@ -694,18 +702,15 @@ void GridTestCase::Editable() sim.Char(WXK_RETURN); wxYield(); - CPPUNIT_ASSERT_EQUAL(0, frame->GetEventCount()); + CPPUNIT_ASSERT_EQUAL(0, created.GetCount()); #endif } void GridTestCase::ReadOnly() { #if wxUSE_UIACTIONSIMULATOR - wxTestableFrame* frame = wxStaticCast(wxTheApp->GetTopWindow(), - wxTestableFrame); - //As the cell is readonly we shouldn't create an editor - EventCounter count(m_grid, wxEVT_GRID_EDITOR_CREATED); + EventCounter created(m_grid, wxEVT_GRID_EDITOR_CREATED); wxUIActionSimulator sim; @@ -728,7 +733,7 @@ void GridTestCase::ReadOnly() sim.Char(WXK_RETURN); wxYield(); - CPPUNIT_ASSERT_EQUAL(0, frame->GetEventCount()); + CPPUNIT_ASSERT_EQUAL(0, created.GetCount()); #endif }