X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/40989e46b86777dd211faeb3e5d2366cdcc6d8cd..b86db821bf1d67c15f87c5343134170a39a363d1:/src/gtk/colour.cpp

diff --git a/src/gtk/colour.cpp b/src/gtk/colour.cpp
index bc76dbfe65..79b2c37f1d 100644
--- a/src/gtk/colour.cpp
+++ b/src/gtk/colour.cpp
@@ -23,22 +23,16 @@
 class wxColourRefData: public wxObjectRefData
 {
 public:
-    wxColourRefData()
+    wxColourRefData(guint16 red, guint16 green, guint16 blue)
     {
-        m_color.red = 0;
-        m_color.green = 0;
-        m_color.blue = 0;
+        m_color.red =
+        m_red = red;
+        m_color.green =
+        m_green = green;
+        m_color.blue =
+        m_blue = blue;
         m_color.pixel = 0;
         m_colormap = NULL;
-        m_hasPixel = false;
-    }
-
-    wxColourRefData(const wxColourRefData& data)
-        : wxObjectRefData()
-    {
-        m_color = data.m_color;
-        m_colormap = data.m_colormap;
-        m_hasPixel = data.m_hasPixel;
     }
 
     ~wxColourRefData()
@@ -51,37 +45,54 @@ public:
 
     GdkColor     m_color;
     GdkColormap *m_colormap;
-    bool         m_hasPixel;
+    // gdk_colormap_alloc_color may change the RGB values in m_color, so we need separate copies
+    guint16 m_red;
+    guint16 m_green;
+    guint16 m_blue;
+
+    DECLARE_NO_COPY_CLASS(wxColourRefData)
 };
 
 void wxColourRefData::FreeColour()
 {
-    if (m_hasPixel)
+    if (m_colormap)
     {
         gdk_colormap_free_colors(m_colormap, &m_color, 1);
+        m_colormap = NULL;
+        m_color.pixel = 0;
     }
 }
 
 void wxColourRefData::AllocColour( GdkColormap *cmap )
 {
-    if (m_hasPixel && (m_colormap == cmap))
-        return;
-
-    FreeColour();
+    if (m_colormap != cmap)
+    {
+        FreeColour();
 
-    m_hasPixel = gdk_colormap_alloc_color(cmap, &m_color, FALSE, TRUE);
-    m_colormap = cmap;
+        m_color.red = m_red;
+        m_color.green = m_green;
+        m_color.blue = m_blue;
+        if (gdk_colormap_alloc_color(cmap, &m_color, FALSE, TRUE))
+        {
+            m_colormap = cmap;
+        }
+    }
 }
 
 //-----------------------------------------------------------------------------
 
 #define M_COLDATA wx_static_cast(wxColourRefData*, m_refData)
 
-// GDK's values are in 0..65535 range, our are in 0..255
+// GDK's values are in 0..65535 range, ours are in 0..255
 #define SHIFT  8
 
 IMPLEMENT_DYNAMIC_CLASS(wxColour,wxGDIObject)
 
+wxColour::wxColour(const GdkColor& gdkColor)
+{
+    m_refData = new wxColourRefData(gdkColor.red, gdkColor.green, gdkColor.blue);
+}
+
 wxColour::~wxColour()
 {
 }
@@ -94,55 +105,42 @@ bool wxColour::operator == ( const wxColour& col ) const
     if (!m_refData || !col.m_refData)
         return false;
 
-    const GdkColor& own = M_COLDATA->m_color;
-    const GdkColor& other = wx_static_cast(wxColourRefData*, col.m_refData)->m_color;
-    return own.red == other.red &&
-           own.blue == other.blue &&
-           own.green == other.green;
-}
-
-wxObjectRefData *wxColour::CreateRefData() const
-{
-    return new wxColourRefData;
-}
-
-wxObjectRefData *wxColour::CloneRefData(const wxObjectRefData *data) const
-{
-    return new wxColourRefData(*(wxColourRefData *)data);
+    wxColourRefData* refData = M_COLDATA;
+    wxColourRefData* that_refData = wx_static_cast(wxColourRefData*, col.m_refData);
+    return refData->m_red == that_refData->m_red &&
+           refData->m_green == that_refData->m_green &&
+           refData->m_blue == that_refData->m_blue;
 }
 
 void wxColour::InitWith( unsigned char red, unsigned char green, unsigned char blue )
 {
-    AllocExclusive();
+    UnRef();
 
-    M_COLDATA->m_color.red = ((unsigned short)red) << SHIFT;
-    M_COLDATA->m_color.green = ((unsigned short)green) << SHIFT;
-    M_COLDATA->m_color.blue = ((unsigned short)blue) << SHIFT;
-    M_COLDATA->m_color.pixel = 0;
-
-    M_COLDATA->m_colormap = NULL;
-    M_COLDATA->m_hasPixel = false;
+    m_refData = new wxColourRefData(
+        (guint16(red) << SHIFT) + red,
+        (guint16(green) << SHIFT) + green,
+        (guint16(blue) << SHIFT) + blue);
 }
 
 unsigned char wxColour::Red() const
 {
     wxCHECK_MSG( Ok(), 0, wxT("invalid colour") );
 
-    return (unsigned char)(M_COLDATA->m_color.red >> SHIFT);
+    return wxByte(M_COLDATA->m_red >> SHIFT);
 }
 
 unsigned char wxColour::Green() const
 {
     wxCHECK_MSG( Ok(), 0, wxT("invalid colour") );
 
-    return (unsigned char)(M_COLDATA->m_color.green >> SHIFT);
+    return wxByte(M_COLDATA->m_green >> SHIFT);
 }
 
 unsigned char wxColour::Blue() const
 {
     wxCHECK_MSG( Ok(), 0, wxT("invalid colour") );
 
-    return (unsigned char)(M_COLDATA->m_color.blue >> SHIFT);
+    return wxByte(M_COLDATA->m_blue >> SHIFT);
 }
 
 void wxColour::CalcPixel( GdkColormap *cmap )
@@ -159,7 +157,11 @@ int wxColour::GetPixel() const
     return M_COLDATA->m_color.pixel;
 }
 
-GdkColor *wxColour::GetColor() const
+#ifdef __WXGTK24__
+const GdkColor *wxColour::GetColor() const
+#else
+      GdkColor *wxColour::GetColor() const
+#endif
 {
     wxCHECK_MSG( Ok(), NULL, wxT("invalid colour") );
 
@@ -171,10 +173,7 @@ bool wxColour::FromString(const wxChar *str)
     GdkColor colGDK;
     if ( gdk_color_parse( wxGTK_CONV_SYS( str ), &colGDK ) )
     {
-        UnRef();
-
-        m_refData = new wxColourRefData;
-        M_COLDATA->m_color = colGDK;
+        *this = wxColour(colGDK);
         return true;
     }