X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/3d1a4878f36ba4b5f66c2ccfd2cb27a9dc528b6f..5fa7a49ce395b2a84d0c5d405fdb13277402e95f:/src/mac/carbon/scrolbar.cpp?ds=sidebyside

diff --git a/src/mac/carbon/scrolbar.cpp b/src/mac/carbon/scrolbar.cpp
index 4dd6127cfb..2be39020bd 100644
--- a/src/mac/carbon/scrolbar.cpp
+++ b/src/mac/carbon/scrolbar.cpp
@@ -9,10 +9,6 @@
 // Licence:       wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
-#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
-#pragma implementation "scrolbar.h"
-#endif
-
 #include "wx/wxprec.h"
 
 #ifndef WX_PRECOMP
@@ -23,38 +19,34 @@
 #include "wx/scrolbar.h"
 #include "wx/mac/uma.h"
 
-#if !USE_SHARED_LIBRARY
 IMPLEMENT_DYNAMIC_CLASS(wxScrollBar, wxControl)
 
 BEGIN_EVENT_TABLE(wxScrollBar, wxControl)
 END_EVENT_TABLE()
 
-#endif
-
-extern ControlActionUPP wxMacLiveScrollbarActionUPP ;
 
-// Scrollbar
-bool wxScrollBar::Create(wxWindow *parent, wxWindowID id,
-           const wxPoint& pos,
-           const wxSize& size, long style,
-           const wxValidator& validator,
-           const wxString& name)
+bool wxScrollBar::Create(wxWindow *parent,
+    wxWindowID id,
+    const wxPoint& pos,
+    const wxSize& size,
+    long style,
+    const wxValidator& validator,
+    const wxString& name)
 {
-    m_macIsUserPane = FALSE ;
-    
+    m_macIsUserPane = false ;
+
     if ( !wxControl::Create(parent, id, pos, size, style, validator, name) )
-        return FALSE;
+        return false;
 
     Rect bounds = wxMacGetBoundsForControl( this , pos , size ) ;
 
-    m_peer = new wxMacControl() ;
-    verify_noerr ( CreateScrollBarControl( MAC_WXHWND(parent->MacGetTopLevelWindowRef()) , &bounds , 
-    0 , 0 , 100 , 1 , true /* liveTracking */ , wxMacLiveScrollbarActionUPP , m_peer->GetControlRefAddr() ) );
-    
+    m_peer = new wxMacControl(this) ;
+    verify_noerr( CreateScrollBarControl( MAC_WXHWND(parent->MacGetTopLevelWindowRef()) , &bounds ,
+    0 , 0 , 100 , 1 , true /* liveTracking */ , GetwxMacLiveScrollbarActionProc() , m_peer->GetControlRefAddr() ) );
 
-    MacPostControlCreate(pos,size) ;
+    MacPostControlCreate( pos, size ) ;
 
-    return TRUE;
+    return true;
 }
 
 wxScrollBar::~wxScrollBar()
@@ -71,8 +63,7 @@ int wxScrollBar::GetThumbPosition() const
     return m_peer->GetValue() ;
 }
 
-void wxScrollBar::SetScrollbar(int position, int thumbSize, int range, int pageSize,
-    bool refresh)
+void wxScrollBar::SetScrollbar(int position, int thumbSize, int range, int pageSize, bool refresh)
 {
     m_pageSize = pageSize;
     m_viewSize = thumbSize;
@@ -84,49 +75,49 @@ void wxScrollBar::SetScrollbar(int position, int thumbSize, int range, int pageS
     m_peer->SetMinimum( 0 ) ;
     m_peer->SetValue( position ) ;
     m_peer->SetViewSize( m_viewSize ) ;
-
-    if ( refresh )
-      MacRedrawControl() ;
 }
 
-
 void wxScrollBar::Command(wxCommandEvent& event)
 {
     SetThumbPosition(event.GetInt());
     ProcessCommand(event);
 }
 
-void wxScrollBar::MacHandleControlClick( WXWidget control , wxInt16 controlpart , bool mouseStillDown ) 
+void wxScrollBar::MacHandleControlClick( WXWidget control , wxInt16 controlpart , bool mouseStillDown )
 {
     int position = m_peer->GetValue() ;
     int minPos = m_peer->GetMinimum() ;
     int maxPos = m_peer->GetMaximum() ;
-    
+
     wxEventType scrollEvent = wxEVT_NULL;
     int nScrollInc = 0;
-    
+
     // all events have already been reported during mouse down, except for THUMBRELEASE
-    if ( !mouseStillDown && controlpart !=kControlIndicatorPart )
+    if ( !mouseStillDown && controlpart != kControlIndicatorPart )
         return ;
-    
-    switch( controlpart )
+
+    switch ( controlpart )
     {
     case kControlUpButtonPart :
         nScrollInc = -1;
         scrollEvent = wxEVT_SCROLL_LINEUP;
         break ;
+
     case kControlDownButtonPart :
         nScrollInc = 1;
         scrollEvent = wxEVT_SCROLL_LINEDOWN;
         break ;
+
     case kControlPageUpPart :
         nScrollInc = -m_pageSize;
         scrollEvent = wxEVT_SCROLL_PAGEUP;
         break ;
+
     case kControlPageDownPart :
         nScrollInc = m_pageSize;
         scrollEvent = wxEVT_SCROLL_PAGEDOWN;
         break ;
+
     case kControlIndicatorPart :
         nScrollInc = 0 ;
         if ( mouseStillDown )
@@ -134,97 +125,91 @@ void wxScrollBar::MacHandleControlClick( WXWidget control , wxInt16 controlpart
         else
             scrollEvent = wxEVT_SCROLL_THUMBRELEASE;
         break ;
+
     default :
         wxFAIL_MSG(wxT("illegal scrollbar selector"));
         break ;
     }
-    
+
     int new_pos = position + nScrollInc;
-    
+
     if (new_pos < minPos)
         new_pos = minPos;
-    if (new_pos > maxPos)
+    else if (new_pos > maxPos)
         new_pos = maxPos;
+
     if ( nScrollInc )
         SetThumbPosition(new_pos);
-    
+
     wxScrollEvent event(scrollEvent, m_windowId);
     if ( m_windowStyle & wxHORIZONTAL )
-    {
         event.SetOrientation( wxHORIZONTAL ) ;
-    }
     else
-    {
         event.SetOrientation( wxVERTICAL ) ;
-    }
+
     event.SetPosition(new_pos);
     event.SetEventObject( this );
+
     wxWindow* window = GetParent() ;
     if (window && window->MacIsWindowScrollbar(this) )
-    {
         // this is hardcoded
         window->MacOnScroll(event);
-    }
     else
         GetEventHandler()->ProcessEvent(event);
 }
 
-wxInt32 wxScrollBar::MacControlHit( WXEVENTHANDLERREF handler , WXEVENTREF mevent ) 
+wxInt32 wxScrollBar::MacControlHit( WXEVENTHANDLERREF handler , WXEVENTREF mevent )
 {
     int position = m_peer->GetValue() ;
     int minPos = m_peer->GetMinimum() ;
     int maxPos = m_peer->GetMaximum() ;
-    
+
     wxEventType scrollEvent = wxEVT_NULL;
     int nScrollInc = 0;
-    
+
     wxMacCarbonEvent cEvent( (EventRef) mevent ) ;
-    ControlPartCode controlpart = cEvent.GetParameter<ControlPartCode>(kEventParamControlPart,typeControlPartCode) ;
-    
+    ControlPartCode controlpart = cEvent.GetParameter<ControlPartCode>(kEventParamControlPart, typeControlPartCode) ;
+
     // all events have already been reported during mouse down, except for THUMBRELEASE
-    if ( controlpart !=kControlIndicatorPart )
+    if ( controlpart != kControlIndicatorPart )
         return eventNotHandledErr ;
-    
-    switch( controlpart )
+
+    switch ( controlpart )
     {
     case kControlIndicatorPart :
         nScrollInc = 0 ;
         scrollEvent = wxEVT_SCROLL_THUMBRELEASE;
         break ;
+
     default :
         wxFAIL_MSG(wxT("illegal scrollbar selector"));
         break ;
     }
-    
+
     int new_pos = position + nScrollInc;
-    
+
     if (new_pos < minPos)
         new_pos = minPos;
-    if (new_pos > maxPos)
+    else if (new_pos > maxPos)
         new_pos = maxPos;
+
     if ( nScrollInc )
         SetThumbPosition(new_pos);
-    
+
     wxScrollEvent event(scrollEvent, m_windowId);
     if ( m_windowStyle & wxHORIZONTAL )
-    {
-        event.SetOrientation( wxHORIZONTAL ) ;
-    }
+        event.SetOrientation( wxHORIZONTAL );
     else
-    {
-        event.SetOrientation( wxVERTICAL ) ;
-    }
+        event.SetOrientation( wxVERTICAL );
+
     event.SetPosition(new_pos);
     event.SetEventObject( this );
     wxWindow* window = GetParent() ;
     if (window && window->MacIsWindowScrollbar(this) )
-    {
         // this is hardcoded
         window->MacOnScroll(event);
-    }
     else
         GetEventHandler()->ProcessEvent(event);
+
     return noErr ;
 }
-
-