X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/353f41cb3b49d4b49adaa6ee173a71bf75c17015..ab5fe83396c13f9fbf01630c52adf4df7607cbfe:/src/common/filename.cpp diff --git a/src/common/filename.cpp b/src/common/filename.cpp index 17525840a4..aae38ea3ef 100644 --- a/src/common/filename.cpp +++ b/src/common/filename.cpp @@ -34,7 +34,7 @@ (although :filename works as well). Since the volume is just part of the file path, it is not treated like a separate entity as it is done under DOS and - VMS, it is just treated as another dir. + VMS, it is just treated as another dir. wxPATH_VMS: VMS native format, absolute file names have the form :[dir1.dir2.dir3]file.txt @@ -61,55 +61,53 @@ // ---------------------------------------------------------------------------- #ifdef __GNUG__ - #pragma implementation "filename.h" +#pragma implementation "filename.h" #endif // For compilers that support precompilation, includes "wx.h". #include "wx/wxprec.h" #ifdef __BORLANDC__ - #pragma hdrstop +#pragma hdrstop #endif #ifndef WX_PRECOMP - #include "wx/intl.h" - #include "wx/log.h" +#include "wx/intl.h" +#include "wx/log.h" +#include "wx/file.h" #endif #include "wx/filename.h" #include "wx/tokenzr.h" #include "wx/config.h" // for wxExpandEnvVars #include "wx/utils.h" - -#if wxUSE_DYNLIB_CLASS - #include "wx/dynlib.h" -#endif +#include "wx/file.h" +//#include "wx/dynlib.h" // see GetLongPath below, code disabled. // For GetShort/LongPathName #ifdef __WIN32__ - #include - - #include "wx/msw/winundef.h" +#include +#include "wx/msw/winundef.h" #endif // utime() is POSIX so should normally be available on all Unices #ifdef __UNIX_LIKE__ - #include - #include - #include - #include +#include +#include +#include +#include #endif #ifdef __MWERKS__ - #include - #include - #include +#include +#include +#include #endif #ifdef __WATCOMC__ - #include - #include - #include +#include +#include +#include #endif #ifdef __VISAGECPP__ @@ -236,13 +234,13 @@ void wxFileName::Assign(const wxString& volume, { wxPathFormat my_format = GetFormat( format ); wxString my_path = path; - + m_dirs.Clear(); - + if (!my_path.empty()) { // 1) Determine if the path is relative or absolute. - + switch (my_format) { case wxPATH_MAC: @@ -250,7 +248,7 @@ void wxFileName::Assign(const wxString& volume, // We then remove a leading ":". The reason is in our // storage form for relative paths: // ":dir:file.txt" actually means "./dir/file.txt" in - // DOS notation and should get stored as + // DOS notation and should get stored as // (relative) (dir) (file.txt) // "::dir:file.txt" actually means "../dir/file.txt" // stored as (relative) (..) (dir) (file.txt) @@ -271,14 +269,14 @@ void wxFileName::Assign(const wxString& volume, m_relative = ( (my_path[0u] != wxT('/')) && (my_path[0u] != wxT('\\')) ); break; default: - wxFAIL_MSG( "error" ); + wxFAIL_MSG( wxT("error") ); break; } - + // 2) Break up the path into its members. If the original path // was just "/" or "\\", m_dirs will be empty. We know from // the m_relative field, if this means "nothing" or "root dir". - + wxStringTokenizer tn( my_path, GetPathSeparators(my_format) ); while ( tn.HasMoreTokens() ) @@ -456,9 +454,9 @@ wxString wxFileName::GetHomeDir() return ::wxGetHomeDir(); } -void wxFileName::AssignTempFileName( const wxString& prefix ) +void wxFileName::AssignTempFileName(const wxString& prefix, wxFile *fileTemp) { - wxString tempname = CreateTempFileName(prefix); + wxString tempname = CreateTempFileName(prefix, fileTemp); if ( tempname.empty() ) { // error, failed to get temp file name @@ -471,7 +469,8 @@ void wxFileName::AssignTempFileName( const wxString& prefix ) } /* static */ -wxString wxFileName::CreateTempFileName(const wxString& prefix) +wxString +wxFileName::CreateTempFileName(const wxString& prefix, wxFile *fileTemp) { wxString path, dir, name; @@ -521,7 +520,7 @@ wxString wxFileName::CreateTempFileName(const wxString& prefix) #ifndef __WATCOMC__ ::DosCreateDir(wxStringBuffer(path, MAX_PATH), NULL); #endif - + #else // !Windows, !OS/2 if ( dir.empty() ) { @@ -558,13 +557,25 @@ wxString wxFileName::CreateTempFileName(const wxString& prefix) // can use the cast here because the length doesn't change and the string // is not shared - if ( mkstemp((char *)path.mb_str()) == -1 ) + int fdTemp = mkstemp((char *)path.mb_str()); + if ( fdTemp == -1 ) { // this might be not necessary as mkstemp() on most systems should have // already done it but it doesn't hurt neither... path.clear(); } - //else: file already created + else // mkstemp() succeeded + { + // avoid leaking the fd + if ( fileTemp ) + { + fileTemp->Attach(fdTemp); + } + else + { + close(fdTemp); + } + } #else // !HAVE_MKSTEMP #ifdef HAVE_MKTEMP @@ -601,10 +612,29 @@ wxString wxFileName::CreateTempFileName(const wxString& prefix) if ( !path.empty() ) { - // create the file - of course, there is a race condition here, this is + } +#endif // HAVE_MKSTEMP/!HAVE_MKSTEMP + +#endif // Windows/!Windows + + if ( path.empty() ) + { + wxLogSysError(_("Failed to create a temporary file name")); + } + else if ( fileTemp && !fileTemp->IsOpened() ) + { + // open the file - of course, there is a race condition here, this is // why we always prefer using mkstemp()... - wxFile file; - if ( !file.Open(path, wxFile::write_excl, wxS_IRUSR | wxS_IWUSR) ) + // + // NB: GetTempFileName() under Windows creates the file, so using + // write_excl there would fail + if ( !fileTemp->Open(path, +#if defined(__WINDOWS__) && !defined(__WXMICROWIN__) + wxFile::write, +#else + wxFile::write_excl, +#endif + wxS_IRUSR | wxS_IWUSR) ) { // FIXME: If !ok here should we loop and try again with another // file name? That is the standard recourse if open(O_EXCL) @@ -616,14 +646,6 @@ wxString wxFileName::CreateTempFileName(const wxString& prefix) path.clear(); } } -#endif // HAVE_MKSTEMP/!HAVE_MKSTEMP - -#endif // Windows/!Windows - - if ( path.empty() ) - { - wxLogSysError(_("Failed to create a temporary file name")); - } return path; } @@ -728,6 +750,7 @@ bool wxFileName::Normalize(wxPathNormalize flags, } } #endif + m_relative = FALSE; } // handle ~ stuff under Unix only @@ -853,7 +876,7 @@ bool wxFileName::MakeRelativeTo(const wxString& pathBase, wxPathFormat format) { m_dirs.Insert(wxT(".."), 0u); } - + m_relative = TRUE; // we were modified @@ -1020,7 +1043,7 @@ wxString wxFileName::GetPath( bool add_separator, wxPathFormat format ) const if (!m_relative) fullpath += wxFILE_SEP_PATH_UNIX; } - + // then concatenate all the path components using the path separator size_t dirCount = m_dirs.GetCount(); if ( dirCount ) @@ -1070,7 +1093,7 @@ wxString wxFileName::GetPath( bool add_separator, wxPathFormat format ) const } default: { - wxFAIL_MSG( "error" ); + wxFAIL_MSG( wxT("error") ); } } } @@ -1090,23 +1113,23 @@ wxString wxFileName::GetFullPath( wxPathFormat format ) const // first put the volume if ( !m_volume.empty() ) { - { - // Special Windows UNC paths hack, part 2: undo what we did in - // SplitPath() and make an UNC path if we have a drive which is not a - // single letter (hopefully the network shares can't be one letter only - // although I didn't find any authoritative docs on this) - if ( format == wxPATH_DOS && m_volume.length() > 1 ) - { - fullpath << wxFILE_SEP_PATH_DOS << wxFILE_SEP_PATH_DOS << m_volume; - } - else if ( format == wxPATH_DOS || format == wxPATH_VMS ) - { - fullpath << m_volume << GetVolumeSeparator(format); + { + // Special Windows UNC paths hack, part 2: undo what we did in + // SplitPath() and make an UNC path if we have a drive which is not a + // single letter (hopefully the network shares can't be one letter only + // although I didn't find any authoritative docs on this) + if ( format == wxPATH_DOS && m_volume.length() > 1 ) + { + fullpath << wxFILE_SEP_PATH_DOS << wxFILE_SEP_PATH_DOS << m_volume; + } + else if ( format == wxPATH_DOS || format == wxPATH_VMS ) + { + fullpath << m_volume << GetVolumeSeparator(format); } // else ignore } } - + // the leading character if ( format == wxPATH_MAC && m_relative ) { @@ -1122,7 +1145,7 @@ wxString wxFileName::GetFullPath( wxPathFormat format ) const if (!m_relative) fullpath += wxFILE_SEP_PATH_UNIX; } - + // then concatenate all the path components using the path separator size_t dirCount = m_dirs.GetCount(); if ( dirCount ) @@ -1172,7 +1195,7 @@ wxString wxFileName::GetFullPath( wxPathFormat format ) const } default: { - wxFAIL_MSG( "error" ); + wxFAIL_MSG( wxT("error") ); } } } @@ -1221,7 +1244,7 @@ wxString wxFileName::GetLongPath() const bool success = FALSE; // VZ: this code was disabled, why? -#if 0 // wxUSE_DYNLIB_CLASS +#if 0 // wxUSE_DYNAMIC_LOADER typedef DWORD (*GET_LONG_PATH_NAME)(const wxChar *, wxChar *, DWORD); static bool s_triedToLoad = FALSE; @@ -1269,7 +1292,7 @@ wxString wxFileName::GetLongPath() const } if (success) return pathOut; -#endif // wxUSE_DYNLIB_CLASS +#endif // wxUSE_DYNAMIC_LOADER if (!success) {