X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/2f2aa6287bd281037a8c329c65219324f81c613c..520e470fdd0daef09c77938db642e4583933c90d:/src/gtk1/tbargtk.cpp

diff --git a/src/gtk1/tbargtk.cpp b/src/gtk1/tbargtk.cpp
index 1ced090e50..29c954eca5 100644
--- a/src/gtk1/tbargtk.cpp
+++ b/src/gtk1/tbargtk.cpp
@@ -14,7 +14,6 @@
 #endif
 
 #include "wx/toolbar.h"
-#include <wx/intl.h>
 
 //-----------------------------------------------------------------------------
 // data
@@ -29,10 +28,12 @@ extern bool   g_blockEventsOnDrag;
 IMPLEMENT_DYNAMIC_CLASS(wxToolBarTool,wxObject)
 
 wxToolBarTool::wxToolBarTool( wxToolBar *owner, int theIndex,
-      const wxBitmap& bitmap1, const  wxBitmap& bitmap2,
-      bool toggle, wxObject *clientData,
-      const wxString& shortHelpString, const wxString& longHelpString,
-      GtkWidget *item  )
+                              const wxBitmap& bitmap1, const  wxBitmap& bitmap2,
+                              bool toggle, 
+                              wxObject *clientData,
+                              const wxString& shortHelpString,
+                              const wxString& longHelpString,
+                              GtkWidget *item  )
 {
   m_owner = owner;
   m_index = theIndex;
@@ -78,7 +79,7 @@ static gint gtk_toolbar_enter_callback( GtkWidget *WXUNUSED(widget),
   
   tool->m_owner->OnMouseEnter( tool->m_index );
   
-  return TRUE;
+  return FALSE;
 }
 
 //-----------------------------------------------------------------------------
@@ -115,6 +116,7 @@ bool wxToolBar::Create( wxWindow *parent, wxWindowID id,
   m_widget = gtk_handle_box_new();
 
   m_toolbar = GTK_TOOLBAR( gtk_toolbar_new( GTK_ORIENTATION_HORIZONTAL, GTK_TOOLBAR_ICONS ) );
+  gtk_toolbar_set_tooltips( GTK_TOOLBAR(m_toolbar), TRUE );
 
   gtk_container_add( GTK_CONTAINER(m_widget), GTK_WIDGET(m_toolbar) );
 
@@ -162,18 +164,22 @@ wxToolBarTool *wxToolBar::AddTool( int toolIndex, const wxBitmap& bitmap,
   float WXUNUSED(xPos), float WXUNUSED(yPos), wxObject *clientData,
   const wxString& helpString1, const wxString& helpString2 )
 {
-  if (!bitmap.Ok()) return (wxToolBarTool *) NULL;
+  wxCHECK_MSG( bitmap.Ok(), (wxToolBarTool *)NULL,
+               "invalid bitmap for wxToolBar icon" );
 
-  wxToolBarTool *tool = new wxToolBarTool( this, toolIndex, bitmap, pushedBitmap, toggle,
-    clientData, helpString1, helpString2 );
+  wxToolBarTool *tool = new wxToolBarTool( this, toolIndex, bitmap, pushedBitmap,
+                                           toggle, clientData,
+                                           helpString1, helpString2 );
 
-  GtkWidget *tool_pixmap = (GtkWidget *) NULL;
-  
-  wxCHECK_MSG( bitmap.GetBitmap() == NULL, (wxToolBarTool *)NULL, "wxToolBar doesn't support GdkBitmap" )
+  wxCHECK_MSG( bitmap.GetBitmap() == NULL, (wxToolBarTool *)NULL,
+               "wxToolBar doesn't support GdkBitmap" );
+
+  wxCHECK_MSG( bitmap.GetPixmap() != NULL, (wxToolBarTool *)NULL,
+               "wxToolBar::Add needs a wxBitmap" );
   
-  wxCHECK_MSG( bitmap.GetPixmap() != NULL, (wxToolBarTool *)NULL, "wxToolBar::Add needs a wxBitmap" )
+  GtkWidget *tool_pixmap = (GtkWidget *) NULL;
   
-  if (TRUE)
+  if (TRUE) // FIXME huh?
   {
     GdkPixmap *pixmap = bitmap.GetPixmap();
 
@@ -185,31 +191,56 @@ wxToolBarTool *wxToolBar::AddTool( int toolIndex, const wxBitmap& bitmap,
   
   gtk_misc_set_alignment( GTK_MISC(tool_pixmap), 0.5, 0.5 );
 
-  GtkToolbarChildType ctype = GTK_TOOLBAR_CHILD_BUTTON;
-  if (toggle) ctype = GTK_TOOLBAR_CHILD_TOGGLEBUTTON;
-
-  tool->m_item = gtk_toolbar_append_element( m_toolbar, ctype, (GtkWidget *) NULL, (const char *) NULL, helpString1, "", tool_pixmap, 
-                                             (GtkSignalFunc)gtk_toolbar_callback, (gpointer)tool );
-
-  gtk_signal_connect( GTK_OBJECT(tool->m_item), "enter_notify_event", 
-      GTK_SIGNAL_FUNC(gtk_toolbar_enter_callback), (gpointer)tool );
+#if 0
+  GtkToolbarChildType ctype = toggle ? GTK_TOOLBAR_CHILD_TOGGLEBUTTON
+                                     : GTK_TOOLBAR_CHILD_BUTTON;
+
+  tool->m_item = gtk_toolbar_append_element
+                 (
+                  GTK_TOOLBAR(m_toolbar),
+                  ctype,
+                  (GtkWidget *)NULL,
+                  (const char *)NULL,
+                  helpString1,
+                  "",
+                  tool_pixmap,
+                  (GtkSignalFunc)gtk_toolbar_callback,
+                  (gpointer)tool
+                 );
+
+  gtk_signal_connect( GTK_OBJECT(tool->m_item),
+                      "enter_notify_event", 
+                      GTK_SIGNAL_FUNC(gtk_toolbar_enter_callback),
+                      (gpointer)tool );
+#else
+  tool->m_item = gtk_toolbar_append_item 
+                 (
+                  GTK_TOOLBAR(m_toolbar),
+                  (const char *)NULL,
+                  helpString1,
+                  "",
+                  tool_pixmap,
+                  (GtkSignalFunc)gtk_toolbar_callback,
+                  (gpointer)tool
+                 );
+#endif
 
   m_tools.Append( tool );
 
   return tool;
 }
 
-void wxToolBar::AddSeparator(void)
+void wxToolBar::AddSeparator()
 {
   gtk_toolbar_append_space( m_toolbar );
 }
 
-void wxToolBar::ClearTools(void)
+void wxToolBar::ClearTools()
 {
   wxFAIL_MSG( "wxToolBar::ClearTools not implemented" );
 }
 
-void wxToolBar::Realize(void)
+void wxToolBar::Realize()
 {
   m_x = 0;
   m_y = 0;
@@ -315,10 +346,12 @@ bool wxToolBar::GetToolEnabled(int toolIndex) const
 
 void wxToolBar::SetMargins( int WXUNUSED(x), int WXUNUSED(y) )
 {
+  wxFAIL_MSG( "wxToolBar::SetMargins not implemented" );
 }
 
 void wxToolBar::SetToolPacking( int WXUNUSED(packing) )
 {
+  wxFAIL_MSG( "wxToolBar::SetToolPacking not implemented" );
 }
 
 void wxToolBar::SetToolSeparation( int separation )