X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/2f1ae4143271ae63a17e052a1a471d16e9cd8c44..abbcdf3ff7a6d33ff09cbbbf7dbf3aa53d60972b:/src/mac/carbon/listbox.cpp

diff --git a/src/mac/carbon/listbox.cpp b/src/mac/carbon/listbox.cpp
index 6564af7b77..6e387a01da 100644
--- a/src/mac/carbon/listbox.cpp
+++ b/src/mac/carbon/listbox.cpp
@@ -1,42 +1,140 @@
 ///////////////////////////////////////////////////////////////////////////////
 // Name:        listbox.cpp
 // Purpose:     wxListBox
-// Author:      AUTHOR
+// Author:      Stefan Csomor
 // Modified by:
-// Created:     ??/??/98
+// Created:     1998-01-01
 // RCS-ID:      $Id$
-// Copyright:   (c) AUTHOR
+// Copyright:   (c) Stefan Csomor
 // Licence:     wxWindows licence
 ///////////////////////////////////////////////////////////////////////////////
 
-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
 #pragma implementation "listbox.h"
 #endif
 
+#include "wx/wxprec.h"
+
+#include "wx/app.h"
 #include "wx/listbox.h"
+#include "wx/button.h"
 #include "wx/settings.h"
+#include "wx/toplevel.h"
 #include "wx/dynarray.h"
 #include "wx/log.h"
 
 #include "wx/utils.h"
-#include "extldef.h"
 
 #if !USE_SHARED_LIBRARY
-  IMPLEMENT_DYNAMIC_CLASS(wxListBox, wxControl)
+IMPLEMENT_DYNAMIC_CLASS(wxListBox, wxControl)
 
 BEGIN_EVENT_TABLE(wxListBox, wxControl)
-	EVT_SIZE( wxListBox::OnSize ) 
+#ifndef __WXMAC_OSX__
+//    EVT_SIZE( wxListBox::OnSize )
+    EVT_CHAR( wxListBox::OnChar )
+#endif
 END_EVENT_TABLE()
 #endif
 
-#include <wx/mac/uma.h>
+#include "wx/mac/uma.h"
 
-extern "C" void MacDrawStringCell(Rect *cellRect, Cell lCell, ListHandle theList, long refCon) ;
-const short kwxMacListWithVerticalScrollbar = 128 ;
+const short kTextColumnId = 1024 ;
+
+// new databrowserbased version
+// because of the limited insert
+// functionality of DataBrowser,
+// we just introduce id s corresponding
+// to the line number
+
+#if TARGET_API_MAC_OSX
+static pascal void DataBrowserItemNotificationProc(ControlRef browser, DataBrowserItemID itemID,
+    DataBrowserItemNotification message, DataBrowserItemDataRef itemData)
+#else
+static pascal  void DataBrowserItemNotificationProc(ControlRef browser, DataBrowserItemID itemID,
+    DataBrowserItemNotification message)
+#endif
+{
+    long ref = GetControlReference( browser ) ;
+    if ( ref )
+    {
+        wxListBox* list = wxDynamicCast( (wxObject*) ref , wxListBox ) ;
+        int i = itemID - 1 ;
+        if (i >= 0 && i < list->GetCount() )
+        {
+            bool trigger = false ;
+            wxCommandEvent event(
+                wxEVT_COMMAND_LISTBOX_SELECTED, list->GetId() );
+            switch( message )
+            {
+                case kDataBrowserItemDeselected :
+                    if ( list->HasMultipleSelection() )
+                        trigger = !list->MacIsSelectionSuppressed() ;
+                    break ;
+                case kDataBrowserItemSelected :
+                    trigger = !list->MacIsSelectionSuppressed() ;
+                    break ;
+                case kDataBrowserItemDoubleClicked :
+                    event.SetEventType(wxEVT_COMMAND_LISTBOX_DOUBLECLICKED) ;
+                    trigger = true ;
+                    break ;
+                default :
+                    break ;
+            }
+            if ( trigger )
+            {
+                event.SetEventObject( list );
+                if ( list->HasClientObjectData() )
+                    event.SetClientObject( list->GetClientObject(i) );
+                else if ( list->HasClientUntypedData() )
+                    event.SetClientData( list->GetClientData(i) );
+                event.SetString( list->GetString(i) );
+                event.SetInt(i) ;
+                event.SetExtraLong( list->HasMultipleSelection() ? message == kDataBrowserItemSelected : TRUE );
+                wxPostEvent( list->GetEventHandler() , event ) ;
+                // direct notification is not always having the listbox GetSelection() having in synch with event
+                // list->GetEventHandler()->ProcessEvent(event) ;
+            }
+        }
+    }
+}
+
+static pascal OSStatus ListBoxGetSetItemData(ControlRef browser,
+    DataBrowserItemID itemID, DataBrowserPropertyID property,
+    DataBrowserItemDataRef itemData, Boolean changeValue)
+{
+	OSStatus err = errDataBrowserPropertyNotSupported;
+
+	if ( ! changeValue )
+	{
+    	switch (property)
+    	{
+
+    	    case kTextColumnId:
+    		{
+    		    long ref = GetControlReference( browser ) ;
+    		    if ( ref )
+    		    {
+    		        wxListBox* list = wxDynamicCast( (wxObject*) ref , wxListBox ) ;
+                    int i = itemID - 1 ;
+                    if (i >= 0 && i < list->GetCount() )
+		            {
+		                wxMacCFStringHolder cf( list->GetString(i) , list->GetFont().GetEncoding() ) ;
+		                verify_noerr( ::SetDataBrowserItemDataText( itemData , cf ) ) ;
+		                err = noErr ;
+		            }
+    			}
+    		}
+    		break;
+
+    		default:
+
+    		break;
+    	}
+	}
+
+	return err;
+}
 
-// ============================================================================
-// list box control implementation
-// ============================================================================
 
 // Listbox item
 wxListBox::wxListBox()
@@ -44,6 +142,21 @@ wxListBox::wxListBox()
   m_noItems = 0;
   m_selected = 0;
   m_macList = NULL ;
+  m_suppressSelection = false ;
+}
+
+bool wxListBox::Create(wxWindow *parent, wxWindowID id,
+                       const wxPoint& pos,
+                       const wxSize& size,
+                       const wxArrayString& choices,
+                       long style,
+                       const wxValidator& validator,
+                       const wxString& name)
+{
+    wxCArrayString chs(choices);
+
+    return Create(parent, id, pos, size, chs.GetCount(), chs.GetStrings(),
+                  style, validator, name);
 }
 
 bool wxListBox::Create(wxWindow *parent, wxWindowID id,
@@ -54,71 +167,114 @@ bool wxListBox::Create(wxWindow *parent, wxWindowID id,
                        const wxValidator& validator,
                        const wxString& name)
 {
-  m_noItems = 0 ; // this will be increased by our append command
-  m_selected = 0;
+    m_macIsUserPane = FALSE ;
 
-	Rect bounds ;
-	Str255 title ;
-	
-	MacPreControlCreate( parent , id ,  "" , pos , size ,style, validator , name , &bounds , title ) ;
-
-	m_macControl = UMANewControl( parent->GetMacRootWindow() , &bounds , title , true , kwxMacListWithVerticalScrollbar , 0 , 0, 
-	  	kControlListBoxProc , (long) this ) ;
-	
-	long	result ;
-	UMAGetControlData( m_macControl , kControlNoPart , kControlListBoxListHandleTag , sizeof( ListHandle ) , (char*) &m_macList  , &result ) ;
-
-	HLock( (Handle) m_macList ) ;
-	NewExtLDEFInfo( m_macList , MacDrawStringCell , (long) this ) ;
-	(**m_macList).selFlags = 0 ;
-	if ( style & wxLB_MULTIPLE )
-	{
-		(**m_macList).selFlags += lNoExtend ;
-	}
-	else if ( style & wxLB_EXTENDED )
-	{
-		(**m_macList).selFlags += lExtendDrag ;
-	}
-	else
-	{
-		(**m_macList).selFlags = lOnlyOne ;
-	}
-	Point pt = (**m_macList).cellSize ;
-	pt.v = 14 ;
-	LCellSize( pt , m_macList ) ;
+    wxASSERT_MSG( !(style & wxLB_MULTIPLE) || !(style & wxLB_EXTENDED),
+                  _T("only one of listbox selection modes can be specified") );
 
-	LAddColumn( 1 , 0 , m_macList ) ;
+    if ( !wxListBoxBase::Create(parent, id, pos, size, style & ~(wxHSCROLL|wxVSCROLL), validator, name) )
+        return false;
 
-	MacPostControlCreate() ;
+    m_noItems = 0 ; // this will be increased by our append command
+    m_selected = 0;
 
-	ControlFontStyleRec		controlstyle ;
-	controlstyle.flags = kControlUseFontMask + kControlUseSizeMask ;
-	//controlstyle.font = kControlFontSmallSystemFont ;
-	controlstyle.font = kFontIDMonaco ;
-	controlstyle.size = 9 ;
-	::UMASetControlFontStyle( m_macControl , &controlstyle ) ;
+    Rect bounds = wxMacGetBoundsForControl( this , pos , size ) ;
 
-	for ( int i = 0 ; i < n ; i++ )
-	{
-		Append( choices[i] ) ;
-	}
+    m_peer = new wxMacControl() ;
+    verify_noerr( ::CreateDataBrowserControl( MAC_WXHWND(parent->MacGetTopLevelWindowRef()), &bounds, kDataBrowserListView , m_peer->GetControlRefAddr() ) );
+
+    DataBrowserSelectionFlags  options = kDataBrowserDragSelect ;
+    if ( style & wxLB_MULTIPLE )
+    {
+        options += kDataBrowserAlwaysExtendSelection + kDataBrowserCmdTogglesSelection  ;
+    }
+    else if ( style & wxLB_EXTENDED )
+    {
+        // default behaviour
+    }
+    else
+    {
+        options += kDataBrowserSelectOnlyOne ;
+    }
+    verify_noerr(m_peer->SetSelectionFlags( options ) );
+
+    DataBrowserListViewColumnDesc columnDesc ;
+    columnDesc.headerBtnDesc.titleOffset = 0;
+	columnDesc.headerBtnDesc.version = kDataBrowserListViewLatestHeaderDesc;
+
+	columnDesc.headerBtnDesc.btnFontStyle.flags	=
+		kControlUseFontMask | kControlUseJustMask;
+
+	columnDesc.headerBtnDesc.btnContentInfo.contentType = kControlNoContent;
+	columnDesc.propertyDesc.propertyType = kDataBrowserTextType;
+	columnDesc.headerBtnDesc.btnFontStyle.just = teFlushDefault;
+	columnDesc.headerBtnDesc.minimumWidth = 0;
+	columnDesc.headerBtnDesc.maximumWidth = 10000;
+
+	columnDesc.headerBtnDesc.btnFontStyle.font = kControlFontViewSystemFont;
+	columnDesc.headerBtnDesc.btnFontStyle.style = normal;
+	columnDesc.headerBtnDesc.titleString = NULL ; // CFSTR( "" );
+
+	columnDesc.propertyDesc.propertyID = kTextColumnId;
+	columnDesc.propertyDesc.propertyType = kDataBrowserTextType;
+	columnDesc.propertyDesc.propertyFlags =
+#if MAC_OS_X_VERSION_MAX_ALLOWED > MAC_OS_X_VERSION_10_2
+	 kDataBrowserListViewTypeSelectColumn |
+#endif
+	 kDataBrowserTableViewSelectionColumn ;
+
+
+	verify_noerr(m_peer->AddListViewColumn( &columnDesc, kDataBrowserListViewAppendColumn) ) ;
+    verify_noerr(m_peer->AutoSizeListViewColumns() ) ;
+    verify_noerr(m_peer->SetHasScrollBars(false , true ) ) ;
+    verify_noerr(m_peer->SetTableViewHiliteStyle(kDataBrowserTableViewFillHilite  ) ) ;
+    verify_noerr(m_peer->SetListViewHeaderBtnHeight( 0 ) ) ;
+    DataBrowserCallbacks callbacks ;
+
+    callbacks.version = kDataBrowserLatestCallbacks;
+
+    InitDataBrowserCallbacks(&callbacks);
+
+    callbacks.u.v1.itemDataCallback =
+        NewDataBrowserItemDataUPP(ListBoxGetSetItemData);
+
+	callbacks.u.v1.itemNotificationCallback =
+#if TARGET_API_MAC_OSX
+	    (DataBrowserItemNotificationUPP) NewDataBrowserItemNotificationWithItemUPP(DataBrowserItemNotificationProc) ;
+#else
+	    NewDataBrowserItemNotificationUPP(DataBrowserItemNotificationProc) ;
+#endif
+    m_peer->SetCallbacks( &callbacks);
 
-	LSetDrawingMode( true , m_macList ) ;
+#if TARGET_API_MAC_OSX
+    // there is a redraw bug in 10.2.X
+    if ( UMAGetSystemVersion() < 0x1030 )
+        m_peer->SetData( kControlNoPart, kControlDataBrowserIncludesFrameAndFocusTag, (Boolean) false ) ;
+#endif
+    MacPostControlCreate(pos,size) ;
 
-  return TRUE;
+    for ( int i = 0 ; i < n ; i++ )
+    {
+        Append( choices[i] ) ;
+    }
+
+    SetBestSize(size);   // Needed because it is a wxControlWithItems
+
+    return TRUE;
 }
 
 wxListBox::~wxListBox()
 {
-	Free() ;
-	if ( m_macList )
-	{
-		DisposeExtLDEFInfo( m_macList ) ;
-		m_macList = NULL ;
-	}
+    m_peer->SetReference( 0 ) ;
+    FreeData() ;
+    // avoid access during destruction
+    if ( m_macList )
+    {
+        m_macList = NULL ;
+    }
 }
 
-void wxListBox::Free()
+void wxListBox::FreeData()
 {
 #if wxUSE_OWNER_DRAWN
     if ( m_windowStyle & wxLB_OWNERDRAW )
@@ -126,6 +282,7 @@ void wxListBox::Free()
         size_t uiCount = m_aItems.Count();
         while ( uiCount-- != 0 ) {
             delete m_aItems[uiCount];
+            m_aItems[uiCount] = NULL;
         }
 
         m_aItems.Clear();
@@ -141,9 +298,16 @@ void wxListBox::Free()
     }
 }
 
+void  wxListBox::DoSetSize(int x, int y,
+            int width, int height,
+            int sizeFlags )
+{
+    wxControl::DoSetSize( x , y , width , height , sizeFlags ) ;
+}
+
 void wxListBox::DoSetFirstItem(int N)
 {
-	MacScrollTo( N ) ;
+    MacScrollTo( N ) ;
 }
 
 void wxListBox::Delete(int N)
@@ -153,55 +317,53 @@ void wxListBox::Delete(int N)
 
 #if wxUSE_OWNER_DRAWN
     delete m_aItems[N];
-    m_aItems.Remove(N);
+    m_aItems.RemoveAt(N);
 #else // !wxUSE_OWNER_DRAWN
     if ( HasClientObjectData() )
     {
         delete GetClientObject(N);
     }
 #endif // wxUSE_OWNER_DRAWN/!wxUSE_OWNER_DRAWN
-	m_stringArray.Remove( N ) ;
-	m_dataArray.Remove( N ) ;
-	m_noItems --;
-	
-	MacDelete( N ) ;
+    m_stringArray.RemoveAt( N ) ;
+    m_dataArray.RemoveAt( N ) ;
+    m_noItems --;
+
+    MacDelete( N ) ;
 }
 
 int wxListBox::DoAppend(const wxString& item)
 {
-	int index = m_noItems ;
-	if( wxApp::s_macDefaultEncodingIsPC )
-	{
-		m_stringArray.Add( wxMacMakeMacStringFromPC( item ) ) ;
-	}
-	else
-		m_stringArray.Add( item ) ;
- 	m_noItems ++;
-	MacAppend( item ) ;
+    InvalidateBestSize();
 
-	return index ;
+    int index = m_noItems ;
+    m_stringArray.Add( item ) ;
+    m_dataArray.Add( NULL );
+    m_noItems ++;
+    DoSetItemClientData( index , NULL ) ;
+    MacAppend( item ) ;
+
+    return index ;
 }
 
 void wxListBox::DoSetItems(const wxArrayString& choices, void** clientData)
-{ 
-  MacSetRedraw( false ) ;
-  Clear() ;  
-  int n = choices.GetCount();
-
-  for( int i = 0 ; i < n ; ++i )
-  {
-  	if ( clientData )
-  	{
+{
+    Clear() ;
+    int n = choices.GetCount();
+
+    for( int i = 0 ; i < n ; ++i )
+    {
+        if ( clientData )
+        {
 #if wxUSE_OWNER_DRAWN
             wxASSERT_MSG(clientData[i] == NULL,
-                         wxT("Can't use client data with owner-drawn listboxes"));
+                wxT("Can't use client data with owner-drawn listboxes"));
 #else // !wxUSE_OWNER_DRAWN
-  		Append( choices[i] , clientData[i] ) ;
- #endif
-  	}
-  	else
-  		Append( choices[i] ) ;
-  }
+            Append( choices[i] , clientData[i] ) ;
+#endif
+        }
+        else
+            Append( choices[i] ) ;
+    }
 
 #if wxUSE_OWNER_DRAWN
     if ( m_windowStyle & wxLB_OWNERDRAW ) {
@@ -209,6 +371,7 @@ void wxListBox::DoSetItems(const wxArrayString& choices, void** clientData)
         size_t ui = m_aItems.Count();
         while ( ui-- != 0 ) {
             delete m_aItems[ui];
+            m_aItems[ui] = NULL;
         }
         m_aItems.Empty();
 
@@ -220,96 +383,99 @@ void wxListBox::DoSetItems(const wxArrayString& choices, void** clientData)
         }
     }
 #endif // wxUSE_OWNER_DRAWN
-  MacSetRedraw( true ) ;
 }
 
-bool wxListBox::HasMultipleSelection() const
+int wxListBox::FindString(const wxString& s) const
 {
-    return (m_windowStyle & wxLB_MULTIPLE) || (m_windowStyle & wxLB_EXTENDED);
-}
 
-int wxListBox::FindString(const wxString& st) const
-{
-	wxString s ;
-	if( wxApp::s_macDefaultEncodingIsPC )
-	{
-		s = wxMacMakeMacStringFromPC( st ) ;
-	}
-	else
-		s = st ;
-		
-	if ( s.Right(1) == "*" )
-	{
-		wxString search = s.Left( s.Length() - 1 ) ;
-		int len = search.Length() ;
-    	Str255 s1 , s2 ;
-	    strcpy( (char*) s2 , search.c_str() ) ;
-	    c2pstr( (char*) s2 ) ;
-    	for ( int i = 0 ; i < m_noItems ; ++ i )
-	    {
-	    	strcpy( (char*) s1 , m_stringArray[i].Left( len ).c_str() ) ;
-	    	c2pstr( (char*) s1 ) ;
-	    	if ( EqualString( s1 , s2 , false , false ) )
-	    		return i ;
-	    }
-	}
-	else
-	{
-    	Str255 s1 , s2 ;
-	    strcpy( (char*) s2 , s.c_str() ) ;
-	    c2pstr( (char*) s2 ) ;
-	    for ( int i = 0 ; i < m_noItems ; ++ i )
-	    {
-	    	strcpy( (char*) s1 , m_stringArray[i].c_str() ) ;
-	    	c2pstr( (char*) s1 ) ;
-	    	if ( EqualString( s1 , s2 , false , false ) )
-	    		return i ;
-	    }
-   }
-   return -1;
+    if ( s.Right(1) == wxT("*") )
+    {
+        wxString search = s.Left( s.Length() - 1 ) ;
+        int len = search.Length() ;
+        Str255 s1 , s2 ;
+        wxMacStringToPascal( search , s2 ) ;
+
+        for ( int i = 0 ; i < m_noItems ; ++ i )
+        {
+        	wxMacStringToPascal( m_stringArray[i].Left( len ) , s1 ) ;
+
+            if ( EqualString( s1 , s2 , false , false ) )
+                return i ;
+        }
+        if ( s.Left(1) == wxT("*") && s.Length() > 1 )
+        {
+            wxString st = s ;
+            st.MakeLower() ;
+            for ( int i = 0 ; i < m_noItems ; ++i )
+            {
+                if ( GetString(i).Lower().Matches(st) )
+                    return i ;
+            }
+        }
+
+    }
+    else
+    {
+        Str255 s1 , s2 ;
+
+        wxMacStringToPascal( s , s2 ) ;
+
+        for ( int i = 0 ; i < m_noItems ; ++ i )
+        {
+        	wxMacStringToPascal( m_stringArray[i] , s1 ) ;
+
+            if ( EqualString( s1 , s2 , false , false ) )
+                return i ;
+        }
+    }
+    return -1;
 }
 
 void wxListBox::Clear()
 {
-  Free();
-  m_noItems = 0;
-  m_stringArray.Empty() ;
-  m_dataArray.Empty() ;
-  MacClear() ;
+    FreeData();
+    m_noItems = 0;
+    m_stringArray.Empty() ;
+    m_dataArray.Empty() ;
+    MacClear() ;
 }
 
-void wxListBox::SetSelection(int N, bool select)
+void wxListBox::DoSetSelection(int N, bool select)
 {
-    wxCHECK_RET( N >= 0 && N < m_noItems,
-                 "invalid index in wxListBox::SetSelection" );
-	MacSetSelection( N , select ) ;
+    wxCHECK_RET( N == wxNOT_FOUND || (N >= 0 && N < m_noItems) ,
+        wxT("invalid index in wxListBox::SetSelection") );
+
+    if ( N == wxNOT_FOUND )
+        MacDeselectAll() ;
+    else
+        MacSetSelection( N , select ) ;
 }
 
 bool wxListBox::IsSelected(int N) const
 {
     wxCHECK_MSG( N >= 0 && N < m_noItems, FALSE,
-                 "invalid index in wxListBox::Selected" );
+        wxT("invalid index in wxListBox::Selected") );
 
-	return MacIsSelected( N ) ;
+    return MacIsSelected( N ) ;
 }
 
 void *wxListBox::DoGetItemClientData(int N) const
 {
     wxCHECK_MSG( N >= 0 && N < m_noItems, NULL,
-                 "invalid index in wxListBox::GetClientData" );
+        wxT("invalid index in wxListBox::GetClientData"));
 
     return (void *)m_dataArray[N];
 }
 
 wxClientData *wxListBox::DoGetItemClientObject(int N) const
 {
-	return (wxClientData *) DoGetItemClientData( N ) ;
+    return (wxClientData *) DoGetItemClientData( N ) ;
 }
 
 void wxListBox::DoSetItemClientData(int N, void *Client_data)
 {
     wxCHECK_RET( N >= 0 && N < m_noItems,
-                 "invalid index in wxListBox::SetClientData" );
+        wxT("invalid index in wxListBox::SetClientData") );
 
 #if wxUSE_OWNER_DRAWN
     if ( m_windowStyle & wxLB_OWNERDRAW )
@@ -319,15 +485,15 @@ void wxListBox::DoSetItemClientData(int N, void *Client_data)
         wxFAIL_MSG(wxT("Can't use client data with owner-drawn listboxes"));
     }
 #endif // wxUSE_OWNER_DRAWN
-	wxASSERT_MSG( m_dataArray.GetCount() >= N , "invalid client_data array" ) ;
-	
-	if ( m_dataArray.GetCount() > N )
-	{
-    	m_dataArray[N] = (char*) Client_data ;
+    wxASSERT_MSG( m_dataArray.GetCount() >= (size_t) N , wxT("invalid client_data array") ) ;
+
+    if ( m_dataArray.GetCount() > (size_t) N )
+    {
+        m_dataArray[N] = (char*) Client_data ;
     }
     else
     {
-    	m_dataArray.Add( (char*) Client_data ) ;
+        m_dataArray.Add( (char*) Client_data ) ;
     }
 }
 
@@ -339,76 +505,100 @@ void wxListBox::DoSetItemClientObject(int n, wxClientData* clientData)
 // Return number of selections and an array of selected integers
 int wxListBox::GetSelections(wxArrayInt& aSelections) const
 {
-	return MacGetSelections( aSelections ) ;
-
-/* TODO
-    if ((m_windowStyle & wxLB_MULTIMacE) || (m_windowStyle & wxLB_EXTENDED))
-    {
-        int no_sel = ??
-        for ( int n = 0; n < no_sel; n++ )
-            aSelections.Add(??);
-
-        return no_sel;
-    }
-    else  // single-selection listbox
-    {
-        aSelections.Add(??);
-
-        return 1;
-    }
-*/
+    return MacGetSelections( aSelections ) ;
 }
 
 // Get single selection, for single choice list items
 int wxListBox::GetSelection() const
 {
-	return MacGetSelection() ;
+    return MacGetSelection() ;
 }
 
 // Find string for position
 wxString wxListBox::GetString(int N) const
 {
-	if( wxApp::s_macDefaultEncodingIsPC )
-	{
-		return 		wxMacMakePCStringFromMac( m_stringArray[N] ) ;
-	}
-	else
-		return m_stringArray[N]  ;
+	return m_stringArray[N]  ;
 }
 
 void wxListBox::DoInsertItems(const wxArrayString& items, int pos)
 {
     wxCHECK_RET( pos >= 0 && pos <= m_noItems,
-                 wxT("invalid index in wxListBox::InsertItems") );
+        wxT("invalid index in wxListBox::InsertItems") );
 
-    int nItems = items.GetCount();
+    InvalidateBestSize();
 
-	for ( int i = 0 ; i < nItems ; i++ )
-	{
-		m_stringArray.Insert( items[i] , pos + i ) ;
-		m_dataArray.Insert( NULL , pos + i ) ;
-		MacInsert( pos + i , items[i] ) ;
-	}
+    int nItems = items.GetCount();
 
-    m_noItems += nItems;
+    for ( int i = 0 ; i < nItems ; i++ )
+    {
+        m_stringArray.Insert( items[i] , pos + i ) ;
+        m_dataArray.Insert( NULL , pos + i ) ;
+        m_noItems++ ;
+        MacInsert( pos + i , items[i] ) ;
+    }
 }
 
 void wxListBox::SetString(int N, const wxString& s)
 {
-	wxString str ;
-	if( wxApp::s_macDefaultEncodingIsPC )
-	{
-		str = wxMacMakeMacStringFromPC( s )  ;
-	}
-	else
-		str = s ;
-	m_stringArray[N] = str ;
-	MacSet( N , s ) ;
+    m_stringArray[N] = s ;
+    MacSet( N , s ) ;
 }
 
 wxSize wxListBox::DoGetBestSize() const
 {
-    return wxSize(100, 100);
+    int lbWidth = 100;  // some defaults
+    int lbHeight = 110;
+    int wLine;
+
+    {
+        wxMacPortStateHelper st( UMAGetWindowPort( (WindowRef) MacGetTopLevelWindowRef() ) ) ;
+
+        if ( m_font.Ok() )
+        {
+            ::TextFont( m_font.MacGetFontNum() ) ;
+            ::TextSize( m_font.MacGetFontSize() ) ;
+            ::TextFace( m_font.MacGetFontStyle() ) ;
+        }
+        else
+        {
+            ::TextFont( kFontIDMonaco ) ;
+            ::TextSize( 9  );
+            ::TextFace( 0 ) ;
+        }
+
+        // Find the widest line
+        for(int i = 0; i < GetCount(); i++) {
+            wxString str(GetString(i));
+        #if wxUSE_UNICODE
+            Point bounds={0,0} ;
+            SInt16 baseline ;
+            ::GetThemeTextDimensions( wxMacCFStringHolder( str , m_font.GetEncoding() ) ,
+                kThemeCurrentPortFont,
+                kThemeStateActive,
+                false,
+                &bounds,
+                &baseline );
+            wLine = bounds.h ;
+        #else
+            wLine = ::TextWidth( str.c_str() , 0 , str.Length() ) ;
+        #endif
+            lbWidth = wxMax(lbWidth, wLine);
+        }
+
+        // Add room for the scrollbar
+        lbWidth += wxSystemSettings::GetMetric(wxSYS_VSCROLL_X);
+
+        // And just a bit more
+        int cy = 12 ;
+        int cx = ::TextWidth( "X" , 0 , 1 ) ;
+        lbWidth += cx ;
+
+        // don't make the listbox too tall (limit height to around 10 items) but don't
+        // make it too small neither
+        lbHeight = (cy+4) * wxMin(wxMax(GetCount(), 3), 10);
+    }
+
+    return wxSize(lbWidth, lbHeight);
 }
 
 int wxListBox::GetCount() const
@@ -416,10 +606,9 @@ int wxListBox::GetCount() const
     return m_noItems;
 }
 
-void wxListBox::SetupColours()
+void wxListBox::Refresh(bool eraseBack, const wxRect *rect)
 {
-    SetBackgroundColour(wxSystemSettings::GetSystemColour(wxSYS_COLOUR_WINDOW));
-    SetForegroundColour(GetParent()->GetForegroundColour());
+    wxControl::Refresh( eraseBack , rect ) ;
 }
 
 #if wxUSE_OWNER_DRAWN
@@ -443,180 +632,273 @@ wxOwnerDrawn *wxListBox::CreateItem(size_t n)
 
 #endif  //USE_OWNER_DRAWN
 
+
+// Some custom controls depend on this
+/* static */ wxVisualAttributes
+wxListBox::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant))
+{
+    wxVisualAttributes attr;
+    attr.colFg = wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOWTEXT);
+    attr.colBg = wxSystemSettings::GetColour(wxSYS_COLOUR_LISTBOX);
+    attr.font  = wxSystemSettings::GetFont(wxSYS_DEFAULT_GUI_FONT);
+    return attr;
+}
+
 // ============================================================================
 // list box control implementation
 // ============================================================================
 
-void MacDrawStringCell(Rect *cellRect, Cell lCell, ListHandle theList, long refCon)
+void wxListBox::MacDelete( int n )
 {
-	wxListBox*			list;
-	// typecast our refCon
-	list = (wxListBox*)refCon;
-		
-	MoveTo(cellRect->left + 4 , cellRect->top + 10 );
-	const wxString text = list->m_stringArray[lCell.v] ;
-	::TextFont( kFontIDMonaco ) ;
-	::TextSize( 9  );
-	::TextFace( 0 ) ;
-	DrawText(text, 0 , text.Length());
-		
-}
+    wxArrayInt selectionBefore ;
+    MacGetSelections( selectionBefore ) ;
 
-void wxListBox::MacDelete( int N )
-{
-	ListHandle list ;
-	long	result ;
-	Cell cell = { 0 , 0 } ;
-	UMAGetControlData( m_macControl , kControlNoPart , kControlListBoxListHandleTag , sizeof( ListHandle ) , (char*) &list  , &result ) ;
-	LDelRow( 1 , N , list ) ;
+    UInt32 id = m_noItems+1 ;
+    verify_noerr( m_peer->RemoveItems( kDataBrowserNoItem , 1 , (UInt32*) &id , kDataBrowserItemNoProperty ) ) ;
+    for ( size_t i = 0 ; i < selectionBefore.GetCount() ; ++i )
+    {
+        int current = selectionBefore[i] ;
+        if ( current == n )
+        {
+            // selection was deleted
+            MacSetSelection( current , false ) ;
+        }
+        else if ( current > n )
+        {
+            // something behind the deleted item was selected -> move up
+            MacSetSelection( current - 1 , true ) ;
+            MacSetSelection( current , false ) ;
+        }
+    }
+    // refresh all
+    verify_noerr( m_peer->UpdateItems( kDataBrowserNoItem , 1 , (UInt32*) kDataBrowserNoItem , kDataBrowserItemNoProperty , kDataBrowserItemNoProperty ) ) ;
 }
 
-void wxListBox::MacInsert( int n , const char * text) 
+void wxListBox::MacInsert( int n , const wxString& text)
 {
-	Cell	cell ;
+    wxArrayInt selectionBefore ;
+    MacGetSelections( selectionBefore ) ;
 
-	cell.h = 0 ;
-	cell.v = n ;
+    UInt32 id = m_noItems ; // this has already been increased
+    verify_noerr( m_peer->AddItems( kDataBrowserNoItem , 1 ,  (UInt32*) &id , kDataBrowserItemNoProperty ) ) ;
 
-	LAddRow( 1 , cell.v , m_macList ) ;
+    for ( int i = selectionBefore.GetCount()-1 ; i >= 0 ; --i )
+    {
+        int current = selectionBefore[i] ;
+        if ( current >= n )
+        {
+            MacSetSelection( current + 1 , true ) ;
+            MacSetSelection( current , false ) ;
+        }
+    }
+
+    // refresh all
+    verify_noerr( m_peer->UpdateItems( kDataBrowserNoItem , 1 , (UInt32*) kDataBrowserNoItem , kDataBrowserItemNoProperty , kDataBrowserItemNoProperty ) ) ;
 }
 
-void wxListBox::MacAppend( const char * text) 
+void wxListBox::MacAppend( const wxString& text)
 {
-	Cell cell = { 0 , 0 } ;
-	cell.v = (**m_macList).dataBounds.bottom ;
-	LAddRow( 1 , cell.v , m_macList ) ;
+    UInt32 id = m_noItems ; // this has already been increased
+    verify_noerr( m_peer->AddItems( kDataBrowserNoItem , 1 ,  (UInt32*) &id , kDataBrowserItemNoProperty ) ) ;
+    // no need to deal with selections nor refreshed, as we have appended
 }
 
-void wxListBox::MacClear() 
+void wxListBox::MacClear()
 {
-	LDelRow( (**m_macList).dataBounds.bottom , 0 , m_macList ) ;
+    verify_noerr( m_peer->RemoveItems( kDataBrowserNoItem , 0 , NULL , kDataBrowserItemNoProperty ) ) ;
+}
+
+void wxListBox::MacDeselectAll()
+{
+    bool former = MacSuppressSelection( true ) ;
+    verify_noerr(m_peer->SetSelectedItems( 0 , NULL , kDataBrowserItemsRemove ) ) ;
+    MacSuppressSelection( former ) ;
 }
 
 void wxListBox::MacSetSelection( int n , bool select )
 {
-	Cell cell = { 0 , 0 } ;
-	if ( LGetSelect( TRUE , &cell , m_macList ) )
-	{
-		LSetSelect( false , cell , m_macList ) ;
-	}
-	
-	cell.v = n ;
-	LSetSelect( select , cell , m_macList ) ;
-	LAutoScroll( m_macList ) ;
+    bool former = MacSuppressSelection( true ) ;
+    UInt32 id = n + 1 ;
+
+    if ( m_peer->IsItemSelected( id ) != select )
+    {
+        if ( select )
+            verify_noerr(m_peer->SetSelectedItems( 1 , & id , HasMultipleSelection() ? kDataBrowserItemsAdd : kDataBrowserItemsAssign ) ) ;
+        else
+            verify_noerr(m_peer->SetSelectedItems( 1 , & id , kDataBrowserItemsRemove ) ) ;
+    }
+    MacScrollTo( n ) ;
+    MacSuppressSelection( former ) ;
 }
 
-bool wxListBox::MacIsSelected( int n ) const
+bool  wxListBox::MacSuppressSelection( bool suppress )
 {
-	Cell cell = { 0 , 0 } ;
-	cell.v = n ;
-	return LGetSelect( false , &cell , m_macList ) ;
+	bool former = m_suppressSelection ;
+	m_suppressSelection = suppress ;
+	return former ;
 }
 
-void wxListBox::MacDestroy()
+bool wxListBox::MacIsSelected( int n ) const
 {
-//	DisposeExtLDEFInfo( m_macList ) ;
+    return m_peer->IsItemSelected( n + 1 ) ;
 }
 
 int wxListBox::MacGetSelection() const
 {
-	Cell cell = { 0 , 0 } ;
-	if ( LGetSelect( true , &cell , m_macList ) )
-		return cell.v ;
-	else
-		return -1 ;
+    for ( int i = 0 ; i < GetCount() ; ++i )
+    {
+        if ( m_peer->IsItemSelected( i + 1 ) )
+        {
+            return i ;
+        }
+    }
+    return -1 ;
 }
 
 int wxListBox::MacGetSelections( wxArrayInt& aSelections ) const
 {
-	int no_sel = 0 ;
-	
+    int no_sel = 0 ;
+
     aSelections.Empty();
 
-	Cell cell = { 0 , 0 } ;
-	cell.v = 0 ;
-	
-	while ( LGetSelect( true , &cell , m_macList ) )
-	{
-		aSelections.Add( cell.v ) ;
-		no_sel++ ;
-		cell.v++ ;
-	}
-	return no_sel ;
+    UInt32 first , last ;
+    m_peer->GetSelectionAnchor( &first , &last ) ;
+    if ( first != kDataBrowserNoItem )
+    {
+        for ( size_t i = first ; i <= last ; ++i )
+        {
+            if ( m_peer->IsItemSelected( i ) )
+            {
+                aSelections.Add( i - 1 ) ;
+                no_sel++ ;
+            }
+        }
+    }
+    return no_sel ;
 }
 
-void wxListBox::MacSet( int n , const char * text )
+void wxListBox::MacSet( int n , const wxString& text )
 {
-	// our implementation does not store anything in the list
-	// so we just have to redraw
-	Cell cell = { 0 , 0 } ;
-	cell.v = n ;
-	LDraw( cell , m_macList ) ;
+    // as we don't store the strings we only have to issue a redraw
+    UInt32 id = n + 1 ;
+    verify_noerr( m_peer->UpdateItems( kDataBrowserNoItem , 1 , &id , kDataBrowserItemNoProperty , kDataBrowserItemNoProperty ) ) ;
 }
 
 void wxListBox::MacScrollTo( int n )
 {
-	// TODO implement scrolling
+    UInt32 id = n + 1 ;
+    verify_noerr(  m_peer->RevealItem( id , kTextColumnId , kDataBrowserRevealWithoutSelecting ) ) ;
 }
 
-void wxListBox::OnSize( const wxSizeEvent &event)
-{
-	Point pt = (**m_macList).cellSize ;
-	pt.h =  m_width - 15  ;
-	LCellSize( pt , m_macList ) ;
-}
+#if !TARGET_API_MAC_OSX
 
-void wxListBox::MacHandleControlClick( ControlHandle control , SInt16 controlpart ) 
+void wxListBox::OnChar(wxKeyEvent& event)
 {
-	Boolean wasDoubleClick = false ;
-	long	result ;
+    // todo trigger proper events here
+    event.Skip() ;
+    return ;
 
-	UMAGetControlData( m_macControl , kControlNoPart , kControlListBoxDoubleClickTag , sizeof( wasDoubleClick ) , (char*) &wasDoubleClick  , &result ) ;
-	if ( !wasDoubleClick )
-	{
-		MacDoClick() ;
-	}
-	else
-	{
-		MacDoDoubleClick() ;
-	}
-}
+    if ( event.GetKeyCode() == WXK_RETURN || event.GetKeyCode() == WXK_NUMPAD_ENTER)
+    {
+        wxWindow* parent = GetParent() ;
+        while( parent  && !parent->IsTopLevel() && parent->GetDefaultItem() == NULL )
+            parent = parent->GetParent() ;
 
-void wxListBox::MacSetRedraw( bool doDraw ) 
-{
-	LSetDrawingMode( doDraw , m_macList ) ;
-	
-}
+        if ( parent && parent->GetDefaultItem() )
+        {
+            wxButton *def = wxDynamicCast(parent->GetDefaultItem(),
+                wxButton);
+            if ( def && def->IsEnabled() )
+            {
+                wxCommandEvent event(wxEVT_COMMAND_BUTTON_CLICKED, def->GetId() );
+                event.SetEventObject(def);
+                def->Command(event);
+                return ;
+            }
+        }
+        event.Skip() ;
+    }
+    /* generate wxID_CANCEL if command-. or <esc> has been pressed (typically in dialogs) */
+    else if (event.GetKeyCode() == WXK_ESCAPE || (event.GetKeyCode() == '.' && event.MetaDown() ) )
+    {
+    	// FIXME: look in ancestors, not just parent.
+        wxWindow* win = GetParent()->FindWindow( wxID_CANCEL ) ;
+        if (win)
+        {
+        	wxCommandEvent new_event(wxEVT_COMMAND_BUTTON_CLICKED,wxID_CANCEL);
+        	new_event.SetEventObject( win );
+        	win->GetEventHandler()->ProcessEvent( new_event );
+      	}
+    }
+    else if ( event.GetKeyCode() == WXK_TAB )
+    {
+        wxNavigationKeyEvent new_event;
+        new_event.SetEventObject( this );
+        new_event.SetDirection( !event.ShiftDown() );
+        /* CTRL-TAB changes the (parent) window, i.e. switch notebook page */
+        new_event.SetWindowChange( event.ControlDown() );
+        new_event.SetCurrentFocus( this );
+        if ( !GetEventHandler()->ProcessEvent( new_event ) )
+            event.Skip() ;
+    }
+    else if ( event.GetKeyCode() == WXK_DOWN || event.GetKeyCode() == WXK_UP )
+    {
+        // perform the default key handling first
+        wxControl::OnKeyDown( event ) ;
 
-void wxListBox::MacDoClick()
-{
-	wxCommandEvent event(wxEVT_COMMAND_LISTBOX_SELECTED, m_windowId);
-    event.SetEventObject( this );
+        wxCommandEvent event(wxEVT_COMMAND_LISTBOX_SELECTED, m_windowId);
+        event.SetEventObject( this );
 
-	wxArrayInt aSelections;
-	int n, count = GetSelections(aSelections);
-	if ( count > 0 )
-	{
-           n = aSelections[0];
-           if ( HasClientObjectData() )
-              event.SetClientObject( GetClientObject(n) );
-          else if ( HasClientUntypedData() )
-              event.SetClientData( GetClientData(n) );
-          event.SetString( GetString(n) );
-	}
-	else
-	{
-         n = -1;
-	}
-	
-    event.m_commandInt = n;
+        wxArrayInt aSelections;
+        int n, count = GetSelections(aSelections);
+        if ( count > 0 )
+        {
+            n = aSelections[0];
+            if ( HasClientObjectData() )
+                event.SetClientObject( GetClientObject(n) );
+            else if ( HasClientUntypedData() )
+                event.SetClientData( GetClientData(n) );
+            event.SetString( GetString(n) );
+        }
+        else
+        {
+            n = -1;
+        }
 
-    GetEventHandler()->ProcessEvent(event);
-}
+        event.SetInt(n);
 
-void wxListBox::MacDoDoubleClick()
-{
-    wxCommandEvent event(wxEVT_COMMAND_LISTBOX_DOUBLECLICKED, m_windowId);
-    event.SetEventObject( this );
-	GetEventHandler()->ProcessEvent(event) ; 
+        GetEventHandler()->ProcessEvent(event);
+    }
+    else
+    {
+        if ( event.GetTimestamp() > m_lastTypeIn + 60 )
+        {
+            m_typeIn = wxEmptyString ;
+        }
+        m_lastTypeIn = event.GetTimestamp() ;
+        m_typeIn += (char) event.GetKeyCode() ;
+        int line = FindString(wxT("*")+m_typeIn+wxT("*")) ;
+        if ( line >= 0 )
+        {
+            if ( GetSelection() != line )
+            {
+                SetSelection(line) ;
+                wxCommandEvent event(wxEVT_COMMAND_LISTBOX_SELECTED, m_windowId);
+                event.SetEventObject( this );
+
+                if ( HasClientObjectData() )
+                    event.SetClientObject( GetClientObject( line ) );
+                else if ( HasClientUntypedData() )
+                    event.SetClientData( GetClientData(line) );
+                event.SetString( GetString(line) );
+
+                event.SetInt(line);
+
+                GetEventHandler()->ProcessEvent(event);
+            }
+        }
+    }
 }
+
+#endif // !TARGET_API_MAC_OSX
+