X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/2b1d737b3e9413217302cde932cbc3af91d79024..e5a870a20f8a6fcbd796611857c81d49aa891b9b:/src/common/debugrpt.cpp diff --git a/src/common/debugrpt.cpp b/src/common/debugrpt.cpp index 96ccc60012..e9d477c1fa 100644 --- a/src/common/debugrpt.cpp +++ b/src/common/debugrpt.cpp @@ -30,10 +30,11 @@ #include "wx/utils.h" #endif // WX_PRECOMP -#if wxUSE_DEBUGREPORT +#if wxUSE_DEBUGREPORT && wxUSE_XML #include "wx/debugrpt.h" +#include "wx/ffile.h" #include "wx/filename.h" #include "wx/dir.h" #include "wx/dynlib.h" @@ -53,12 +54,14 @@ #include "wx/zipstrm.h" #endif // wxUSE_ZIPSTREAM -#if wxUSE_STACKWALKER +WX_CHECK_BUILD_OPTIONS("wxQA") // ---------------------------------------------------------------------------- // XmlStackWalker: stack walker specialization which dumps stack in XML // ---------------------------------------------------------------------------- +#if wxUSE_STACKWALKER + class XmlStackWalker : public wxStackWalker { public: @@ -224,7 +227,12 @@ wxDebugReport::~wxDebugReport() if ( !m_dir.empty() ) { + // Temp fix: what should this be? eVC++ doesn't like wxRmDir +#ifdef __WXWINCE__ + if ( wxRmdir(m_dir.fn_str()) != 0 ) +#else if ( wxRmDir(m_dir.fn_str()) != 0 ) +#endif { wxLogSysError(_("Failed to clean up debug report directory \"%s\""), m_dir.c_str()); @@ -244,12 +252,49 @@ wxString wxDebugReport::GetReportName() const return _T("wx"); } -void wxDebugReport::AddFile(const wxString& name, const wxString& description) +void +wxDebugReport::AddFile(const wxString& filename, const wxString& description) { + wxString name; + wxFileName fn(filename); + if ( fn.IsAbsolute() ) + { + // we need to copy the file to the debug report directory: give it the + // same name there + name = fn.GetFullName(); + wxCopyFile(fn.GetFullPath(), + wxFileName(GetDirectory(), name).GetFullPath()); + } + else // file relative to the report directory + { + name = filename; + + wxASSERT_MSG( wxFileName(GetDirectory(), name).FileExists(), + _T("file should exist in debug report directory") ); + } + m_files.Add(name); m_descriptions.Add(description); } +bool +wxDebugReport::AddText(const wxString& filename, + const wxString& text, + const wxString& description) +{ + wxASSERT_MSG( !wxFileName(filename).IsAbsolute(), + _T("filename should be relative to debug report directory") ); + + wxFileName fn(GetDirectory(), filename); + wxFFile file(fn.GetFullPath(), _T("w")); + if ( !file.IsOpened() || !file.Write(text) ) + return false; + + AddFile(filename, description); + + return true; +} + void wxDebugReport::RemoveFile(const wxString& name) { const int n = m_files.Index(name); @@ -322,8 +367,8 @@ bool wxDebugReport::DoAddLoadedModules(wxXmlNode *nodeModules) if ( !path.empty() ) nodeModule->AddProperty(_T("path"), path); - void *addr; - size_t len; + void *addr = NULL; + size_t len = 0; if ( info.GetAddress(&addr, &len) ) { HexProperty(nodeModule, _T("address"), (unsigned long)addr); @@ -395,8 +440,8 @@ bool wxDebugReport::AddContext(wxDebugReport::Context ctx) wxXmlNode *nodeRoot = new wxXmlNode(wxXML_ELEMENT_NODE, _T("report")); xmldoc.SetRoot(nodeRoot); nodeRoot->AddProperty(_T("version"), _T("1.0")); - nodeRoot->AddProperty(_T("kind"), ctx == Context_Curent ? _T("user") - : _T("exception")); + nodeRoot->AddProperty(_T("kind"), ctx == Context_Current ? _T("user") + : _T("exception")); // add system information wxXmlNode *nodeSystemInfo = new wxXmlNode(wxXML_ELEMENT_NODE, _T("system")); @@ -431,7 +476,7 @@ bool wxDebugReport::AddContext(wxDebugReport::Context ctx) { sw.WalkFromException(); } - else // Context_Curent + else // Context_Current { sw.Walk(); } @@ -608,7 +653,7 @@ bool wxDebugReportUpload::DoProcess() wxArrayString output, errors; int rc = wxExecute(wxString::Format ( - _T("%s -F %s=@%s %s"), + _T("%s -F %s=@\"%s\" %s"), m_curlCmd.c_str(), m_inputField.c_str(), GetCompressedFileName().c_str(),