X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/24a7a1980f309763c349541daffa46f1a5fd16b2..33980f0da63a5c78e88df40d39b010fbe33d867a:/src/common/containr.cpp

diff --git a/src/common/containr.cpp b/src/common/containr.cpp
index 04a7794bfe..b76ec648d6 100644
--- a/src/common/containr.cpp
+++ b/src/common/containr.cpp
@@ -50,13 +50,24 @@ wxControlContainer::wxControlContainer(wxWindow *winParent)
 
 void wxControlContainer::SetLastFocus(wxWindow *win)
 {
-    // find the last _immediate_ child which got focus
-    while ( win && win != m_winParent )
+    // if we're setting the focus
+    if ( win )
     {
-        win = win->GetParent();
-    }
+        // find the last _immediate_ child which got focus but be prepared to
+        // handle the case when win == m_winParent as well
+        wxWindow *winParent = win;
+        while ( winParent != m_winParent )
+        {
+            win = winParent;
+            winParent = win->GetParent();
+
+            // Yes, this can happen, though in a totally pathological case.
+            // like when detaching a menubar from a frame with a child which
+            // has pushed itself as an event handler for the menubar.  (wxGtk)
 
-    wxASSERT_MSG( win, _T("attempt to set last focus to not a child?") );
+            wxASSERT_MSG( winParent, _T("Setting last-focus for a window that is not our child?") );
+        }
+    }
 
     m_winLastFocused = win;
 }
@@ -273,6 +284,23 @@ bool wxControlContainer::DoSetFocus()
     //
     // RR: Removed for now. Let's see what happens..
 
+    // if our child already has focus, don't take it away from it
+    wxWindow *win = wxWindow::FindFocus();
+    while ( win )
+    {
+        if ( win == m_winParent )
+            return TRUE;
+
+        if ( win->IsTopLevel() )
+        {
+            // don't look beyond the first top level parent - useless and
+            // unnecessary
+            break;
+        }
+
+        win = win->GetParent();
+    }
+
     return SetFocusToChild();
 }