X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/227989f3e96d846023d36a797931875c57fbae6d..586c455167ef67ac2920db45e48f8509b8be8d31:/src/common/file.cpp?ds=sidebyside

diff --git a/src/common/file.cpp b/src/common/file.cpp
index 8aaa9ac05e..bc6be8c1c4 100644
--- a/src/common/file.cpp
+++ b/src/common/file.cpp
@@ -24,7 +24,7 @@
 #if wxUSE_FILE
 
 // standard
-#if defined(__WXMSW__) && !defined(__GNUWIN32__) && !defined(__WXMICROWIN__) && !defined(__WXWINCE__)
+#if defined(__WINDOWS__) && !defined(__GNUWIN32__) && !defined(__WXMICROWIN__) && !defined(__WXWINCE__)
 
 #define   WIN32_LEAN_AND_MEAN
 #define   NOSERVICE
@@ -47,7 +47,7 @@
 #define   NOCRYPT
 #define   NOMCX
 
-#elif defined(__WXMSW__) && defined(__WXWINCE__)
+#elif defined(__WINDOWS__) && defined(__WXWINCE__)
     #include  "wx/msw/missing.h"
 #elif (defined(__OS2__))
     #include <io.h>
@@ -80,14 +80,16 @@
     char* mktemp( char * path ) { return path ;}
     #include <stat.h>
     #include <unistd.h>
-#elif defined(__WXPALMOS__)
-    #include "wx/palmos/missing.h"
 #else
     #error  "Please specify the header with file functions declarations."
 #endif  //Win/UNIX
 
 #include  <stdio.h>       // SEEK_xxx constants
 
+#ifndef __WXWINCE__
+    #include <errno.h>
+#endif
+
 // Windows compilers don't have these constants
 #ifndef W_OK
     enum
@@ -117,7 +119,7 @@
     #define   O_BINARY    (0)
 #endif  //__UNIX__
 
-#ifdef __WXMSW__
+#ifdef __WINDOWS__
     #include "wx/msw/mslu.h"
 #endif
 
@@ -176,11 +178,27 @@ bool wxFile::Access(const wxString& name, OpenMode mode)
 wxFile::wxFile(const wxString& fileName, OpenMode mode)
 {
     m_fd = fd_invalid;
-    m_error = false;
+    m_lasterror = 0;
 
     Open(fileName, mode);
 }
 
+bool wxFile::CheckForError(wxFileOffset rc) const
+{
+    if ( rc != -1 )
+        return false;
+
+    const_cast<wxFile *>(this)->m_lasterror =
+#ifndef __WXWINCE__
+                                                errno
+#else
+                                                ::GetLastError()
+#endif
+                                                ;
+
+    return true;
+}
+
 // create the file, fail if it already exists and bOverwrite
 bool wxFile::Create(const wxString& fileName, bool bOverwrite, int accessMode)
 {
@@ -190,7 +208,7 @@ bool wxFile::Create(const wxString& fileName, bool bOverwrite, int accessMode)
                      O_BINARY | O_WRONLY | O_CREAT |
                      (bOverwrite ? O_TRUNC : O_EXCL),
                      accessMode );
-    if ( fd == -1 )
+    if ( CheckForError(fd) )
     {
         wxLogSysError(_("can't create file '%s'"), fileName);
         return false;
@@ -242,7 +260,7 @@ bool wxFile::Open(const wxString& fileName, OpenMode mode, int accessMode)
 
     int fd = wxOpen( fileName, flags, accessMode);
 
-    if ( fd == -1 )
+    if ( CheckForError(fd) )
     {
         wxLogSysError(_("can't open file '%s'"), fileName);
         return false;
@@ -256,7 +274,7 @@ bool wxFile::Open(const wxString& fileName, OpenMode mode, int accessMode)
 bool wxFile::Close()
 {
     if ( IsOpened() ) {
-        if (wxClose(m_fd) == -1)
+        if ( CheckForError(wxClose(m_fd)) )
         {
             wxLogSysError(_("can't close file descriptor %d"), m_fd);
             m_fd = fd_invalid;
@@ -280,7 +298,7 @@ ssize_t wxFile::Read(void *pBuf, size_t nCount)
 
     ssize_t iRc = wxRead(m_fd, pBuf, nCount);
 
-    if ( iRc == -1 )
+    if ( CheckForError(iRc) )
     {
         wxLogSysError(_("can't read from file descriptor %d"), m_fd);
         return wxInvalidOffset;
@@ -296,10 +314,9 @@ size_t wxFile::Write(const void *pBuf, size_t nCount)
 
     ssize_t iRc = wxWrite(m_fd, pBuf, nCount);
 
-    if ( iRc == -1 )
+    if ( CheckForError(iRc) )
     {
         wxLogSysError(_("can't write to file descriptor %d"), m_fd);
-        m_error = true;
         iRc = 0;
     }
 
@@ -312,7 +329,12 @@ bool wxFile::Write(const wxString& s, const wxMBConv& conv)
   if ( !buf )
       return false;
 
+#if wxUSE_UNICODE
   const size_t size = buf.length();
+#else
+  const size_t size = s.length();
+#endif
+
   return Write(buf, size) == size;
 }
 
@@ -324,7 +346,7 @@ bool wxFile::Flush()
     // call it then
     if ( IsOpened() && GetKind() == wxFILE_KIND_DISK )
     {
-        if ( wxFsync(m_fd) == -1 )
+        if ( CheckForError(wxFsync(m_fd)) )
         {
             wxLogSysError(_("can't flush file descriptor %d"), m_fd);
             return false;
@@ -366,7 +388,7 @@ wxFileOffset wxFile::Seek(wxFileOffset ofs, wxSeekMode mode)
     }
 
     wxFileOffset iRc = wxSeek(m_fd, ofs, origin);
-    if ( iRc == wxInvalidOffset )
+    if ( CheckForError(iRc) )
     {
         wxLogSysError(_("can't seek on file descriptor %d"), m_fd);
     }
@@ -380,7 +402,7 @@ wxFileOffset wxFile::Tell() const
     wxASSERT( IsOpened() );
 
     wxFileOffset iRc = wxTell(m_fd);
-    if ( iRc == wxInvalidOffset )
+    if ( CheckForError(iRc) )
     {
         wxLogSysError(_("can't get seek position on file descriptor %d"), m_fd);
     }
@@ -410,8 +432,7 @@ wxFileOffset wxFile::Length() const
 
     wxFileOffset iRc = Tell();
     if ( iRc != wxInvalidOffset ) {
-        // have to use const_cast :-(
-        wxFileOffset iLen = ((wxFile *)this)->SeekEnd();
+        wxFileOffset iLen = const_cast<wxFile *>(this)->SeekEnd();
         if ( iLen != wxInvalidOffset ) {
             // restore old position
             if ( ((wxFile *)this)->Seek(iRc) == wxInvalidOffset ) {
@@ -425,6 +446,7 @@ wxFileOffset wxFile::Length() const
 
     if ( iRc == wxInvalidOffset )
     {
+        // last error was already set by Tell()
         wxLogSysError(_("can't find length of file on file descriptor %d"), m_fd);
     }
 
@@ -438,7 +460,7 @@ bool wxFile::Eof() const
 
     wxFileOffset iRc;
 
-#if defined(__DOS__) || defined(__UNIX__) || defined(__GNUWIN32__) || defined( __MWERKS__ )
+#if defined(__DOS__) || defined(__UNIX__) || defined(__GNUWIN32__)
     // @@ this doesn't work, of course, on unseekable file descriptors
     wxFileOffset ofsCur = Tell(),
     ofsMax = Length();