X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/223d09f6b523aac674ef9b72a883dfa8d37c5d4e..cb98e78b1e363e70d07360728c49b6dd21f36f7c:/src/gtk/choice.cpp?ds=sidebyside diff --git a/src/gtk/choice.cpp b/src/gtk/choice.cpp index 32322e0a7f..462d9266ef 100644 --- a/src/gtk/choice.cpp +++ b/src/gtk/choice.cpp @@ -1,5 +1,5 @@ ///////////////////////////////////////////////////////////////////////////// -// Name: choice.cpp +// Name: src/gtk/choice.cpp // Purpose: // Author: Robert Roebling // Id: $Id$ @@ -7,417 +7,382 @@ // Licence: wxWindows licence ///////////////////////////////////////////////////////////////////////////// +#include "wx/wxprec.h" -#ifdef __GNUG__ -#pragma implementation "choice.h" -#endif +#if wxUSE_CHOICE || wxUSE_COMBOBOX #include "wx/choice.h" -#if wxUSE_CHOICE +#ifndef WX_PRECOMP + #include "wx/arrstr.h" +#endif -#include "gdk/gdk.h" -#include "gtk/gtk.h" +#include "wx/gtk/private.h" -//----------------------------------------------------------------------------- -// idle system -//----------------------------------------------------------------------------- -extern void wxapp_install_idle_handler(); -extern bool g_isIdle; - -//----------------------------------------------------------------------------- -// data -//----------------------------------------------------------------------------- +// ---------------------------------------------------------------------------- +// GTK callbacks +// ---------------------------------------------------------------------------- -extern bool g_blockEventsOnDrag; +extern "C" { -//----------------------------------------------------------------------------- -// "activate" -//----------------------------------------------------------------------------- - -static void gtk_choice_clicked_callback( GtkWidget *WXUNUSED(widget), wxChoice *choice ) +static void +gtk_choice_changed_callback( GtkWidget *WXUNUSED(widget), wxChoice *choice ) { - if (g_isIdle) - wxapp_install_idle_handler(); - - if (!choice->m_hasVMT) return; - - if (g_blockEventsOnDrag) return; + choice->SendSelectionChangedEvent(wxEVT_COMMAND_CHOICE_SELECTED); +} - wxCommandEvent event(wxEVT_COMMAND_CHOICE_SELECTED, choice->GetId() ); - event.SetInt( choice->GetSelection() ); - event.SetString( choice->GetStringSelection() ); - event.SetEventObject(choice); - choice->GetEventHandler()->ProcessEvent(event); } //----------------------------------------------------------------------------- // wxChoice //----------------------------------------------------------------------------- -IMPLEMENT_DYNAMIC_CLASS(wxChoice,wxControl) +IMPLEMENT_DYNAMIC_CLASS(wxChoice, wxControlWithItems) -wxChoice::wxChoice() +void wxChoice::Init() { + m_strings = NULL; + m_stringCellIndex = 0; } bool wxChoice::Create( wxWindow *parent, wxWindowID id, const wxPoint &pos, const wxSize &size, - int n, const wxString choices[], - long style, const wxValidator& validator, const wxString &name ) + const wxArrayString& choices, + long style, const wxValidator& validator, + const wxString &name ) { - m_needParent = TRUE; -#if (GTK_MINOR_VERSION > 0) - m_acceptsFocus = TRUE; -#endif + wxCArrayString chs(choices); + + return Create( parent, id, pos, size, chs.GetCount(), chs.GetStrings(), + style, validator, name ); +} +bool wxChoice::Create( wxWindow *parent, wxWindowID id, + const wxPoint &pos, const wxSize &size, + int n, const wxString choices[], + long style, const wxValidator& validator, + const wxString &name ) +{ if (!PreCreation( parent, pos, size ) || !CreateBase( parent, id, pos, size, style, validator, name )) { wxFAIL_MSG( wxT("wxChoice creation failed") ); - return FALSE; + return false; } - m_widget = gtk_option_menu_new(); - - wxSize newSize(size); - if (newSize.x == -1) - newSize.x = 80; - if (newSize.y == -1) - newSize.y = 26; - SetSize( newSize.x, newSize.y ); - - GtkWidget *menu = gtk_menu_new(); - - for (int i = 0; i < n; i++) + if ( IsSorted() ) { - m_clientDataList.Append( (wxObject*) NULL ); - m_clientObjectList.Append( (wxObject*) NULL ); - - GtkWidget *item = gtk_menu_item_new_with_label( choices[i].mbc_str() ); - gtk_menu_append( GTK_MENU(menu), item ); + // if our m_strings != NULL, Append() will check for it and insert + // items in the correct order + m_strings = new wxGtkCollatedArrayString; + } - gtk_widget_show( item ); + m_widget = gtk_combo_box_new_text(); + g_object_ref(m_widget); - gtk_signal_connect( GTK_OBJECT( item ), "activate", - GTK_SIGNAL_FUNC(gtk_choice_clicked_callback), (gpointer*)this ); - } - gtk_option_menu_set_menu( GTK_OPTION_MENU(m_widget), menu ); + Append(n, choices); m_parent->DoAddChild( this ); - PostCreation(); - - SetBackgroundColour( parent->GetBackgroundColour() ); - SetForegroundColour( parent->GetForegroundColour() ); - SetFont( parent->GetFont() ); + PostCreation(size); - Show( TRUE ); + g_signal_connect_after (m_widget, "changed", + G_CALLBACK (gtk_choice_changed_callback), this); - return TRUE; + return true; } wxChoice::~wxChoice() { - Clear(); + delete m_strings; } -void wxChoice::AppendCommon( const wxString &item ) +void wxChoice::SendSelectionChangedEvent(wxEventType evt_type) { - wxCHECK_RET( m_widget != NULL, wxT("invalid choice") ); + if (!m_hasVMT) + return; - GtkWidget *menu = gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ); - GtkWidget *menu_item = gtk_menu_item_new_with_label( item.mbc_str() ); - - gtk_menu_append( GTK_MENU(menu), menu_item ); - - if (GTK_WIDGET_REALIZED(m_widget)) - { - gtk_widget_realize( menu_item ); - gtk_widget_realize( GTK_BIN(menu_item)->child ); + if (GetSelection() == -1) + return; - if (m_widgetStyle) ApplyWidgetStyle(); - } + wxCommandEvent event( evt_type, GetId() ); - gtk_signal_connect( GTK_OBJECT( menu_item ), "activate", - GTK_SIGNAL_FUNC(gtk_choice_clicked_callback), (gpointer*)this ); + int n = GetSelection(); + event.SetInt( n ); + event.SetString( GetStringSelection() ); + event.SetEventObject( this ); + InitCommandEventWithItems( event, n ); - gtk_widget_show( menu_item ); + HandleWindowEvent( event ); } -void wxChoice::Append( const wxString &item ) +void wxChoice::GTKInsertComboBoxTextItem( unsigned int n, const wxString& text ) { - m_clientDataList.Append( (wxObject*) NULL ); - m_clientObjectList.Append( (wxObject*) NULL ); - - AppendCommon( item ); + gtk_combo_box_insert_text( GTK_COMBO_BOX( m_widget ), n, wxGTK_CONV( text ) ); } -void wxChoice::Append( const wxString &item, void *clientData ) +int wxChoice::DoInsertItems(const wxArrayStringsAdapter & items, + unsigned int pos, + void **clientData, wxClientDataType type) { - m_clientDataList.Append( (wxObject*) clientData ); - m_clientObjectList.Append( (wxObject*) NULL ); - - AppendCommon( item ); -} + wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid control") ); -void wxChoice::Append( const wxString &item, wxClientData *clientData ) -{ - m_clientObjectList.Append( (wxObject*) clientData ); - m_clientDataList.Append( (wxObject*) NULL ); + wxASSERT_MSG( !IsSorted() || (pos == GetCount()), + wxT("In a sorted choice data could only be appended")); - AppendCommon( item ); -} + const int count = items.GetCount(); -void wxChoice::SetClientData( int n, void* clientData ) -{ - wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") ); + int n = wxNOT_FOUND; - wxNode *node = m_clientDataList.Nth( n ); - if (!node) return; + for ( int i = 0; i < count; ++i ) + { + n = pos + i; + // If sorted, use this wxSortedArrayStrings to determine + // the right insertion point + if (m_strings) + n = m_strings->Add(items[i]); - node->SetData( (wxObject*) clientData ); -} + GTKInsertComboBoxTextItem( n, items[i] ); -void* wxChoice::GetClientData( int n ) -{ - wxCHECK_MSG( m_widget != NULL, NULL, wxT("invalid combobox") ); + m_clientData.Insert( NULL, n ); + AssignNewItemClientData(n, clientData, i, type); + } - wxNode *node = m_clientDataList.Nth( n ); - if (!node) return NULL; + InvalidateBestSize(); - return node->Data(); + return n; } -void wxChoice::SetClientObject( int n, wxClientData* clientData ) +void wxChoice::DoSetItemClientData(unsigned int n, void* clientData) { - wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") ); - - wxNode *node = m_clientObjectList.Nth( n ); - if (!node) return; - - wxClientData *cd = (wxClientData*) node->Data(); - if (cd) delete cd; + m_clientData[n] = clientData; +} - node->SetData( (wxObject*) clientData ); +void* wxChoice::DoGetItemClientData(unsigned int n) const +{ + return m_clientData[n]; } -wxClientData* wxChoice::GetClientObject( int n ) +void wxChoice::DoClear() { - wxCHECK_MSG( m_widget != NULL, (wxClientData*) NULL, wxT("invalid combobox") ); + wxCHECK_RET( m_widget != NULL, wxT("invalid control") ); - wxNode *node = m_clientObjectList.Nth( n ); - if (!node) return (wxClientData*) NULL; + GTKDisableEvents(); - return (wxClientData*) node->Data(); -} + GtkComboBox* combobox = GTK_COMBO_BOX( m_widget ); + GtkTreeModel* model = gtk_combo_box_get_model( combobox ); + gtk_list_store_clear(GTK_LIST_STORE(model)); -void wxChoice::Clear() -{ - wxCHECK_RET( m_widget != NULL, wxT("invalid choice") ); + m_clientData.Clear(); - gtk_option_menu_remove_menu( GTK_OPTION_MENU(m_widget) ); - GtkWidget *menu = gtk_menu_new(); - gtk_option_menu_set_menu( GTK_OPTION_MENU(m_widget), menu ); + if (m_strings) + m_strings->Clear(); - wxNode *node = m_clientObjectList.First(); - while (node) - { - wxClientData *cd = (wxClientData*)node->Data(); - if (cd) delete cd; - node = node->Next(); - } - m_clientObjectList.Clear(); + GTKEnableEvents(); - m_clientDataList.Clear(); + InvalidateBestSize(); } -void wxChoice::Delete( int WXUNUSED(n) ) +void wxChoice::DoDeleteOneItem(unsigned int n) { - wxFAIL_MSG( wxT("wxChoice:Delete not implemented") ); + wxCHECK_RET( m_widget != NULL, wxT("invalid control") ); + wxCHECK_RET( IsValid(n), wxT("invalid index in wxChoice::Delete") ); + + GtkComboBox* combobox = GTK_COMBO_BOX( m_widget ); + GtkTreeModel* model = gtk_combo_box_get_model( combobox ); + GtkListStore* store = GTK_LIST_STORE(model); + GtkTreeIter iter; + gtk_tree_model_iter_nth_child( model, &iter, + NULL, (gint) n ); + gtk_list_store_remove( store, &iter ); + + m_clientData.RemoveAt( n ); + if ( m_strings ) + m_strings->RemoveAt( n ); + + InvalidateBestSize(); } -int wxChoice::FindString( const wxString &string ) const +int wxChoice::FindString( const wxString &item, bool bCase ) const { - wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid choice") ); - - // If you read this code once and you think you understand - // it, then you are very wrong. Robert Roebling. - - GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) ); + wxCHECK_MSG( m_widget != NULL, wxNOT_FOUND, wxT("invalid control") ); + + GtkComboBox* combobox = GTK_COMBO_BOX( m_widget ); + GtkTreeModel* model = gtk_combo_box_get_model( combobox ); + GtkTreeIter iter; + gtk_tree_model_get_iter_first( model, &iter ); + if (!gtk_list_store_iter_is_valid(GTK_LIST_STORE(model), &iter )) + return -1; int count = 0; - GList *child = menu_shell->children; - while (child) + do { - GtkBin *bin = GTK_BIN( child->data ); - GtkLabel *label = (GtkLabel *) NULL; - if (bin->child) label = GTK_LABEL(bin->child); - if (!label) label = GTK_LABEL( GTK_BUTTON(m_widget)->child ); - - wxASSERT_MSG( label != NULL , wxT("wxChoice: invalid label") ); + GValue value = { 0, }; + gtk_tree_model_get_value( model, &iter, m_stringCellIndex, &value ); + wxString str = wxGTK_CONV_BACK( g_value_get_string( &value ) ); + g_value_unset( &value ); - if (string == wxString(label->label,*wxConvCurrent)) - return count; + if (item.IsSameAs( str, bCase ) ) + return count; - child = child->next; - count++; + count++; } + while ( gtk_tree_model_iter_next(model, &iter) ); - return -1; + return wxNOT_FOUND; } -int wxChoice::GetColumns() const +int wxChoice::GetSelection() const { - return 1; + return gtk_combo_box_get_active( GTK_COMBO_BOX( m_widget ) ); } -int wxChoice::GetSelection() +void wxChoice::SetString(unsigned int n, const wxString &text) { - wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid choice") ); + wxCHECK_RET( m_widget != NULL, wxT("invalid control") ); - GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) ); - int count = 0; - GList *child = menu_shell->children; - while (child) + GtkComboBox* combobox = GTK_COMBO_BOX( m_widget ); + wxCHECK_RET( IsValid(n), wxT("invalid index") ); + + GtkTreeModel *model = gtk_combo_box_get_model( combobox ); + GtkTreeIter iter; + if (gtk_tree_model_iter_nth_child (model, &iter, NULL, n)) { - GtkBin *bin = GTK_BIN( child->data ); - if (!bin->child) return count; - child = child->next; - count++; + GValue value = { 0, }; + g_value_init( &value, G_TYPE_STRING ); + g_value_set_string( &value, wxGTK_CONV( text ) ); + gtk_list_store_set_value( GTK_LIST_STORE(model), &iter, m_stringCellIndex, &value ); + g_value_unset( &value ); } - return -1; + InvalidateBestSize(); } -wxString wxChoice::GetString( int n ) const +wxString wxChoice::GetString(unsigned int n) const { - wxCHECK_MSG( m_widget != NULL, wxT(""), wxT("invalid choice") ); - - GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) ); - int count = 0; - GList *child = menu_shell->children; - while (child) - { - GtkBin *bin = GTK_BIN( child->data ); - if (count == n) - { - GtkLabel *label = (GtkLabel *) NULL; - if (bin->child) label = GTK_LABEL(bin->child); - if (!label) label = GTK_LABEL( GTK_BUTTON(m_widget)->child ); + wxCHECK_MSG( m_widget != NULL, wxEmptyString, wxT("invalid control") ); - wxASSERT_MSG( label != NULL , wxT("wxChoice: invalid label") ); + wxString str; - return wxString(label->label,*wxConvCurrent); - } - child = child->next; - count++; + GtkComboBox* combobox = GTK_COMBO_BOX( m_widget ); + GtkTreeModel *model = gtk_combo_box_get_model( combobox ); + GtkTreeIter iter; + if (gtk_tree_model_iter_nth_child (model, &iter, NULL, n)) + { + GValue value = { 0, }; + gtk_tree_model_get_value( model, &iter, m_stringCellIndex, &value ); + wxString tmp = wxGTK_CONV_BACK( g_value_get_string( &value ) ); + g_value_unset( &value ); + return tmp; } - wxFAIL_MSG( wxT("wxChoice: invalid index in GetString()") ); + return str; +} - return wxT(""); +unsigned int wxChoice::GetCount() const +{ + wxCHECK_MSG( m_widget != NULL, 0, wxT("invalid control") ); + + GtkComboBox* combobox = GTK_COMBO_BOX( m_widget ); + GtkTreeModel* model = gtk_combo_box_get_model( combobox ); + GtkTreeIter iter; + gtk_tree_model_get_iter_first( model, &iter ); + if (!gtk_list_store_iter_is_valid(GTK_LIST_STORE(model), &iter )) + return 0; + unsigned int ret = 1; + while (gtk_tree_model_iter_next( model, &iter )) + ret++; + return ret; } -wxString wxChoice::GetStringSelection() const +void wxChoice::SetSelection( int n ) { - wxCHECK_MSG( m_widget != NULL, wxT(""), wxT("invalid choice") ); + wxCHECK_RET( m_widget != NULL, wxT("invalid control") ); - GtkLabel *label = GTK_LABEL( GTK_BUTTON(m_widget)->child ); + GTKDisableEvents(); - wxASSERT_MSG( label != NULL , wxT("wxChoice: invalid label") ); + GtkComboBox* combobox = GTK_COMBO_BOX( m_widget ); + gtk_combo_box_set_active( combobox, n ); - return wxString(label->label,*wxConvCurrent); + GTKEnableEvents(); } -int wxChoice::Number() const +void wxChoice::SetColumns(int n) { - wxCHECK_MSG( m_widget != NULL, 0, wxT("invalid choice") ); - - GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) ); - int count = 0; - GList *child = menu_shell->children; - while (child) - { - count++; - child = child->next; - } - return count; + gtk_combo_box_set_wrap_width(GTK_COMBO_BOX(m_widget), n); } -void wxChoice::SetColumns( int WXUNUSED(n) ) +int wxChoice::GetColumns() const { + // gtk_combo_box_get_wrap_width() was added in gtk 2.6 + gint intval; + g_object_get(G_OBJECT(m_widget), "wrap-width", &intval, NULL); + return intval; } -void wxChoice::SetSelection( int n ) -{ - wxCHECK_RET( m_widget != NULL, wxT("invalid choice") ); - - int tmp = n; - gtk_option_menu_set_history( GTK_OPTION_MENU(m_widget), (gint)tmp ); -} -void wxChoice::SetStringSelection( const wxString &string ) +void wxChoice::GTKDisableEvents() { - wxCHECK_RET( m_widget != NULL, wxT("invalid choice") ); - - int n = FindString( string ); - if (n != -1) SetSelection( n ); + g_signal_handlers_block_by_func(m_widget, + (gpointer) gtk_choice_changed_callback, this); } -void wxChoice::DisableEvents() +void wxChoice::GTKEnableEvents() { -/* - GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) ); - GList *child = menu_shell->children; - while (child) - { - gtk_signal_disconnect_by_func( GTK_OBJECT( child->data ), - GTK_SIGNAL_FUNC(gtk_choice_clicked_callback), (gpointer*)this ); - - child = child->next; - } -*/ + g_signal_handlers_unblock_by_func(m_widget, + (gpointer) gtk_choice_changed_callback, this); } -void wxChoice::EnableEvents() -{ -/* - GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) ); - GList *child = menu_shell->children; - while (child) - { - gtk_signal_connect( GTK_OBJECT( child->data ), "activate", - GTK_SIGNAL_FUNC(gtk_choice_clicked_callback), (gpointer*)this ); - child = child->next; - } -*/ +GdkWindow *wxChoice::GTKGetWindow(wxArrayGdkWindows& WXUNUSED(windows)) const +{ + return m_widget->window; } -void wxChoice::ApplyWidgetStyle() +// Notice that this method shouldn't be necessary, because GTK calculates +// properly size of the combobox but for unknown reasons it doesn't work +// correctly in wx without this. +wxSize wxChoice::DoGetBestSize() const { - SetWidgetStyle(); + // strangely, this returns a width of 188 pixels from GTK+ (?) + wxSize ret( wxControl::DoGetBestSize() ); - GtkMenuShell *menu_shell = GTK_MENU_SHELL( gtk_option_menu_get_menu( GTK_OPTION_MENU(m_widget) ) ); + // we know better our horizontal extent: it depends on the longest string + // in the combobox + if ( m_widget ) + { + ret.x = GetCount() > 0 ? 0 : 60; // start with something "sensible" + int width; + unsigned int count = GetCount(); + for ( unsigned int n = 0; n < count; n++ ) + { + GetTextExtent(GetString(n), &width, NULL, NULL, NULL ); + if ( width + 40 > ret.x ) // 40 for drop down arrow and space around text + ret.x = width + 40; + } + } - gtk_widget_set_style( m_widget, m_widgetStyle ); - gtk_widget_set_style( GTK_WIDGET( menu_shell ), m_widgetStyle ); + // empty combobox should have some reasonable default size too + if ((GetCount() == 0) && (ret.x < 80)) + ret.x = 80; - GList *child = menu_shell->children; - while (child) - { - gtk_widget_set_style( GTK_WIDGET( child->data ), m_widgetStyle ); + CacheBestSize(ret); + return ret; +} - GtkBin *bin = GTK_BIN( child->data ); - GtkWidget *label = (GtkWidget *) NULL; - if (bin->child) label = bin->child; - if (!label) label = GTK_BUTTON(m_widget)->child; +void wxChoice::DoApplyWidgetStyle(GtkRcStyle *style) +{ + gtk_widget_modify_style(m_widget, style); + gtk_widget_modify_style(GTK_BIN(m_widget)->child, style); +} - gtk_widget_set_style( label, m_widgetStyle ); - child = child->next; - } +// static +wxVisualAttributes +wxChoice::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant)) +{ + return GetDefaultAttributesFromGTKWidget(gtk_combo_box_new); } -#endif + +#endif // wxUSE_CHOICE || wxUSE_COMBOBOX