X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/1ffeecf7a90f620c9a194a138bc84db17fdd18e0..b53aea81d2e102224b452ef5bf7aee1132f37c6f:/src/common/xpmdecod.cpp diff --git a/src/common/xpmdecod.cpp b/src/common/xpmdecod.cpp index b866d751aa..54e54c5221 100644 --- a/src/common/xpmdecod.cpp +++ b/src/common/xpmdecod.cpp @@ -108,6 +108,7 @@ license is as follows: #include "wx/hashmap.h" #include "wx/stream.h" #include "wx/image.h" + #include "wx/palette.h" #endif #include @@ -121,7 +122,8 @@ bool wxXPMDecoder::CanRead(wxInputStream& stream) if ( !stream.Read(buf, WXSIZEOF(buf)) ) return false; - stream.SeekI(-(wxFileOffset)WXSIZEOF(buf), wxFromCurrent); + if (stream.SeekI(-(wxFileOffset)WXSIZEOF(buf), wxFromCurrent) == wxInvalidOffset) + return false; return memcmp(buf, "/* XPM */", WXSIZEOF(buf)) == 0; } @@ -265,7 +267,7 @@ typedef struct #define myRGB(r,g,b) ((wxUint32)r<<16|(wxUint32)g<<8|(wxUint32)b) -static rgbRecord theRGBRecords[] = +static const rgbRecord theRGBRecords[] = { {"aliceblue", myRGB(240, 248, 255)}, {"antiquewhite", myRGB(250, 235, 215)}, @@ -504,7 +506,7 @@ static rgbRecord theRGBRecords[] = {"yellowgreen", myRGB(50, 216, 56)}, {NULL, myRGB(0, 0, 0)} }; -static int numTheRGBRecords = 235; +static const int numTheRGBRecords = 235; static unsigned char ParseHexadecimal(char digit1, char digit2) { @@ -664,12 +666,12 @@ wxImage wxXPMDecoder::ReadData(const char* const* xpm_data) int count; unsigned width, height, colors_cnt, chars_per_pixel; size_t i, j, i_key; - wxChar key[64]; + char key[64]; const char *clr_def; - bool hasMask; wxXPMColourMap clr_tbl; wxXPMColourMap::iterator it; wxString maskKey; + wxString keyString; /* * Read hints and initialize structures: @@ -688,12 +690,10 @@ wxImage wxXPMDecoder::ReadData(const char* const* xpm_data) // 8bit RGB... wxCHECK_MSG(chars_per_pixel < 64, wxNullImage, wxT("XPM colormaps this large not supported.")); - if ( !img.Create(width, height) ) + if (!img.Create(width, height, false)) return wxNullImage; - img.SetMask(false); - key[chars_per_pixel] = wxT('\0'); - hasMask = false; + key[chars_per_pixel] = '\0'; /* * Create colour map: @@ -712,7 +712,7 @@ wxImage wxXPMDecoder::ReadData(const char* const* xpm_data) } for (i_key = 0; i_key < chars_per_pixel; i_key++) - key[i_key] = (wxChar)xmpColLine[i_key]; + key[i_key] = xmpColLine[i_key]; clr_def = ParseColor(xmpColLine + chars_per_pixel); if ( clr_def == NULL ) @@ -731,32 +731,41 @@ wxImage wxXPMDecoder::ReadData(const char* const* xpm_data) return wxNullImage; } + keyString = key; if ( isNone ) - { - hasMask = true; - maskKey = key; - } + maskKey = keyString; - clr_tbl[key] = clr_data; + clr_tbl[keyString] = clr_data; } // deal with the mask: we must replace pseudo-colour "None" with the mask // colour (which can be any colour not otherwise used in the image) - if (hasMask) + if (!maskKey.empty()) { - unsigned char r, g, b; - if ( !img.FindFirstUnusedColour(&r, &g, &b) ) + wxLongToLongHashMap rgb_table; + long rgb; + const size_t n = clr_tbl.size(); + wxXPMColourMap::const_iterator iter = clr_tbl.begin(); + for (i = 0; i < n; ++i, ++iter) + { + const wxXPMColourMapData& data = iter->second; + rgb = (data.R << 16) + (data.G << 8) + data.B; + rgb_table[rgb]; + } + for (rgb = 0; rgb <= 0xffffff && rgb_table.count(rgb); ++rgb) + ; + if (rgb > 0xffffff) { wxLogError(_("XPM: no colors left to use for mask!")); return wxNullImage; } - clr_tbl[maskKey].R = r; - clr_tbl[maskKey].G = g; - clr_tbl[maskKey].B = b; + wxXPMColourMapData& maskData = clr_tbl[maskKey]; + maskData.R = wxByte(rgb >> 16); + maskData.G = wxByte(rgb >> 8); + maskData.B = wxByte(rgb); - img.SetMask(true); - img.SetMaskColour(r, g, b); + img.SetMaskColour(maskData.R, maskData.G, maskData.B); } /* @@ -781,10 +790,11 @@ wxImage wxXPMDecoder::ReadData(const char* const* xpm_data) for (i_key = 0; i_key < chars_per_pixel; i_key++) { - key[i_key] = (wxChar)xpmImgLine[chars_per_pixel * i + i_key]; + key[i_key] = xpmImgLine[chars_per_pixel * i + i_key]; } - entry = clr_tbl.find(key); + keyString = key; + entry = clr_tbl.find(keyString); if ( entry == end ) { wxLogError(_("XPM: Malformed pixel data!")); @@ -795,15 +805,29 @@ wxImage wxXPMDecoder::ReadData(const char* const* xpm_data) // each remaining pixel if we don't bail out return wxNullImage; } - else - { - img_data[0] = entry->second.R; - img_data[1] = entry->second.G; - img_data[2] = entry->second.B; - } + + img_data[0] = entry->second.R; + img_data[1] = entry->second.G; + img_data[2] = entry->second.B; } } +#if wxUSE_PALETTE + unsigned char* r = new unsigned char[colors_cnt]; + unsigned char* g = new unsigned char[colors_cnt]; + unsigned char* b = new unsigned char[colors_cnt]; + for (it = clr_tbl.begin(), i = 0; it != clr_tbl.end(); it++, i++) + { + r[i] = it->second.R; + g[i] = it->second.G; + b[i] = it->second.B; + } + wxASSERT(i == colors_cnt); + img.SetPalette(wxPalette(colors_cnt, r, g, b)); + delete[] r; + delete[] g; + delete[] b; +#endif // wxUSE_PALETTE return img; }