X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/1f8b8785bf01e2bde40e50130a610a20f2909247..e7300ec6d9ebbd1cfa2fcf12c0ce6e5aee85a152:/src/common/containr.cpp?ds=sidebyside

diff --git a/src/common/containr.cpp b/src/common/containr.cpp
index 2cac0008ac..b76ec648d6 100644
--- a/src/common/containr.cpp
+++ b/src/common/containr.cpp
@@ -50,13 +50,24 @@ wxControlContainer::wxControlContainer(wxWindow *winParent)
 
 void wxControlContainer::SetLastFocus(wxWindow *win)
 {
-    // find the last _immediate_ child which got focus
-    while ( win && win != m_winParent )
+    // if we're setting the focus
+    if ( win )
     {
-        win = win->GetParent();
-    }
+        // find the last _immediate_ child which got focus but be prepared to
+        // handle the case when win == m_winParent as well
+        wxWindow *winParent = win;
+        while ( winParent != m_winParent )
+        {
+            win = winParent;
+            winParent = win->GetParent();
 
-    wxASSERT_MSG( win, _T("attempt to set last focus to not a child?") );
+            // Yes, this can happen, though in a totally pathological case.
+            // like when detaching a menubar from a frame with a child which
+            // has pushed itself as an event handler for the menubar.  (wxGtk)
+
+            wxASSERT_MSG( winParent, _T("Setting last-focus for a window that is not our child?") );
+        }
+    }
 
     m_winLastFocused = win;
 }
@@ -241,7 +252,7 @@ void wxControlContainer::HandleOnWindowDestroy(wxWindowBase *child)
 // focus handling
 // ----------------------------------------------------------------------------
 
-void wxControlContainer::DoSetFocus()
+bool wxControlContainer::DoSetFocus()
 {
     wxLogTrace(_T("focus"), _T("SetFocus on wxPanel 0x%08x."),
                m_winParent->GetHandle());
@@ -273,10 +284,24 @@ void wxControlContainer::DoSetFocus()
     //
     // RR: Removed for now. Let's see what happens..
 
-    if ( !SetFocusToChild() )
+    // if our child already has focus, don't take it away from it
+    wxWindow *win = wxWindow::FindFocus();
+    while ( win )
     {
-        m_winParent->SetFocus();
+        if ( win == m_winParent )
+            return TRUE;
+
+        if ( win->IsTopLevel() )
+        {
+            // don't look beyond the first top level parent - useless and
+            // unnecessary
+            break;
+        }
+
+        win = win->GetParent();
     }
+
+    return SetFocusToChild();
 }
 
 void wxControlContainer::HandleOnFocus(wxFocusEvent& event)