X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/1f6c517ca52cdb17cfb3930bc53c8b4e90f6c3fd..9d5507f7a2701395e1d5c121bd877bb9066ee6ea:/src/msw/crashrpt.cpp?ds=inline diff --git a/src/msw/crashrpt.cpp b/src/msw/crashrpt.cpp index 7f017f5a36..d1a372467d 100644 --- a/src/msw/crashrpt.cpp +++ b/src/msw/crashrpt.cpp @@ -130,7 +130,9 @@ void wxCrashReportImpl::Output(const wxChar *format, ...) DWORD cbWritten; wxString s = wxString::FormatV(format, argptr); - ::WriteFile(m_hFile, s, s.length() * sizeof(wxChar), &cbWritten, 0); + + wxCharBuffer buf(s.mb_str(wxConvUTF8)); + ::WriteFile(m_hFile, buf.data(), strlen(buf.data()), &cbWritten, 0); va_end(argptr); } @@ -195,7 +197,14 @@ bool wxCrashReportImpl::Generate(int flags, EXCEPTION_POINTERS *ep) } else // minimal dump { - dumpFlags = MiniDumpNormal; + // the file size is not much bigger than when using MiniDumpNormal + // if we use the flags below, but the minidump is much more useful + // as it contains the values of many (but not all) local variables + dumpFlags = (MINIDUMP_TYPE)(MiniDumpScanMemory +#if _MSC_VER > 1300 + |MiniDumpWithIndirectlyReferencedMemory +#endif + ); } if ( !wxDbgHelpDLL::MiniDumpWriteDump