X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/1b086de1460fd46c21a432ac3d8dec2759e5d05a..2b0246530d08cf7724d94c70d631c166f9717c2c:/src/os2/radiobut.cpp?ds=inline diff --git a/src/os2/radiobut.cpp b/src/os2/radiobut.cpp index f06181dd45..7134de72b4 100644 --- a/src/os2/radiobut.cpp +++ b/src/os2/radiobut.cpp @@ -21,12 +21,18 @@ #include "wx/setup.h" #include "wx/radiobut.h" #include "wx/brush.h" +#include "wx/dcscreen.h" +#include "wx/settings.h" #endif #include "wx/os2/private.h" IMPLEMENT_DYNAMIC_CLASS(wxRadioButton, wxControl) +extern void wxAssociateWinWithHandle( HWND hWnd + ,wxWindowOS2* pWin + ); + void wxRadioButton::Init() { m_bFocusJustSet = FALSE; @@ -47,9 +53,7 @@ bool wxRadioButton::Create( , const wxPoint& rPos , const wxSize& rSize , long lStyle -#if wxUSE_VALIDATORS , const wxValidator& rValidator -#endif , const wxString& rsName ) { @@ -58,15 +62,27 @@ bool wxRadioButton::Create( ,rPos ,rSize ,lStyle -#if wxUSE_VALIDATORS ,rValidator -#endif ,rsName)) return FALSE; - long lSstyle = HasFlag(wxRB_GROUP) ? WS_GROUP : 0; + long lSstyle = WS_TABSTOP; + + if (HasFlag(wxRB_GROUP)) + lSstyle |= WS_GROUP; - lSstyle |= BS_AUTORADIOBUTTON; + // + // wxRB_SINGLE is a temporary workaround for the following problem: if you + // have 2 radiobuttons in the same group but which are not consecutive in + // the dialog, Windows can enter an infinite loop! The simplest way to + // reproduce it is to create radio button, then a panel and then another + // radio button: then checking the last button hangs the app. + // + // Ideally, we'd detect (and avoid) such situation automatically but for + // now, as I don't know how to do it, just allow the user to create + // BS_RADIOBUTTON buttons for such situations. + // + lSstyle |= HasFlag(wxRB_SINGLE) ? BS_RADIOBUTTON : BS_AUTORADIOBUTTON; if (HasFlag(wxCLIP_SIBLINGS)) lSstyle |= WS_CLIPSIBLINGS; @@ -80,6 +96,7 @@ bool wxRadioButton::Create( )) return FALSE; + wxAssociateWinWithHandle(m_hWnd, this); if (HasFlag(wxRB_GROUP)) SetValue(TRUE); @@ -94,17 +111,11 @@ bool wxRadioButton::Create( wxSize wxRadioButton::DoGetBestSize() const { - static int snRadioSize = 0; + // We should probably compute snRadioSize but it seems to be a constant + // independent of its label's font size and not made available by OS/2. + static int snRadioSize = RADIO_SIZE; - if (!snRadioSize) - { - wxScreenDC vDC; - - vDC.SetFont(wxSystemSettings::GetFont(wxSYS_DEFAULT_GUI_FONT)); - snRadioSize = vDC.GetCharHeight(); - } - - wxString sStr = GetLabel(); + wxString sStr = wxGetWindowText(GetHwnd()); int nRadioWidth; int nRadioHeight; @@ -114,7 +125,7 @@ wxSize wxRadioButton::DoGetBestSize() const ,&nRadioWidth ,&nRadioHeight ); - nRadioWidth += snRadioSize + GetCharWidth(); + nRadioWidth += snRadioSize; if (nRadioHeight < snRadioSize) nRadioHeight = snRadioSize; } @@ -136,23 +147,37 @@ bool wxRadioButton::GetValue() const return((::WinSendMsg((HWND) GetHWND(), BM_QUERYCHECK, (MPARAM)0L, (MPARAM)0L) != 0)); } // end of wxRadioButton::GetValue -bool wxRadioButton::OS2Command( - WXUINT wParam -, WXWORD wId -) +bool wxRadioButton::OS2Command( WXUINT wParam, WXWORD WXUNUSED(wId) ) { - if (wParam == BN_CLICKED) + if (wParam != BN_CLICKED) + return false; + + if (m_bFocusJustSet) { - wxCommandEvent rEvent( wxEVT_COMMAND_RADIOBUTTON_SELECTED - ,m_windowId - ); + // + // See above: we want to ignore this event + // + m_bFocusJustSet = false; + } + else + { + bool bIsChecked = GetValue(); + if (HasFlag(wxRB_SINGLE)) + { + // + // When we use a "manual" radio button, we have to check the button + // ourselves -- but it's reset to unchecked state by the user code + // (presumably when another button is pressed) + // + if (!bIsChecked ) + SetValue(TRUE); + } + wxCommandEvent rEvent( wxEVT_COMMAND_RADIOBUTTON_SELECTED, m_windowId ); rEvent.SetEventObject(this); ProcessCommand(rEvent); - return TRUE; } - else - return FALSE; + return true; } // end of wxRadioButton::OS2Command void wxRadioButton::SetFocus() @@ -164,9 +189,9 @@ void wxRadioButton::SetFocus() // generates BN_CLICKED which leads to showing another dialog and so on // without end! // - // to aviod this, we drop the pseudo BN_CLICKED events generated when the + // to avoid this, we drop the pseudo BN_CLICKED events generated when the // button gains focus - m_bFocusJustSet = TRUE; + m_bFocusJustSet = true; wxControl::SetFocus(); } @@ -175,7 +200,8 @@ void wxRadioButton::SetLabel( const wxString& rsLabel ) { - ::WinSetWindowText((HWND)GetHWND(), (const char *)rsLabel.c_str()); + wxString sLabel = ::wxPMTextToLabel(rsLabel); + ::WinSetWindowText((HWND)GetHWND(), (const char *)sLabel.c_str()); } // end of wxRadioButton::SetLabel void wxRadioButton::SetValue( @@ -183,5 +209,91 @@ void wxRadioButton::SetValue( ) { ::WinSendMsg((HWND)GetHWND(), BM_SETCHECK, (MPARAM)bValue, (MPARAM)0); + if (bValue) + { + const wxWindowList& rSiblings = GetParent()->GetChildren(); + wxWindowList::compatibility_iterator nodeThis = rSiblings.Find(this); + + wxCHECK_RET(nodeThis, _T("radio button not a child of its parent?")); + + // + // If it's not the first item of the group ... + // + if ( !HasFlag(wxRB_GROUP) ) + { + // + // ...turn off all radio buttons before this one + // + for ( wxWindowList::compatibility_iterator nodeBefore = nodeThis->GetPrevious(); + nodeBefore; + nodeBefore = nodeBefore->GetPrevious() ) + { + wxRadioButton* pBtn = wxDynamicCast( nodeBefore->GetData() + ,wxRadioButton + ); + if (!pBtn) + { + // + // The radio buttons in a group must be consecutive, so there + // are no more of them + // + break; + } + pBtn->SetValue(FALSE); + if (pBtn->HasFlag(wxRB_GROUP)) + { + // + // Even if there are other radio buttons before this one, + // they're not in the same group with us + // + break; + } + } + } + + // + // ... and all after this one + // + for (wxWindowList::compatibility_iterator nodeAfter = nodeThis->GetNext(); + nodeAfter; + nodeAfter = nodeAfter->GetNext()) + { + wxRadioButton* pBtn = wxDynamicCast( nodeAfter->GetData() + ,wxRadioButton + ); + + if (!pBtn || pBtn->HasFlag(wxRB_GROUP) ) + { + // + // No more buttons or the first button of the next group + // + break; + } + pBtn->SetValue(FALSE); + } + } } // end of wxRadioButton::SetValue +MRESULT wxRadioButton::OS2WindowProc( + WXUINT uMsg +, WXWPARAM wParam +, WXLPARAM lParam +) +{ + if (uMsg == WM_SETFOCUS) + { + m_bFocusJustSet = TRUE; + + MRESULT mRc = wxControl::OS2WindowProc( uMsg + ,wParam + ,lParam + ); + + m_bFocusJustSet = FALSE; + return mRc; + } + return wxControl::OS2WindowProc( uMsg + ,wParam + ,lParam + ); +} // end of wxRadioButton::OS2WindowProc