X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/1934a64e10df502a7930e97767e213e235fe551b..3e1924dd5f5744c3e2a8973de9b3e4f372b7fd85:/src/mac/carbon/listctrl_mac.cpp?ds=inline diff --git a/src/mac/carbon/listctrl_mac.cpp b/src/mac/carbon/listctrl_mac.cpp index a43925527a..e307203d98 100644 --- a/src/mac/carbon/listctrl_mac.cpp +++ b/src/mac/carbon/listctrl_mac.cpp @@ -30,6 +30,7 @@ #ifndef WX_PRECOMP #include "wx/intl.h" + #include "wx/settings.h" #endif #include "wx/mac/uma.h" @@ -38,7 +39,7 @@ #include "wx/sysopt.h" #include "wx/timer.h" -#define wxMAC_ALWAYS_USE_GENERIC_LISTCTRL wxT("mac.listctrl.always_use_generic") +#include "wx/hashmap.h" #if wxUSE_EXTENDED_RTTI WX_DEFINE_FLAGS( wxListCtrlStyle ) @@ -102,7 +103,7 @@ wxEND_HANDLERS_TABLE() wxCONSTRUCTOR_5( wxListCtrl , wxWindow* , Parent , wxWindowID , Id , wxPoint , Position , wxSize , Size , long , WindowStyle ) /* - TODO : Expose more information of a list's layout etc. via appropriate objects (à la NotebookPageInfo) + TODO : Expose more information of a list's layout etc. via appropriate objects (ï¿  la NotebookPageInfo) */ #else IMPLEMENT_DYNAMIC_CLASS(wxListCtrl, wxControl) @@ -113,9 +114,9 @@ IMPLEMENT_DYNAMIC_CLASS(wxListItem, wxObject) IMPLEMENT_DYNAMIC_CLASS(wxListEvent, wxNotifyEvent) -WX_DECLARE_EXPORTED_LIST(wxListItem, wxListItemList); +WX_DECLARE_HASH_MAP( int, wxListItem*, wxIntegerHash, wxIntegerEqual, wxListItemList ); + #include "wx/listimpl.cpp" -WX_DEFINE_LIST(wxListItemList) WX_DEFINE_LIST(wxColumnList) // so we can check for column clicks @@ -149,7 +150,10 @@ static pascal OSStatus wxMacListCtrlEventHandler( EventHandlerCallRef handler , GetDataBrowserSortProperty(controlRef, &col); int column = col - kMinColumnId; le.m_col = column; - window->GetEventHandler()->ProcessEvent( le ); + // FIXME: we can't use the sort property for virtual listctrls + // so we need to find a better way to determine which column was clicked... + if (!window->IsVirtual()) + window->HandleWindowEvent( le ); } result = CallNextEventHandler(handler, event); break; @@ -186,7 +190,7 @@ public: virtual bool HasColumnInfo( unsigned int column ); virtual void SetColumnTextValue( unsigned int column, const wxString& text ); - virtual const wxString& GetColumnTextValue( unsigned int column ); + virtual wxString GetColumnTextValue( unsigned int column ); virtual int GetColumnImageValue( unsigned int column ); virtual void SetColumnImageValue( unsigned int column, int imageIndex ); @@ -205,6 +209,7 @@ class wxMacDataBrowserListCtrlControl : public wxMacDataItemBrowserControl { public: wxMacDataBrowserListCtrlControl( wxWindow *peer, const wxPoint& pos, const wxSize& size, long style ); + wxMacDataBrowserListCtrlControl() {} virtual ~wxMacDataBrowserListCtrlControl(); // create a list item (can be a subclass of wxMacListBoxItem) @@ -215,6 +220,7 @@ public: virtual void MacSetColumnInfo( unsigned int row, unsigned int column, wxListItem* item ); virtual void MacGetColumnInfo( unsigned int row, unsigned int column, wxListItem& item ); virtual void UpdateState(wxMacDataItem* dataItem, wxListItem* item); + int GetFlags() { return m_flags; } protected: // we need to override to provide specialized handling for virtual wxListCtrls @@ -254,11 +260,11 @@ protected: Rect *maxEditTextRect, Boolean *shrinkToFit); - static pascal Boolean DataBrowserHitTestProc(ControlRef browser, - DataBrowserItemID itemID, - DataBrowserPropertyID property, - const Rect *theRect, - const Rect *mouseRect) { return true; } + static pascal Boolean DataBrowserHitTestProc(ControlRef WXUNUSED(browser), + DataBrowserItemID WXUNUSED(itemID), + DataBrowserPropertyID WXUNUSED(property), + const Rect *WXUNUSED(theRect), + const Rect *WXUNUSED(mouseRect)) { return true; } virtual bool ConfirmEditText(DataBrowserItemID item, DataBrowserPropertyID property, @@ -270,7 +276,8 @@ protected: wxClientDataType m_clientDataItemsType; bool m_isVirtual; - + int m_flags; + DECLARE_DYNAMIC_CLASS_NO_COPY(wxMacDataBrowserListCtrlControl) }; class wxMacListCtrlEventDelegate : public wxEvtHandler @@ -299,7 +306,7 @@ bool wxMacListCtrlEventDelegate::ProcessEvent( wxEvent& event ) if ( !event.IsKindOf( CLASSINFO( wxCommandEvent ) ) ) { - if (m_list->GetEventHandler()->ProcessEvent( event )) + if (m_list->HandleWindowEvent( event )) return true; } return wxEvtHandler::ProcessEvent(event); @@ -390,11 +397,12 @@ wxListCtrlTextCtrlWrapper::wxListCtrlTextCtrlWrapper(wxListCtrl *owner, m_aboutToFinish = false; wxRect rectLabel; + int offset = 8; owner->GetItemRect(itemEdit, rectLabel); m_text->Create(owner, wxID_ANY, m_startValue, - wxPoint(rectLabel.x+8,rectLabel.y), - wxSize(rectLabel.width,rectLabel.height)); + wxPoint(rectLabel.x+offset,rectLabel.y), + wxSize(rectLabel.width-offset,rectLabel.height)); m_text->SetFocus(); m_text->PushEventHandler(this); @@ -500,6 +508,9 @@ void wxListCtrlTextCtrlWrapper::OnKillFocus( wxFocusEvent &event ) BEGIN_EVENT_TABLE(wxListCtrl, wxControl) EVT_LEFT_DOWN(wxListCtrl::OnLeftDown) EVT_LEFT_DCLICK(wxListCtrl::OnDblClick) + EVT_MIDDLE_DOWN(wxListCtrl::OnMiddleDown) + EVT_RIGHT_DOWN(wxListCtrl::OnRightDown) + EVT_CHAR(wxListCtrl::OnChar) END_EVENT_TABLE() // ============================================================================ @@ -508,7 +519,8 @@ END_EVENT_TABLE() wxMacListControl* wxListCtrl::GetPeer() const { - return dynamic_cast(m_peer); + wxMacDataBrowserListCtrlControl *lb = wxDynamicCast(m_peer,wxMacDataBrowserListCtrlControl); + return lb ? wx_static_cast(wxMacListControl*,lb) : 0 ; } // ---------------------------------------------------------------------------- @@ -608,6 +620,91 @@ void wxListCtrl::OnDblClick(wxMouseEvent& event) event.Skip(); } +#if wxABI_VERSION >= 20801 +void wxListCtrl::OnRightDown(wxMouseEvent& event) +{ + if (m_dbImpl) + FireMouseEvent(wxEVT_COMMAND_LIST_ITEM_RIGHT_CLICK, event.GetPosition()); + event.Skip(); +} + +void wxListCtrl::OnMiddleDown(wxMouseEvent& event) +{ + if (m_dbImpl) + FireMouseEvent(wxEVT_COMMAND_LIST_ITEM_MIDDLE_CLICK, event.GetPosition()); + event.Skip(); +} + +void wxListCtrl::FireMouseEvent(wxEventType eventType, wxPoint position) +{ + wxListEvent le( eventType, GetId() ); + le.SetEventObject(this); + le.m_pointDrag = position; + le.m_itemIndex = -1; + + int flags; + long item = HitTest(position, flags); + if (flags & wxLIST_HITTEST_ONITEM) + { + le.m_itemIndex = item; + le.m_item.m_itemId = item; + GetItem(le.m_item); + HandleWindowEvent(le); + } +} + +void wxListCtrl::OnChar(wxKeyEvent& event) +{ + + + if (m_dbImpl) + { + wxListEvent le( wxEVT_COMMAND_LIST_KEY_DOWN, GetId() ); + le.SetEventObject(this); + le.m_code = event.GetKeyCode(); + le.m_itemIndex = -1; + + if (m_current == -1) + { + // if m_current isn't set, check if there's been a selection + // made before continuing + m_current = GetNextItem(-1, wxLIST_NEXT_BELOW, wxLIST_STATE_SELECTED); + } + + // We need to determine m_current ourselves when navigation keys + // are used. Note that PAGEUP and PAGEDOWN do not alter the current + // item on native Mac ListCtrl, so we only handle up and down keys. + switch ( event.GetKeyCode() ) + { + case WXK_UP: + if ( m_current > 0 ) + m_current -= 1; + else + m_current = 0; + + break; + + case WXK_DOWN: + if ( m_current < GetItemCount() - 1 ) + m_current += 1; + else + m_current = GetItemCount() - 1; + + break; + } + + if (m_current != -1) + { + le.m_itemIndex = m_current; + le.m_item.m_itemId = m_current; + GetItem(le.m_item); + HandleWindowEvent(le); + } + } + event.Skip(); +} +#endif + bool wxListCtrl::Create(wxWindow *parent, wxWindowID id, const wxPoint& pos, @@ -620,16 +717,21 @@ bool wxListCtrl::Create(wxWindow *parent, // for now, we'll always use the generic list control for ICON and LIST views, // because they dynamically change the number of columns on resize. // Also, allow the user to set it to use the list ctrl as well. - // Also, use generic list control in VIRTUAL mode. if ( (wxSystemOptions::HasOption( wxMAC_ALWAYS_USE_GENERIC_LISTCTRL ) && (wxSystemOptions::GetOptionInt( wxMAC_ALWAYS_USE_GENERIC_LISTCTRL ) == 1)) || (style & wxLC_ICON) || (style & wxLC_SMALL_ICON) || (style & wxLC_LIST) ) { m_macIsUserPane = true; - if ( !wxWindow::Create(parent, id, pos, size, style | wxNO_BORDER, name) ) + long paneStyle = style; + paneStyle &= ~wxSIMPLE_BORDER; + paneStyle &= ~wxDOUBLE_BORDER; + paneStyle &= ~wxSUNKEN_BORDER; + paneStyle &= ~wxRAISED_BORDER; + paneStyle &= ~wxSTATIC_BORDER; + if ( !wxWindow::Create(parent, id, pos, size, paneStyle | wxNO_BORDER, name) ) return false; - + // since the generic control is a child, make sure we position it at 0, 0 m_genericImpl = new wxGenericListCtrlHook(this, id, wxPoint(0, 0), size, style, validator, name); m_genericImpl->PushEventHandler( new wxMacListCtrlEventDelegate( this, GetId() ) ); @@ -639,8 +741,7 @@ bool wxListCtrl::Create(wxWindow *parent, else { m_macIsUserPane = false; - - if ( !wxWindow::Create(parent, id, pos, size, style, name) ) + if ( !wxWindow::Create(parent, id, pos, size, style & ~(wxHSCROLL | wxVSCROLL), name) ) return false; m_dbImpl = new wxMacDataBrowserListCtrlControl( this, pos, size, style ); m_peer = m_dbImpl; @@ -672,6 +773,18 @@ wxListCtrl::~wxListCtrl() delete m_renameTimer; } +/*static*/ +wxVisualAttributes wxListCtrl::GetClassDefaultAttributes(wxWindowVariant variant) +{ + wxVisualAttributes attr; + + attr.colFg = wxSystemSettings::GetColour( wxSYS_COLOUR_WINDOWTEXT ); + attr.colBg = wxSystemSettings::GetColour( wxSYS_COLOUR_LISTBOX ); + attr.font.MacCreateFromThemeFont(kThemeViewsFont); + + return attr; +} + // ---------------------------------------------------------------------------- // set/get/change style // ---------------------------------------------------------------------------- @@ -722,6 +835,26 @@ void wxListCtrl::DoSetSize( int x, int y, int width, int height, int sizeFlags ) if (m_genericImpl) m_genericImpl->SetSize(0, 0, width, height, sizeFlags); + + // determine if we need a horizontal scrollbar, and add it if so + if (m_dbImpl) + { + int totalWidth = 0; + for (int column = 0; column < GetColumnCount(); column++) + { + totalWidth += m_dbImpl->GetColumnWidth( column ); + } + + if ( !(m_dbImpl->GetFlags() & wxHSCROLL) ) + { + Boolean vertScrollBar; + GetDataBrowserHasScrollBars( m_dbImpl->GetControlRef(), NULL, &vertScrollBar ); + if (totalWidth > width) + SetDataBrowserHasScrollBars( m_dbImpl->GetControlRef(), true, vertScrollBar ); + else + SetDataBrowserHasScrollBars( m_dbImpl->GetControlRef(), false, vertScrollBar ); + } + } } wxSize wxListCtrl::DoGetBestSize() const @@ -782,7 +915,6 @@ bool wxListCtrl::GetColumn(int col, wxListItem& item) const if (m_dbImpl) { - wxColumnList::compatibility_iterator node = m_colsInfo.Item( col ); wxASSERT_MSG( node, _T("invalid column index in wxMacListCtrlItem") ); wxListItem* column = node->GetData(); @@ -813,6 +945,7 @@ bool wxListCtrl::SetColumn(int col, wxListItem& item) if (m_dbImpl) { + long mask = item.GetMask(); if ( col >= (int)m_colsInfo.GetCount() ) { wxListItem* listItem = new wxListItem(item); @@ -822,7 +955,7 @@ bool wxListCtrl::SetColumn(int col, wxListItem& item) { wxListItem listItem; GetColumn( col, listItem ); - long mask = item.GetMask(); + if (mask & wxLIST_MASK_TEXT) listItem.SetText(item.GetText()); if (mask & wxLIST_MASK_DATA) @@ -847,10 +980,10 @@ bool wxListCtrl::SetColumn(int col, wxListItem& item) { wxFontEncoding enc; if ( m_font.Ok() ) - enc = m_font.GetEncoding(); + enc = GetFont().GetEncoding(); else enc = wxLocale::GetSystemEncoding(); - wxMacCFStringHolder cfTitle; + wxCFStringRef cfTitle; cfTitle.Assign( item.GetText() , enc ); if(columnDesc.titleString) CFRelease(columnDesc.titleString); @@ -860,13 +993,13 @@ bool wxListCtrl::SetColumn(int col, wxListItem& item) if (item.GetMask() & wxLIST_MASK_IMAGE && item.GetImage() != -1 ) { - columnDesc.btnContentInfo.contentType = kControlContentIconRef; wxImageList* imageList = GetImageList(wxIMAGE_LIST_SMALL); if (imageList && imageList->GetImageCount() > 0 ) { wxBitmap bmp = imageList->GetBitmap( item.GetImage() ); - IconRef icon = bmp.GetBitmapData()->GetIconRef(); + IconRef icon = bmp.GetIconRef(); columnDesc.btnContentInfo.u.iconRef = icon; + columnDesc.btnContentInfo.contentType = kControlContentIconRef; } } @@ -921,10 +1054,22 @@ bool wxListCtrl::SetColumnWidth(int col, int width) { for (int column = 0; column < GetColumnCount(); column++) { + wxListItem colInfo; + GetColumn(col, colInfo); + + colInfo.SetWidth(width); + SetColumn(col, colInfo); + m_dbImpl->SetColumnWidth(col, mywidth); } } - else{ + else + { + wxListItem colInfo; + GetColumn(col, colInfo); + + colInfo.SetWidth(width); + SetColumn(col, colInfo); m_dbImpl->SetColumnWidth(col, mywidth); } return true; @@ -944,6 +1089,10 @@ int wxListCtrl::GetCountPerPage() const if (m_dbImpl) { + UInt16 height = 1; + m_dbImpl->GetDefaultRowHeight( &height ); + if (height > 0) + return GetClientSize().y / height; } return 1; @@ -967,17 +1116,37 @@ bool wxListCtrl::GetItem(wxListItem& info) const if (m_dbImpl) { if (!IsVirtual()) - m_dbImpl->MacGetColumnInfo(info.m_itemId, info.m_col, info); + { + if (info.m_itemId >= 0 && info.m_itemId < GetItemCount()) + { + m_dbImpl->MacGetColumnInfo(info.m_itemId, info.m_col, info); + if (info.GetMask() & wxLIST_MASK_STATE) + { + DataBrowserItemID id = (DataBrowserItemID)m_dbImpl->GetItemFromLine(info.m_itemId); + if (IsDataBrowserItemSelected( m_dbImpl->GetControlRef(), id )) + info.SetState(info.GetState() | wxLIST_STATE_SELECTED); + } + } + } else { - info.SetText( OnGetItemText(info.m_itemId, info.m_col) ); - info.SetImage( OnGetItemColumnImage(info.m_itemId, info.m_col) ); - wxListItemAttr* attrs = OnGetItemAttr( info.m_itemId ); - if (attrs) + if (info.m_itemId >= 0 && info.m_itemId < GetItemCount()) { - info.SetFont( attrs->GetFont() ); - info.SetBackgroundColour( attrs->GetBackgroundColour() ); - info.SetTextColour( attrs->GetTextColour() ); + info.SetText( OnGetItemText(info.m_itemId, info.m_col) ); + info.SetImage( OnGetItemColumnImage(info.m_itemId, info.m_col) ); + if (info.GetMask() & wxLIST_MASK_STATE) + { + if (IsDataBrowserItemSelected( m_dbImpl->GetControlRef(), info.m_itemId+1 )) + info.SetState(info.GetState() | wxLIST_STATE_SELECTED); + } + + wxListItemAttr* attrs = OnGetItemAttr( info.m_itemId ); + if (attrs) + { + info.SetFont( attrs->GetFont() ); + info.SetBackgroundColour( attrs->GetBackgroundColour() ); + info.SetTextColour( attrs->GetTextColour() ); + } } } } @@ -1022,16 +1191,34 @@ int wxListCtrl::GetItemState(long item, long stateMask) const if (m_genericImpl) return m_genericImpl->GetItemState(item, stateMask); - wxListItem info; + if (m_dbImpl) + { + if ( HasFlag(wxLC_VIRTUAL) ) + { + if (stateMask == wxLIST_STATE_SELECTED) + { + if (IsDataBrowserItemSelected( m_dbImpl->GetControlRef(), item+1 )) + return wxLIST_STATE_SELECTED; + else + return 0; + } + } + else + { + wxListItem info; - info.m_mask = wxLIST_MASK_STATE; - info.m_stateMask = stateMask; - info.m_itemId = item; + info.m_mask = wxLIST_MASK_STATE; + info.m_stateMask = stateMask; + info.m_itemId = item; - if (!GetItem(info)) - return 0; + if (!GetItem(info)) + return 0; - return info.m_state; + return info.m_state; + } + } + + return 0; } // Sets the item state @@ -1040,12 +1227,58 @@ bool wxListCtrl::SetItemState(long item, long state, long stateMask) if (m_genericImpl) return m_genericImpl->SetItemState(item, state, stateMask); - wxListItem info; - info.m_mask = wxLIST_MASK_STATE; - info.m_stateMask = stateMask; - info.m_state = state; - info.m_itemId = item; - return SetItem(info); + if (m_dbImpl) + { + DataBrowserSetOption option = kDataBrowserItemsAdd; + if ( (stateMask & wxLIST_STATE_SELECTED) && state == 0 ) + option = kDataBrowserItemsRemove; + + if (item == -1) + { + if ( HasFlag(wxLC_VIRTUAL) ) + { + wxMacDataItemBrowserSelectionSuppressor suppressor(m_dbImpl); + m_dbImpl->SetSelectedAllItems(option); + } + else + { + for(int i = 0; i < GetItemCount();i++) + { + wxListItem info; + info.m_itemId = i; + info.m_mask = wxLIST_MASK_STATE; + info.m_stateMask = stateMask; + info.m_state = state; + SetItem(info); + } + } + } + else + { + if ( HasFlag(wxLC_VIRTUAL) ) + { + long itemID = item+1; + bool isSelected = IsDataBrowserItemSelected(m_dbImpl->GetControlRef(), (DataBrowserItemID)itemID ); + bool isSelectedState = (state == wxLIST_STATE_SELECTED); + + // toggle the selection state if wxListInfo state and actual state don't match. + if ( (stateMask & wxLIST_STATE_SELECTED) && isSelected != isSelectedState ) + { + SetDataBrowserSelectedItems(m_dbImpl->GetControlRef(), 1, (DataBrowserItemID*)&itemID, option); + } + } + else + { + wxListItem info; + info.m_itemId = item; + info.m_mask = wxLIST_MASK_STATE; + info.m_stateMask = stateMask; + info.m_state = state; + return SetItem(info); + } + } + } + return true; } // Sets the item image @@ -1118,7 +1351,7 @@ long wxListCtrl::GetItemData(long item) const } // Sets the item data -bool wxListCtrl::SetItemData(long item, long data) +bool wxListCtrl::SetItemPtrData(long item, wxUIntPtr data) { if (m_genericImpl) return m_genericImpl->SetItemData(item, data); @@ -1168,7 +1401,7 @@ bool wxListCtrl::GetItemRect(long item, wxRect& rect, int code) const id = (DataBrowserItemID) thisItem; } else - id = item; + id = item+1; GetDataBrowserItemPartBounds( m_dbImpl->GetControlRef(), id, col, part, &bounds ); @@ -1365,6 +1598,14 @@ long wxListCtrl::GetTopItem() const if (m_genericImpl) return m_genericImpl->GetTopItem(); + if (m_dbImpl) + { + int flags = 0; + long item = HitTest( wxPoint(1, 1), flags); + if (flags == wxLIST_HITTEST_ONITEM) + return item; + } + return 0; } @@ -1381,19 +1622,48 @@ long wxListCtrl::GetNextItem(long item, int geom, int state) const if (m_genericImpl) return m_genericImpl->GetNextItem(item, geom, state); - if (m_dbImpl && geom == wxLIST_NEXT_ALL && state == wxLIST_STATE_SELECTED ) + // TODO: implement all geometry and state options? + if ( m_dbImpl ) { - long count = m_dbImpl->MacGetCount() ; - for ( long line = item + 1 ; line < count; line++ ) + if ( geom == wxLIST_NEXT_ALL || geom == wxLIST_NEXT_BELOW ) + { + long count = m_dbImpl->MacGetCount() ; + for ( long line = item + 1 ; line < count; line++ ) + { + DataBrowserItemID id = line + 1; + if ( !IsVirtual() ) + id = (DataBrowserItemID)m_dbImpl->GetItemFromLine(line); + + if ( (state == wxLIST_STATE_DONTCARE ) ) + return line; + + if ( (state & wxLIST_STATE_SELECTED) && IsDataBrowserItemSelected(m_dbImpl->GetControlRef(), id ) ) + return line; + } + } + + if ( geom == wxLIST_NEXT_ABOVE ) { - wxMacDataItem* id = m_dbImpl->GetItemFromLine(line); - if ( m_dbImpl->IsItemSelected(id ) ) - return line; + int item2 = item; + if ( item2 == -1 ) + item2 = m_dbImpl->MacGetCount(); + + for ( long line = item2 - 1 ; line >= 0; line-- ) + { + DataBrowserItemID id = line + 1; + if ( !IsVirtual() ) + id = (DataBrowserItemID)m_dbImpl->GetItemFromLine(line); + + if ( (state == wxLIST_STATE_DONTCARE ) ) + return line; + + if ( (state & wxLIST_STATE_SELECTED) && IsDataBrowserItemSelected(m_dbImpl->GetControlRef(), id ) ) + return line; + } } - return -1; } - return 0; + return -1; } @@ -1486,7 +1756,7 @@ bool wxListCtrl::DeleteItem(long item) wxListEvent event( wxEVT_COMMAND_LIST_DELETE_ITEM, GetId() ); event.SetEventObject( this ); event.m_itemIndex = item; - GetEventHandler()->ProcessEvent( event ); + HandleWindowEvent( event ); } return true; @@ -1503,7 +1773,7 @@ bool wxListCtrl::DeleteAllItems() m_dbImpl->MacClear(); wxListEvent event( wxEVT_COMMAND_LIST_DELETE_ALL_ITEMS, GetId() ); event.SetEventObject( this ); - GetEventHandler()->ProcessEvent( event ); + HandleWindowEvent( event ); } return true; } @@ -1520,7 +1790,7 @@ bool wxListCtrl::DeleteAllColumns() m_dbImpl->GetColumnCount(&cols); for (UInt32 col = 0; col < cols; col++) { - DeleteColumn(col); + DeleteColumn(0); } } @@ -1577,7 +1847,7 @@ wxTextCtrl* wxListCtrl::EditLabel(long item, wxClassInfo* textControlClass) le.m_col = 0; GetItem( le.m_item ); - if ( GetParent()->GetEventHandler()->ProcessEvent( le ) && !le.IsAllowed() ) + if ( GetParent()->HandleWindowEvent( le ) && !le.IsAllowed() ) { // vetoed by user code return NULL; @@ -1591,7 +1861,7 @@ wxTextCtrl* wxListCtrl::EditLabel(long item, wxClassInfo* textControlClass) } // End label editing, optionally cancelling the edit -bool wxListCtrl::EndEditLabel(bool cancel) +bool wxListCtrl::EndEditLabel(bool WXUNUSED(cancel)) { // TODO: generic impl. doesn't have this method - is it needed for us? if (m_genericImpl) @@ -1624,7 +1894,31 @@ long wxListCtrl::FindItem(long start, const wxString& str, bool partial) if (m_genericImpl) return m_genericImpl->FindItem(start, str, partial); - return -1; + wxString str_upper = str.Upper(); + + long idx = start; + if (idx < 0) + idx = 0; + long count = GetItemCount(); + + while (idx < count) + { + wxString line_upper = GetItemText(idx).Upper(); + if (!partial) + { + if (line_upper == str_upper ) + return idx; + } + else + { + if (line_upper.find(str_upper) == 0) + return idx; + } + + idx++; + }; + + return wxNOT_FOUND; } // Find an item whose data matches this data, starting from the item after 'start' @@ -1634,7 +1928,9 @@ long wxListCtrl::FindItem(long start, long data) if (m_genericImpl) return m_genericImpl->FindItem(start, data); - long idx = start + 1; + long idx = start; + if (idx < 0) + idx = 0; long count = GetItemCount(); while (idx < count) @@ -1644,7 +1940,7 @@ long wxListCtrl::FindItem(long start, long data) idx++; }; - return -1; + return wxNOT_FOUND; } // Find an item nearest this position in the specified direction, starting from @@ -1680,6 +1976,9 @@ wxListCtrl::HitTest(const wxPoint& point, int& flags, long *ptrSubItem) const if ( !(GetWindowStyleFlag() & wxLC_NO_HEADER) ) y -= colHeaderHeight; + if ( y < 0 ) + return -1; + int row = y / rowHeight; DataBrowserItemID id; m_dbImpl->GetItemID( (DataBrowserTableViewRowIndex) row, &id ); @@ -1708,6 +2007,23 @@ wxListCtrl::HitTest(const wxPoint& point, int& flags, long *ptrSubItem) const return -1; } +int wxListCtrl::GetScrollPos(int orient) const +{ + if (m_genericImpl) + return m_genericImpl->GetScrollPos(orient); + + if (m_dbImpl) + { + UInt32 offsetX, offsetY; + m_dbImpl->GetScrollPosition( &offsetY, &offsetX ); + if ( orient == wxHORIZONTAL ) + return offsetX; + else + return offsetY; + } + + return 0; +} // Inserts an item, returning the index of the new item if successful, // -1 otherwise. @@ -1718,7 +2034,7 @@ long wxListCtrl::InsertItem(wxListItem& info) if (m_genericImpl) return m_genericImpl->InsertItem(info); - if (m_dbImpl) + if (m_dbImpl && !IsVirtual()) { int count = GetItemCount(); @@ -1726,13 +2042,14 @@ long wxListCtrl::InsertItem(wxListItem& info) info.m_itemId = count; m_dbImpl->MacInsertItem(info.m_itemId, &info ); + wxListEvent event( wxEVT_COMMAND_LIST_INSERT_ITEM, GetId() ); event.SetEventObject( this ); event.m_itemIndex = info.m_itemId; - GetEventHandler()->ProcessEvent( event ); + HandleWindowEvent( event ); + return info.m_itemId; } - - return info.m_itemId; + return -1; } long wxListCtrl::InsertItem(long index, const wxString& label) @@ -1870,6 +2187,12 @@ bool wxListCtrl::SortItems(wxListCtrlCompare fn, long data) { m_compareFunc = fn; m_compareFuncData = data; + SortDataBrowserContainer( m_dbImpl->GetControlRef(), kDataBrowserNoItem, true); + + // we need to do this after each call, else we get a crash from wxPython when + // SortItems is called the second time. + m_compareFunc = NULL; + m_compareFuncData = 0; } return true; @@ -1890,7 +2213,7 @@ bool wxListCtrl::OnRenameAccept(long itemEdit, const wxString& value) GetItem( le.m_item ); le.m_item.m_text = value; - return !GetEventHandler()->ProcessEvent( le ) || + return !HandleWindowEvent( le ) || le.IsAllowed(); } @@ -1905,7 +2228,7 @@ void wxListCtrl::OnRenameCancelled(long itemEdit) le.m_itemIndex = itemEdit; GetItem( le.m_item ); - GetEventHandler()->ProcessEvent( le ); + HandleWindowEvent( le ); } // ---------------------------------------------------------------------------- @@ -1961,6 +2284,10 @@ void wxListCtrl::SetItemCount(long count) // we need to temporarily disable the new item creation notification // procedure to speed things up // FIXME: Even this doesn't seem to help much... + + // FIXME: Find a more efficient way to do this. + m_dbImpl->MacClear(); + DataBrowserCallbacks callbacks; DataBrowserItemNotificationUPP itemUPP; GetDataBrowserCallbacks(m_dbImpl->GetControlRef(), &callbacks); @@ -1983,9 +2310,26 @@ void wxListCtrl::RefreshItem(long item) return; } - wxRect rect; - GetItemRect(item, rect); - RefreshRect(rect); + if (m_dbImpl) + { + DataBrowserItemID id; + + if ( !IsVirtual() ) + { + wxMacDataItem* thisItem = m_dbImpl->GetItemFromLine(item); + id = (DataBrowserItemID) thisItem; + } + else + id = item+1; + + m_dbImpl->wxMacDataBrowserControl::UpdateItems + ( + kDataBrowserNoItem, + 1, &id, + kDataBrowserItemNoProperty, // preSortProperty + kDataBrowserNoItem // update all columns + ); + } } void wxListCtrl::RefreshItems(long itemFrom, long itemTo) @@ -1996,16 +2340,72 @@ void wxListCtrl::RefreshItems(long itemFrom, long itemTo) return; } - wxRect rect1, rect2; - GetItemRect(itemFrom, rect1); - GetItemRect(itemTo, rect2); + if (m_dbImpl) + { + const long count = itemTo - itemFrom + 1; + DataBrowserItemID *ids = new DataBrowserItemID[count]; - wxRect rect = rect1; - rect.height = rect2.GetBottom() - rect1.GetTop(); + if ( !IsVirtual() ) + { + for ( long i = 0; i < count; i++ ) + { + wxMacDataItem* thisItem = m_dbImpl->GetItemFromLine(itemFrom+i); + ids[i] = (DataBrowserItemID) thisItem; + } + } + else + { + for ( long i = 0; i < count; i++ ) + ids[i] = itemFrom+i+1; + } - RefreshRect(rect); + m_dbImpl->wxMacDataBrowserControl::UpdateItems + ( + kDataBrowserNoItem, + count, ids, + kDataBrowserItemNoProperty, // preSortProperty + kDataBrowserNoItem // update all columns + ); + + delete[] ids; + } +} + +void wxListCtrl::SetDropTarget( wxDropTarget *dropTarget ) +{ +#if wxUSE_DRAG_AND_DROP + if (m_genericImpl) + m_genericImpl->SetDropTarget( dropTarget ); + + if (m_dbImpl) + wxWindow::SetDropTarget( dropTarget ); +#endif } +wxDropTarget *wxListCtrl::GetDropTarget() const +{ +#if wxUSE_DRAG_AND_DROP + if (m_genericImpl) + return m_genericImpl->GetDropTarget(); + + if (m_dbImpl) + return wxWindow::GetDropTarget(); +#endif + return NULL; +} + +#if wxABI_VERSION >= 20801 +void wxListCtrl::SetFocus() +{ + if (m_genericImpl) + { + m_genericImpl->SetFocus(); + return; + } + + wxWindow::SetFocus(); +} +#endif // wxMac internal data structures @@ -2015,10 +2415,10 @@ wxMacListCtrlItem::~wxMacListCtrlItem() void wxMacListCtrlItem::Notification(wxMacDataItemBrowserControl *owner , DataBrowserItemNotification message, - DataBrowserItemDataRef itemData ) const + DataBrowserItemDataRef WXUNUSED(itemData) ) const { - wxMacDataBrowserListCtrlControl *lb = dynamic_cast(owner); + wxMacDataBrowserListCtrlControl *lb = wxDynamicCast(owner, wxMacDataBrowserListCtrlControl); // we want to depend on as little as possible to make sure tear-down of controls is safe if ( message == kDataBrowserItemRemoved) @@ -2039,7 +2439,7 @@ void wxMacListCtrlItem::Notification(wxMacDataItemBrowserControl *owner , } wxListCtrl *list = wxDynamicCast( owner->GetPeer() , wxListCtrl ); - if ( list ) + if ( list && lb ) { bool trigger = false; @@ -2048,10 +2448,8 @@ void wxMacListCtrlItem::Notification(wxMacDataItemBrowserControl *owner , event.SetEventObject( list ); event.m_itemIndex = owner->GetLineFromItem( this ) ; - if ( !list->IsVirtual() ) - { - lb->MacGetColumnInfo(event.m_itemIndex,0,event.m_item); - } + event.m_item.m_itemId = event.m_itemIndex; + list->GetItem(event.m_item); switch (message) { @@ -2096,12 +2494,15 @@ void wxMacListCtrlItem::Notification(wxMacDataItemBrowserControl *owner , } +IMPLEMENT_DYNAMIC_CLASS(wxMacDataBrowserListCtrlControl, wxMacDataItemBrowserControl ) + wxMacDataBrowserListCtrlControl::wxMacDataBrowserListCtrlControl( wxWindow *peer, const wxPoint& pos, const wxSize& size, long style) : wxMacDataItemBrowserControl( peer, pos, size, style ) { OSStatus err = noErr; m_clientDataItemsType = wxClientData_None; m_isVirtual = false; + m_flags = 0; if ( style & wxLC_VIRTUAL ) m_isVirtual = true; @@ -2125,14 +2526,10 @@ wxMacDataBrowserListCtrlControl::wxMacDataBrowserListCtrlControl( wxWindow *peer if ( gDataBrowserDrawItemUPP == NULL ) gDataBrowserDrawItemUPP = NewDataBrowserDrawItemUPP(DataBrowserDrawItemProc); -// if ( gDataBrowserEditItemUPP == NULL ) -// gDataBrowserEditItemUPP = NewDataBrowserEditItemUPP(DataBrowserEditTextProc); - if ( gDataBrowserHitTestUPP == NULL ) gDataBrowserHitTestUPP = NewDataBrowserHitTestUPP(DataBrowserHitTestProc); callbacks.u.v1.drawItemCallback = gDataBrowserDrawItemUPP; -// callbacks.u.v1.editTextCallback = gDataBrowserEditItemUPP; callbacks.u.v1.hitTestCallback = gDataBrowserHitTestUPP; SetDataBrowserCustomCallbacks( GetControlRef(), &callbacks ); @@ -2150,30 +2547,25 @@ wxMacDataBrowserListCtrlControl::wxMacDataBrowserListCtrlControl( wxWindow *peer SetSortProperty( kMinColumnId - 1 ); else SetSortProperty( kMinColumnId ); - if ( style & wxLC_SORT_ASCENDING ) - { - m_sortOrder = SortOrder_Text_Ascending; - SetSortOrder( kDataBrowserOrderIncreasing ); - } - else if ( style & wxLC_SORT_DESCENDING ) + + m_sortOrder = SortOrder_None; + + if ( style & wxLC_SORT_DESCENDING ) { - m_sortOrder = SortOrder_Text_Descending; SetSortOrder( kDataBrowserOrderDecreasing ); } - else + else if ( style & wxLC_SORT_ASCENDING ) { - m_sortOrder = SortOrder_None; + SetSortOrder( kDataBrowserOrderIncreasing ); } if ( style & wxLC_VRULES ) { -#if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_4 verify_noerr( DataBrowserChangeAttributes(m_controlRef, kDataBrowserAttributeListViewDrawColumnDividers, kDataBrowserAttributeNone) ); -#endif } verify_noerr( SetHiliteStyle(kDataBrowserTableViewFillHilite ) ); - err = SetHasScrollBars( (style & wxHSCROLL) != 0 , true ); + verify_noerr( SetHasScrollBars( (style & wxHSCROLL) != 0 , true ) ); } pascal Boolean wxMacDataBrowserListCtrlControl::DataBrowserEditTextProc( @@ -2185,7 +2577,7 @@ pascal Boolean wxMacDataBrowserListCtrlControl::DataBrowserEditTextProc( Boolean *shrinkToFit) { Boolean result = false; - wxMacDataBrowserListCtrlControl* ctl = dynamic_cast( wxMacControl::GetReferenceFromNativeControl( browser ) ); + wxMacDataBrowserListCtrlControl* ctl = wxDynamicCast(wxMacControl::GetReferenceFromNativeControl( browser ), wxMacDataBrowserListCtrlControl); if ( ctl != 0 ) { result = ctl->ConfirmEditText(itemID, property, theString, maxEditTextRect, shrinkToFit); @@ -2195,13 +2587,12 @@ pascal Boolean wxMacDataBrowserListCtrlControl::DataBrowserEditTextProc( } bool wxMacDataBrowserListCtrlControl::ConfirmEditText( - DataBrowserItemID itemID, - DataBrowserPropertyID property, - CFStringRef theString, - Rect *maxEditTextRect, - Boolean *shrinkToFit) + DataBrowserItemID WXUNUSED(itemID), + DataBrowserPropertyID WXUNUSED(property), + CFStringRef WXUNUSED(theString), + Rect *WXUNUSED(maxEditTextRect), + Boolean *WXUNUSED(shrinkToFit)) { - //wxListCtrl* list = wxDynamicCast( GetPeer() , wxListCtrl ); return false; } @@ -2214,7 +2605,7 @@ pascal void wxMacDataBrowserListCtrlControl::DataBrowserDrawItemProc( SInt16 gdDepth, Boolean colorDevice) { - wxMacDataBrowserListCtrlControl* ctl = dynamic_cast( wxMacControl::GetReferenceFromNativeControl( browser ) ); + wxMacDataBrowserListCtrlControl* ctl = wxDynamicCast(wxMacControl::GetReferenceFromNativeControl( browser ), wxMacDataBrowserListCtrlControl); if ( ctl != 0 ) { ctl->DrawItem(itemID, property, itemState, itemRect, gdDepth, colorDevice); @@ -2259,7 +2650,7 @@ void wxMacDataBrowserListCtrlControl::DrawItem( DataBrowserItemID itemID, DataBrowserPropertyID property, DataBrowserItemState itemState, - const Rect *itemRect, + const Rect *WXUNUSED(itemRect), SInt16 gdDepth, Boolean colorDevice) { @@ -2299,17 +2690,21 @@ void wxMacDataBrowserListCtrlControl::DrawItem( } else { - text = list->OnGetItemText( (long)itemID-1, listColumn ); - imgIndex = list->OnGetItemColumnImage( (long)itemID-1, listColumn ); - wxListItemAttr* attrs = list->OnGetItemAttr( (long)itemID-1 ); - if (attrs) + long itemNum = (long)itemID-1; + if (itemNum >= 0 && itemNum < list->GetItemCount()) { - if (attrs->HasBackgroundColour()) - bgColor = attrs->GetBackgroundColour(); - if (attrs->HasTextColour()) - color = attrs->GetTextColour(); - if (attrs->HasFont()) - font = attrs->GetFont(); + text = list->OnGetItemText( itemNum, listColumn ); + imgIndex = list->OnGetItemColumnImage( itemNum, listColumn ); + wxListItemAttr* attrs = list->OnGetItemAttr( itemNum ); + if (attrs) + { + if (attrs->HasBackgroundColour()) + bgColor = attrs->GetBackgroundColour(); + if (attrs->HasTextColour()) + color = attrs->GetTextColour(); + if (attrs->HasFont()) + font = attrs->GetFont(); + } } } } @@ -2318,12 +2713,10 @@ void wxMacDataBrowserListCtrlControl::DrawItem( if (bgColor == wxNullColour) bgColor = listBgColor; - wxFont listFont = list->GetFont(); - if (font == wxNullFont) - font = listFont; + if (!font.Ok()) + font = list->GetFont(); - wxMacCFStringHolder cfString; - cfString.Assign( text, wxLocale::GetSystemEncoding() ); + wxCFStringRef cfString( text, wxLocale::GetSystemEncoding() ); Rect enclosingRect; CGRect enclosingCGRect, iconCGRect, textCGRect; @@ -2331,6 +2724,14 @@ void wxMacDataBrowserListCtrlControl::DrawItem( ThemeDrawingState savedState = NULL; CGContextRef context = (CGContextRef)list->MacGetDrawingContext(); RGBColor labelColor; + labelColor.red = 0; + labelColor.green = 0; + labelColor.blue = 0; + + RGBColor backgroundColor; + backgroundColor.red = 255; + backgroundColor.green = 255; + backgroundColor.blue = 255; GetDataBrowserItemPartBounds(GetControlRef(), itemID, property, kDataBrowserPropertyEnclosingPart, &enclosingRect); @@ -2340,22 +2741,35 @@ void wxMacDataBrowserListCtrlControl::DrawItem( enclosingRect.right - enclosingRect.left, enclosingRect.bottom - enclosingRect.top); + bool hasFocus = (wxWindow::FindFocus() == list); active = IsControlActive(GetControlRef()); + // don't paint the background over the vertical rule line + if ( list->GetWindowStyleFlag() & wxLC_VRULES ) + { + enclosingCGRect.origin.x += 1; + enclosingCGRect.size.width -= 1; + } if (itemState == kDataBrowserItemIsSelected) { - RGBColor foregroundColor; GetThemeDrawingState(&savedState); - GetThemeBrushAsColor(kThemeBrushAlternatePrimaryHighlightColor, 32, true, &foregroundColor); - GetThemeTextColor(kThemeTextColorWhite, gdDepth, colorDevice, &labelColor); - + if (active && hasFocus) + { + GetThemeBrushAsColor(kThemeBrushAlternatePrimaryHighlightColor, 32, true, &backgroundColor); + GetThemeTextColor(kThemeTextColorWhite, gdDepth, colorDevice, &labelColor); + } + else + { + GetThemeBrushAsColor(kThemeBrushSecondaryHighlightColor, 32, true, &backgroundColor); + GetThemeTextColor(kThemeTextColorBlack, gdDepth, colorDevice, &labelColor); + } CGContextSaveGState(context); - CGContextSetRGBFillColor(context, (float)foregroundColor.red / (float)USHRT_MAX, - (float)foregroundColor.green / (float)USHRT_MAX, - (float)foregroundColor.blue / (float)USHRT_MAX, 1.0); + CGContextSetRGBFillColor(context, (CGFloat)backgroundColor.red / (CGFloat)USHRT_MAX, + (CGFloat)backgroundColor.green / (CGFloat)USHRT_MAX, + (CGFloat)backgroundColor.blue / (CGFloat)USHRT_MAX, (CGFloat) 1.0); CGContextFillRect(context, enclosingCGRect); CGContextRestoreGState(context); @@ -2364,24 +2778,18 @@ void wxMacDataBrowserListCtrlControl::DrawItem( { if (color.Ok()) - labelColor = MAC_WXCOLORREF( color.GetPixel() ); + color.GetRGBColor(&labelColor); else if (list->GetTextColour().Ok()) - labelColor = MAC_WXCOLORREF( list->GetTextColour().GetPixel() ); - else - { - labelColor.red = 0; - labelColor.green = 0; - labelColor.blue = 0; - } + list->GetTextColour().GetRGBColor(&labelColor); if (bgColor.Ok()) { - RGBColor foregroundColor = MAC_WXCOLORREF( bgColor.GetPixel() ); + bgColor.GetRGBColor(&backgroundColor); CGContextSaveGState(context); - CGContextSetRGBFillColor(context, (float)foregroundColor.red / (float)USHRT_MAX, - (float)foregroundColor.green / (float)USHRT_MAX, - (float)foregroundColor.blue / (float)USHRT_MAX, 1.0); + CGContextSetRGBFillColor(context, (CGFloat)backgroundColor.red / (CGFloat)USHRT_MAX, + (CGFloat)backgroundColor.green / (CGFloat)USHRT_MAX, + (CGFloat)backgroundColor.blue / (CGFloat)USHRT_MAX, (CGFloat) 1.0); CGContextFillRect(context, enclosingCGRect); CGContextRestoreGState(context); @@ -2395,18 +2803,13 @@ void wxMacDataBrowserListCtrlControl::DrawItem( wxImageList* imageList = list->GetImageList(wxIMAGE_LIST_SMALL); if (imageList && imageList->GetImageCount() > 0){ wxBitmap bmp = imageList->GetBitmap(imgIndex); - IconRef icon = bmp.GetBitmapData()->GetIconRef(); - - RGBColor iconLabel; - iconLabel.red = 0; - iconLabel.green = 0; - iconLabel.blue = 0; + IconRef icon = bmp.GetIconRef(); CGContextSaveGState(context); CGContextTranslateCTM(context, 0,iconCGRect.origin.y + CGRectGetMaxY(iconCGRect)); CGContextScaleCTM(context,1.0f,-1.0f); PlotIconRefInContext(context, &iconCGRect, kAlignNone, - active ? kTransformNone : kTransformDisabled, &iconLabel, + active ? kTransformNone : kTransformDisabled, NULL, kPlotIconRefNormalFlags, icon); CGContextRestoreGState(context); @@ -2414,19 +2817,36 @@ void wxMacDataBrowserListCtrlControl::DrawItem( } HIThemeTextHorizontalFlush hFlush = kHIThemeTextHorizontalFlushLeft; - UInt16 fontID = kThemeViewsFont; - - if (font.Ok()) + HIThemeTextInfo info; + bool setup = false; +#if wxMAC_USE_CORE_TEXT + if ( UMAGetSystemVersion() >= 0x1050 ) { - if (font.GetFamily() != wxFONTFAMILY_DEFAULT) - fontID = font.MacGetThemeFontID(); - -// FIXME: replace these with CG or ATSUI calls so we can remove this #ifndef. -#ifndef __LP64__ - ::TextSize( (short)(font.MacGetFontSize()) ) ; - ::TextFace( font.MacGetFontStyle() ) ; + info.version = kHIThemeTextInfoVersionOne; + info.fontID = kThemeViewsFont; + if (font.Ok()) + { + info.fontID = kThemeSpecifiedFont; + info.font = (CTFontRef) font.MacGetCTFont(); + setup = true; + } + } #endif +#if wxMAC_USE_ATSU_TEXT + if ( !setup ) + { + info.version = kHIThemeTextInfoVersionZero; + info.fontID = kThemeViewsFont; + + if (font.Ok()) + { + info.fontID = font.MacGetThemeFontID(); + + ::TextSize( (short)(font.MacGetFontSize()) ) ; + ::TextFace( font.MacGetFontStyle() ) ; + } } +#endif wxListItem item; list->GetColumn(listColumn, item); @@ -2443,10 +2863,7 @@ void wxMacDataBrowserListCtrlControl::DrawItem( } } - HIThemeTextInfo info; - info.version = kHIThemeTextInfoVersionZero; info.state = active ? kThemeStateActive : kThemeStateInactive; - info.fontID = fontID; info.horizontalFlushness = hFlush; info.verticalFlushness = kHIThemeTextVerticalFlushCenter; info.options = kHIThemeTextBoxOptionNone; @@ -2454,16 +2871,18 @@ void wxMacDataBrowserListCtrlControl::DrawItem( info.truncationMaxLines = 1; CGContextSaveGState(context); - CGContextSetRGBFillColor (context, (float)labelColor.red / (float)USHRT_MAX, - (float)labelColor.green / (float)USHRT_MAX, - (float)labelColor.blue / (float)USHRT_MAX, 1.0); + CGContextSetRGBFillColor (context, (CGFloat)labelColor.red / (CGFloat)USHRT_MAX, + (CGFloat)labelColor.green / (CGFloat)USHRT_MAX, + (CGFloat)labelColor.blue / (CGFloat)USHRT_MAX, (CGFloat) 1.0); HIThemeDrawTextBox(cfString, &textCGRect, &info, context, kHIThemeOrientationNormal); CGContextRestoreGState(context); +#ifndef __LP64__ if (savedState != NULL) SetThemeDrawingState(savedState, true); +#endif } OSStatus wxMacDataBrowserListCtrlControl::GetSetItemData(DataBrowserItemID itemID, @@ -2477,14 +2896,14 @@ OSStatus wxMacDataBrowserListCtrlControl::GetSetItemData(DataBrowserItemID itemI OSStatus err = errDataBrowserPropertyNotSupported; wxListCtrl* list = wxDynamicCast( GetPeer() , wxListCtrl ); - wxMacListCtrlItem* lcItem; + wxMacListCtrlItem* lcItem = NULL; if (listColumn >= 0) { if (!m_isVirtual) { lcItem = (wxMacListCtrlItem*) itemID; - if (lcItem->HasColumnInfo(listColumn)){ + if (lcItem && lcItem->HasColumnInfo(listColumn)){ wxListItem* item = lcItem->GetColumnInfo(listColumn); if (item->GetMask() & wxLIST_MASK_TEXT) text = item->GetText(); @@ -2494,8 +2913,12 @@ OSStatus wxMacDataBrowserListCtrlControl::GetSetItemData(DataBrowserItemID itemI } else { - text = list->OnGetItemText( (long)itemID-1, listColumn ); - imgIndex = list->OnGetItemColumnImage( (long)itemID-1, listColumn ); + long itemNum = (long)itemID-1; + if (itemNum >= 0 && itemNum < list->GetItemCount()) + { + text = list->OnGetItemText( itemNum, listColumn ); + imgIndex = list->OnGetItemColumnImage( itemNum, listColumn ); + } } } @@ -2513,10 +2936,8 @@ OSStatus wxMacDataBrowserListCtrlControl::GetSetItemData(DataBrowserItemID itemI default : if ( property >= kMinColumnId ) { - wxMacCFStringHolder cfStr; - - if (text){ - cfStr.Assign( text, wxLocale::GetSystemEncoding() ); + if (!text.IsEmpty()){ + wxCFStringRef cfStr( text, wxLocale::GetSystemEncoding() ); err = ::SetDataBrowserItemDataText( itemData, cfStr ); err = noErr; } @@ -2528,7 +2949,7 @@ OSStatus wxMacDataBrowserListCtrlControl::GetSetItemData(DataBrowserItemID itemI wxImageList* imageList = list->GetImageList(wxIMAGE_LIST_SMALL); if (imageList && imageList->GetImageCount() > 0){ wxBitmap bmp = imageList->GetBitmap(imgIndex); - IconRef icon = bmp.GetBitmapData()->GetIconRef(); + IconRef icon = bmp.GetIconRef(); ::SetDataBrowserItemDataIcon(itemData, icon); } } @@ -2551,7 +2972,7 @@ OSStatus wxMacDataBrowserListCtrlControl::GetSetItemData(DataBrowserItemID itemI // can then deal with the veto CFStringRef sr ; verify_noerr( GetDataBrowserItemDataText( itemData , &sr ) ) ; - wxMacCFStringHolder cfStr(sr) ;; + wxCFStringRef cfStr(sr) ;; if (m_isVirtual) list->SetItem( (long)itemData-1 , listColumn, cfStr.AsString() ) ; else @@ -2569,7 +2990,7 @@ OSStatus wxMacDataBrowserListCtrlControl::GetSetItemData(DataBrowserItemID itemI void wxMacDataBrowserListCtrlControl::ItemNotification(DataBrowserItemID itemID, DataBrowserItemNotification message, - DataBrowserItemDataRef itemData ) + DataBrowserItemDataRef WXUNUSED(itemData) ) { // we want to depend on as little as possible to make sure tear-down of controls is safe if ( message == kDataBrowserItemRemoved) @@ -2590,7 +3011,6 @@ void wxMacDataBrowserListCtrlControl::ItemNotification(DataBrowserItemID itemID, bool trigger = false; wxListEvent event( wxEVT_COMMAND_LIST_ITEM_SELECTED, list->GetId() ); - bool isSingle = (list->GetWindowStyle() & wxLC_SINGLE_SEL) != 0; event.SetEventObject( list ); if ( !list->IsVirtual() ) @@ -2598,21 +3018,21 @@ void wxMacDataBrowserListCtrlControl::ItemNotification(DataBrowserItemID itemID, DataBrowserTableViewRowIndex result = 0; verify_noerr( GetItemRow( itemID, &result ) ) ; event.m_itemIndex = result; - - if (event.m_itemIndex >= 0) - MacGetColumnInfo(event.m_itemIndex,0,event.m_item); } else { - event.m_itemIndex = (long)itemID; + event.m_itemIndex = (long)itemID-1; } + event.m_item.m_itemId = event.m_itemIndex; + list->GetItem(event.m_item); switch (message) { case kDataBrowserItemDeselected: event.SetEventType(wxEVT_COMMAND_LIST_ITEM_DESELECTED); - if ( !isSingle ) - trigger = !IsSelectionSuppressed(); + // as the generic implementation is also triggering this + // event for single selection, we do the same (different than listbox) + trigger = !IsSelectionSuppressed(); break; case kDataBrowserItemSelected: @@ -2658,49 +3078,58 @@ Boolean wxMacDataBrowserListCtrlControl::CompareItems(DataBrowserItemID itemOneI bool retval = false; wxString itemText; wxString otherItemText; + long itemOrder; + long otherItemOrder; + int colId = sortProperty - kMinColumnId; - long itemNum = 0; - long otherItemNum = 0; wxListCtrl* list = wxDynamicCast( GetPeer() , wxListCtrl ); - // means we need to + DataBrowserSortOrder sort; + verify_noerr(GetSortOrder(&sort)); + if (colId >= 0) { if (!m_isVirtual) { wxMacListCtrlItem* item = (wxMacListCtrlItem*)itemOneID; wxMacListCtrlItem* otherItem = (wxMacListCtrlItem*)itemTwoID; + + itemOrder = item->GetOrder(); + otherItemOrder = item->GetOrder(); + wxListCtrlCompare func = list->GetCompareFunc(); - if (func != NULL && item->HasColumnInfo(colId) && otherItem->HasColumnInfo(colId)) - return func(item->GetColumnInfo(colId)->GetData(), otherItem->GetColumnInfo(colId)->GetData(), list->GetCompareFuncData()) >= 0; - - itemNum = item->GetOrder(); - otherItemNum = otherItem->GetOrder(); - if (item->HasColumnInfo(colId)) - itemText = item->GetColumnInfo(colId)->GetText(); - if (otherItem->HasColumnInfo(colId)) - otherItemText = otherItem->GetColumnInfo(colId)->GetText(); + if (func != NULL) + { + long item1 = -1; + long item2 = -1; + if (item && item->HasColumnInfo(0)) + item1 = item->GetColumnInfo(0)->GetData(); + if (otherItem && otherItem->HasColumnInfo(0)) + item2 = otherItem->GetColumnInfo(0)->GetData(); + + if (item1 > -1 && item2 > -1) + { + int result = func(item1, item2, list->GetCompareFuncData()); + if (sort == kDataBrowserOrderIncreasing) + return result >= 0; + else + return result < 0; + } + } + + // we can't use the native control's sorting abilities, so just + // sort by item id. + return itemOrder < otherItemOrder; } else { - itemNum = (long)itemOneID; - otherItemNum = (long)itemTwoID; - itemText = list->OnGetItemText( itemNum-1, colId ); - otherItemText = list->OnGetItemText( otherItemNum-1, colId ); - } - - DataBrowserSortOrder sort; - verify_noerr(GetSortOrder(&sort)); + long itemNum = (long)itemOneID; + long otherItemNum = (long)itemTwoID; - if ( sort == kDataBrowserOrderIncreasing ) - { - retval = itemText.CmpNoCase( otherItemText ) > 0; - } - else if ( sort == kDataBrowserOrderDecreasing ) - { - retval = itemText.CmpNoCase( otherItemText ) < 0; + // virtual listctrls don't support sorting + return itemNum < otherItemNum; } } else{ @@ -2718,11 +3147,24 @@ wxMacDataBrowserListCtrlControl::~wxMacDataBrowserListCtrlControl() void wxMacDataBrowserListCtrlControl::MacSetColumnInfo( unsigned int row, unsigned int column, wxListItem* item ) { wxMacDataItem* dataItem = GetItemFromLine(row); + wxASSERT_MSG( dataItem, _T("could not obtain wxMacDataItem for row in MacSetColumnInfo. Is row a valid wxListCtrl row?") ); if (item) { - wxMacListCtrlItem* listItem = dynamic_cast(dataItem); + wxMacListCtrlItem* listItem = wx_static_cast(wxMacListCtrlItem*,dataItem); + bool hasInfo = listItem->HasColumnInfo( column ); listItem->SetColumnInfo( column, item ); + listItem->SetOrder(row); UpdateState(dataItem, item); + + wxListCtrl* list = wxDynamicCast( GetPeer() , wxListCtrl ); + + // NB: When this call was made before a control was completely shown, it would + // update the item prematurely (i.e. no text would be listed) and, on show, + // only the sorted column would be refreshed, meaning only first column text labels + // would be shown. Making sure not to update items until the control is visible + // seems to fix this issue. + if (hasInfo && list->IsShown()) + UpdateItem( wxMacDataBrowserRootContainer, listItem , kMinColumnId + column ); } } @@ -2734,7 +3176,7 @@ void wxMacDataBrowserListCtrlControl::UpdateState(wxMacDataItem* dataItem, wxLis bool isSelectedState = (listItem->GetState() == wxLIST_STATE_SELECTED); // toggle the selection state if wxListInfo state and actual state don't match. - if ( isSelected != isSelectedState ) + if ( listItem->GetMask() & wxLIST_MASK_STATE && isSelected != isSelectedState ) { DataBrowserSetOption options = kDataBrowserItemsAdd; if (!isSelectedState) @@ -2747,33 +3189,41 @@ void wxMacDataBrowserListCtrlControl::UpdateState(wxMacDataItem* dataItem, wxLis void wxMacDataBrowserListCtrlControl::MacGetColumnInfo( unsigned int row, unsigned int column, wxListItem& item ) { wxMacDataItem* dataItem = GetItemFromLine(row); + wxASSERT_MSG( dataItem, _T("could not obtain wxMacDataItem in MacGetColumnInfo. Is row a valid wxListCtrl row?") ); // CS should this guard against dataItem = 0 ? , as item is not a pointer if (item) is not appropriate //if (item) { - wxMacListCtrlItem* listItem = dynamic_cast(dataItem); - wxListItem* oldItem = listItem->GetColumnInfo( column ); + wxMacListCtrlItem* listItem =wx_static_cast(wxMacListCtrlItem*,dataItem); - long mask = item.GetMask(); - if ( !mask ) - // by default, get everything for backwards compatibility - mask = -1; + if (!listItem->HasColumnInfo( column )) + return; - if ( mask & wxLIST_MASK_TEXT ) - item.SetText(oldItem->GetText()); - if ( mask & wxLIST_MASK_IMAGE ) - item.SetImage(oldItem->GetImage()); - if ( mask & wxLIST_MASK_DATA ) - item.SetData(oldItem->GetData()); - if ( mask & wxLIST_MASK_STATE ) - item.SetState(oldItem->GetState()); - if ( mask & wxLIST_MASK_WIDTH ) - item.SetWidth(oldItem->GetWidth()); - if ( mask & wxLIST_MASK_FORMAT ) - item.SetAlign(oldItem->GetAlign()); + wxListItem* oldItem = listItem->GetColumnInfo( column ); - item.SetTextColour(oldItem->GetTextColour()); - item.SetBackgroundColour(oldItem->GetBackgroundColour()); - item.SetFont(oldItem->GetFont()); + if (oldItem) + { + long mask = item.GetMask(); + if ( !mask ) + // by default, get everything for backwards compatibility + mask = -1; + + if ( mask & wxLIST_MASK_TEXT ) + item.SetText(oldItem->GetText()); + if ( mask & wxLIST_MASK_IMAGE ) + item.SetImage(oldItem->GetImage()); + if ( mask & wxLIST_MASK_DATA ) + item.SetData(oldItem->GetData()); + if ( mask & wxLIST_MASK_STATE ) + item.SetState(oldItem->GetState()); + if ( mask & wxLIST_MASK_WIDTH ) + item.SetWidth(oldItem->GetWidth()); + if ( mask & wxLIST_MASK_FORMAT ) + item.SetAlign(oldItem->GetAlign()); + + item.SetTextColour(oldItem->GetTextColour()); + item.SetBackgroundColour(oldItem->GetBackgroundColour()); + item.SetFont(oldItem->GetFont()); + } } } @@ -2795,25 +3245,33 @@ wxMacListCtrlItem::wxMacListCtrlItem() int wxMacListCtrlItem::GetColumnImageValue( unsigned int column ) { - return GetColumnInfo(column)->GetImage(); + if ( HasColumnInfo(column) ) + return GetColumnInfo(column)->GetImage(); + + return -1; } void wxMacListCtrlItem::SetColumnImageValue( unsigned int column, int imageIndex ) { - GetColumnInfo(column)->SetImage(imageIndex); + if ( HasColumnInfo(column) ) + GetColumnInfo(column)->SetImage(imageIndex); } -const wxString& wxMacListCtrlItem::GetColumnTextValue( unsigned int column ) +wxString wxMacListCtrlItem::GetColumnTextValue( unsigned int column ) { if ( column == 0 ) return GetLabel(); - return GetColumnInfo(column)->GetText(); + if ( HasColumnInfo(column) ) + return GetColumnInfo(column)->GetText(); + + return wxEmptyString; } void wxMacListCtrlItem::SetColumnTextValue( unsigned int column, const wxString& text ) { - GetColumnInfo(column)->SetText(text); + if ( HasColumnInfo(column) ) + GetColumnInfo(column)->SetText(text); // for compatibility with superclass APIs if ( column == 0 ) @@ -2822,24 +3280,22 @@ void wxMacListCtrlItem::SetColumnTextValue( unsigned int column, const wxString& wxListItem* wxMacListCtrlItem::GetColumnInfo( unsigned int column ) { - wxListItemList::compatibility_iterator node = m_rowItems.Item( column ); - wxASSERT_MSG( node, _T("invalid column index in wxMacListCtrlItem") ); - - return node->GetData(); + wxASSERT_MSG( HasColumnInfo(column), _T("invalid column index in wxMacListCtrlItem") ); + return m_rowItems[column]; } bool wxMacListCtrlItem::HasColumnInfo( unsigned int column ) { - return m_rowItems.GetCount() > column; + return !(m_rowItems.find( column ) == m_rowItems.end()); } void wxMacListCtrlItem::SetColumnInfo( unsigned int column, wxListItem* item ) { - if ( column >= m_rowItems.GetCount() ) + if ( !HasColumnInfo(column) ) { wxListItem* listItem = new wxListItem(*item); - m_rowItems.Append( listItem ); + m_rowItems[column] = listItem; } else { @@ -2858,10 +3314,19 @@ void wxMacListCtrlItem::SetColumnInfo( unsigned int column, wxListItem* item ) if (mask & wxLIST_MASK_WIDTH) listItem->SetWidth(item->GetWidth()); - listItem->SetTextColour(item->GetTextColour()); - listItem->SetBackgroundColour(item->GetBackgroundColour()); - listItem->SetFont(item->GetFont()); + if ( item->HasAttributes() ) + { + if ( listItem->HasAttributes() ) + listItem->GetAttributes()->AssignFrom(*item->GetAttributes()); + else + { + listItem->SetTextColour(item->GetTextColour()); + listItem->SetBackgroundColour(item->GetBackgroundColour()); + listItem->SetFont(item->GetFont()); + } + } } } #endif // wxUSE_LISTCTRL +