X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/19193a2c85987b595932957e73013e7ea100f0e8..d179e30b0a4b474d987714323eb56e86b67b1e23:/src/univ/scrarrow.cpp diff --git a/src/univ/scrarrow.cpp b/src/univ/scrarrow.cpp index c3db2abdf8..48d669cf0d 100644 --- a/src/univ/scrarrow.cpp +++ b/src/univ/scrarrow.cpp @@ -134,17 +134,18 @@ void wxScrollArrows::DrawArrow(Arrow arrow, { wxUP, wxDOWN } }; - void (wxRenderer::*pfn)(wxDC&, wxDirection, const wxRect&, int) = - scrollbarLike ? wxRenderer::DrawScrollbarArrow - : wxRenderer::DrawArrow; - - (m_control->GetRenderer()->*pfn) - ( - dc, - arrowDirs[m_control->IsVertical()][arrow], - rect, - m_control->GetArrowState(arrow) - ); + if ( scrollbarLike ) + m_control->GetRenderer()->DrawScrollbarArrow( + dc, + arrowDirs[m_control->IsVertical()][arrow], + rect, + m_control->GetArrowState(arrow)); + else + m_control->GetRenderer()->DrawArrow( + dc, + arrowDirs[m_control->IsVertical()][arrow], + rect, + m_control->GetArrowState(arrow)); } // ---------------------------------------------------------------------------- @@ -169,7 +170,7 @@ bool wxScrollArrows::HandleMouseMove(const wxMouseEvent& event) const arrow = m_control->HitTest(event.GetPosition()); } - if ( m_captureData ) + if ( m_captureData && m_captureData->m_timerScroll) { // the mouse is captured, we may want to pause scrolling if it goes // outside the arrow or to resume it if we had paused it before @@ -245,11 +246,23 @@ bool wxScrollArrows::HandleMouse(const wxMouseEvent& event) const m_captureData->m_window = m_control->GetWindow(); m_captureData->m_window->CaptureMouse(); - // start scrolling - m_captureData->m_timerScroll = + // start scrolling + wxScrollArrowTimer *tmpTimerScroll = new wxScrollArrowTimer(m_control, arrow); - m_control->SetArrowFlag(arrow, wxCONTROL_PRESSED, TRUE); + // Because in some cases wxScrollArrowTimer can cause + // m_captureData to be destructed we need to test if it + // is still valid before using. + if (m_captureData) + { + m_captureData->m_timerScroll = tmpTimerScroll; + + m_control->SetArrowFlag(arrow, wxCONTROL_PRESSED, TRUE); + } + else + { + delete tmpTimerScroll; + } } //else: mouse already captured, nothing to do }