X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/1897abe1d8ac5e9575f4c9a589ea7ce08189506a..92a98ecc5369edfebf13151dc9e9d4acaf326342:/src/gtk/choice.cpp?ds=sidebyside diff --git a/src/gtk/choice.cpp b/src/gtk/choice.cpp index 7a6be36377..d8819a2abc 100644 --- a/src/gtk/choice.cpp +++ b/src/gtk/choice.cpp @@ -2,7 +2,6 @@ // Name: src/gtk/choice.cpp // Purpose: // Author: Robert Roebling -// Id: $Id$ // Copyright: (c) 1998 Robert Roebling // Licence: wxWindows licence ///////////////////////////////////////////////////////////////////////////// @@ -30,7 +29,7 @@ extern "C" { static void gtk_choice_changed_callback( GtkWidget *WXUNUSED(widget), wxChoice *choice ) { - choice->SendSelectionChangedEvent(wxEVT_COMMAND_CHOICE_SELECTED); + choice->SendSelectionChangedEvent(wxEVT_CHOICE); } } @@ -101,22 +100,6 @@ wxChoice::~wxChoice() delete m_strings; } -void wxChoice::SendSelectionChangedEvent(wxEventType evt_type) -{ - if (GetSelection() == -1) - return; - - wxCommandEvent event( evt_type, GetId() ); - - int n = GetSelection(); - event.SetInt( n ); - event.SetString( GetStringSelection() ); - event.SetEventObject( this ); - InitCommandEventWithItems( event, n ); - - HandleWindowEvent( event ); -} - void wxChoice::GTKInsertComboBoxTextItem( unsigned int n, const wxString& text ) { #ifdef __WXGTK3__ @@ -197,8 +180,12 @@ void wxChoice::DoDeleteOneItem(unsigned int n) GtkTreeModel* model = gtk_combo_box_get_model( combobox ); GtkListStore* store = GTK_LIST_STORE(model); GtkTreeIter iter; - gtk_tree_model_iter_nth_child( model, &iter, - NULL, (gint) n ); + if ( !gtk_tree_model_iter_nth_child(model, &iter, NULL, n) ) + { + // This is really not supposed to happen for a valid index. + wxFAIL_MSG(wxS("Item unexpectedly not found.")); + return; + } gtk_list_store_remove( store, &iter ); m_clientData.RemoveAt( n );