X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/15f2ee32702569c5ed944b45ea5b8a1ec4d68f16..50f65637a84135808d0fa246b7f53c6d66889a74:/tests/strings/strings.cpp?ds=sidebyside

diff --git a/tests/strings/strings.cpp b/tests/strings/strings.cpp
index 19414f05d5..ff320ac926 100644
--- a/tests/strings/strings.cpp
+++ b/tests/strings/strings.cpp
@@ -11,7 +11,7 @@
 // headers
 // ----------------------------------------------------------------------------
 
-#include "wx/wxprec.h"
+#include "testprec.h"
 
 #ifdef __BORLANDC__
     #pragma hdrstop
@@ -23,8 +23,6 @@
 
 #include "wx/tokenzr.h"
 
-#include "wx/cppunit.h"
-
 // ----------------------------------------------------------------------------
 // test class
 // ----------------------------------------------------------------------------
@@ -44,7 +42,8 @@ private:
         CPPUNIT_TEST( ConstructorsWithConversion );
         CPPUNIT_TEST( Conversion );
         CPPUNIT_TEST( ConversionUTF7 );
-#endif
+        CPPUNIT_TEST( ConversionUTF8 );
+#endif // wxUSE_WCHAR_T
         CPPUNIT_TEST( Extraction );
         CPPUNIT_TEST( Find );
         CPPUNIT_TEST( Tokenizer );
@@ -64,7 +63,8 @@ private:
     void ConstructorsWithConversion();
     void Conversion();
     void ConversionUTF7();
-#endif
+    void ConversionUTF8();
+#endif // wxUSE_WCHAR_T
     void Extraction();
     void Find();
     void SingleTokenizerTest( wxChar *str, wxChar *delims, size_t count , wxStringTokenizerMode mode );
@@ -76,6 +76,14 @@ private:
     void Compare();
     void CompareNoCase();
 
+#if wxUSE_WCHAR_T
+    // test if converting s using the given encoding gives ws and vice versa
+    //
+    // if either of the first 2 arguments is NULL, the conversion is supposed
+    // to fail
+    void DoTestConversion(const char *s, const wchar_t *w, wxCSConv& conv);
+#endif // wxUSE_WCHAR_T
+
     DECLARE_NO_COPY_CLASS(StringTestCase)
 };
 
@@ -197,7 +205,8 @@ void StringTestCase::Conversion()
         CPPUNIT_ASSERT( memcmp(theBuffer.data(), "The\0String", 11) == 0 );
 
         wxString szTheString2("The\0String", wxConvLocal, 10);
-        CPPUNIT_ASSERT( wxMemcmp(szTheString2.c_str(), L"The\0String", 11) == 0 );
+        CPPUNIT_ASSERT( szTheString2.length() == 11 );
+        CPPUNIT_ASSERT( wxTmemcmp(szTheString2.c_str(), L"The\0String", 11) == 0 );
 #else
         wxString szTheString(wxT("TheString"));
         szTheString.insert(3, 1, '\0');
@@ -213,40 +222,78 @@ void StringTestCase::Conversion()
 #endif
 }
 
-void StringTestCase::ConversionUTF7()
+void
+StringTestCase::DoTestConversion(const char *s,
+                                 const wchar_t *ws,
+                                 wxCSConv& conv)
 {
-    const wchar_t data[] = { 0x00A3, 0x00A3, 0x00A3, 0x00A3, 0 }; // pound signs
-
-    //utf7 and utf7alt are equivelent
-    const char *utf7 = "+AKM-+AKM-+AKM-+AKM-";
-    const char *utf7alt = "+AKMAowCjAKM-";
-
 #if wxUSE_UNICODE
-    wxString str(data);
-
-    wxCSConv conv(_T("utf-7"));
-
-    wxCharBuffer theBuffer = str.mb_str(conv);
-
-    CPPUNIT_ASSERT( strcmp(theBuffer, utf7) == 0 || strcmp(theBuffer, utf7alt) == 0);
-#else //ANSI
-    wxString str(utf7);
+    if ( ws )
+    {
+        wxCharBuffer buf(wxString(ws).mb_str(conv));
 
-    wxCSConv conv(_T("utf-7"));
+        CPPUNIT_ASSERT( strcmp(buf, s) == 0 );
+    }
+#else // wxUSE_UNICODE
+    if ( s )
+    {
+        wxWCharBuffer wbuf(wxString(s).wc_str(conv));
 
-    wxWCharBuffer theWBuffer = str.wc_str(conv);
+        if ( ws )
+            CPPUNIT_ASSERT( wcscmp(wbuf, ws) == 0 );
+        else
+            CPPUNIT_ASSERT( !*wbuf );
+    }
+#endif // wxUSE_UNICODE/!wxUSE_UNICODE
+}
 
-    CPPUNIT_ASSERT( wxWcslen(theWBuffer) == wxWcslen(data) );
-    CPPUNIT_ASSERT( memcmp(theWBuffer, data, wxWcslen(data) * sizeof(wchar_t)) == 0 );
+struct StringConversionData
+{
+    const char *str;
+    const wchar_t *wcs;
+};
 
-    wxString stralt(utf7alt);
+void StringTestCase::ConversionUTF7()
+{
+    static const StringConversionData utf7data[] =
+    {
+        { "+-", L"+" },
+        { "+--", L"+-" },
+        { "+AKM-", L"\u00a3" },
+
+        // Windows accepts invalid UTF-7 strings and so does our UTF-7
+        // conversion code -- this is wrong IMO but the way it is for now
+        //
+        // notice that converting "+" still behaves as expected because the
+        // result is just an empty string, i.e. the same as if there were an
+        // error, but converting "a+" results in "a" while it really should
+        // fail
+        { "+", NULL },
+        { "a+", L"a" },
+    };
 
-    wxWCharBuffer theWBufferAlt = stralt.wc_str(conv);
+    wxCSConv conv(_T("utf-7"));
+    for ( size_t n = 0; n < WXSIZEOF(utf7data); n++ )
+    {
+        const StringConversionData& d = utf7data[n];
+        DoTestConversion(d.str, d.wcs, conv);
+    }
+}
 
-    CPPUNIT_ASSERT( wxWcslen(theWBufferAlt) == wxWcslen(data) );
-    CPPUNIT_ASSERT( memcmp(theWBufferAlt, data, wxWcslen(data) * sizeof(wchar_t)) == 0 );
+void StringTestCase::ConversionUTF8()
+{
+    static const StringConversionData utf8data[] =
+    {
+        { "\xc2\xa3", L"\u00a3" },
+        { "\xc2", NULL },
+    };
 
-#endif // wxUSE_UNICODE
+    wxCSConv conv(_T("utf-8"));
+    for ( size_t n = 0; n < WXSIZEOF(utf8data); n++ )
+    {
+        const StringConversionData& d = utf8data[n];
+        DoTestConversion(d.str, d.wcs, conv);
+    }
 }
 
 #endif // wxUSE_WCHAR_T