X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/0a67a93b17c37c018f60e662645ee2a44ba4e58e..6d9022fe3bb50a75b9b5eaf5cf32558e518ba310:/src/mac/carbon/macnotfy.cpp

diff --git a/src/mac/carbon/macnotfy.cpp b/src/mac/carbon/macnotfy.cpp
index a47fce31e5..507605510d 100644
--- a/src/mac/carbon/macnotfy.cpp
+++ b/src/mac/carbon/macnotfy.cpp
@@ -8,6 +8,9 @@
  */
 
 #include "wx/wx.h"
+
+#include "wx/mac/private.h"
+
 #include "wx/mac/macnotfy.h"
 
 const short kMaxEvents = 1000 ;
@@ -74,6 +77,7 @@ void wxMacAddEvent(
 	short wakeUp ) 
 {
 	wxMacNotificationEvents *e = (wxMacNotificationEvents *) table ;
+	wxASSERT_MSG( handler != NULL , "illegal notification proc ptr" ) ;
 	/* this should be protected eventually */
 	short index = e->top++ ;
 	
@@ -111,21 +115,31 @@ void wxMacProcessNotifierEvents()
 //  	return ;
   	
   gInProcessing = true ;
-  while ( gMacNotificationEvents.top != gMacNotificationEvents.bottom )
+  if ( gMacNotificationEvents.top != gMacNotificationEvents.bottom )
   {
-    // consume event at bottom
-	short index = gMacNotificationEvents.bottom++ ;
-    if ( gMacNotificationEvents.bottom == kMaxEvents )
-      gMacNotificationEvents.bottom = 0 ;
-    void* data = gMacNotificationEvents.data[index] ;
-    unsigned long event = gMacNotificationEvents.events[index] ;
-	wxMacNotificationProcPtr handler =  gMacNotificationEvents.proc[index] ;
-	
-	gMacNotificationEvents.data[index] = NULL ;
-	gMacNotificationEvents.events[index] = NULL ;
-	gMacNotificationEvents.proc[index]  = NULL ;
-    
-	handler( event , data  ) ;
+    // we only should process the notifiers that were here when we entered it
+    // otherwise we might never get out...  
+	short count = gMacNotificationEvents.top - gMacNotificationEvents.bottom ;
+	if ( count < 0 )
+        count += kMaxEvents ;
+        
+    while ( count-- )
+    {
+        // consume event at bottom
+    	short index = gMacNotificationEvents.bottom++ ;
+        if ( gMacNotificationEvents.bottom == kMaxEvents )
+          gMacNotificationEvents.bottom = 0 ;
+        void* data = gMacNotificationEvents.data[index] ;
+        unsigned long event = gMacNotificationEvents.events[index] ;
+    	wxMacNotificationProcPtr handler =  gMacNotificationEvents.proc[index] ;
+    	
+    	gMacNotificationEvents.data[index] = NULL ;
+    	gMacNotificationEvents.events[index] = NULL ;
+    	gMacNotificationEvents.proc[index]  = NULL ;
+        
+        if ( handler )
+    	    handler( event , data  ) ;
+	}
   }
   gInProcessing = false ;
 }