X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/0627d0917bc2e34724055f72e6c36787a7de642f..7b35aa40a06a160ae4a8650c5820880a020697e3:/src/msw/filedlg.cpp diff --git a/src/msw/filedlg.cpp b/src/msw/filedlg.cpp index 89bf4ae96c..94a4e60b58 100644 --- a/src/msw/filedlg.cpp +++ b/src/msw/filedlg.cpp @@ -259,12 +259,13 @@ int wxFileDialog::ShowModal() { msw_flags |= OFN_NOCHANGEDIR; } - +/* chris elliott for some reason this does not work usefully if no extension + is given, as it test for junk instead of junk.ext if ( m_dialogStyle & wxOVERWRITE_PROMPT ) { msw_flags |= OFN_OVERWRITEPROMPT; } - +*/ OPENFILENAME of; wxZeroMemory(of); @@ -309,8 +310,11 @@ int wxFileDialog::ShowModal() if ( chNext != _T('\\') && chNext != _T('/') ) break; - // ignore the next one - i++; + // ignore the next one, unless it is at the start of a UNC path + if (i > 0) + i++; + else + break; } // fall through @@ -398,7 +402,7 @@ int wxFileDialog::ShowModal() : (GetOpenFileName(&of) != 0); } } -#endif +#endif // __WIN32__ if ( success ) { @@ -424,7 +428,7 @@ int wxFileDialog::ShowModal() i += wxStrlen(&fileNameBuffer[i]) + 1; } #else - wxStringTokenizer toke(fileNameBuffer, " \t\r\n"); + wxStringTokenizer toke(fileNameBuffer, _T(" \t\r\n")); m_dir = toke.GetNextToken(); m_fileName = toke.GetNextToken(); m_fileNames.Add(m_fileName); @@ -448,9 +452,21 @@ int wxFileDialog::ShowModal() m_filterIndex = (int)of.nFilterIndex - 1; - if ( !of.nFileExtension || (of.nFileExtension && fileNameBuffer[ of.nFileExtension-1] != wxT('.')) ) - { // user has typed an filename - // without an extension: + if ( !of.nFileExtension || + (of.nFileExtension && fileNameBuffer[of.nFileExtension] == wxT('\0')) ) + { + // User has typed a filename without an extension: + + // A filename can end in a "." here ("abc."), this means it + // does not have an extension. Because later on a "." with + // the default extension is appended we remove the "." if + // filename ends with one (We don't want files called + // "abc..ext") + int idx = wxStrlen(fileNameBuffer) - 1; + if ( fileNameBuffer[idx] == wxT('.') ) + { + fileNameBuffer[idx] = wxT('\0'); + } int maxFilter = (int)(of.nFilterIndex*2L-1L); extension = filterBuffer; @@ -480,6 +496,18 @@ int wxFileDialog::ShowModal() m_fileNames.Add(m_fileName); m_dir = wxPathOnly(fileNameBuffer); } + //=== Simulating the wxOVERWRITE_PROMPT >>============================ + //should we also test for file save style ?? + if ( (m_dialogStyle & wxOVERWRITE_PROMPT) && + ::wxFileExists( fileNameBuffer ) ) + { + wxString messageText; + messageText.Printf(_("File '%s' already exists.\nDo you want to replace it?"), fileNameBuffer); + if ( wxMessageBox(messageText, wxT("Save File As"), wxYES_NO | wxICON_EXCLAMATION ) != wxYES ) + { + success = FALSE; + } + } } else {