X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/04ef50df3a0fa3c343800c554e609f98fc7575cc..2fe212b0336512aac9eace69fab09ce856b0bf4b:/src/msw/gdiimage.cpp?ds=sidebyside diff --git a/src/msw/gdiimage.cpp b/src/msw/gdiimage.cpp index 000238864c..3ead2479d1 100644 --- a/src/msw/gdiimage.cpp +++ b/src/msw/gdiimage.cpp @@ -355,6 +355,8 @@ bool wxBMPFileHandler::LoadFile(wxBitmap *bitmap, #if wxUSE_IMAGE_LOADING_IN_MSW wxPalette *palette = NULL; bool success = wxLoadIntoBitmap(WXSTRINGCAST name, bitmap, &palette) != 0; + +#if wxUSE_PALETTE if ( success && palette ) { bitmap->SetPalette(*palette); @@ -362,6 +364,7 @@ bool wxBMPFileHandler::LoadFile(wxBitmap *bitmap, // it was copied by the bitmap if it was loaded successfully delete palette; +#endif // wxUSE_PALETTE return success; #else @@ -375,9 +378,15 @@ bool wxBMPFileHandler::SaveFile(wxBitmap *bitmap, const wxPalette *pal) { #if wxUSE_IMAGE_LOADING_IN_MSW + +#if wxUSE_PALETTE wxPalette *actualPalette = (wxPalette *)pal; if ( !actualPalette ) actualPalette = bitmap->GetPalette(); +#else + wxPalette *actualPalette = NULL; +#endif // wxUSE_PALETTE + return wxSaveBitmap(WXSTRINGCAST name, bitmap, actualPalette) != 0; #else return FALSE; @@ -402,12 +411,26 @@ bool wxICOFileHandler::LoadIcon(wxIcon *icon, #ifdef __WIN32__ HICON hicon = NULL; + // Parse the filename: it may be of the form "filename;n" in order to + // specify the nth icon in the file. + // + // For the moment, ignore the issue of possible semicolons in the + // filename. + int iconIndex = 0; + wxString nameReal(name); + wxString strIconIndex = name.AfterLast(wxT(';')); + if (strIconIndex != name) + { + iconIndex = wxAtoi(strIconIndex); + nameReal = name.BeforeLast(wxT(';')); + } + // were we asked for a large icon? if ( desiredWidth == ::GetSystemMetrics(SM_CXICON) && desiredHeight == ::GetSystemMetrics(SM_CYICON) ) { - // get the first large icon from file - if ( !::ExtractIconEx(name, 0, &hicon, NULL, 1) ) + // get the specified large icon from file + if ( !::ExtractIconEx(nameReal, iconIndex, &hicon, NULL, 1) ) { // it is not an error, but it might still be useful to be informed // about it optionally @@ -419,8 +442,8 @@ bool wxICOFileHandler::LoadIcon(wxIcon *icon, else if ( desiredWidth == ::GetSystemMetrics(SM_CXSMICON) && desiredHeight == ::GetSystemMetrics(SM_CYSMICON) ) { - // get the first small icon from file - if ( !::ExtractIconEx(name, 0, NULL, &hicon, 1) ) + // get the specified small icon from file + if ( !::ExtractIconEx(nameReal, iconIndex, NULL, &hicon, 1) ) { wxLogTrace(_T("iconload"), _T("No small icons found in the file '%s'."), @@ -432,7 +455,7 @@ bool wxICOFileHandler::LoadIcon(wxIcon *icon, if ( !hicon ) { // take any (the first one) icon from the file by default - hicon = ::ExtractIcon(wxGetInstance(), name, 0 /* first */); + hicon = ::ExtractIcon(wxGetInstance(), nameReal, 0 /* first */); } if ( !hicon ) @@ -479,8 +502,17 @@ bool wxICOResourceHandler::LoadIcon(wxIcon *icon, { HICON hicon; + // do we need the icon of the specific size or would any icon do? + bool hasSize = desiredWidth != -1 || desiredHeight != -1; + + wxASSERT_MSG( !hasSize || (desiredWidth != -1 && desiredHeight != -1), + _T("width and height should be either both -1 or not") ); + + // try to load the icon from this program first to allow overriding the + // standard icons (although why one would want to do it considering that + // we already have wxApp::GetStdIcon() is unclear) #if defined(__WIN32__) && !defined(__SC__) - if ( desiredWidth != -1 && desiredHeight != -1 ) + if ( hasSize ) { hicon = (HICON)::LoadImage(wxGetInstance(), name, IMAGE_ICON, desiredWidth, desiredHeight, @@ -492,6 +524,30 @@ bool wxICOResourceHandler::LoadIcon(wxIcon *icon, hicon = ::LoadIcon(wxGetInstance(), name); } + // next check if it's not a standard icon + if ( !hicon && !hasSize ) + { + static const struct + { + const wxChar *name; + LPTSTR id; + } stdIcons[] = + { + { wxT("wxICON_QUESTION"), IDI_QUESTION }, + { wxT("wxICON_WARNING"), IDI_EXCLAMATION }, + { wxT("wxICON_ERROR"), IDI_HAND }, + { wxT("wxICON_INFO"), IDI_ASTERISK }, + }; + + for ( size_t nIcon = 0; !hicon && nIcon < WXSIZEOF(stdIcons); nIcon++ ) + { + if ( name == stdIcons[nIcon].name ) + { + hicon = ::LoadIcon((HINSTANCE)NULL, stdIcons[nIcon].id); + } + } + } + wxSize size = GetHiconSize(hicon); icon->SetSize(size.x, size.y);