X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/0187ddb4a81e1eea473b960f9d740b4f531f1ada..c5feba0ea35d8e0b4f35e4a0fbab8c4c3db63cf6:/src/cocoa/app.mm diff --git a/src/cocoa/app.mm b/src/cocoa/app.mm index 2ee2c6bab8..99eb4261c8 100644 --- a/src/cocoa/app.mm +++ b/src/cocoa/app.mm @@ -36,12 +36,15 @@ #import #import #import +#import // ======================================================================== // wxPoseAsInitializer // ======================================================================== wxPoseAsInitializer *wxPoseAsInitializer::sm_first = NULL; +static bool sg_needIdle = true; + // ======================================================================== // wxPoserNSApplication // ======================================================================== @@ -49,7 +52,7 @@ wxPoseAsInitializer *wxPoseAsInitializer::sm_first = NULL; { } -- (void)doIdle: (id)data; +- (NSEvent *)nextEventMatchingMask:(unsigned int)mask untilDate:(NSDate *)expiration inMode:(NSString *)mode dequeue:(BOOL)flag; - (void)sendEvent: (NSEvent*)anEvent; @end // wxPoserNSApplication @@ -57,43 +60,53 @@ WX_IMPLEMENT_POSER(wxPoserNSApplication); @implementation wxPoserNSApplication : NSApplication -- (void)doIdle: (id)data +/* NOTE: The old method of idle event handling added the handler using the + [NSRunLoop -performSelector:target:argument:order:modes] which caused + the invocation to occur at the begining of [NSApplication + -nextEventMatchingMask:untilDate:expiration:inMode:dequeue:]. However, + the code would be scheduled for invocation with every iteration of + the event loop. This new method simply overrides the method. The + same caveats apply. In particular, by the time the event loop has + called this method, it usually expects to receive an event. If you + plan on stopping the event loop, it is wise to send an event through + the queue to ensure this method will return. + See wxEventLoop::Exit() for more information. +*/ + +- (NSEvent *)nextEventMatchingMask:(unsigned int)mask untilDate:(NSDate *)expiration inMode:(NSString *)mode dequeue:(BOOL)flag { - wxASSERT(wxTheApp); - wxASSERT(wxMenuBarManager::GetInstance()); - wxMenuBarManager::GetInstance()->CocoaInternalIdle(); - wxLogDebug("doIdle called"); -#ifdef __WXDEBUG__ - if(wxTheApp->IsInAssert()) - { - wxLogDebug("Idle events ignored durring assertion dialog"); - } - else -#endif + // Get the same events except don't block + NSEvent *event = [super nextEventMatchingMask:mask untilDate:nil/* equivalent to [NSDate distantPast] */ inMode:mode dequeue:flag]; + // If we got one, simply return it + if(event) + return event; + // No events, try doing some idle stuff + if(sg_needIdle && !wxTheApp->IsInAssert() && ([NSDefaultRunLoopMode isEqualToString:mode] || [NSModalPanelRunLoopMode isEqualToString:mode])) { - NSRunLoop *rl = [NSRunLoop currentRunLoop]; - // runMode: beforeDate returns YES if something was done - while(wxTheApp->ProcessIdle()) // FIXME: AND NO EVENTS ARE PENDING + sg_needIdle = false; + wxLogDebug("Processing idle events"); + while(wxTheApp->ProcessIdle()) { - wxLogDebug("Looping for idle events"); - #if 1 - if( [rl runMode:[rl currentMode] beforeDate:[NSDate distantPast]]) - { - wxLogDebug("Found actual work to do"); - break; - } - #endif + // Get the same events except don't block + NSEvent *event = [super nextEventMatchingMask:mask untilDate:nil/* equivalent to [NSDate distantPast] */ inMode:mode dequeue:flag]; + // If we got one, simply return it + if(event) + return event; + // we didn't get one, do some idle work + wxLogDebug("Looping idle events"); } + // No more idle work requested, block + wxLogDebug("Finished idle processing"); } - wxLogDebug("Idle processing complete, requesting next idle event"); - // Add ourself back into the run loop (on next event) if necessary - wxTheApp->CocoaRequestIdle(); + else + wxLogDebug("Avoiding idle processing sg_needIdle=%d",sg_needIdle); + return [super nextEventMatchingMask:mask untilDate:expiration inMode:mode dequeue:flag]; } - (void)sendEvent: (NSEvent*)anEvent { wxLogDebug("SendEvent"); - wxTheApp->CocoaInstallRequestedIdleHandler(); + sg_needIdle = true; [super sendEvent: anEvent]; } @@ -106,6 +119,7 @@ WX_IMPLEMENT_POSER(wxPoserNSApplication); { } +// Delegate methods - (BOOL)applicationShouldTerminateAfterLastWindowClosed:(NSApplication *)theApplication; - (void)applicationWillBecomeActive:(NSNotification *)notification; - (void)applicationDidBecomeActive:(NSNotification *)notification; @@ -173,10 +187,11 @@ bool wxApp::Initialize(int& argc, wxChar **argv) if ( argc > 1 ) { static const wxChar *ARG_PSN = _T("-psn_"); - if ( wxStrncmp(argv[1], ARG_PSN, sizeof(ARG_PSN) - 1) == 0 ) + if ( wxStrncmp(argv[1], ARG_PSN, strlen(ARG_PSN)) == 0 ) { // remove this argument - memmove(argv, argv + 1, argc--); + --argc; + memmove(argv + 1, argv + 2, argc * sizeof(char *)); } } @@ -208,7 +223,6 @@ wxApp::wxApp() { m_topWindow = NULL; - m_isIdle = true; #if WXWIN_COMPATIBILITY_2_2 m_wantDebugOutput = TRUE; #endif @@ -222,24 +236,6 @@ wxApp::wxApp() m_cocoaAppDelegate = NULL; } -void wxApp::CocoaInstallIdleHandler() -{ - // If we're not the main thread, don't install the idle handler - if(m_cocoaMainThread != [NSThread currentThread]) - { - wxLogDebug("Attempt to install idle handler from secondary thread"); - return; - } - // If we're supposed to be stopping, don't add more idle events - if(![m_cocoaApp isRunning]) - return; - wxLogDebug("wxApp::CocoaInstallIdleHandler"); - m_isIdle = false; - // Call doIdle for EVERYTHING dammit -// We'd need Foundation/NSConnection.h for this next constant, do we need it? - [[ NSRunLoop currentRunLoop ] performSelector:@selector(doIdle:) target:m_cocoaApp argument:NULL order:0 modes:[NSArray arrayWithObjects:NSDefaultRunLoopMode, /* NSConnectionReplyRunLoopMode,*/ NSModalPanelRunLoopMode, /**/NSEventTrackingRunLoopMode,/**/ nil] ]; -} - void wxApp::CocoaDelegate_applicationWillBecomeActive() { } @@ -250,6 +246,7 @@ void wxApp::CocoaDelegate_applicationDidBecomeActive() void wxApp::CocoaDelegate_applicationWillResignActive() { + wxTopLevelWindowCocoa::DeactivatePendingWindow(); } void wxApp::CocoaDelegate_applicationDidResignActive() @@ -271,11 +268,6 @@ bool wxApp::OnInitGui() wxDC::CocoaInitializeTextSystem(); // [ m_cocoaApp setDelegate:m_cocoaApp ]; - #if 0 - wxLogDebug("Just for kicks"); - [ m_cocoaApp performSelector:@selector(doIdle:) withObject:NULL ]; - wxLogDebug("okay.. done now"); - #endif return TRUE; } @@ -344,6 +336,14 @@ bool wxApp::Yield(bool onlyIfNeeded) return true; } +void wxApp::WakeUpIdle() +{ + [m_cocoaApp postEvent:[NSEvent otherEventWithType:NSApplicationDefined + location:NSZeroPoint modifierFlags:NSAnyEventMask + timestamp:0 windowNumber:0 context:nil + subtype:0 data1:0 data2:0] atStart:NO]; +} + #ifdef __WXDEBUG__ void wxApp::OnAssert(const wxChar *file, int line, const wxChar* cond, const wxChar *msg) {