// Author: Robert Roebling
// Id: $Id$
// Copyright: (c) 1998 Robert Roebling
-// Licence: wxWindows licence
+// Licence: wxWindows licence
/////////////////////////////////////////////////////////////////////////////
-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
#pragma implementation "combobox.h"
#endif
+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"
+
#include "wx/combobox.h"
-#include <wx/intl.h>
+
+#if wxUSE_COMBOBOX
+
+#include "wx/settings.h"
+#include "wx/arrstr.h"
+#include "wx/intl.h"
+
+#include "wx/textctrl.h" // for wxEVT_COMMAND_TEXT_UPDATED
+
+#include "wx/gtk/private.h"
+
+//-----------------------------------------------------------------------------
+// idle system
+//-----------------------------------------------------------------------------
+
+extern void wxapp_install_idle_handler();
+extern bool g_isIdle;
//-----------------------------------------------------------------------------
// data
extern bool g_blockEventsOnDrag;
//-----------------------------------------------------------------------------
-// "select"
+// "select-child" - click/cursor get select-child, changed, select-child
//-----------------------------------------------------------------------------
-static void gtk_combo_clicked_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )
+static void
+gtk_combo_select_child_callback( GtkList *WXUNUSED(list), GtkWidget *WXUNUSED(widget), wxComboBox *combo )
{
- if (!combo->HasVMT()) return;
+ if (g_isIdle) wxapp_install_idle_handler();
+
+ if (!combo->m_hasVMT) return;
+
if (g_blockEventsOnDrag) return;
-
- if (combo->m_alreadySent)
- {
- combo->m_alreadySent = FALSE;
- return;
- }
- combo->m_alreadySent = TRUE;
-
- wxCommandEvent event(wxEVT_COMMAND_CHOICE_SELECTED, combo->GetId());
- event.SetInt( combo->GetSelection() );
- wxString tmp( combo->GetStringSelection() );
- event.SetString( WXSTRINGCAST(tmp) );
- event.SetEventObject(combo);
- combo->GetEventHandler()->ProcessEvent(event);
+ int curSelection = combo->GetSelection();
+
+ if (combo->m_prevSelection == curSelection) return;
+
+ GtkWidget *list = GTK_COMBO(combo->m_widget)->list;
+ gtk_list_unselect_item( GTK_LIST(list), combo->m_prevSelection );
+
+ combo->m_prevSelection = curSelection;
+
+ wxCommandEvent event( wxEVT_COMMAND_COMBOBOX_SELECTED, combo->GetId() );
+ event.SetInt( curSelection );
+ event.SetString( combo->GetStringSelection() );
+ event.SetEventObject( combo );
+
+ combo->GetEventHandler()->ProcessEvent( event );
+}
+
+//-----------------------------------------------------------------------------
+// "changed" - typing and list item matches get changed, select-child
+// if it doesn't match an item then just get a single changed
+//-----------------------------------------------------------------------------
+
+static void
+gtk_text_changed_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )
+{
+ if (g_isIdle) wxapp_install_idle_handler();
+
+ if (!combo->m_hasVMT) return;
+
+ wxCommandEvent event( wxEVT_COMMAND_TEXT_UPDATED, combo->GetId() );
+ event.SetString( combo->GetValue() );
+ event.SetEventObject( combo );
+ combo->GetEventHandler()->ProcessEvent( event );
+}
+
+static void
+gtk_dummy_callback(GtkEntry *WXUNUSED(entry), GtkCombo *WXUNUSED(combo))
+{
}
//-----------------------------------------------------------------------------
BEGIN_EVENT_TABLE(wxComboBox, wxControl)
EVT_SIZE(wxComboBox::OnSize)
+ EVT_CHAR(wxComboBox::OnChar)
END_EVENT_TABLE()
+bool wxComboBox::Create( wxWindow *parent, wxWindowID id,
+ const wxString& value,
+ const wxPoint& pos, const wxSize& size,
+ const wxArrayString& choices,
+ long style, const wxValidator& validator,
+ const wxString& name )
+{
+ wxCArrayString chs(choices);
+
+ return Create( parent, id, value, pos, size, chs.GetCount(),
+ chs.GetStrings(), style, validator, name );
+}
+
bool wxComboBox::Create( wxWindow *parent, wxWindowID id, const wxString& value,
const wxPoint& pos, const wxSize& size,
int n, const wxString choices[],
- long style, const wxValidator& validator,
- const wxString& name )
+ long style, const wxValidator& validator,
+ const wxString& name )
{
m_alreadySent = FALSE;
m_needParent = TRUE;
-
- PreCreation( parent, id, pos, size, style, name );
-
- SetValidator( validator );
+ m_acceptsFocus = TRUE;
+ m_prevSelection = 0;
+
+ if (!PreCreation( parent, pos, size ) ||
+ !CreateBase( parent, id, pos, size, style, validator, name ))
+ {
+ wxFAIL_MSG( wxT("wxComboBox creation failed") );
+ return FALSE;
+ }
m_widget = gtk_combo_new();
-
- wxSize newSize = size;
- if (newSize.x == -1) newSize.x = 100;
- if (newSize.y == -1) newSize.y = 26;
- SetSize( newSize.x, newSize.y );
-
+ GtkCombo *combo = GTK_COMBO(m_widget);
+
+ // Disable GTK's broken events ...
+ gtk_signal_disconnect( GTK_OBJECT(combo->entry), combo->entry_change_id );
+ // ... and add surogate handler.
+ combo->entry_change_id = gtk_signal_connect (GTK_OBJECT (combo->entry), "changed",
+ (GtkSignalFunc) gtk_dummy_callback, combo);
+
+ // make it more useable
+ gtk_combo_set_use_arrows_always( GTK_COMBO(m_widget), TRUE );
+
+ // and case-sensitive
+ gtk_combo_set_case_sensitive( GTK_COMBO(m_widget), TRUE );
+
GtkWidget *list = GTK_COMBO(m_widget)->list;
-
+
+#ifndef __WXGTK20__
+ // gtk_list_set_selection_mode( GTK_LIST(list), GTK_SELECTION_MULTIPLE );
+#endif
+
for (int i = 0; i < n; i++)
{
- GtkWidget *list_item = gtk_list_item_new_with_label( choices[i] );
-
+ GtkWidget *list_item = gtk_list_item_new_with_label( wxGTK_CONV( choices[i] ) );
+
m_clientDataList.Append( (wxObject*)NULL );
-
+ m_clientObjectList.Append( (wxObject*)NULL );
+
gtk_container_add( GTK_CONTAINER(list), list_item );
-
- gtk_widget_realize( list_item );
- gtk_widget_realize( GTK_BIN(list_item)->child );
-
+
gtk_widget_show( list_item );
-
- gtk_signal_connect( GTK_OBJECT(list_item), "select",
- GTK_SIGNAL_FUNC(gtk_combo_clicked_callback), (gpointer)this );
}
-
- m_parent->AddChild( this );
- (m_parent->m_insertCallback)( m_parent, this );
-
- PostCreation();
+ m_parent->DoAddChild( this );
- ConnectWidget( GTK_COMBO(m_widget)->button );
-
- if (!value.IsNull()) SetValue( value );
-
- gtk_widget_realize( GTK_COMBO(m_widget)->list );
- gtk_widget_realize( GTK_COMBO(m_widget)->entry );
- gtk_widget_realize( GTK_COMBO(m_widget)->button );
-
- SetBackgroundColour( parent->GetBackgroundColour() );
- SetForegroundColour( parent->GetForegroundColour() );
-
- Show( TRUE );
+ m_focusWidget = combo->entry;
+
+ PostCreation(size);
+
+ ConnectWidget( combo->button );
+
+ // MSW's combo box shows the value and the selection is -1
+ gtk_entry_set_text( GTK_ENTRY(combo->entry), wxGTK_CONV(value) );
+ gtk_list_unselect_all( GTK_LIST(combo->list) );
+
+ if (style & wxCB_READONLY)
+ gtk_entry_set_editable( GTK_ENTRY( combo->entry ), FALSE );
+
+ gtk_signal_connect( GTK_OBJECT(combo->entry), "changed",
+ GTK_SIGNAL_FUNC(gtk_text_changed_callback), (gpointer)this );
+
+ gtk_signal_connect( GTK_OBJECT(combo->list), "select-child",
+ GTK_SIGNAL_FUNC(gtk_combo_select_child_callback), (gpointer)this );
+
+ SetBestSize(size); // need this too because this is a wxControlWithItems
+
+ // This is required for tool bar support
+ wxSize setsize = GetSize();
+ gtk_widget_set_usize( m_widget, setsize.x, setsize.y );
return TRUE;
}
wxComboBox::~wxComboBox()
{
- wxNode *node = m_clientDataList.First();
+ wxList::compatibility_iterator node = m_clientObjectList.GetFirst();
while (node)
{
- wxClientData *cd = (wxClientData*)node->Data();
+ wxClientData *cd = (wxClientData*)node->GetData();
if (cd) delete cd;
- node = node->Next();
+ node = node->GetNext();
}
+ m_clientObjectList.Clear();
+
m_clientDataList.Clear();
}
-void wxComboBox::AppendCommon( const wxString &item )
+void wxComboBox::SetFocus()
{
- wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-
+ if ( m_hasFocus )
+ {
+ // don't do anything if we already have focus
+ return;
+ }
+
+ gtk_widget_grab_focus( m_focusWidget );
+}
+
+int wxComboBox::DoAppend( const wxString &item )
+{
+ wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid combobox") );
+
+ DisableEvents();
+
GtkWidget *list = GTK_COMBO(m_widget)->list;
-
- GtkWidget *list_item = gtk_list_item_new_with_label( item );
-
- gtk_signal_connect( GTK_OBJECT(list_item), "select",
- GTK_SIGNAL_FUNC(gtk_combo_clicked_callback), (gpointer)this );
-
+
+ GtkWidget *list_item = gtk_list_item_new_with_label( wxGTK_CONV( item ) );
+
gtk_container_add( GTK_CONTAINER(list), list_item );
-
- if (m_widgetStyle) ApplyWidgetStyle();
-
+
+ if (GTK_WIDGET_REALIZED(m_widget))
+ {
+ gtk_widget_realize( list_item );
+ gtk_widget_realize( GTK_BIN(list_item)->child );
+ }
+
+ // Apply current widget style to the new list_item
+ GtkRcStyle *style = CreateWidgetStyle();
+ if (style)
+ {
+ gtk_widget_modify_style( GTK_WIDGET( list_item ), style );
+ GtkBin *bin = GTK_BIN( list_item );
+ GtkWidget *label = GTK_WIDGET( bin->child );
+ gtk_widget_modify_style( label, style );
+ gtk_rc_style_unref( style );
+ }
+
gtk_widget_show( list_item );
-}
-void wxComboBox::Append( const wxString &item )
-{
- m_clientDataList.Append( (wxObject*)NULL );
-
- AppendCommon( item );
-}
+ const int count = GetCount();
-void wxComboBox::Append( const wxString &item, void *clientData )
-{
- if (clientData)
- m_clientDataList.Append( (wxObject*) new wxVoidClientData( clientData ) );
- else
- m_clientDataList.Append( (wxObject*)NULL );
-
- AppendCommon( item );
+ if ( (int)m_clientDataList.GetCount() < count )
+ m_clientDataList.Append( (wxObject*) NULL );
+ if ( (int)m_clientObjectList.GetCount() < count )
+ m_clientObjectList.Append( (wxObject*) NULL );
+
+ EnableEvents();
+
+ InvalidateBestSize();
+
+ return count - 1;
}
-void wxComboBox::Append( const wxString &item, wxClientData *clientData )
+int wxComboBox::DoInsert( const wxString &item, int pos )
{
- m_clientDataList.Append( (wxObject*) clientData );
-
- AppendCommon( item );
+ wxCHECK_MSG( !(GetWindowStyle() & wxCB_SORT), -1,
+ wxT("can't insert into sorted list"));
+
+ wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid combobox") );
+
+ int count = GetCount();
+ wxCHECK_MSG( (pos >= 0) && (pos <= count), -1, wxT("invalid index") );
+
+ if (pos == count)
+ return Append(item);
+
+ DisableEvents();
+
+ GtkWidget *list = GTK_COMBO(m_widget)->list;
+
+ GtkWidget *list_item = gtk_list_item_new_with_label( wxGTK_CONV( item ) );
+
+ GList *gitem_list = g_list_alloc ();
+ gitem_list->data = list_item;
+ gtk_list_insert_items( GTK_LIST (list), gitem_list, pos );
+
+ if (GTK_WIDGET_REALIZED(m_widget))
+ {
+ gtk_widget_realize( list_item );
+ gtk_widget_realize( GTK_BIN(list_item)->child );
+
+ ApplyWidgetStyle();
+ }
+
+ gtk_widget_show( list_item );
+
+ count = GetCount();
+
+ if ( (int)m_clientDataList.GetCount() < count )
+ m_clientDataList.Insert( pos, (wxObject*) NULL );
+ if ( (int)m_clientObjectList.GetCount() < count )
+ m_clientObjectList.Insert( pos, (wxObject*) NULL );
+
+ EnableEvents();
+
+ InvalidateBestSize();
+
+ return pos;
}
-void wxComboBox::SetClientData( int n, void* clientData )
+void wxComboBox::DoSetItemClientData( int n, void* clientData )
{
- wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-
- wxNode *node = m_clientDataList.Nth( n );
+ wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+
+ wxList::compatibility_iterator node = m_clientDataList.Item( n );
if (!node) return;
-
- wxClientData *cd = (wxClientData*) node->Data();
- if (cd) delete cd;
-
- if (clientData)
- node->SetData( (wxObject*) new wxVoidClientData(clientData) );
- else
- node->SetData( (wxObject*) NULL );
+
+ node->SetData( (wxObject*) clientData );
}
-void* wxComboBox::GetClientData( int n )
+void* wxComboBox::DoGetItemClientData( int n ) const
{
- wxCHECK_MSG( m_widget != NULL, NULL, "invalid combobox" );
-
- wxNode *node = m_clientDataList.Nth( n );
- if (!node) return NULL;
-
- wxVoidClientData *cd = (wxVoidClientData*) node->Data();
- if (cd)
- return cd->GetData();
- else
- return (void*) NULL;
+ wxCHECK_MSG( m_widget != NULL, NULL, wxT("invalid combobox") );
+
+ wxList::compatibility_iterator node = m_clientDataList.Item( n );
+
+ return node ? node->GetData() : NULL;
}
-void wxComboBox::SetClientObject( int n, wxClientData* clientData )
+void wxComboBox::DoSetItemClientObject( int n, wxClientData* clientData )
{
- wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-
- wxNode *node = m_clientDataList.Nth( n );
+ wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+
+ wxList::compatibility_iterator node = m_clientObjectList.Item( n );
if (!node) return;
-
- wxClientData *cd = (wxClientData*) node->Data();
- if (cd) delete cd;
-
+
+ // wxItemContainer already deletes data for us
+
node->SetData( (wxObject*) clientData );
}
-wxClientData* wxComboBox::GetClientObject( int n )
+wxClientData* wxComboBox::DoGetItemClientObject( int n ) const
{
- wxCHECK_MSG( m_widget != NULL, (wxClientData*)NULL, "invalid combobox" );
-
- wxNode *node = m_clientDataList.Nth( n );
- if (!node) return (wxClientData*) NULL;
-
- return (wxClientData*) node->Data();
+ wxCHECK_MSG( m_widget != NULL, (wxClientData*)NULL, wxT("invalid combobox") );
+
+ wxList::compatibility_iterator node = m_clientObjectList.Item( n );
+
+ return node ? (wxClientData*) node->GetData() : NULL;
}
void wxComboBox::Clear()
{
- wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-
+ wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+
+ DisableEvents();
+
GtkWidget *list = GTK_COMBO(m_widget)->list;
- gtk_list_clear_items( GTK_LIST(list), 0, Number() );
-
- wxNode *node = m_clientDataList.First();
+ gtk_list_clear_items( GTK_LIST(list), 0, GetCount() );
+
+ wxList::compatibility_iterator node = m_clientObjectList.GetFirst();
while (node)
{
- wxClientData *cd = (wxClientData*)node->Data();
+ wxClientData *cd = (wxClientData*)node->GetData();
if (cd) delete cd;
- node = node->Next();
+ node = node->GetNext();
}
+ m_clientObjectList.Clear();
+
m_clientDataList.Clear();
+
+ EnableEvents();
+
+ InvalidateBestSize();
}
void wxComboBox::Delete( int n )
{
- wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-
+ wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+
GtkList *listbox = GTK_LIST( GTK_COMBO(m_widget)->list );
-
+
GList *child = g_list_nth( listbox->children, n );
-
+
if (!child)
{
- wxFAIL_MSG("wrong index");
+ wxFAIL_MSG(wxT("wrong index"));
return;
}
-
- GList *list = g_list_append( NULL, child->data );
+
+ DisableEvents();
+
+ GList *list = g_list_append( (GList*) NULL, child->data );
gtk_list_remove_items( listbox, list );
g_list_free( list );
-
- wxNode *node = m_clientDataList.Nth( n );
- if (!node)
+
+ wxList::compatibility_iterator node = m_clientObjectList.Item( n );
+ if (node)
+ {
+ wxClientData *cd = (wxClientData*)node->GetData();
+ if (cd) delete cd;
+ m_clientObjectList.Erase( node );
+ }
+
+ node = m_clientDataList.Item( n );
+ if (node)
+ m_clientDataList.Erase( node );
+
+ EnableEvents();
+
+ InvalidateBestSize();
+}
+
+void wxComboBox::SetString(int n, const wxString &text)
+{
+ wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+
+ GtkWidget *list = GTK_COMBO(m_widget)->list;
+
+ GList *child = g_list_nth( GTK_LIST(list)->children, n );
+ if (child)
{
- wxFAIL_MSG( "wrong index" );
+ GtkBin *bin = GTK_BIN( child->data );
+ GtkLabel *label = GTK_LABEL( bin->child );
+ gtk_label_set_text(label, wxGTK_CONV(text));
}
else
{
- wxClientData *cd = (wxClientData*)node->Data();
- if (cd) delete cd;
- m_clientDataList.DeleteNode( node );
+ wxFAIL_MSG( wxT("wxComboBox: wrong index") );
}
+
+ InvalidateBestSize();
}
-int wxComboBox::FindString( const wxString &item )
+int wxComboBox::FindString( const wxString &item ) const
{
- wxCHECK_MSG( m_widget != NULL, -1, "invalid combobox" );
-
+ wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid combobox") );
+
GtkWidget *list = GTK_COMBO(m_widget)->list;
-
+
GList *child = GTK_LIST(list)->children;
int count = 0;
while (child)
{
GtkBin *bin = GTK_BIN( child->data );
GtkLabel *label = GTK_LABEL( bin->child );
- if (item == label->label) return count;
+#ifdef __WXGTK20__
+ wxString str( wxGTK_CONV_BACK( gtk_label_get_text(label) ) );
+#else
+ wxString str( label->label );
+#endif
+ if (item == str)
+ return count;
+
count++;
child = child->next;
}
-
- wxFAIL_MSG( "wxComboBox: string not found" );
-
- return -1;
+
+ return wxNOT_FOUND;
}
int wxComboBox::GetSelection() const
{
- wxCHECK_MSG( m_widget != NULL, -1, "invalid combobox" );
-
+ wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid combobox") );
+
GtkWidget *list = GTK_COMBO(m_widget)->list;
-
+
GList *selection = GTK_LIST(list)->selection;
if (selection)
{
child = child->next;
}
}
-
- wxFAIL_MSG( "wxComboBox: no selection" );
-
+
return -1;
}
wxString wxComboBox::GetString( int n ) const
{
- wxCHECK_MSG( m_widget != NULL, "", "invalid combobox" );
-
+ wxCHECK_MSG( m_widget != NULL, wxT(""), wxT("invalid combobox") );
+
GtkWidget *list = GTK_COMBO(m_widget)->list;
-
+
+ wxString str;
GList *child = g_list_nth( GTK_LIST(list)->children, n );
if (child)
{
GtkBin *bin = GTK_BIN( child->data );
GtkLabel *label = GTK_LABEL( bin->child );
- return label->label;
+#ifdef __WXGTK20__
+ str = wxGTK_CONV_BACK( gtk_label_get_text(label) );
+#else
+ str = wxString( label->label );
+#endif
+ }
+ else
+ {
+ wxFAIL_MSG( wxT("wxComboBox: wrong index") );
}
-
- wxFAIL_MSG( "wxComboBox: wrong index" );
-
- return "";
+
+ return str;
}
wxString wxComboBox::GetStringSelection() const
{
- wxCHECK_MSG( m_widget != NULL, "", "invalid combobox" );
-
+ wxCHECK_MSG( m_widget != NULL, wxT(""), wxT("invalid combobox") );
+
GtkWidget *list = GTK_COMBO(m_widget)->list;
-
+
GList *selection = GTK_LIST(list)->selection;
if (selection)
{
GtkBin *bin = GTK_BIN( selection->data );
- wxString tmp = GTK_LABEL( bin->child )->label;
+ GtkLabel *label = GTK_LABEL( bin->child );
+#ifdef __WXGTK20__
+ wxString tmp( wxGTK_CONV_BACK( gtk_label_get_text(label) ) );
+#else
+ wxString tmp( label->label );
+#endif
return tmp;
}
-
- wxFAIL_MSG( "wxComboBox: no selection" );
-
- return "";
+
+ wxFAIL_MSG( wxT("wxComboBox: no selection") );
+
+ return wxT("");
}
-int wxComboBox::Number() const
+int wxComboBox::GetCount() const
{
- wxCHECK_MSG( m_widget != NULL, 0, "invalid combobox" );
-
+ wxCHECK_MSG( m_widget != NULL, 0, wxT("invalid combobox") );
+
GtkWidget *list = GTK_COMBO(m_widget)->list;
-
+
GList *child = GTK_LIST(list)->children;
int count = 0;
while (child) { count++; child = child->next; }
void wxComboBox::SetSelection( int n )
{
- wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-
+ wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+
+ DisableEvents();
+
GtkWidget *list = GTK_COMBO(m_widget)->list;
+ gtk_list_unselect_item( GTK_LIST(list), m_prevSelection );
gtk_list_select_item( GTK_LIST(list), n );
+ m_prevSelection = n;
+
+ EnableEvents();
}
-void wxComboBox::SetStringSelection( const wxString &string )
+bool wxComboBox::SetStringSelection( const wxString &string )
{
- wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-
+ wxCHECK_MSG( m_widget != NULL, false, wxT("invalid combobox") );
+
int res = FindString( string );
- if (res == -1) return;
+ if (res == -1) return false;
SetSelection( res );
+ return true;
}
wxString wxComboBox::GetValue() const
{
- GtkWidget *entry = GTK_COMBO(m_widget)->entry;
- wxString tmp = gtk_entry_get_text( GTK_ENTRY(entry) );
+ GtkEntry *entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );
+ wxString tmp( wxGTK_CONV_BACK( gtk_entry_get_text( entry ) ) );
+
+#if 0
+ for (int i = 0; i < wxStrlen(tmp.c_str()) +1; i++)
+ {
+ wxChar c = tmp[i];
+ printf( "%d ", (int) (c) );
+ }
+ printf( "\n" );
+#endif
+
return tmp;
}
void wxComboBox::SetValue( const wxString& value )
{
- wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-
+ wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+
GtkWidget *entry = GTK_COMBO(m_widget)->entry;
- wxString tmp = "";
+ wxString tmp = wxT("");
if (!value.IsNull()) tmp = value;
- gtk_entry_set_text( GTK_ENTRY(entry), tmp );
+ gtk_entry_set_text( GTK_ENTRY(entry), wxGTK_CONV( tmp ) );
+
+ InvalidateBestSize();
}
void wxComboBox::Copy()
{
- wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-
+ wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+
GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-#if (GTK_MINOR_VERSION == 1)
- gtk_editable_copy_clipboard( GTK_EDITABLE(entry) );
-#else
- gtk_editable_copy_clipboard( GTK_EDITABLE(entry), 0 );
-#endif
+ gtk_editable_copy_clipboard( GTK_EDITABLE(entry) DUMMY_CLIPBOARD_ARG );
}
void wxComboBox::Cut()
{
- wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-
+ wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+
GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-#if (GTK_MINOR_VERSION == 1)
- gtk_editable_cut_clipboard( GTK_EDITABLE(entry) );
-#else
- gtk_editable_cut_clipboard( GTK_EDITABLE(entry), 0 );
-#endif
+ gtk_editable_cut_clipboard( GTK_EDITABLE(entry) DUMMY_CLIPBOARD_ARG );
}
void wxComboBox::Paste()
{
- wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-
+ wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+
GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-#if (GTK_MINOR_VERSION == 1)
- gtk_editable_paste_clipboard( GTK_EDITABLE(entry) );
-#else
- gtk_editable_paste_clipboard( GTK_EDITABLE(entry), 0 );
-#endif
+ gtk_editable_paste_clipboard( GTK_EDITABLE(entry) DUMMY_CLIPBOARD_ARG);
}
void wxComboBox::SetInsertionPoint( long pos )
{
- wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-
- GtkWidget *entry = GTK_COMBO(m_widget)->entry;
- int tmp = (int) pos;
- gtk_entry_set_position( GTK_ENTRY(entry), tmp );
-}
+ wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+
+ if ( pos == GetLastPosition() )
+ pos = -1;
-void wxComboBox::SetInsertionPointEnd()
-{
- wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-
GtkWidget *entry = GTK_COMBO(m_widget)->entry;
- int pos = GTK_ENTRY(entry)->text_length;
- SetInsertionPoint( pos-1 );
+ gtk_entry_set_position( GTK_ENTRY(entry), (int)pos );
}
long wxComboBox::GetInsertionPoint() const
{
- GtkWidget *entry = GTK_COMBO(m_widget)->entry;
- return (long) GTK_EDITABLE(entry)->current_pos;
+ return (long) GET_EDITABLE_POS( GTK_COMBO(m_widget)->entry );
}
long wxComboBox::GetLastPosition() const
void wxComboBox::Replace( long from, long to, const wxString& value )
{
- wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-
+ wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+
GtkWidget *entry = GTK_COMBO(m_widget)->entry;
gtk_editable_delete_text( GTK_EDITABLE(entry), (gint)from, (gint)to );
if (value.IsNull()) return;
gint pos = (gint)to;
- gtk_editable_insert_text( GTK_EDITABLE(entry), value, value.Length(), &pos );
+
+#if wxUSE_UNICODE
+ wxCharBuffer buffer = wxConvUTF8.cWX2MB( value );
+ gtk_editable_insert_text( GTK_EDITABLE(entry), (const char*) buffer, strlen( (const char*) buffer ), &pos );
+#else
+ gtk_editable_insert_text( GTK_EDITABLE(entry), value.c_str(), value.Length(), &pos );
+#endif
}
-void wxComboBox::Remove(long from, long to)
+void wxComboBox::SetSelection( long from, long to )
{
- wxCHECK_RET( m_widget != NULL, "invalid combobox" );
-
GtkWidget *entry = GTK_COMBO(m_widget)->entry;
- gtk_editable_delete_text( GTK_EDITABLE(entry), (gint)from, (gint)to );
+ gtk_editable_select_region( GTK_EDITABLE(entry), (gint)from, (gint)to );
+}
+
+void wxComboBox::SetEditable( bool editable )
+{
+ GtkWidget *entry = GTK_COMBO(m_widget)->entry;
+ gtk_entry_set_editable( GTK_ENTRY(entry), editable );
+}
+
+void wxComboBox::OnChar( wxKeyEvent &event )
+{
+ if ( event.GetKeyCode() == WXK_RETURN )
+ {
+ // GTK automatically selects an item if its in the list
+ wxCommandEvent event(wxEVT_COMMAND_TEXT_ENTER, GetId());
+ event.SetString( GetValue() );
+ event.SetInt( GetSelection() );
+ event.SetEventObject( this );
+
+ if (!GetEventHandler()->ProcessEvent( event ))
+ {
+ // This will invoke the dialog default action, such
+ // as the clicking the default button.
+
+ wxWindow *top_frame = m_parent;
+ while (top_frame->GetParent() && !(top_frame->IsTopLevel()))
+ top_frame = top_frame->GetParent();
+
+ if (top_frame && GTK_IS_WINDOW(top_frame->m_widget))
+ {
+ GtkWindow *window = GTK_WINDOW(top_frame->m_widget);
+
+ if (window->default_widget)
+ gtk_widget_activate (window->default_widget);
+ }
+ }
+
+ // Catch GTK event so that GTK doesn't open the drop
+ // down list upon RETURN.
+ return;
+ }
+
+ event.Skip();
}
-void wxComboBox::SetSelection( long WXUNUSED(from), long WXUNUSED(to) )
+void wxComboBox::DisableEvents()
{
- wxFAIL_MSG( "wxComboBox::SetSelection not implemented" );
+ gtk_signal_disconnect_by_func( GTK_OBJECT(GTK_COMBO(m_widget)->list),
+ GTK_SIGNAL_FUNC(gtk_combo_select_child_callback), (gpointer)this );
+ gtk_signal_disconnect_by_func( GTK_OBJECT(GTK_COMBO(m_widget)->entry),
+ GTK_SIGNAL_FUNC(gtk_text_changed_callback), (gpointer)this );
}
-void wxComboBox::SetEditable( bool WXUNUSED(editable) )
+void wxComboBox::EnableEvents()
{
- wxFAIL_MSG( "wxComboBox::SetEditable not implemented" );
+ gtk_signal_connect( GTK_OBJECT(GTK_COMBO(m_widget)->list), "select-child",
+ GTK_SIGNAL_FUNC(gtk_combo_select_child_callback), (gpointer)this );
+ gtk_signal_connect( GTK_OBJECT(GTK_COMBO(m_widget)->entry), "changed",
+ GTK_SIGNAL_FUNC(gtk_text_changed_callback), (gpointer)this );
}
void wxComboBox::OnSize( wxSizeEvent &event )
{
- wxControl::OnSize( event );
-
- int w = 21;
- gtk_widget_set_usize( GTK_COMBO(m_widget)->entry, m_width-w-1, m_height );
-
- gtk_widget_set_uposition( GTK_COMBO(m_widget)->button, m_x+m_width-w, m_y );
- gtk_widget_set_usize( GTK_COMBO(m_widget)->button, w, m_height );
+ // NB: In some situations (e.g. on non-first page of a wizard, if the
+ // size used is default size), GtkCombo widget is resized correctly,
+ // but it's look is not updated, it's rendered as if it was much wider.
+ // No other widgets are affected, so it looks like a bug in GTK+.
+ // Manually requesting resize calculation (as gtk_pizza_set_size does)
+ // fixes it.
+ if (GTK_WIDGET_VISIBLE(m_widget))
+ gtk_widget_queue_resize(m_widget);
+
+ event.Skip();
}
-void wxComboBox::ApplyWidgetStyle()
+void wxComboBox::DoApplyWidgetStyle(GtkRcStyle *style)
{
- SetWidgetStyle();
-
- gtk_widget_set_style( GTK_COMBO(m_widget)->button, m_widgetStyle );
- gtk_widget_set_style( GTK_COMBO(m_widget)->entry, m_widgetStyle );
- gtk_widget_set_style( GTK_COMBO(m_widget)->list, m_widgetStyle );
-
+// gtk_widget_modify_style( GTK_COMBO(m_widget)->button, syle );
+
+ gtk_widget_modify_style( GTK_COMBO(m_widget)->entry, style );
+ gtk_widget_modify_style( GTK_COMBO(m_widget)->list, style );
+
GtkList *list = GTK_LIST( GTK_COMBO(m_widget)->list );
GList *child = list->children;
while (child)
{
- gtk_widget_set_style( GTK_WIDGET(child->data), m_widgetStyle );
-
+ gtk_widget_modify_style( GTK_WIDGET(child->data), style );
+
GtkBin *bin = GTK_BIN(child->data);
- gtk_widget_set_style( bin->child, m_widgetStyle );
-
+ gtk_widget_modify_style( bin->child, style );
+
child = child->next;
}
}
return ( (window == GTK_ENTRY( GTK_COMBO(m_widget)->entry )->text_area) ||
(window == GTK_COMBO(m_widget)->button->window ) );
}
+
+wxSize wxComboBox::DoGetBestSize() const
+{
+ wxSize ret( wxControl::DoGetBestSize() );
+
+ // we know better our horizontal extent: it depends on the longest string
+ // in the combobox
+ if ( m_widget )
+ {
+ int width;
+ size_t count = GetCount();
+ for ( size_t n = 0; n < count; n++ )
+ {
+ GetTextExtent( GetString(n), &width, NULL, NULL, NULL );
+ if ( width > ret.x )
+ ret.x = width;
+ }
+ }
+
+ // empty combobox should have some reasonable default size too
+ if ( ret.x < 100 )
+ ret.x = 100;
+
+ CacheBestSize(ret);
+ return ret;
+}
+
+// static
+wxVisualAttributes
+wxComboBox::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant))
+{
+ return GetDefaultAttributesFromGTKWidget(gtk_combo_new, true);
+}
+
+#endif
projects / wxWidgets.git / blobdiff