replace @b Note with @note; replace '' with "

[wxWidgets.git] / src / generic / datavgen.cpp

diff --git a/src/generic/datavgen.cpp b/src/generic/datavgen.cpp
index fa4dd8c5c29f711a61431cdbae864ab6a4a2d578..d23b3c54ee00f3f62b7096304cf751f6c829087d 100644 (file)
--- a/src/generic/datavgen.cpp
+++ b/src/generic/datavgen.cpp
@@ -56,9 +56,6 @@ static const int SCROLL_UNIT_X = 15;
 // the cell padding on the left/right
 static const int PADDING_RIGHTLEFT = 3;
 
 // the cell padding on the left/right
 static const int PADDING_RIGHTLEFT = 3;
 

-// the cell padding on the top/bottom
-static const int PADDING_TOPBOTTOM = 1;
-

 // the expander space margin
 static const int EXPANDER_MARGIN = 4;
 
 // the expander space margin
 static const int EXPANDER_MARGIN = 4;
 


@@ -66,7 +63,16 @@ static const int EXPANDER_MARGIN = 4;
 // wxDataViewHeaderWindow
 //-----------------------------------------------------------------------------
 
 // wxDataViewHeaderWindow
 //-----------------------------------------------------------------------------
 

-#define USE_NATIVE_HEADER_WINDOW    0
+// on wxMSW the header window (only that part however) can be made native!
+#if defined(__WXMSW__) && !defined(__WXUNIVERSAL__)
+    #define USE_NATIVE_HEADER_WINDOW
+#endif
+
+//Below is the compare stuff
+//For the generic implements, both the leaf nodes and the nodes are sorted for fast search when needed
+static wxDataViewModel * g_model;
+static int g_column = -2;
+static bool g_asending = true;

 
 // NB: for some reason, this class must be dllexport'ed or we get warnings from
 //     MSVC in DLL build
 
 // NB: for some reason, this class must be dllexport'ed or we get warnings from
 //     MSVC in DLL build


@@ -106,8 +112,7 @@ protected:
     void SendEvent(wxEventType type, unsigned int n);
 };
 
     void SendEvent(wxEventType type, unsigned int n);
 };
 

-// on wxMSW the header window (only that part however) can be made native!
-#if defined(__WXMSW__) && USE_NATIVE_HEADER_WINDOW
+#ifdef USE_NATIVE_HEADER_WINDOW

 
 #define COLUMN_WIDTH_OFFSET         2
 #define wxDataViewHeaderWindowMSW   wxDataViewHeaderWindow
 
 #define COLUMN_WIDTH_OFFSET         2
 #define wxDataViewHeaderWindowMSW   wxDataViewHeaderWindow


@@ -135,18 +140,29 @@ public:
     // the column count
     virtual void UpdateDisplay();
 
     // the column count
     virtual void UpdateDisplay();
 

-    // called when the main window gets scrolled
+    virtual void OnInternalIdle();
+
+    // called Refresh afterwards

     virtual void ScrollWindow(int dx, int dy, const wxRect *rect = NULL);
 
     virtual void ScrollWindow(int dx, int dy, const wxRect *rect = NULL);
 

+    virtual wxBorder GetDefaultBorder() const { return wxBORDER_NONE; }
+

 protected:
     virtual bool MSWOnNotify(int idCtrl, WXLPARAM lParam, WXLPARAM *result);
 protected:
     virtual bool MSWOnNotify(int idCtrl, WXLPARAM lParam, WXLPARAM *result);

+

     virtual void DoSetSize(int x, int y, int width, int height, int sizeFlags);
 
     virtual void DoSetSize(int x, int y, int width, int height, int sizeFlags);
 

+    wxSize DoGetBestSize() const;
+

     unsigned int GetColumnIdxFromHeader(NMHEADER *nmHDR);
 
     wxDataViewColumn *GetColumnFromHeader(NMHEADER *nmHDR)
         { return GetColumn(GetColumnIdxFromHeader(nmHDR)); }
 
     unsigned int GetColumnIdxFromHeader(NMHEADER *nmHDR);
 
     wxDataViewColumn *GetColumnFromHeader(NMHEADER *nmHDR)
         { return GetColumn(GetColumnIdxFromHeader(nmHDR)); }
 

+    int   m_scrollOffsetX;
+    int   m_buttonHeight;
+    bool  m_delayedUpdate;
+

 private:
     DECLARE_DYNAMIC_CLASS(wxDataViewHeaderWindowMSW)
 };
 private:
     DECLARE_DYNAMIC_CLASS(wxDataViewHeaderWindowMSW)
 };


@@ -198,6 +214,7 @@ protected:
     bool                 m_isDragging;
 
     bool                 m_dirty;     // needs refresh?
     bool                 m_isDragging;
 
     bool                 m_dirty;     // needs refresh?

+    int                  m_hover;     // index of the column under the mouse

     int                  m_column;    // index of the column being resized
     int                  m_currentX;  // divider line position in logical (unscrolled) coords
     int                  m_minX;      // minimal position beyond which the divider line
     int                  m_column;    // index of the column being resized
     int                  m_currentX;  // divider line position in logical (unscrolled) coords
     int                  m_minX;      // minimal position beyond which the divider line


@@ -218,6 +235,7 @@ protected:
         m_isDragging = false;
         m_dirty = false;
 
         m_isDragging = false;
         m_dirty = false;
 

+        m_hover = wxNOT_FOUND;

         m_column = wxNOT_FOUND;
         m_currentX = 0;
         m_minX = 0;
         m_column = wxNOT_FOUND;
         m_currentX = 0;
         m_minX = 0;


@@ -226,7 +244,6 @@ protected:
         m_penCurrent = wxPen(col, 1, wxSOLID);
     }
 
         m_penCurrent = wxPen(col, 1, wxSOLID);
     }
 

-    void DrawCurrent();

     void AdjustDC(wxDC& dc);
 
 private:
     void AdjustDC(wxDC& dc);
 
 private:


@@ -254,148 +271,136 @@ public:
 // wxDataViewTreeNode
 //-----------------------------------------------------------------------------
 class wxDataViewTreeNode;
 // wxDataViewTreeNode
 //-----------------------------------------------------------------------------
 class wxDataViewTreeNode;

-WX_DEFINE_SORTED_ARRAY( wxDataViewTreeNode *, wxDataViewTreeNodes );
-WX_DEFINE_SORTED_ARRAY( void* , wxDataViewTreeLeaves);
+WX_DEFINE_ARRAY( wxDataViewTreeNode *, wxDataViewTreeNodes );
+WX_DEFINE_ARRAY( void* , wxDataViewTreeLeaves);

 
 

-int LINKAGEMODE wxGenericTreeModelNodeCmp( wxDataViewTreeNode * node1, wxDataViewTreeNode * node2);
-int LINKAGEMODE wxGenericTreeModelItemCmp( void * id1, void * id2);
+int LINKAGEMODE wxGenericTreeModelNodeCmp( wxDataViewTreeNode ** node1, wxDataViewTreeNode ** node2);
+int LINKAGEMODE wxGenericTreeModelItemCmp( void ** id1, void ** id2);

 
 class wxDataViewTreeNode
 {
 public:
     wxDataViewTreeNode( wxDataViewTreeNode * parent = NULL )
 
 class wxDataViewTreeNode
 {
 public:
     wxDataViewTreeNode( wxDataViewTreeNode * parent = NULL )

-        :leaves( wxGenericTreeModelItemCmp ),
-         nodes(wxGenericTreeModelNodeCmp)
-       { this->parent = parent;
-          if( parent == NULL )
-              open = true;
-          else
-               open = false;
-          hasChildren = false;
-          subTreeCount  = 0;
-       }
-    //I don't know what I need to do in the destructure
-    ~wxDataViewTreeNode()

     {
     {

+        m_parent = parent;
+        if (!parent)
+            m_open = true;
+        else
+            m_open = false;
+        m_hasChildren = false;
+        m_subTreeCount  = 0;
+    }

 
 

+    ~wxDataViewTreeNode()
+    {

     }
 
     }
 

-    wxDataViewTreeNode * GetParent() { return parent; }
-    void SetParent( wxDataViewTreeNode * parent ) { this->parent = parent; }
-    wxDataViewTreeNodes &  GetNodes() { return nodes; }
-    wxDataViewTreeLeaves & GetChildren() { return leaves; }
+    wxDataViewTreeNode * GetParent() { return m_parent; }
+    void SetParent( wxDataViewTreeNode * parent ) { m_parent = parent; }
+    wxDataViewTreeNodes &  GetNodes() { return m_nodes; }
+    wxDataViewTreeLeaves & GetChildren() { return m_leaves; }

 
     void AddNode( wxDataViewTreeNode * node )
     {
 
     void AddNode( wxDataViewTreeNode * node )
     {

-        nodes.Add( node );
-        leaves.Add( node->GetItem().GetID() );
+        m_leaves.Add( node->GetItem().GetID() );
+        if (g_column >= -1)
+            m_leaves.Sort( &wxGenericTreeModelItemCmp );
+        m_nodes.Add( node );
+        if (g_column >= -1)
+            m_nodes.Sort( &wxGenericTreeModelNodeCmp );
+    }
+    void AddLeaf( void * leaf )
+    {
+        m_leaves.Add( leaf );
+        if (g_column >= -1)
+            m_leaves.Sort( &wxGenericTreeModelItemCmp );

     }
     }

-    void AddLeaf( void * leaf ) { leaves.Add( leaf ); }

 
 

-    wxDataViewItem & GetItem() { return item; }
-    void SetItem( const wxDataViewItem & item ) { this->item = item; }
+    wxDataViewItem & GetItem() { return m_item; }
+    void SetItem( const wxDataViewItem & item ) { m_item = item; }

 
 

-    unsigned int GetChildrenNumber() { return leaves.GetCount(); }
-    unsigned int GetNodeNumber() { return nodes.GetCount(); }
+    unsigned int GetChildrenNumber() { return m_leaves.GetCount(); }
+    unsigned int GetNodeNumber() { return m_nodes.GetCount(); }

     int GetIndentLevel()
     {
         int ret = 0 ;
     int GetIndentLevel()
     {
         int ret = 0 ;

-        wxDataViewTreeNode * node = this;
-        while( node->GetParent()->GetParent() != NULL )
-        {
-            node = node->GetParent();
-            ret ++;
-        }
-        return ret;
+        wxDataViewTreeNode * node = this;
+        while( node->GetParent()->GetParent() != NULL )
+        {
+            node = node->GetParent();
+            ret ++;
+        }
+        return ret;

     }
 
     bool IsOpen()
     {
     }
 
     bool IsOpen()
     {

-        return open ;
+        return m_open ;

     }
 
     void ToggleOpen()
     {
     }
 
     void ToggleOpen()
     {

-        int len = nodes.GetCount();
+        int len = m_nodes.GetCount();

         int sum = 0;
         for ( int i = 0 ;i < len ; i ++)
         int sum = 0;
         for ( int i = 0 ;i < len ; i ++)

-            sum += nodes[i]->GetSubTreeCount();
+            sum += m_nodes[i]->GetSubTreeCount();

 
 

-        sum += leaves.GetCount();
-        if( open )
+        sum += m_leaves.GetCount();
+        if (m_open)

         {
             ChangeSubTreeCount(-sum);
         {
             ChangeSubTreeCount(-sum);

-            open = !open;
+            m_open = !m_open;

         }
         else
         {
         }
         else
         {

-            open = !open;
+            m_open = !m_open;

             ChangeSubTreeCount(sum);
         }
     }
             ChangeSubTreeCount(sum);
         }
     }

-    bool HasChildren() { return hasChildren; }
-    void SetHasChildren( bool has ){ hasChildren = has; }
+    bool HasChildren() { return m_hasChildren; }
+    void SetHasChildren( bool has ){ m_hasChildren = has; }

 
 

-    void SetSubTreeCount( int num ) { subTreeCount = num; }
-    int GetSubTreeCount() { return subTreeCount; }
+    void SetSubTreeCount( int num ) { m_subTreeCount = num; }
+    int GetSubTreeCount() { return m_subTreeCount; }

     void ChangeSubTreeCount( int num )
     {
     void ChangeSubTreeCount( int num )
     {

-        if( !open )
+        if( !m_open )

             return ;
             return ;

-        subTreeCount += num;
-        if( parent )
-            parent->ChangeSubTreeCount(num);
+        m_subTreeCount += num;
+        if( m_parent )
+            m_parent->ChangeSubTreeCount(num);

     }
 
     void Resort()
     {
     }
 
     void Resort()
     {

-        wxDataViewTreeNodes nds = nodes;
-        wxDataViewTreeLeaves lvs = leaves;
-        nodes.Empty();
-        leaves.Empty();
-
-        int len = nds.GetCount();
-        if(len > 0)
-        {
-                       int i;
-            for(i = 0; i < len; i ++)
-                nodes.Add(nds[i]);
-            for(i = 0; i < len; i ++)
-                nodes[i]->Resort();
-        }
-
-        len = lvs.GetCount();
-        if(len > 0)
+        if (g_column >= -1)

         {
         {

-            for(int i = 0; i < len; i++)
-                leaves.Add(lvs[i]);
+            m_nodes.Sort( &wxGenericTreeModelNodeCmp );
+            int len = m_nodes.GetCount();
+            for (int i = 0; i < len; i ++)
+                m_nodes[i]->Resort();
+            m_leaves.Sort( &wxGenericTreeModelItemCmp );

         }
     }
 
 private:
         }
     }
 
 private:

-    wxDataViewTreeNode * parent;
-    wxDataViewTreeNodes  nodes;
-    wxDataViewTreeLeaves leaves;
-    wxDataViewItem  item;
-    bool open;
-    bool hasChildren;
-    int subTreeCount;
+    wxDataViewTreeNode  *m_parent;
+    wxDataViewTreeNodes  m_nodes;
+    wxDataViewTreeLeaves m_leaves;
+    wxDataViewItem       m_item;
+    bool                 m_open;
+    bool                 m_hasChildren;
+    int                  m_subTreeCount;

 };
 
 };
 

-//Below is the compare stuff
-//For the generic implements, both the leaf nodes and the nodes are sorted for fast search when needed
-static wxDataViewModel * g_model;
-static unsigned int g_column;
-static bool g_asending;
-
-int LINKAGEMODE wxGenericTreeModelNodeCmp( wxDataViewTreeNode * node1, wxDataViewTreeNode * node2)
+int LINKAGEMODE wxGenericTreeModelNodeCmp( wxDataViewTreeNode ** node1, wxDataViewTreeNode ** node2)

 {
 {

-    return g_model->Compare( node1->GetItem(), node2->GetItem(), g_column, g_asending );
+    return g_model->Compare( (*node1)->GetItem(), (*node2)->GetItem(), g_column, g_asending );

 }
 
 }
 

-int LINKAGEMODE wxGenericTreeModelItemCmp( void * id1, void * id2)
+int LINKAGEMODE wxGenericTreeModelItemCmp( void ** id1, void ** id2)

 {
 {

-    return g_model->Compare( id1, id2, g_column, g_asending );
+    return g_model->Compare( *id1, *id2, g_column, g_asending );

 }
 
 
 }
 
 


@@ -407,7 +412,7 @@ int LINKAGEMODE wxGenericTreeModelItemCmp( void * id1, void * id2)
 WX_DEFINE_SORTED_USER_EXPORTED_ARRAY_SIZE_T(unsigned int, wxDataViewSelection,
                                             WXDLLIMPEXP_ADV);
 WX_DECLARE_LIST(wxDataViewItem, ItemList);
 WX_DEFINE_SORTED_USER_EXPORTED_ARRAY_SIZE_T(unsigned int, wxDataViewSelection,
                                             WXDLLIMPEXP_ADV);
 WX_DECLARE_LIST(wxDataViewItem, ItemList);

-WX_DEFINE_LIST(ItemList);
+WX_DEFINE_LIST(ItemList)

 
 class wxDataViewMainWindow: public wxWindow
 {
 
 class wxDataViewMainWindow: public wxWindow
 {


@@ -420,32 +425,39 @@ public:
     virtual ~wxDataViewMainWindow();
 
     // notifications from wxDataViewModel
     virtual ~wxDataViewMainWindow();
 
     // notifications from wxDataViewModel

-    void SendModelEvent( wxEventType type, const wxDataViewItem & item);

     bool ItemAdded( const wxDataViewItem &parent, const wxDataViewItem &item );
     bool ItemDeleted( const wxDataViewItem &parent, const wxDataViewItem &item );
     bool ItemChanged( const wxDataViewItem &item );
     bool ValueChanged( const wxDataViewItem &item, unsigned int col );
     bool Cleared();
     void Resort()
     bool ItemAdded( const wxDataViewItem &parent, const wxDataViewItem &item );
     bool ItemDeleted( const wxDataViewItem &parent, const wxDataViewItem &item );
     bool ItemChanged( const wxDataViewItem &item );
     bool ValueChanged( const wxDataViewItem &item, unsigned int col );
     bool Cleared();
     void Resort()

-    { 
-        SortPrepare();
-        m_root->Resort(); 
-        UpdateDisplay(); 
+    {
+        if (m_root)
+        {
+            SortPrepare();
+            m_root->Resort();
+        }
+        UpdateDisplay();

     }
 
     void SortPrepare()
     {
     }
 
     void SortPrepare()
     {

-        g_model = GetOwner()->GetModel(); 
-        g_column = GetOwner()->GetSortingColumn();
-        wxDataViewColumn * col = GetOwner()->GetColumn(g_column);
+        g_model = GetOwner()->GetModel();
+        wxDataViewColumn* col = GetOwner()->GetSortingColumn();

         if( !col )
         {
         if( !col )
         {

+            if (g_model->HasDefaultCompare())
+                g_column = -1;
+            else
+                g_column = -2;
+

             g_asending = true;
             return;
         }
             g_asending = true;
             return;
         }

-        g_asending = col->IsSortOrderAscending();    
+        g_column = col->GetModelColumn();
+        g_asending = col->IsSortOrderAscending();

     }
     }

-       
+

     void SetOwner( wxDataViewCtrl* owner ) { m_owner = owner; }
     wxDataViewCtrl *GetOwner() { return m_owner; }
     const wxDataViewCtrl *GetOwner() const { return m_owner; }
     void SetOwner( wxDataViewCtrl* owner ) { m_owner = owner; }
     wxDataViewCtrl *GetOwner() { return m_owner; }
     const wxDataViewCtrl *GetOwner() const { return m_owner; }


@@ -488,6 +500,7 @@ public:
     void SelectRows( unsigned int from, unsigned int to, bool on );
     void ReverseRowSelection( unsigned int row );
     bool IsRowSelected( unsigned int row );
     void SelectRows( unsigned int from, unsigned int to, bool on );
     void ReverseRowSelection( unsigned int row );
     bool IsRowSelected( unsigned int row );

+    void SendSelectionChangedEvent( const wxDataViewItem& item);

 
     void RefreshRow( unsigned int row );
     void RefreshRows( unsigned int from, unsigned int to );
 
     void RefreshRow( unsigned int row );
     void RefreshRows( unsigned int from, unsigned int to );


@@ -499,7 +512,6 @@ public:
         return wxSystemSettings::GetColour(wxSYS_COLOUR_3DLIGHT);
     }
 
         return wxSystemSettings::GetColour(wxSYS_COLOUR_3DLIGHT);
     }
 

-    //void EnsureVisible( unsigned int row );

     wxRect GetLineRect( unsigned int row ) const;
 
     //Some useful functions for row and item mapping
     wxRect GetLineRect( unsigned int row ) const;
 
     //Some useful functions for row and item mapping


@@ -509,8 +521,11 @@ public:
     //Methods for building the mapping tree
     void BuildTree( wxDataViewModel  * model );
     void DestroyTree();
     //Methods for building the mapping tree
     void BuildTree( wxDataViewModel  * model );
     void DestroyTree();

-    void HitTest( const wxPoint & point, wxDataViewItem & item, wxDataViewColumn* column );
+    void HitTest( const wxPoint & point, wxDataViewItem & item, wxDataViewColumn* &column );

     wxRect GetItemRect( const wxDataViewItem & item, const wxDataViewColumn* column );
     wxRect GetItemRect( const wxDataViewItem & item, const wxDataViewColumn* column );

+
+    void Expand( unsigned int row ) { OnExpanding( row ); }
+    void Collapse( unsigned int row ) { OnCollapsing( row ); }

 private:
     wxDataViewTreeNode * GetTreeNodeByRow( unsigned int row );
     //We did not need this temporarily
 private:
     wxDataViewTreeNode * GetTreeNodeByRow( unsigned int row );
     //We did not need this temporarily


@@ -555,6 +570,8 @@ private:
     //This is the tree structure of the model
     wxDataViewTreeNode * m_root;
     int m_count;
     //This is the tree structure of the model
     wxDataViewTreeNode * m_root;
     int m_count;

+    //This is the tree node under the cursor
+    wxDataViewTreeNode * m_underMouse;

 private:
     DECLARE_DYNAMIC_CLASS(wxDataViewMainWindow)
     DECLARE_EVENT_TABLE()
 private:
     DECLARE_DYNAMIC_CLASS(wxDataViewMainWindow)
     DECLARE_EVENT_TABLE()


@@ -581,7 +598,7 @@ public:
     virtual bool Cleared()
         { return m_mainWindow->Cleared(); }
     virtual void Resort()
     virtual bool Cleared()
         { return m_mainWindow->Cleared(); }
     virtual void Resort()

-        { m_mainWindow->Resort(); }
+         { m_mainWindow->Resort(); }

 
     wxDataViewMainWindow    *m_mainWindow;
 };
 
     wxDataViewMainWindow    *m_mainWindow;
 };


@@ -600,6 +617,8 @@ wxDataViewRenderer::wxDataViewRenderer( const wxString &varianttype,
     m_dc = NULL;
     m_align = align;
     m_mode = mode;
     m_dc = NULL;
     m_align = align;
     m_mode = mode;

+    m_wantsAttr = false;
+    m_hasAttr = false;

 }
 
 wxDataViewRenderer::~wxDataViewRenderer()
 }
 
 wxDataViewRenderer::~wxDataViewRenderer()


@@ -634,6 +653,16 @@ wxDataViewCustomRenderer::wxDataViewCustomRenderer( const wxString &varianttype,
 {
 }
 
 {
 }
 

+void wxDataViewCustomRenderer::RenderText( const wxString &text, int xoffset, wxRect cell, wxDC *dc, int state )
+{
+    wxDataViewCtrl *view = GetOwner()->GetOwner();
+    wxColour col = (state & wxDATAVIEW_CELL_SELECTED) ?
+                        wxSystemSettings::GetColour(wxSYS_COLOUR_HIGHLIGHTTEXT) :
+                        view->GetForegroundColour();
+    dc->SetTextForeground(col);
+    dc->DrawText( text, cell.x + xoffset, cell.y + ((cell.height - dc->GetCharHeight()) / 2));
+}
+

 // ---------------------------------------------------------
 // wxDataViewTextRenderer
 // ---------------------------------------------------------
 // ---------------------------------------------------------
 // wxDataViewTextRenderer
 // ---------------------------------------------------------


@@ -680,14 +709,7 @@ bool wxDataViewTextRenderer::GetValueFromEditorCtrl( wxControl *editor, wxVarian
 
 bool wxDataViewTextRenderer::Render( wxRect cell, wxDC *dc, int state )
 {
 
 bool wxDataViewTextRenderer::Render( wxRect cell, wxDC *dc, int state )
 {

-    wxDataViewCtrl *view = GetOwner()->GetOwner();
-    wxColour col = (state & wxDATAVIEW_CELL_SELECTED) ?
-                        wxSystemSettings::GetColour(wxSYS_COLOUR_HIGHLIGHTTEXT) :
-                        view->GetForegroundColour();
-
-    dc->SetTextForeground(col);
-    dc->DrawText( m_text, cell.x, cell.y );
-
+    RenderText( m_text, 0, cell, dc, state );

     return true;
 }
 
     return true;
 }
 


@@ -703,6 +725,60 @@ wxSize wxDataViewTextRenderer::GetSize() const
     return wxSize(80,20);
 }
 
     return wxSize(80,20);
 }
 

+// ---------------------------------------------------------
+// wxDataViewTextRendererAttr
+// ---------------------------------------------------------
+
+IMPLEMENT_CLASS(wxDataViewTextRendererAttr, wxDataViewTextRenderer)
+
+wxDataViewTextRendererAttr::wxDataViewTextRendererAttr( const wxString &varianttype,
+                            wxDataViewCellMode mode, int align ) :
+    wxDataViewTextRenderer( varianttype, mode, align )
+{
+    m_wantsAttr = true;
+}
+
+bool wxDataViewTextRendererAttr::Render( wxRect cell, wxDC *dc, int WXUNUSED(state) )
+{
+    wxFont font;
+    wxColour colour;
+
+    if (m_hasAttr)
+    {
+        if (m_attr.HasColour())
+        {
+            colour = dc->GetTextForeground();
+            dc->SetTextForeground( m_attr.GetColour() );
+        }
+
+        if (m_attr.GetBold() || m_attr.GetItalic())
+        {
+             font = dc->GetFont();
+             wxFont myfont = font;
+             if (m_attr.GetBold())
+                 myfont.SetWeight( wxFONTWEIGHT_BOLD );
+             if (m_attr.GetItalic())
+                 myfont.SetStyle( wxFONTSTYLE_ITALIC );
+             dc->SetFont( myfont );
+        }
+    }
+
+    dc->DrawText( m_text, cell.x, cell.y + ((cell.height - dc->GetCharHeight()) / 2));
+
+    // restore dc
+    if (m_hasAttr)
+    {
+        if (m_attr.HasColour())
+            dc->SetTextForeground( colour );
+
+        if (m_attr.GetBold() || m_attr.GetItalic())
+            dc->SetFont( font );
+    }
+
+    return true;
+}
+
+

 // ---------------------------------------------------------
 // wxDataViewBitmapRenderer
 // ---------------------------------------------------------
 // ---------------------------------------------------------
 // wxDataViewBitmapRenderer
 // ---------------------------------------------------------


@@ -948,12 +1024,10 @@ bool wxDataViewDateRenderer::GetValue( wxVariant &value ) const
     return true;
 }
 
     return true;
 }
 

-bool wxDataViewDateRenderer::Render( wxRect cell, wxDC *dc, int WXUNUSED(state) )
+bool wxDataViewDateRenderer::Render( wxRect cell, wxDC *dc, int state )

 {
 {

-    dc->SetFont( GetOwner()->GetOwner()->GetFont() );

     wxString tmp = m_date.FormatDate();
     wxString tmp = m_date.FormatDate();

-    dc->DrawText( tmp, cell.x, cell.y );
-
+    RenderText( tmp, 0, cell, dc, state );

     return true;
 }
 
     return true;
 }
 


@@ -986,6 +1060,80 @@ bool wxDataViewDateRenderer::Activate( wxRect WXUNUSED(cell), wxDataViewModel *m
     return true;
 }
 
     return true;
 }
 

+// ---------------------------------------------------------
+// wxDataViewIconTextRenderer
+// ---------------------------------------------------------
+
+IMPLEMENT_CLASS(wxDataViewIconTextRenderer, wxDataViewCustomRenderer)
+
+wxDataViewIconTextRenderer::wxDataViewIconTextRenderer(
+  const wxString &varianttype, wxDataViewCellMode mode, int align ) :
+    wxDataViewCustomRenderer( varianttype, mode, align )
+{
+    SetMode(mode);
+    SetAlignment(align);
+}
+
+wxDataViewIconTextRenderer::~wxDataViewIconTextRenderer()
+{
+}
+
+bool wxDataViewIconTextRenderer::SetValue( const wxVariant &value )
+{
+    m_value << value;
+    return true;
+}
+
+bool wxDataViewIconTextRenderer::GetValue( wxVariant& WXUNUSED(value) ) const
+{
+    return false;
+}
+
+bool wxDataViewIconTextRenderer::Render( wxRect cell, wxDC *dc, int state )
+{
+    int xoffset = 0;
+    const wxIcon &icon = m_value.GetIcon();
+    if (icon.IsOk())
+    {
+        dc->DrawIcon( icon, cell.x, cell.y + ((cell.height - icon.GetHeight()) / 2));
+        xoffset =  icon.GetWidth()+4;
+    }
+
+    RenderText( m_value.GetText(), xoffset, cell, dc, state );
+
+    return true;
+}
+
+wxSize wxDataViewIconTextRenderer::GetSize() const
+{
+    const wxDataViewCtrl *view = GetView();
+    if (!m_value.GetText().empty())
+    {
+        int x,y;
+        view->GetTextExtent( m_value.GetText(), &x, &y );
+
+        if (m_value.GetIcon().IsOk())
+            x += m_value.GetIcon().GetWidth() + 4;
+        return wxSize( x, y );
+    }
+    return wxSize(80,20);
+}
+
+wxControl *
+wxDataViewIconTextRenderer::CreateEditorCtrl(wxWindow * WXUNUSED(parent),
+                                             wxRect WXUNUSED(labelRect),
+                                             const wxVariant& WXUNUSED(value))
+{
+    return NULL;
+}
+
+bool
+wxDataViewIconTextRenderer::GetValueFromEditorCtrl(wxControl* WXUNUSED(editor),
+                                                   wxVariant& WXUNUSED(value))
+{
+    return false;
+}
+

 // ---------------------------------------------------------
 // wxDataViewColumn
 // ---------------------------------------------------------
 // ---------------------------------------------------------
 // wxDataViewColumn
 // ---------------------------------------------------------


@@ -1001,6 +1149,8 @@ wxDataViewColumn::wxDataViewColumn( const wxString &title, wxDataViewRenderer *c
     SetTitle(title);
     SetFlags(flags);
 
     SetTitle(title);
     SetFlags(flags);
 

+    m_autosize = width < 0;  // TODO
+

     Init(width < 0 ? wxDVC_DEFAULT_WIDTH : width);
 }
 
     Init(width < 0 ? wxDVC_DEFAULT_WIDTH : width);
 }
 


@@ -1058,6 +1208,14 @@ void wxDataViewColumn::SetSortable( bool sortable )
         GetOwner()->OnColumnChange();
 }
 
         GetOwner()->OnColumnChange();
 }
 

+void wxDataViewColumn::SetReorderable( bool reorderable )
+{
+    if (reorderable)
+        m_flags |= wxDATAVIEW_COL_REORDERABLE;
+    else
+        m_flags &= ~wxDATAVIEW_COL_REORDERABLE;
+}
+

 void wxDataViewColumn::SetSortOrder( bool ascending )
 {
     m_ascending = ascending;
 void wxDataViewColumn::SetSortOrder( bool ascending )
 {
     m_ascending = ascending;


@@ -1083,7 +1241,7 @@ void wxDataViewColumn::SetInternalWidth( int width )
 
 void wxDataViewColumn::SetWidth( int width )
 {
 
 void wxDataViewColumn::SetWidth( int width )
 {

-    m_owner->m_headerArea->UpdateDisplay();
+    if (m_owner->m_headerArea) m_owner->m_headerArea->UpdateDisplay();

 
     SetInternalWidth(width);
 }
 
     SetInternalWidth(width);
 }


@@ -1109,7 +1267,14 @@ void wxDataViewHeaderWindowBase::SendEvent(wxEventType type, unsigned int n)
     parent->GetEventHandler()->ProcessEvent(le);
 }
 
     parent->GetEventHandler()->ProcessEvent(le);
 }
 

-#if defined(__WXMSW__) && USE_NATIVE_HEADER_WINDOW
+#ifdef USE_NATIVE_HEADER_WINDOW
+
+#ifndef HDS_DRAGDROP
+    #define HDS_DRAGDROP 0x0040
+#endif
+#ifndef HDS_FULLDRAG
+    #define HDS_FULLDRAG 0x0080
+#endif

 
 // implemented in msw/listctrl.cpp:
 int WXDLLIMPEXP_CORE wxMSWGetColumnClicked(NMHDR *nmhdr, POINT *ptClick);
 
 // implemented in msw/listctrl.cpp:
 int WXDLLIMPEXP_CORE wxMSWGetColumnClicked(NMHDR *nmhdr, POINT *ptClick);


@@ -1122,17 +1287,27 @@ bool wxDataViewHeaderWindowMSW::Create( wxDataViewCtrl *parent, wxWindowID id,
 {
     m_owner = parent;
 
 {
     m_owner = parent;
 

-    if ( !CreateControl(parent, id, pos, size, 0, wxDefaultValidator, name) )
-        return false;
+    m_scrollOffsetX = 0;
+    m_delayedUpdate = false;
+    m_buttonHeight = wxRendererNative::Get().GetHeaderButtonHeight( this );

 
     int x = pos.x == wxDefaultCoord ? 0 : pos.x,
         y = pos.y == wxDefaultCoord ? 0 : pos.y,
         w = size.x == wxDefaultCoord ? 1 : size.x,
 
     int x = pos.x == wxDefaultCoord ? 0 : pos.x,
         y = pos.y == wxDefaultCoord ? 0 : pos.y,
         w = size.x == wxDefaultCoord ? 1 : size.x,

-        h = size.y == wxDefaultCoord ? 22 : size.y;
+        h = m_buttonHeight;
+
+    wxSize new_size(w,h);
+
+    if ( !CreateControl(parent, id, pos, new_size, 0, wxDefaultValidator, name) )
+        return false;

 
     // create the native WC_HEADER window:
     WXHWND hwndParent = (HWND)parent->GetHandle();
 
     // create the native WC_HEADER window:
     WXHWND hwndParent = (HWND)parent->GetHandle();

-    WXDWORD msStyle = WS_CHILD | HDS_BUTTONS | HDS_HORZ | HDS_HOTTRACK | HDS_FULLDRAG;
+    WXDWORD msStyle = WS_CHILD | HDS_DRAGDROP | HDS_BUTTONS | HDS_HORZ | HDS_HOTTRACK | HDS_FULLDRAG;
+
+    if ( m_isShown )
+        msStyle |= WS_VISIBLE;
+

     m_hWnd = CreateWindowEx(0,
                             WC_HEADER,
                             (LPCTSTR) NULL,
     m_hWnd = CreateWindowEx(0,
                             WC_HEADER,
                             (LPCTSTR) NULL,


@@ -1156,36 +1331,6 @@ bool wxDataViewHeaderWindowMSW::Create( wxDataViewCtrl *parent, wxWindowID id,
     // header windows and must be done befor sending the HDM_LAYOUT msg
     SetFont(GetFont());
 
     // header windows and must be done befor sending the HDM_LAYOUT msg
     SetFont(GetFont());
 

-    RECT rcParent;
-    HDLAYOUT hdl;
-    WINDOWPOS wp;
-
-    // Retrieve the bounding rectangle of the parent window's
-    // client area, and then request size and position values
-    // from the header control.
-    ::GetClientRect((HWND)hwndParent, &rcParent);
-
-    hdl.prc = &rcParent;
-    hdl.pwpos = &wp;
-    if (!SendMessage((HWND)m_hWnd, HDM_LAYOUT, 0, (LPARAM) &hdl))
-    {
-        wxLogLastError(_T("SendMessage"));
-        return false;
-    }
-
-    // Set the size, position, and visibility of the header control.
-    SetWindowPos((HWND)m_hWnd,
-                 wp.hwndInsertAfter,
-                 wp.x, wp.y,
-                 wp.cx, wp.cy,
-                 wp.flags | SWP_SHOWWINDOW);
-
-    // set our size hints: wxDataViewCtrl will put this wxWindow inside
-    // a wxBoxSizer and in order to avoid super-big header windows,
-    // we need to set our height as fixed
-    SetMinSize(wxSize(-1, wp.cy));
-    SetMaxSize(wxSize(-1, wp.cy));
-

     return true;
 }
 
     return true;
 }
 


@@ -1194,6 +1339,20 @@ wxDataViewHeaderWindowMSW::~wxDataViewHeaderWindow()
     UnsubclassWin();
 }
 
     UnsubclassWin();
 }
 

+wxSize wxDataViewHeaderWindowMSW::DoGetBestSize() const
+{
+    return wxSize( 80, m_buttonHeight+2 );
+}
+
+void wxDataViewHeaderWindowMSW::OnInternalIdle()
+{
+    if (m_delayedUpdate)
+    {
+        m_delayedUpdate = false;
+        UpdateDisplay();
+    }
+}
+

 void wxDataViewHeaderWindowMSW::UpdateDisplay()
 {
     // remove old columns
 void wxDataViewHeaderWindowMSW::UpdateDisplay()
 {
     // remove old columns


@@ -1203,7 +1362,6 @@ void wxDataViewHeaderWindowMSW::UpdateDisplay()
     // add the updated array of columns to the header control
     unsigned int cols = GetOwner()->GetColumnCount();
     unsigned int added = 0;
     // add the updated array of columns to the header control
     unsigned int cols = GetOwner()->GetColumnCount();
     unsigned int added = 0;

-    wxDataViewModel * model = GetOwner()->GetModel();

     for (unsigned int i = 0; i < cols; i++)
     {
         wxDataViewColumn *col = GetColumn( i );
     for (unsigned int i = 0; i < cols; i++)
     {
         wxDataViewColumn *col = GetColumn( i );


@@ -1218,13 +1376,12 @@ void wxDataViewHeaderWindowMSW::UpdateDisplay()
         hdi.fmt = HDF_LEFT | HDF_STRING;
         //hdi.fmt &= ~(HDF_SORTDOWN|HDF_SORTUP);
 
         hdi.fmt = HDF_LEFT | HDF_STRING;
         //hdi.fmt &= ~(HDF_SORTDOWN|HDF_SORTUP);
 

-        //sorting support
-        if(model && m_owner->GetSortingColumn() == i)
+        if (col->IsSortable() && GetOwner()->GetSortingColumn() == col)

         {
             //The Microsoft Comctrl32.dll 6.0 support SORTUP/SORTDOWN, but they are not default
             //see http://msdn2.microsoft.com/en-us/library/ms649534.aspx for more detail
         {
             //The Microsoft Comctrl32.dll 6.0 support SORTUP/SORTDOWN, but they are not default
             //see http://msdn2.microsoft.com/en-us/library/ms649534.aspx for more detail

-            //hdi.fmt |= model->GetSortOrderAscending()? HDF_SORTUP:HDF_SORTDOWN;
-            ;
+            // VZ: works with 5.81
+            hdi.fmt |= col->IsSortOrderAscending() ? HDF_SORTUP : HDF_SORTDOWN;

         }
 
         // lParam is reserved for application's use:
         }
 
         // lParam is reserved for application's use:


@@ -1254,7 +1411,7 @@ void wxDataViewHeaderWindowMSW::UpdateDisplay()
 
         default:
             // such alignment is not allowed for the column header!
 
         default:
             // such alignment is not allowed for the column header!

-            wxFAIL;
+            break; // wxFAIL;

         }
 
         SendMessage((HWND)m_hWnd, HDM_INSERTITEM,
         }
 
         SendMessage((HWND)m_hWnd, HDM_INSERTITEM,


@@ -1307,6 +1464,20 @@ bool wxDataViewHeaderWindowMSW::MSWOnNotify(int idCtrl, WXLPARAM lParam, WXLPARA
 
         case HDN_BEGINDRAG:
             // user has started to reorder a column
 
         case HDN_BEGINDRAG:
             // user has started to reorder a column

+            if (!GetColumn(nmHDR->iItem)->IsReorderable())
+            {
+                // veto it!
+                *result = TRUE;
+            }
+            break;
+
+        case HDN_ENDDRAG:       // user has finished reordering a column
+            {
+               wxDataViewColumn *col = GetColumn(nmHDR->iItem);
+               unsigned int new_pos = nmHDR->pitem->iOrder;
+               m_owner->ColumnMoved( col, new_pos );
+               m_delayedUpdate = true;
+            }

             break;
 
         case HDN_ITEMCHANGING:
             break;
 
         case HDN_ITEMCHANGING:


@@ -1325,7 +1496,6 @@ bool wxDataViewHeaderWindowMSW::MSWOnNotify(int idCtrl, WXLPARAM lParam, WXLPARA
 
         case HDN_ITEMCHANGED:   // user is resizing a column
         case HDN_ENDTRACK:      // user has finished resizing a column
 
         case HDN_ITEMCHANGED:   // user is resizing a column
         case HDN_ENDTRACK:      // user has finished resizing a column

-        case HDN_ENDDRAG:       // user has finished reordering a column

 
             // update the width of the modified column:
             if (nmHDR->pitem != NULL &&
 
             // update the width of the modified column:
             if (nmHDR->pitem != NULL &&


@@ -1354,14 +1524,14 @@ bool wxDataViewHeaderWindowMSW::MSWOnNotify(int idCtrl, WXLPARAM lParam, WXLPARA
                     wxDataViewColumn *col = GetColumn(idx);
                     if(col->IsSortable())
                     {
                     wxDataViewColumn *col = GetColumn(idx);
                     if(col->IsSortable())
                     {

-                        if(model && m_owner->GetSortingColumn() == idx)
+                        if(model && m_owner->GetSortingColumn() == col)

                         {
                             bool order = col->IsSortOrderAscending();
                             col->SetSortOrder(!order);
                         }
                         else if(model)
                         {
                         {
                             bool order = col->IsSortOrderAscending();
                             col->SetSortOrder(!order);
                         }
                         else if(model)
                         {

-                            m_owner->SetSortingColumn(idx);
+                            m_owner->SetSortingColumn(col);

                         }
                     }
                     UpdateDisplay();
                         }
                     }
                     UpdateDisplay();


@@ -1429,32 +1599,20 @@ bool wxDataViewHeaderWindowMSW::MSWOnNotify(int idCtrl, WXLPARAM lParam, WXLPARA
     return true;
 }
 
     return true;
 }
 

-void wxDataViewHeaderWindowMSW::ScrollWindow(int WXUNUSED(dx), int WXUNUSED(dy),
-                                             const wxRect *WXUNUSED(rect))
+void wxDataViewHeaderWindowMSW::ScrollWindow(int dx, int WXUNUSED(dy),
+                                             const wxRect * WXUNUSED(rect))

 {
 {

-    wxSize ourSz = GetClientSize();
-    wxSize ownerSz = m_owner->GetClientSize();
-
-    // where should the (logical) origin of this window be placed?
-    int x1 = 0, y1 = 0;
-    m_owner->CalcUnscrolledPosition(0, 0, &x1, &y1);
+    m_scrollOffsetX += dx;

 
 

-    // put this window on top of our parent and
-    SetWindowPos((HWND)m_hWnd, HWND_TOP, -x1, 0,
-                  ownerSz.GetWidth() + x1, ourSz.GetHeight(),
-                  SWP_SHOWWINDOW);
+    GetParent()->Layout();

 }
 
 }
 

-void wxDataViewHeaderWindowMSW::DoSetSize(int WXUNUSED(x), int WXUNUSED(y),
-                                          int WXUNUSED(w), int WXUNUSED(h),
-                                          int WXUNUSED(f))
+void wxDataViewHeaderWindowMSW::DoSetSize(int x, int y,
+                                          int w, int h,
+                                          int f)

 {
 {

-    // the wxDataViewCtrl's internal wxBoxSizer will call this function when
-    // the wxDataViewCtrl window gets resized: the following dummy call
-    // to ScrollWindow() is required in order to get this header window
-    // correctly repainted when it's (horizontally) scrolled:
-
-    ScrollWindow(0, 0);
+    // TODO: why is there a border + 2px around it?
+    wxControl::DoSetSize( x+m_scrollOffsetX+1, y+1, w-m_scrollOffsetX-2, h-2, f );

 }
 
 #else       // !defined(__WXMSW__)
 }
 
 #else       // !defined(__WXMSW__)


@@ -1525,7 +1683,7 @@ void wxGenericDataViewHeaderWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
         int ch = h;
 
         wxHeaderSortIconType sortArrow = wxHDR_SORT_ICON_NONE;
         int ch = h;
 
         wxHeaderSortIconType sortArrow = wxHDR_SORT_ICON_NONE;

-        if (col->IsSortable() && GetOwner()->GetSortingColumn() == i)
+        if (col->IsSortable() && GetOwner()->GetSortingColumn() == col)

         {
             if (col->IsSortOrderAscending())
                 sortArrow = wxHDR_SORT_ICON_UP;
         {
             if (col->IsSortOrderAscending())
                 sortArrow = wxHDR_SORT_ICON_UP;


@@ -1533,13 +1691,23 @@ void wxGenericDataViewHeaderWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
                 sortArrow = wxHDR_SORT_ICON_DOWN;
         }
 
                 sortArrow = wxHDR_SORT_ICON_DOWN;
         }
 

+        int state = 0;
+        if (m_parent->IsEnabled())
+        {
+            if ((int) i == m_hover)
+                state = wxCONTROL_CURRENT;
+        }
+        else
+        {
+            state = (int) wxCONTROL_DISABLED;
+        }
+

         wxRendererNative::Get().DrawHeaderButton
                                 (
                                     this,
                                     dc,
                                     wxRect(xpos, 0, cw, ch-1),
         wxRendererNative::Get().DrawHeaderButton
                                 (
                                     this,
                                     dc,
                                     wxRect(xpos, 0, cw, ch-1),

-                                    m_parent->IsEnabled() ? 0
-                                                          : (int)wxCONTROL_DISABLED,
+                                    state,

                                     sortArrow
                                 );
 
                                     sortArrow
                                 );
 


@@ -1551,13 +1719,14 @@ void wxGenericDataViewHeaderWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
         case wxALIGN_LEFT:
             x += HEADER_HORIZ_BORDER;
             break;
         case wxALIGN_LEFT:
             x += HEADER_HORIZ_BORDER;
             break;

+        case wxALIGN_RIGHT:
+            x += cw - titleSz.GetWidth() - HEADER_HORIZ_BORDER;
+            break;
+        default:

         case wxALIGN_CENTER:
         case wxALIGN_CENTER_HORIZONTAL:
             x += (cw - titleSz.GetWidth() - 2 * HEADER_HORIZ_BORDER)/2;
             break;
         case wxALIGN_CENTER:
         case wxALIGN_CENTER_HORIZONTAL:
             x += (cw - titleSz.GetWidth() - 2 * HEADER_HORIZ_BORDER)/2;
             break;

-        case wxALIGN_RIGHT:
-            x += cw - titleSz.GetWidth() - HEADER_HORIZ_BORDER;
-            break;

         }
 
         // always center the title vertically:
         }
 
         // always center the title vertically:


@@ -1596,10 +1765,6 @@ void wxGenericDataViewHeaderWindow::OnMouse( wxMouseEvent &event )
         m_owner->CalcUnscrolledPosition(w, 0, &w, NULL);
         w -= 6;
 
         m_owner->CalcUnscrolledPosition(w, 0, &w, NULL);
         w -= 6;
 

-        // erase the line if it was drawn
-        if (m_currentX < w)
-            DrawCurrent();
-

         if (event.ButtonUp())
         {
             m_isDragging = false;
         if (event.ButtonUp())
         {
             m_isDragging = false;


@@ -1607,19 +1772,15 @@ void wxGenericDataViewHeaderWindow::OnMouse( wxMouseEvent &event )
                 ReleaseMouse();
 
             m_dirty = true;
                 ReleaseMouse();
 
             m_dirty = true;

+        }
+        m_currentX = wxMax(m_minX + 7, x);

 
 

+        if (m_currentX < w)
+        {

             GetColumn(m_column)->SetWidth(m_currentX - m_minX);
             GetColumn(m_column)->SetWidth(m_currentX - m_minX);

-

             Refresh();
             GetOwner()->Refresh();
         }
             Refresh();
             GetOwner()->Refresh();
         }

-        else
-        {
-            m_currentX = wxMax(m_minX + 7, x);
-
-            // draw in the new location
-            if (m_currentX < w) DrawCurrent();
-        }

 
     }
     else     // not dragging
 
     }
     else     // not dragging


@@ -1658,6 +1819,13 @@ void wxGenericDataViewHeaderWindow::OnMouse( wxMouseEvent &event )
             m_minX = xpos;
         }
 
             m_minX = xpos;
         }
 

+        int old_hover = m_hover;
+        m_hover = m_column;
+        if (event.Leaving())
+            m_hover = wxNOT_FOUND;
+        if (old_hover != m_hover)
+            Refresh();
+

         if (m_column == wxNOT_FOUND)
             return;
 
         if (m_column == wxNOT_FOUND)
             return;
 


@@ -1674,7 +1842,6 @@ void wxGenericDataViewHeaderWindow::OnMouse( wxMouseEvent &event )
                 m_isDragging = true;
                 CaptureMouse();
                 m_currentX = x;
                 m_isDragging = true;
                 CaptureMouse();
                 m_currentX = x;

-                DrawCurrent();

             }
             else    // click on a column
             {
             }
             else    // click on a column
             {


@@ -1690,15 +1857,15 @@ void wxGenericDataViewHeaderWindow::OnMouse( wxMouseEvent &event )
                     wxDataViewColumn *col = GetColumn(m_column);
                     if(col->IsSortable())
                     {
                     wxDataViewColumn *col = GetColumn(m_column);
                     if(col->IsSortable())
                     {

-                        unsigned int colnum = m_owner->GetSortingColumn();
-                        if(model && static_cast<int>(colnum) == m_column)
+                        wxDataViewColumn* sortCol = m_owner->GetSortingColumn();
+                        if(model && sortCol == col)

                         {
                             bool order = col->IsSortOrderAscending();
                             col->SetSortOrder(!order);
                         }
                         else if(model)
                         {
                         {
                             bool order = col->IsSortOrderAscending();
                             col->SetSortOrder(!order);
                         }
                         else if(model)
                         {

-                            m_owner->SetSortingColumn(m_column);
+                            m_owner->SetSortingColumn(col);

                         }
                     }
                     UpdateDisplay();
                         }
                     }
                     UpdateDisplay();


@@ -1721,28 +1888,6 @@ void wxGenericDataViewHeaderWindow::OnMouse( wxMouseEvent &event )
     }
 }
 
     }
 }
 

-void wxGenericDataViewHeaderWindow::DrawCurrent()
-{
-    int x1 = m_currentX;
-    int y1 = 0;
-    ClientToScreen (&x1, &y1);
-
-    int x2 = m_currentX-1;
-#ifdef __WXMSW__
-    ++x2; // but why ????
-#endif
-    int y2 = 0;
-    m_owner->GetClientSize( NULL, &y2 );
-    m_owner->ClientToScreen( &x2, &y2 );
-
-    wxScreenDC dc;
-    dc.SetLogicalFunction(wxINVERT);
-    dc.SetPen(m_penCurrent);
-    dc.SetBrush(*wxTRANSPARENT_BRUSH);
-    AdjustDC(dc);
-    dc.DrawLine(x1, y1, x2, y2);
-}
-

 void wxGenericDataViewHeaderWindow::AdjustDC(wxDC& dc)
 {
     int xpix, x;
 void wxGenericDataViewHeaderWindow::AdjustDC(wxDC& dc)
 {
     int xpix, x;


@@ -1798,7 +1943,7 @@ END_EVENT_TABLE()
 
 wxDataViewMainWindow::wxDataViewMainWindow( wxDataViewCtrl *parent, wxWindowID id,
     const wxPoint &pos, const wxSize &size, const wxString &name ) :
 
 wxDataViewMainWindow::wxDataViewMainWindow( wxDataViewCtrl *parent, wxWindowID id,
     const wxPoint &pos, const wxSize &size, const wxString &name ) :

-    wxWindow( parent, id, pos, size, wxWANTS_CHARS, name ),
+    wxWindow( parent, id, pos, size, wxWANTS_CHARS|wxBORDER_NONE, name ),

     m_selection( wxDataViewSelectionCmp )
 
 {
     m_selection( wxDataViewSelectionCmp )
 
 {


@@ -1811,14 +1956,7 @@ wxDataViewMainWindow::wxDataViewMainWindow( wxDataViewCtrl *parent, wxWindowID i
     m_currentCol = NULL;
     m_currentRow = 0;
 
     m_currentCol = NULL;
     m_currentRow = 0;
 

-    // TODO: we need to calculate this smartly
-    m_lineHeight =
-#ifdef __WXMSW__
-        17;
-#else
-        20;
-#endif
-    wxASSERT(m_lineHeight > 2*PADDING_TOPBOTTOM);
+    m_lineHeight = wxMax( 17, GetCharHeight() + 2 ); // 17 = mini icon height + 1

 
     m_dragCount = 0;
     m_dragStart = wxPoint(0,0);
 
     m_dragCount = 0;
     m_dragStart = wxPoint(0,0);


@@ -1828,19 +1966,21 @@ wxDataViewMainWindow::wxDataViewMainWindow( wxDataViewCtrl *parent, wxWindowID i
 
     m_hasFocus = false;
 
 
     m_hasFocus = false;
 

-    SetBackgroundStyle( wxBG_STYLE_CUSTOM );

     SetBackgroundColour( *wxWHITE );
 
     SetBackgroundColour( *wxWHITE );
 

-    m_penRule = wxPen(GetRuleColour(), 1, wxSOLID);
+    SetBackgroundStyle(wxBG_STYLE_CUSTOM);
+
+    m_penRule = wxPen(GetRuleColour());

 
     //Here I compose a pen can draw black lines, maybe there are something system colour to use
 
     //Here I compose a pen can draw black lines, maybe there are something system colour to use

-    m_penExpander = wxPen( wxColour(0,0,0), 1, wxSOLID );
+    m_penExpander = wxPen(wxColour(0,0,0));

     //Some new added code to deal with the tree structure
     m_root = new wxDataViewTreeNode( NULL );
     m_root->SetHasChildren(true);
 
     //Make m_count = -1 will cause the class recaculate the real displaying number of rows.
     m_count = -1 ;
     //Some new added code to deal with the tree structure
     m_root = new wxDataViewTreeNode( NULL );
     m_root->SetHasChildren(true);
 
     //Make m_count = -1 will cause the class recaculate the real displaying number of rows.
     m_count = -1 ;

+    m_underMouse = NULL;

     UpdateDisplay();
 }
 
     UpdateDisplay();
 }
 


@@ -1850,34 +1990,308 @@ wxDataViewMainWindow::~wxDataViewMainWindow()
     delete m_renameTimer;
 }
 
     delete m_renameTimer;
 }
 

-void wxDataViewMainWindow::OnRenameTimer()
+void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )

 {
 {

-    // We have to call this here because changes may just have
-    // been made and no screen update taken place.
-    if ( m_dirty )
-        wxSafeYield();
+    wxDataViewModel *model = GetOwner()->GetModel();
+    wxAutoBufferedPaintDC dc( this );

 
 

-    int xpos = 0;
+#ifdef __WXMSW__
+    dc.SetPen( *wxTRANSPARENT_PEN );
+    dc.SetBrush( wxBrush( GetBackgroundColour()) );
+    dc.SetBrush( *wxWHITE_BRUSH );
+    wxSize size( GetClientSize() );
+    dc.DrawRectangle( 0,0,size.x,size.y );
+#endif
+
+    // prepare the DC
+    GetOwner()->PrepareDC( dc );
+    dc.SetFont( GetFont() );
+
+    wxRect update = GetUpdateRegion().GetBox();
+    m_owner->CalcUnscrolledPosition( update.x, update.y, &update.x, &update.y );
+
+    // compute which items needs to be redrawn
+    unsigned int item_start = wxMax( 0, (update.y / m_lineHeight) );
+    unsigned int item_count =
+        wxMin( (int)(((update.y + update.height) / m_lineHeight) - item_start + 1),
+               (int)(GetRowCount( ) - item_start));
+    unsigned int item_last = item_start + item_count;
+
+    // compute which columns needs to be redrawn

     unsigned int cols = GetOwner()->GetColumnCount();
     unsigned int cols = GetOwner()->GetColumnCount();

-    unsigned int i;
-    for (i = 0; i < cols; i++)
+    unsigned int col_start = 0;
+    unsigned int x_start = 0;
+    for (x_start = 0; col_start < cols; col_start++)

     {
     {

-        wxDataViewColumn *c = GetOwner()->GetColumn( i );
-        if (c->IsHidden())
+        wxDataViewColumn *col = GetOwner()->GetColumn(col_start);
+        if (col->IsHidden())

             continue;      // skip it!
 
             continue;      // skip it!
 

-        if (c == m_currentCol)
+        unsigned int w = col->GetWidth();
+        if (x_start+w >= (unsigned int)update.x)

             break;
             break;

-        xpos += c->GetWidth();
-    }
-    wxRect labelRect( xpos, m_currentRow * m_lineHeight,
-                      m_currentCol->GetWidth(), m_lineHeight );

 
 

-    GetOwner()->CalcScrolledPosition( labelRect.x, labelRect.y,
-                                     &labelRect.x, &labelRect.y);
+        x_start += w;
+    }
+
+    unsigned int col_last = col_start;
+    unsigned int x_last = x_start;
+    for (; col_last < cols; col_last++)
+    {
+        wxDataViewColumn *col = GetOwner()->GetColumn(col_last);
+        if (col->IsHidden())
+            continue;      // skip it!
+
+        if (x_last > (unsigned int)update.GetRight())
+            break;
+
+        x_last += col->GetWidth();
+    }
+
+    // Draw horizontal rules if required
+    if ( m_owner->HasFlag(wxDV_HORIZ_RULES) )
+    {
+        dc.SetPen(m_penRule);
+        dc.SetBrush(*wxTRANSPARENT_BRUSH);
+
+        for (unsigned int i = item_start; i <= item_last+1; i++)
+        {
+            int y = i * m_lineHeight;
+            dc.DrawLine(x_start, y, x_last, y);
+        }
+    }
+
+    // Draw vertical rules if required
+    if ( m_owner->HasFlag(wxDV_VERT_RULES) )
+    {
+        dc.SetPen(m_penRule);
+        dc.SetBrush(*wxTRANSPARENT_BRUSH);
+
+        int x = x_start;
+        for (unsigned int i = col_start; i < col_last; i++)
+        {
+            wxDataViewColumn *col = GetOwner()->GetColumn(i);
+            if (col->IsHidden())
+                continue;       // skip it
+
+            dc.DrawLine(x, item_start * m_lineHeight,
+                        x, item_last * m_lineHeight);
+
+            x += col->GetWidth();
+        }
+
+        // Draw last vertical rule
+        dc.DrawLine(x, item_start * m_lineHeight,
+                    x, item_last * m_lineHeight);
+    }
+
+    // redraw the background for the items which are selected/current
+    for (unsigned int item = item_start; item < item_last; item++)
+    {
+        bool selected = m_selection.Index( item ) != wxNOT_FOUND;
+        if (selected || item == m_currentRow)
+        {
+            int flags = selected ? (int)wxCONTROL_SELECTED : 0;
+            if (item == m_currentRow)
+                flags |= wxCONTROL_CURRENT;
+            if (m_hasFocus)
+                flags |= wxCONTROL_FOCUSED;
+
+            wxRect rect( x_start, item*m_lineHeight, x_last, m_lineHeight );
+            wxRendererNative::Get().DrawItemSelectionRect
+                                (
+                                    this,
+                                    dc,
+                                    rect,
+                                    flags
+                                );
+        }
+    }
+
+    wxDataViewColumn *expander = GetOwner()->GetExpanderColumn();
+    if (!expander)
+    {
+        // TODO: last column for RTL support
+        expander = GetOwner()->GetColumn( 0 );
+        GetOwner()->SetExpanderColumn(expander);
+    }
+
+    // redraw all cells for all rows which must be repainted and for all columns
+    wxRect cell_rect;
+    cell_rect.x = x_start;
+    cell_rect.height = m_lineHeight;        // -1 is for the horizontal rules
+    for (unsigned int i = col_start; i < col_last; i++)
+    {
+        wxDataViewColumn *col = GetOwner()->GetColumn( i );
+        wxDataViewRenderer *cell = col->GetRenderer();
+        cell_rect.width = col->GetWidth();
+
+        if (col->IsHidden())
+            continue;       // skipt it!
+
+
+        for (unsigned int item = item_start; item < item_last; item++)
+        {
+            // get the cell value and set it into the renderer
+            wxVariant value;
+            wxDataViewTreeNode *node = NULL;
+            wxDataViewItem dataitem;
+
+            if (m_root)
+            {
+                node = GetTreeNodeByRow(item);
+                if( node == NULL )
+                    continue;
+
+                dataitem = node->GetItem();
+
+                if ((i > 0) && model->IsContainer(dataitem) && !model->HasContainerColumns(dataitem))
+                    continue;
+            }
+            else
+            {
+                dataitem = wxDataViewItem( (void*) item );
+            }
+
+            model->GetValue( value, dataitem, col->GetModelColumn());
+            cell->SetValue( value );
+
+            if (cell->GetWantsAttr())
+            {
+                wxDataViewItemAttr attr;
+                bool ret = model->GetAttr( dataitem, col->GetModelColumn(), attr );
+                if (ret)
+                    cell->SetAttr( attr );
+                cell->SetHasAttr( ret );
+            }
+
+            // update the y offset
+            cell_rect.y = item * m_lineHeight;
+
+            //Draw the expander here.
+            int indent = 0;
+            if ((m_root) && (col == expander))
+            {
+                indent = node->GetIndentLevel();
+
+                //Calculate the indent first
+                indent = cell_rect.x + GetOwner()->GetIndent() * indent;
+
+                int expander_width = m_lineHeight - 2*EXPANDER_MARGIN;
+                // change the cell_rect.x to the appropriate pos
+                int  expander_x = indent + EXPANDER_MARGIN , expander_y = cell_rect.y + EXPANDER_MARGIN ;
+                indent = indent + m_lineHeight ;  //try to use the m_lineHeight as the expander space
+                dc.SetPen( m_penExpander );
+                dc.SetBrush( wxNullBrush );
+                if( node->HasChildren() )
+                {
+                    wxRect rect( expander_x , expander_y, expander_width, expander_width);
+                    int flag = 0;
+                    if (m_underMouse == node)
+                    {
+                        flag |= wxCONTROL_CURRENT;
+                    }
+                    if( node->IsOpen() )
+                        wxRendererNative::Get().DrawTreeItemButton( this, dc, rect, flag|wxCONTROL_EXPANDED );
+                    else
+                        wxRendererNative::Get().DrawTreeItemButton( this, dc, rect, flag);
+                }
+                else
+                {
+                     // I am wondering whether we should draw dot lines between tree nodes
+                     if (node)
+                         delete node;
+                     // Yes, if the node does not have any child, it must be a leaf which
+                     // mean that it is a temporarily created by GetTreeNodeByRow
+                }
+
+                 //force the expander column to left-center align
+                 cell->SetAlignment( wxALIGN_CENTER_VERTICAL );
+            }
+
+
+            // cannot be bigger than allocated space
+            wxSize size = cell->GetSize();
+            // Because of the tree structure indent, here we should minus the width of the cell for drawing
+            size.x = wxMin( size.x + 2*PADDING_RIGHTLEFT, cell_rect.width - indent );
+            // size.y = wxMin( size.y, cell_rect.height );
+            size.y = cell_rect.height;
+
+            wxRect item_rect(cell_rect.GetTopLeft(), size);
+            int align = cell->GetAlignment();
+
+            // horizontal alignment:
+            item_rect.x = cell_rect.x;
+            if (align & wxALIGN_CENTER_HORIZONTAL)
+                item_rect.x = cell_rect.x + (cell_rect.width / 2) - (size.x / 2);
+            else if (align & wxALIGN_RIGHT)
+                item_rect.x = cell_rect.x + cell_rect.width - size.x;
+            //else: wxALIGN_LEFT is the default
+
+            // vertical alignment:
+            item_rect.y = cell_rect.y;
+            if (align & wxALIGN_CENTER_VERTICAL)
+                item_rect.y = cell_rect.y + (cell_rect.height / 2) - (size.y / 2);
+            else if (align & wxALIGN_BOTTOM)
+                item_rect.y = cell_rect.y + cell_rect.height - size.y;
+            //else: wxALIGN_TOP is the default
+
+            // add padding
+            item_rect.x += PADDING_RIGHTLEFT;
+            item_rect.width = size.x - 2 * PADDING_RIGHTLEFT;
+
+            //Here we add the tree indent
+            item_rect.x += indent;
+
+            int state = 0;
+            if (m_hasFocus && (m_selection.Index(item) != wxNOT_FOUND))
+                state |= wxDATAVIEW_CELL_SELECTED;
+
+            // TODO: it would be much more efficient to create a clipping
+            //       region for the entire column being rendered (in the OnPaint
+            //       of wxDataViewMainWindow) instead of a single clip region for
+            //       each cell. However it would mean that each renderer should
+            //       respect the given wxRect's top & bottom coords, eventually
+            //       violating only the left & right coords - however the user can
+            //       make its own renderer and thus we cannot be sure of that.
+            dc.SetClippingRegion( item_rect );
+            cell->Render( item_rect, &dc, state );
+            dc.DestroyClippingRegion();
+        }
+
+        cell_rect.x += cell_rect.width;
+    }
+}
+
+void wxDataViewMainWindow::OnRenameTimer()
+{
+    // We have to call this here because changes may just have
+    // been made and no screen update taken place.
+    if ( m_dirty )
+        wxSafeYield();
+
+    int xpos = 0;
+    unsigned int cols = GetOwner()->GetColumnCount();
+    unsigned int i;
+    for (i = 0; i < cols; i++)
+    {
+        wxDataViewColumn *c = GetOwner()->GetColumn( i );
+        if (c->IsHidden())
+            continue;      // skip it!
+
+        if (c == m_currentCol)
+            break;
+        xpos += c->GetWidth();
+    }
+    wxRect labelRect( xpos, m_currentRow * m_lineHeight,
+                      m_currentCol->GetWidth(), m_lineHeight );
+
+    GetOwner()->CalcScrolledPosition( labelRect.x, labelRect.y,
+                                     &labelRect.x, &labelRect.y);

 
     wxDataViewItem item = GetItemByRow( m_currentRow );
     m_currentCol->GetRenderer()->StartEditing( item, labelRect );
 
     wxDataViewItem item = GetItemByRow( m_currentRow );
     m_currentCol->GetRenderer()->StartEditing( item, labelRect );

+

 }
 
 //------------------------------------------------------------------
 }
 
 //------------------------------------------------------------------


@@ -1900,7 +2314,7 @@ public:
 
 bool Walker( wxDataViewTreeNode * node, DoJob & func )
 {
 
 bool Walker( wxDataViewTreeNode * node, DoJob & func )
 {

-    if( node==NULL ||  !node->HasChildren())
+    if( node==NULL )

         return false;
 
     switch( func( node ) )
         return false;
 
     switch( func( node ) )


@@ -1948,25 +2362,19 @@ bool Walker( wxDataViewTreeNode * node, DoJob & func )
     return false;
 }
 
     return false;
 }
 

-void wxDataViewMainWindow::SendModelEvent( wxEventType type, const wxDataViewItem & item )
-{
-    wxWindow *parent = GetParent();
-    wxDataViewEvent le(type, parent->GetId());
-
-    le.SetEventObject(parent);
-    le.SetModel(GetOwner()->GetModel());
-    le.SetItem( item );
-
-    parent->GetEventHandler()->ProcessEvent(le);
-}
-

 bool wxDataViewMainWindow::ItemAdded(const wxDataViewItem & parent, const wxDataViewItem & item)
 {
 bool wxDataViewMainWindow::ItemAdded(const wxDataViewItem & parent, const wxDataViewItem & item)
 {

+    if (!m_root)
+    {
+        m_count++;
+        UpdateDisplay();
+        return true;
+    }
+

     SortPrepare();
 
     wxDataViewTreeNode * node;
     node = FindNode(parent);
     SortPrepare();
 
     wxDataViewTreeNode * node;
     node = FindNode(parent);

-    SendModelEvent(wxEVT_COMMAND_DATAVIEW_MODEL_ITEM_ADDED, item );

 
     if( node == NULL )
         return false;
 
     if( node == NULL )
         return false;


@@ -1996,28 +2404,42 @@ void DestroyTreeHelper( wxDataViewTreeNode * node);
 bool wxDataViewMainWindow::ItemDeleted(const wxDataViewItem& parent,
                                        const wxDataViewItem& item)
 {
 bool wxDataViewMainWindow::ItemDeleted(const wxDataViewItem& parent,
                                        const wxDataViewItem& item)
 {

-    SortPrepare();
+    if (!m_root)
+    {
+        m_count--;
+        if( m_currentRow > GetRowCount() )
+            m_currentRow = m_count - 1;

 
 

-    wxDataViewTreeNode * node;
-    node = FindNode(parent);
+        m_selection.Empty();

 
 

-    SendModelEvent(wxEVT_COMMAND_DATAVIEW_MODEL_ITEM_DELETED, item);
-    if( node == NULL || node->GetChildren().Index( item.GetID() ) == wxNOT_FOUND )
-    {
-        return false;
+        UpdateDisplay();
+
+        return true;

     }
 
     }
 

+    wxDataViewTreeNode * node = FindNode(parent);
+
+    wxCHECK_MSG( node != NULL, false, "item not found" );
+    wxCHECK_MSG( node->GetChildren().Index( item.GetID() ) != wxNOT_FOUND, false, "item not found" );
+

     int sub = -1;
     node->GetChildren().Remove( item.GetID() );
     //Manuplate selection
     if( m_selection.GetCount() > 1 )
     {
     int sub = -1;
     node->GetChildren().Remove( item.GetID() );
     //Manuplate selection
     if( m_selection.GetCount() > 1 )
     {

-        int row = m_selection[0];

         m_selection.Empty();
         m_selection.Empty();

-        m_selection.Add(row);

     }
     }

-
-    if( GetOwner()->GetModel()->IsContainer( item ) )
+    bool isContainer = false;
+    wxDataViewTreeNodes nds = node->GetNodes();
+    for (size_t i = 0; i < nds.GetCount(); i ++)
+    {
+        if (nds[i]->GetItem() == item)
+        {
+            isContainer = true;
+            break;
+        }
+    }
+    if( isContainer )

     {
         wxDataViewTreeNode * n = NULL;
         wxDataViewTreeNodes nodes = node->GetNodes();
     {
         wxDataViewTreeNode * n = NULL;
         wxDataViewTreeNodes nodes = node->GetNodes();


@@ -2031,25 +2453,27 @@ bool wxDataViewMainWindow::ItemDeleted(const wxDataViewItem& parent,
             }
         }
 
             }
         }
 

-        if (!n)
-            return false;
+        wxCHECK_MSG( n != NULL, false, "item not found" );

 
         node->GetNodes().Remove( n );
         sub -= n->GetSubTreeCount();
         DestroyTreeHelper(n);
     }
 
         node->GetNodes().Remove( n );
         sub -= n->GetSubTreeCount();
         DestroyTreeHelper(n);
     }

-
-    if( node->GetChildrenNumber() == 0)
-        node->SetHasChildren( false );
-

     //Make the row number invalid and get a new valid one when user call GetRowCount
     m_count = -1;
     node->ChangeSubTreeCount(sub);
     //Make the row number invalid and get a new valid one when user call GetRowCount
     m_count = -1;
     node->ChangeSubTreeCount(sub);

+    if( node->GetChildrenNumber() == 0)
+    {
+        node->GetParent()->GetNodes().Remove( node );
+        delete node;
+    }
+

     //Change the current row to the last row if the current exceed the max row number
     if( m_currentRow > GetRowCount() )
         m_currentRow = m_count - 1;
 
     UpdateDisplay();
     //Change the current row to the last row if the current exceed the max row number
     if( m_currentRow > GetRowCount() )
         m_currentRow = m_count - 1;
 
     UpdateDisplay();

+

     return true;
 }
 
     return true;
 }
 


@@ -2058,7 +2482,13 @@ bool wxDataViewMainWindow::ItemChanged(const wxDataViewItem & item)
     SortPrepare();
     g_model->Resort();
 
     SortPrepare();
     g_model->Resort();
 

-    SendModelEvent(wxEVT_COMMAND_DATAVIEW_MODEL_ITEM_CHANGED,item);
+    //Send event
+    wxWindow *parent = GetParent();
+    wxDataViewEvent le(wxEVT_COMMAND_DATAVIEW_ITEM_VALUE_CHANGED, parent->GetId());
+    le.SetEventObject(parent);
+    le.SetModel(GetOwner()->GetModel());
+    le.SetItem(item);
+    parent->GetEventHandler()->ProcessEvent(le);

 
     return true;
 }
 
     return true;
 }


@@ -2079,7 +2509,7 @@ bool wxDataViewMainWindow::ValueChanged( const wxDataViewItem & item, unsigned i
 
     //Send event
     wxWindow *parent = GetParent();
 
     //Send event
     wxWindow *parent = GetParent();

-    wxDataViewEvent le(wxEVT_COMMAND_DATAVIEW_MODEL_VALUE_CHANGED, parent->GetId());
+    wxDataViewEvent le(wxEVT_COMMAND_DATAVIEW_ITEM_VALUE_CHANGED, parent->GetId());

     le.SetEventObject(parent);
     le.SetModel(GetOwner()->GetModel());
     le.SetItem(item);
     le.SetEventObject(parent);
     le.SetModel(GetOwner()->GetModel());
     le.SetItem(item);


@@ -2092,17 +2522,13 @@ bool wxDataViewMainWindow::ValueChanged( const wxDataViewItem & item, unsigned i
 
 bool wxDataViewMainWindow::Cleared()
 {
 
 bool wxDataViewMainWindow::Cleared()
 {

+    DestroyTree();
+

     SortPrepare();
     SortPrepare();

+    BuildTree( GetOwner()->GetModel() );

 
 

-    DestroyTree();

     UpdateDisplay();
 
     UpdateDisplay();
 

-    wxWindow *parent = GetParent();
-    wxDataViewEvent le(wxEVT_COMMAND_DATAVIEW_MODEL_CLEARED, parent->GetId());
-    le.SetEventObject(parent);
-    le.SetModel(GetOwner()->GetModel());
-    parent->GetEventHandler()->ProcessEvent(le);
-

     return true;
 }
 
     return true;
 }
 


@@ -2137,283 +2563,52 @@ void wxDataViewMainWindow::RecalculateDisplay()
     SetVirtualSize( width, height );
     GetOwner()->SetScrollRate( 10, m_lineHeight );
 
     SetVirtualSize( width, height );
     GetOwner()->SetScrollRate( 10, m_lineHeight );
 

-    Refresh();
-}
-
-void wxDataViewMainWindow::ScrollWindow( int dx, int dy, const wxRect *rect )
-{
-    wxWindow::ScrollWindow( dx, dy, rect );
-
-    if (GetOwner()->m_headerArea)
-        GetOwner()->m_headerArea->ScrollWindow( dx, 0 );
-}
-
-void wxDataViewMainWindow::ScrollTo( int rows, int column )
-{
-    int x, y;
-    m_owner->GetScrollPixelsPerUnit( &x, &y );
-    int sy = rows*m_lineHeight/y;
-    int sx = 0;
-    if( column != -1 )
-    {
-        wxRect rect = GetClientRect();
-        unsigned int colnum = 0;
-        unsigned int x_start = 0, x_end = 0, w = 0;
-        int xx, yy, xe;
-        m_owner->CalcUnscrolledPosition( rect.x, rect.y, &xx, &yy );
-        for (x_start = 0; colnum < column; colnum++)
-        {
-            wxDataViewColumn *col = GetOwner()->GetColumn(colnum);
-            if (col->IsHidden())
-                continue;      // skip it!
-
-            w = col->GetWidth();
-            x_start += w;
-        }
-
-        x_end = x_start + w;
-        xe = xx + rect.width;
-        if( x_end > xe )
-        {
-            sx = ( xx + x_end - xe )/x;
-        }
-        if( x_start < xx )
-        {
-            sx = x_start/x; 
-        }
-    }
-    m_owner->Scroll( sx, sy );
-}
-
-void wxDataViewMainWindow::OnPaint( wxPaintEvent &WXUNUSED(event) )
-{
-    wxDataViewModel *model = GetOwner()->GetModel();
-    wxAutoBufferedPaintDC dc( this );
-
-    // prepare the DC
-    dc.SetBackground(GetBackgroundColour());
-    dc.Clear();
-    GetOwner()->PrepareDC( dc );
-    dc.SetFont( GetFont() );
-
-    wxRect update = GetUpdateRegion().GetBox();
-    m_owner->CalcUnscrolledPosition( update.x, update.y, &update.x, &update.y );
-
-    // compute which items needs to be redrawn
-    unsigned int item_start = wxMax( 0, (update.y / m_lineHeight) );
-    unsigned int item_count =
-        wxMin( (int)(((update.y + update.height) / m_lineHeight) - item_start + 1),
-               (int)(GetRowCount( )- item_start) );
-    unsigned int item_last = item_start + item_count;
-
-    // compute which columns needs to be redrawn
-    unsigned int cols = GetOwner()->GetColumnCount();
-    unsigned int col_start = 0;
-    unsigned int x_start = 0;
-    for (x_start = 0; col_start < cols; col_start++)
-    {
-        wxDataViewColumn *col = GetOwner()->GetColumn(col_start);
-        if (col->IsHidden())
-            continue;      // skip it!
-
-        unsigned int w = col->GetWidth();
-        if (x_start+w >= (unsigned int)update.x)
-            break;
-
-        x_start += w;
-    }
-
-    unsigned int col_last = col_start;
-    unsigned int x_last = x_start;
-    for (; col_last < cols; col_last++)
-    {
-        wxDataViewColumn *col = GetOwner()->GetColumn(col_last);
-        if (col->IsHidden())
-            continue;      // skip it!
-
-        if (x_last > (unsigned int)update.GetRight())
-            break;
-
-        x_last += col->GetWidth();
-    }
-
-    // Draw horizontal rules if required
-    if ( m_owner->HasFlag(wxDV_HORIZ_RULES) )
-    {
-        dc.SetPen(m_penRule);
-        dc.SetBrush(*wxTRANSPARENT_BRUSH);
-
-        for (unsigned int i = item_start; i <= item_last+1; i++)
-        {
-            int y = i * m_lineHeight;
-            dc.DrawLine(x_start, y, x_last, y);
-        }
-    }
-
-    // Draw vertical rules if required
-    if ( m_owner->HasFlag(wxDV_VERT_RULES) )
-    {
-        dc.SetPen(m_penRule);
-        dc.SetBrush(*wxTRANSPARENT_BRUSH);
-
-        int x = x_start;
-        for (unsigned int i = col_start; i < col_last; i++)
-        {
-            wxDataViewColumn *col = GetOwner()->GetColumn(i);
-            if (col->IsHidden())
-                continue;       // skip it
-
-            dc.DrawLine(x, item_start * m_lineHeight,
-                        x, item_last * m_lineHeight);
-
-            x += col->GetWidth();
-        }
-
-        // Draw last vertical rule
-        dc.DrawLine(x, item_start * m_lineHeight,
-                    x, item_last * m_lineHeight);
-    }
-
-    // redraw the background for the items which are selected/current
-    for (unsigned int item = item_start; item < item_last; item++)
-    {
-        bool selected = m_selection.Index( item ) != wxNOT_FOUND;
-        if (selected || item == m_currentRow)
-        {
-            int flags = selected ? (int)wxCONTROL_SELECTED : 0;
-            if (item == m_currentRow)
-                flags |= wxCONTROL_CURRENT;
-            if (m_hasFocus)
-                flags |= wxCONTROL_FOCUSED;
-
-            wxRect rect( x_start, item*m_lineHeight, x_last, m_lineHeight );
-            wxRendererNative::Get().DrawItemSelectionRect
-                                (
-                                    this,
-                                    dc,
-                                    rect,
-                                    flags
-                                );
-        }
-    }
-
-    // redraw all cells for all rows which must be repainted and for all columns
-    wxRect cell_rect;
-    cell_rect.x = x_start;
-    cell_rect.height = m_lineHeight;        // -1 is for the horizontal rules
-    for (unsigned int i = col_start; i < col_last; i++)
-    {
-        wxDataViewColumn *col = GetOwner()->GetColumn( i );
-        wxDataViewRenderer *cell = col->GetRenderer();
-        cell_rect.width = col->GetWidth();
-
-        if (col->IsHidden())
-            continue;       // skipt it!
-
-        for (unsigned int item = item_start; item < item_last; item++)
-        {
-            // get the cell value and set it into the renderer
-            wxVariant value;
-            wxDataViewTreeNode * node = GetTreeNodeByRow(item);
-            if( node == NULL )
-            {
-                continue;
-            }
-
-            wxDataViewItem dataitem = node->GetItem();
-            model->GetValue( value, dataitem, col->GetModelColumn());
-            cell->SetValue( value );
-
-            // update the y offset
-            cell_rect.y = item * m_lineHeight;
-
-            //Draw the expander here.
-            int indent = node->GetIndentLevel();
-            if( col->GetModelColumn() == GetOwner()->GetExpanderColumn() )
-            {
-                //Calculate the indent first
-                indent = cell_rect.x + GetOwner()->GetIndent() * indent;
-
-                int expander_width = m_lineHeight - 2*EXPANDER_MARGIN;
-                // change the cell_rect.x to the appropriate pos
-                int  expander_x = indent + EXPANDER_MARGIN , expander_y = cell_rect.y + EXPANDER_MARGIN ;
-                indent = indent + m_lineHeight ;  //try to use the m_lineHeight as the expander space
-                dc.SetPen( m_penExpander );
-                dc.SetBrush( wxNullBrush );
-                if( node->HasChildren() )
-                {
-                    //dc.DrawRoundedRectangle( expander_x,expander_y,expander_width,expander_width, 1.0);
-                    //dc.DrawLine( expander_x + 2 , expander_y + expander_width/2, expander_x + expander_width - 2, expander_y + expander_width/2 );
-                    wxRect rect( expander_x , expander_y, expander_width, expander_width);
-                    if( node->IsOpen() )
-                        wxRendererNative::Get().DrawTreeItemButton( this, dc, rect, wxCONTROL_EXPANDED );
-                    else
-                        wxRendererNative::Get().DrawTreeItemButton( this, dc, rect );
-                }
-                else
-                {
-                     // I am wandering whether we should draw dot lines between tree nodes
-                     delete node;
-                     //Yes, if the node does not have any child, it must be a leaf which mean that it is a temporarily created by GetTreeNodeByRow
-                }
-
-                 //force the expander column to left-center align
-                 cell->SetAlignment( wxALIGN_CENTER_VERTICAL );
-            }
-
-
-            // cannot be bigger than allocated space
-            wxSize size = cell->GetSize();
-            // Because of the tree structure indent, here we should minus the width of the cell for drawing
-            size.x = wxMin( size.x + 2*PADDING_RIGHTLEFT, cell_rect.width - indent );
-            size.y = wxMin( size.y + 2*PADDING_TOPBOTTOM, cell_rect.height );
-
-            wxRect item_rect(cell_rect.GetTopLeft(), size);
-            int align = cell->GetAlignment();
-
-            // horizontal alignment:
-            item_rect.x = cell_rect.x;
-            if (align & wxALIGN_CENTER_HORIZONTAL)
-                item_rect.x = cell_rect.x + (cell_rect.width / 2) - (size.x / 2);
-            else if (align & wxALIGN_RIGHT)
-                item_rect.x = cell_rect.x + cell_rect.width - size.x;
-            //else: wxALIGN_LEFT is the default
-
-            // vertical alignment:
-            item_rect.y = cell_rect.y;
-            if (align & wxALIGN_CENTER_VERTICAL)
-                item_rect.y = cell_rect.y + (cell_rect.height / 2) - (size.y / 2);
-            else if (align & wxALIGN_BOTTOM)
-                item_rect.y = cell_rect.y + cell_rect.height - size.y;
-            //else: wxALIGN_TOP is the default
-
-            // add padding
-            item_rect.x += PADDING_RIGHTLEFT;
-            item_rect.y += PADDING_TOPBOTTOM;
-            item_rect.width = size.x - 2 * PADDING_RIGHTLEFT;
-            item_rect.height = size.y - 2 * PADDING_TOPBOTTOM;
+    Refresh();
+}

 
 

-            //Here we add the tree indent
-            item_rect.x += indent;
+void wxDataViewMainWindow::ScrollWindow( int dx, int dy, const wxRect *rect )
+{
+    wxWindow::ScrollWindow( dx, dy, rect );

 
 

-            int state = 0;
-            if (m_selection.Index(item) != wxNOT_FOUND)
-                state |= wxDATAVIEW_CELL_SELECTED;
+    if (GetOwner()->m_headerArea)
+        GetOwner()->m_headerArea->ScrollWindow( dx, 0 );
+}

 
 

-            // TODO: it would be much more efficient to create a clipping
-            //       region for the entire column being rendered (in the OnPaint
-            //       of wxDataViewMainWindow) instead of a single clip region for
-            //       each cell. However it would mean that each renderer should
-            //       respect the given wxRect's top & bottom coords, eventually
-            //       violating only the left & right coords - however the user can
-            //       make its own renderer and thus we cannot be sure of that.
-            dc.SetClippingRegion( item_rect );
-            cell->Render( item_rect, &dc, state );
-            dc.DestroyClippingRegion();
+void wxDataViewMainWindow::ScrollTo( int rows, int column )
+{
+    int x, y;
+    m_owner->GetScrollPixelsPerUnit( &x, &y );
+    int sy = rows*m_lineHeight/y;
+    int sx = 0;
+    if( column != -1 )
+    {
+        wxRect rect = GetClientRect();
+        int colnum = 0;
+        int x_start = 0, x_end = 0, w = 0;
+        int xx, yy, xe;
+        m_owner->CalcUnscrolledPosition( rect.x, rect.y, &xx, &yy );
+        for (x_start = 0; colnum < column; colnum++)
+        {
+            wxDataViewColumn *col = GetOwner()->GetColumn(colnum);
+            if (col->IsHidden())
+                continue;      // skip it!
+
+            w = col->GetWidth();
+            x_start += w;

         }
 
         }
 

-        cell_rect.x += cell_rect.width;
+        x_end = x_start + w;
+        xe = xx + rect.width;
+        if( x_end > xe )
+        {
+            sx = ( xx + x_end - xe )/x;
+        }
+        if( x_start < xx )
+        {
+            sx = x_start/x;
+        }

     }
     }

+    m_owner->Scroll( sx, sy );

 }
 
 int wxDataViewMainWindow::GetCountPerPage() const
 }
 
 int wxDataViewMainWindow::GetCountPerPage() const


@@ -2452,11 +2647,9 @@ unsigned int wxDataViewMainWindow::GetLastVisibleRow()
     m_owner->CalcUnscrolledPosition( client_size.x, client_size.y,
                                      &client_size.x, &client_size.y );
 
     m_owner->CalcUnscrolledPosition( client_size.x, client_size.y,
                                      &client_size.x, &client_size.y );
 

-    //we should deal with the pixel here 
-    unsigned int row = (client_size.y)/m_lineHeight;
-    if( client_size.y % m_lineHeight < m_lineHeight/2 )
-        row -= 1;
-    
+    //we should deal with the pixel here
+    unsigned int row = ((client_size.y)/m_lineHeight) - 1;
+

     return wxMin( GetRowCount()-1, row );
 }
 
     return wxMin( GetRowCount()-1, row );
 }
 


@@ -2579,6 +2772,18 @@ bool wxDataViewMainWindow::IsRowSelected( unsigned int row )
     return (m_selection.Index( row ) != wxNOT_FOUND);
 }
 
     return (m_selection.Index( row ) != wxNOT_FOUND);
 }
 

+void wxDataViewMainWindow::SendSelectionChangedEvent( const wxDataViewItem& item)
+{
+    wxWindow *parent = GetParent();
+    wxDataViewEvent le(wxEVT_COMMAND_DATAVIEW_SELECTION_CHANGED, parent->GetId());
+
+    le.SetEventObject(parent);
+    le.SetModel(GetOwner()->GetModel());
+    le.SetItem( item );
+
+    parent->GetEventHandler()->ProcessEvent(le);
+}
+

 void wxDataViewMainWindow::RefreshRow( unsigned int row )
 {
     wxRect rect( 0, row*m_lineHeight, GetEndOfLastCol(), m_lineHeight );
 void wxDataViewMainWindow::RefreshRow( unsigned int row )
 {
     wxRect rect( 0, row*m_lineHeight, GetEndOfLastCol(), m_lineHeight );


@@ -2653,6 +2858,8 @@ void wxDataViewMainWindow::OnArrowChar(unsigned int newCurrent, const wxKeyEvent
         }
 
         SelectRows( oldCurrent, newCurrent, true );
         }
 
         SelectRows( oldCurrent, newCurrent, true );

+        if (oldCurrent!=newCurrent)
+            SendSelectionChangedEvent(GetItemByRow(m_selection[0]));

     }
     else // !shift
     {
     }
     else // !shift
     {


@@ -2665,12 +2872,15 @@ void wxDataViewMainWindow::OnArrowChar(unsigned int newCurrent, const wxKeyEvent
         ChangeCurrentRow( newCurrent );
 
         if ( !event.ControlDown() )
         ChangeCurrentRow( newCurrent );
 
         if ( !event.ControlDown() )

+        {

             SelectRow( m_currentRow, true );
             SelectRow( m_currentRow, true );

+            SendSelectionChangedEvent(GetItemByRow(m_currentRow));
+        }

         else
             RefreshRow( m_currentRow );
     }
 
         else
             RefreshRow( m_currentRow );
     }
 

-    //EnsureVisible( m_currentRow );
+    GetOwner()->EnsureVisible( m_currentRow, -1 );

 }
 
 wxRect wxDataViewMainWindow::GetLineRect( unsigned int row ) const
 }
 
 wxRect wxDataViewMainWindow::GetLineRect( unsigned int row ) const


@@ -2694,7 +2904,7 @@ public:
     {
         current ++;
         if( current == static_cast<int>(row))
     {
         current ++;
         if( current == static_cast<int>(row))

-        {
+         {

             ret = node->GetItem() ;
             return DoJob::OK;
         }
             ret = node->GetItem() ;
             return DoJob::OK;
         }


@@ -2722,7 +2932,7 @@ public:
     {
         current ++;
         if( current == static_cast<int>(row))
     {
         current ++;
         if( current == static_cast<int>(row))

-        {
+         {

             ret = wxDataViewItem( n ) ;
             return DoJob::OK;
         }
             ret = wxDataViewItem( n ) ;
             return DoJob::OK;
         }


@@ -2737,9 +2947,16 @@ private:
 
 wxDataViewItem wxDataViewMainWindow::GetItemByRow(unsigned int row) const
 {
 
 wxDataViewItem wxDataViewMainWindow::GetItemByRow(unsigned int row) const
 {

-    RowToItemJob job( row, -2 );
-    Walker( m_root , job );
-    return job.GetResult();
+    if (!m_root)
+    {
+        return wxDataViewItem( (void*) row );
+    }
+    else
+    {
+        RowToItemJob job( row, -2 );
+        Walker( m_root , job );
+        return job.GetResult();
+    }

 }
 
 class RowToTreeNodeJob: public DoJob
 }
 
 class RowToTreeNodeJob: public DoJob


@@ -2758,7 +2975,7 @@ public:
     {
         current ++;
         if( current == static_cast<int>(row))
     {
         current ++;
         if( current == static_cast<int>(row))

-        {
+         {

             ret = node ;
             return DoJob::OK;
         }
             ret = node ;
             return DoJob::OK;
         }


@@ -2792,7 +3009,7 @@ public:
     {
         current ++;
         if( current == static_cast<int>(row))
     {
         current ++;
         if( current == static_cast<int>(row))

-        {
+         {

             ret = new wxDataViewTreeNode( parent ) ;
             ret->SetItem( wxDataViewItem( n ));
             ret->SetHasChildren(false);
             ret = new wxDataViewTreeNode( parent ) ;
             ret->SetItem( wxDataViewItem( n ));
             ret->SetHasChildren(false);


@@ -2812,9 +3029,16 @@ private:
 
 wxDataViewTreeNode * wxDataViewMainWindow::GetTreeNodeByRow(unsigned int row)
 {
 
 wxDataViewTreeNode * wxDataViewMainWindow::GetTreeNodeByRow(unsigned int row)
 {

-    RowToTreeNodeJob job( row , -2, m_root );
-    Walker( m_root , job );
-    return job.GetResult();
+    if (!m_root)
+    {
+        return NULL;
+    }
+    else
+    {
+        RowToTreeNodeJob job( row , -2, m_root );
+        Walker( m_root , job );
+        return job.GetResult();
+    }

 }
 
 wxDataViewEvent wxDataViewMainWindow::SendExpanderEvent( wxEventType type, const wxDataViewItem & item )
 }
 
 wxDataViewEvent wxDataViewMainWindow::SendExpanderEvent( wxEventType type, const wxDataViewItem & item )


@@ -2843,11 +3067,14 @@ void wxDataViewMainWindow::OnExpanding( unsigned int row )
                //Check if the user prevent expanding
                if( e.GetSkipped() )
                     return;
                //Check if the user prevent expanding
                if( e.GetSkipped() )
                     return;

-               
+

                node->ToggleOpen();
                //Here I build the children of current node
                if( node->GetChildrenNumber() == 0 )
                node->ToggleOpen();
                //Here I build the children of current node
                if( node->GetChildrenNumber() == 0 )

+               {
+                   SortPrepare();

                    BuildTreeHelper(GetOwner()->GetModel(), node->GetItem(), node);
                    BuildTreeHelper(GetOwner()->GetModel(), node->GetItem(), node);

+               }

                m_count = -1;
                UpdateDisplay();
                //Send the expanded event
                m_count = -1;
                UpdateDisplay();
                //Send the expanded event


@@ -2858,6 +3085,7 @@ void wxDataViewMainWindow::OnExpanding( unsigned int row )
                 SelectRow( row, false );
                 SelectRow( row + 1, true );
                 ChangeCurrentRow( row + 1 );
                 SelectRow( row, false );
                 SelectRow( row + 1, true );
                 ChangeCurrentRow( row + 1 );

+                SendSelectionChangedEvent( GetItemByRow(row+1));

             }
         }
         else
             }
         }
         else


@@ -2893,6 +3121,7 @@ void wxDataViewMainWindow::OnCollapsing(unsigned int row)
                     SelectRow( row, false);
                     SelectRow(parent , true );
                     ChangeCurrentRow( parent );
                     SelectRow( row, false);
                     SelectRow(parent , true );
                     ChangeCurrentRow( parent );

+                    SendSelectionChangedEvent( node->GetItem() );

                 }
             }
         }
                 }
             }
         }


@@ -2921,21 +3150,28 @@ wxDataViewTreeNode * wxDataViewMainWindow::FindNode( const wxDataViewItem & item
     //Find the item along the parent-chain.
     //This algorithm is designed to speed up the node-finding method
     wxDataViewTreeNode * node = m_root;
     //Find the item along the parent-chain.
     //This algorithm is designed to speed up the node-finding method
     wxDataViewTreeNode * node = m_root;

-    for( ItemList::Node * n = list.GetFirst(); n; n = n->GetNext() )
+    for( ItemList::const_iterator iter = list.begin(); iter !=list.end() ; iter++ )

     {
         if( node->HasChildren() )
         {
             if( node->GetChildrenNumber() == 0 )
     {
         if( node->HasChildren() )
         {
             if( node->GetChildrenNumber() == 0 )

+            {
+                SortPrepare();

                 BuildTreeHelper(model, node->GetItem(), node);
                 BuildTreeHelper(model, node->GetItem(), node);

+            }

 
             wxDataViewTreeNodes nodes = node->GetNodes();
 
             wxDataViewTreeNodes nodes = node->GetNodes();

-            //The wxSortedArray search a node in binary search, so using Item() is more efficient
-            wxDataViewTreeNode temp;
-            temp.SetItem(*(n->GetData()));
-            int index = nodes.Index( &temp );
-            if( index == wxNOT_FOUND )
+            unsigned int i = 0;
+            for (; i < nodes.GetCount(); i ++)
+            {
+                if (nodes[i]->GetItem() == (**iter))
+                {
+                    node = nodes[i];
+                    break;
+                }
+            }
+            if (i == nodes.GetCount())

                 return NULL;
                 return NULL;

-            node = nodes[index];

         }
         else
             return NULL;
         }
         else
             return NULL;


@@ -2943,7 +3179,7 @@ wxDataViewTreeNode * wxDataViewMainWindow::FindNode( const wxDataViewItem & item
     return node;
 }
 
     return node;
 }
 

-void wxDataViewMainWindow::HitTest( const wxPoint & point, wxDataViewItem & item, wxDataViewColumn* column )
+void wxDataViewMainWindow::HitTest( const wxPoint & point, wxDataViewItem & item, wxDataViewColumn* &column )

 {
     wxDataViewColumn *col = NULL;
     unsigned int cols = GetOwner()->GetColumnCount();
 {
     wxDataViewColumn *col = NULL;
     unsigned int cols = GetOwner()->GetColumnCount();


@@ -2989,14 +3225,26 @@ wxRect wxDataViewMainWindow::GetItemRect( const wxDataViewItem & item, const wxD
 
 int wxDataViewMainWindow::RecalculateCount()
 {
 
 int wxDataViewMainWindow::RecalculateCount()
 {

-    return m_root->GetSubTreeCount();
+    if (!m_root)
+    {
+        wxDataViewIndexListModel *list_model = (wxDataViewIndexListModel*) GetOwner()->GetModel();
+#ifndef __WXMAC__
+        return list_model->GetLastIndex() + 1;
+#else
+        return list_model->GetLastIndex() - 1;
+#endif
+    }
+    else
+    {
+        return m_root->GetSubTreeCount();
+    }

 }
 
 class ItemToRowJob : public DoJob
 {
 public:
 }
 
 class ItemToRowJob : public DoJob
 {
 public:

-    ItemToRowJob(const wxDataViewItem & item, ItemList::Node * node )
-    { this->item = item ; ret = -1 ; nd = node ; }
+    ItemToRowJob(const wxDataViewItem & item, ItemList::const_iterator iter )
+    { this->item = item ; ret = -1 ; m_iter = iter ; }

     virtual ~ItemToRowJob(){};
 
     //Maybe binary search will help to speed up this process
     virtual ~ItemToRowJob(){};
 
     //Maybe binary search will help to speed up this process


@@ -3008,9 +3256,9 @@ public:
              return DoJob::OK;
          }
 
              return DoJob::OK;
          }
 

-         if( nd && node->GetItem() == *(nd->GetData()))
+         if( node->GetItem() == **m_iter )

          {
          {

-             nd = nd->GetNext();
+             m_iter++ ;

              return DoJob::CONT;
          }
          else
              return DoJob::CONT;
          }
          else


@@ -3031,7 +3279,7 @@ public:
     //the row number is begin from zero
     int GetResult(){ return ret -1 ; }
 private:
     //the row number is begin from zero
     int GetResult(){ return ret -1 ; }
 private:

-    ItemList::Node * nd;
+    ItemList::const_iterator  m_iter;

     wxDataViewItem item;
     int ret;
 
     wxDataViewItem item;
     int ret;
 


@@ -3043,26 +3291,33 @@ int wxDataViewMainWindow::GetRowByItem(const wxDataViewItem & item)
     if( model == NULL )
         return -1;
 
     if( model == NULL )
         return -1;
 

-    if( !item.IsOk() )
-        return -1;
-
-    //Compose the a parent-chain of the finding item
-    ItemList list;
-    wxDataViewItem * pItem = NULL;
-    list.DeleteContents( true );
-    wxDataViewItem it( item );
-    while( it.IsOk() )
+    if (!m_root)

     {
     {

-        pItem = new wxDataViewItem( it );
-        list.Insert( pItem );
-        it = model->GetParent( it );
+        return wxPtrToUInt( item.GetID() );

     }
     }

-    pItem = new wxDataViewItem( );
-    list.Insert( pItem );
+    else
+    {
+        if( !item.IsOk() )
+            return -1;
+
+        //Compose the a parent-chain of the finding item
+        ItemList list;
+        wxDataViewItem * pItem = NULL;
+        list.DeleteContents( true );
+        wxDataViewItem it( item );
+        while( it.IsOk() )
+        {
+            pItem = new wxDataViewItem( it );
+            list.Insert( pItem );
+            it = model->GetParent( it );
+        }
+        pItem = new wxDataViewItem( );
+        list.Insert( pItem );

 
 

-    ItemToRowJob job( item, list.GetFirst() );
-    Walker(m_root , job );
-    return job.GetResult();
+        ItemToRowJob job( item, list.begin() );
+        Walker(m_root , job );
+        return job.GetResult();
+    }

 }
 
 void BuildTreeHelper( wxDataViewModel * model,  wxDataViewItem & item, wxDataViewTreeNode * node)
 }
 
 void BuildTreeHelper( wxDataViewModel * model,  wxDataViewItem & item, wxDataViewTreeNode * node)


@@ -3070,23 +3325,23 @@ void BuildTreeHelper( wxDataViewModel * model,  wxDataViewItem & item, wxDataVie
     if( !model->IsContainer( item ) )
         return ;
 
     if( !model->IsContainer( item ) )
         return ;
 

-    wxDataViewItem i = model->GetFirstChild( item );
-    int num = 0;
-    while( i.IsOk() )
+    wxDataViewItemArray children;
+    unsigned int num = model->GetChildren( item, children);
+    unsigned int index = 0;
+    while( index < num )

     {
     {

-        num ++;
-        if( model->IsContainer( i ) )
+        if( model->IsContainer( children[index] ) )

         {
             wxDataViewTreeNode * n = new wxDataViewTreeNode( node );
         {
             wxDataViewTreeNode * n = new wxDataViewTreeNode( node );

-            n->SetItem(i);
+            n->SetItem(children[index]);

             n->SetHasChildren( true ) ;
             node->AddNode( n );
         }
         else
         {
             n->SetHasChildren( true ) ;
             node->AddNode( n );
         }
         else
         {

-            node->AddLeaf( i.GetID() );
+            node->AddLeaf( children[index].GetID() );

         }
         }

-        i = model->GetNextSibling( i );
+        index ++;

     }
     node->SetSubTreeCount( num );
     wxDataViewTreeNode * n = node->GetParent();
     }
     node->SetSubTreeCount( num );
     wxDataViewTreeNode * n = node->GetParent();


@@ -3097,6 +3352,17 @@ void BuildTreeHelper( wxDataViewModel * model,  wxDataViewItem & item, wxDataVie
 
 void wxDataViewMainWindow::BuildTree(wxDataViewModel * model)
 {
 
 void wxDataViewMainWindow::BuildTree(wxDataViewModel * model)
 {

+    DestroyTree();
+
+    if (GetOwner()->GetModel()->IsIndexListModel())
+    {
+        m_count = -1 ;
+        return;
+    }
+
+    m_root = new wxDataViewTreeNode( NULL );
+    m_root->SetHasChildren(true);
+

     //First we define a invalid item to fetch the top-level elements
     wxDataViewItem item;
     SortPrepare();
     //First we define a invalid item to fetch the top-level elements
     wxDataViewItem item;
     SortPrepare();


@@ -3121,23 +3387,18 @@ void DestroyTreeHelper( wxDataViewTreeNode * node )
 
 void wxDataViewMainWindow::DestroyTree()
 {
 
 void wxDataViewMainWindow::DestroyTree()
 {

-    DestroyTreeHelper(m_root);
-    m_root->SetSubTreeCount(0);
-    m_count = 0 ;
+    if (m_root)
+    {
+        DestroyTreeHelper(m_root);
+        m_count = 0;
+        m_root = NULL;
+    }

 }
 
 void wxDataViewMainWindow::OnChar( wxKeyEvent &event )
 {
 }
 
 void wxDataViewMainWindow::OnChar( wxKeyEvent &event )
 {

-    if (event.GetKeyCode() == WXK_TAB)
-    {
-        wxNavigationKeyEvent nevent;
-        nevent.SetWindowChange( event.ControlDown() );
-        nevent.SetDirection( !event.ShiftDown() );
-        nevent.SetEventObject( GetParent()->GetParent() );
-        nevent.SetCurrentFocus( m_parent );
-        if (GetParent()->GetParent()->GetEventHandler()->ProcessEvent( nevent ))
-            return;
-    }
+    if ( HandleAsNavigationKey(event) )
+        return;

 
     // no item -> nothing to do
     if (!HasCurrentRow())
 
     // no item -> nothing to do
     if (!HasCurrentRow())


@@ -3152,6 +3413,20 @@ void wxDataViewMainWindow::OnChar( wxKeyEvent &event )
 
     switch ( event.GetKeyCode() )
     {
 
     switch ( event.GetKeyCode() )
     {

+        case WXK_RETURN:
+        {
+            if (m_currentRow > 0)
+            {
+                wxWindow *parent = GetParent();
+                wxDataViewEvent le(wxEVT_COMMAND_DATAVIEW_ITEM_ACTIVATED, parent->GetId());
+                le.SetItem( GetItemByRow(m_currentRow) );
+                le.SetEventObject(parent);
+                le.SetModel(GetOwner()->GetModel());
+
+                parent->GetEventHandler()->ProcessEvent(le);
+            }
+            break;
+        }

         case WXK_UP:
             if ( m_currentRow > 0 )
                 OnArrowChar( m_currentRow - 1, event );
         case WXK_UP:
             if ( m_currentRow > 0 )
                 OnArrowChar( m_currentRow - 1, event );


@@ -3163,11 +3438,11 @@ void wxDataViewMainWindow::OnChar( wxKeyEvent &event )
             break;
         //Add the process for tree expanding/collapsing
         case WXK_LEFT:
             break;
         //Add the process for tree expanding/collapsing
         case WXK_LEFT:

-            OnCollapsing(m_currentRow);
-            break;
-        case WXK_RIGHT:
-            OnExpanding( m_currentRow);
-            break;
+         OnCollapsing(m_currentRow);
+         break;
+     case WXK_RIGHT:
+         OnExpanding( m_currentRow);
+         break;

         case WXK_END:
             if (!IsEmpty())
                 OnArrowChar( GetRowCount() - 1, event );
         case WXK_END:
             if (!IsEmpty())
                 OnArrowChar( GetRowCount() - 1, event );


@@ -3218,7 +3493,6 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
     int x = event.GetX();
     int y = event.GetY();
     m_owner->CalcUnscrolledPosition( x, y, &x, &y );
     int x = event.GetX();
     int y = event.GetY();
     m_owner->CalcUnscrolledPosition( x, y, &x, &y );

-

     wxDataViewColumn *col = NULL;
 
     int xpos = 0;
     wxDataViewColumn *col = NULL;
 
     int xpos = 0;


@@ -3239,16 +3513,55 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
     }
     if (!col)
         return;
     }
     if (!col)
         return;

-    wxDataViewRenderer *cell = col->GetRenderer();

 
 

+    wxDataViewRenderer *cell = col->GetRenderer();

     unsigned int current = y / m_lineHeight;
     unsigned int current = y / m_lineHeight;

-

     if ((current > GetRowCount()) || (x > GetEndOfLastCol()))
     {
         // Unselect all if below the last row ?
         return;
     }
 
     if ((current > GetRowCount()) || (x > GetEndOfLastCol()))
     {
         // Unselect all if below the last row ?
         return;
     }
 

+    //Test whether the mouse is hovered on the tree item button
+    bool hover = false;
+    if ((m_root) && (GetOwner()->GetExpanderColumn() == col))
+    {
+        wxDataViewTreeNode * node = GetTreeNodeByRow(current);
+        if( node!=NULL && node->HasChildren() )
+        {
+            int indent = node->GetIndentLevel();
+            indent = GetOwner()->GetIndent()*indent;
+            wxRect rect( xpos + indent + EXPANDER_MARGIN, current * m_lineHeight + EXPANDER_MARGIN, m_lineHeight-2*EXPANDER_MARGIN,m_lineHeight-2*EXPANDER_MARGIN);
+            if( rect.Contains( x, y) )
+            {
+                //So the mouse is over the expander
+                hover = true;
+                if (m_underMouse && m_underMouse != node)
+                {
+                    //wxLogMessage("Undo the row: %d", GetRowByItem(m_underMouse->GetItem()));
+                    RefreshRow(GetRowByItem(m_underMouse->GetItem()));
+                }
+                if (m_underMouse != node)
+                {
+                    //wxLogMessage("Do the row: %d", current);
+                    RefreshRow(current);
+                }
+                m_underMouse = node;
+            }
+        }
+        if (node!=NULL && !node->HasChildren())
+            delete node;
+    }
+    if (!hover)
+    {
+        if (m_underMouse != NULL)
+        {
+            //wxLogMessage("Undo the row: %d", GetRowByItem(m_underMouse->GetItem()));
+            RefreshRow(GetRowByItem(m_underMouse->GetItem()));
+            m_underMouse = NULL;
+        }
+    }
+

     wxDataViewModel *model = GetOwner()->GetModel();
 
     if (event.Dragging())
     wxDataViewModel *model = GetOwner()->GetModel();
 
     if (event.Dragging())


@@ -3285,13 +3598,18 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
         m_lastOnSame = false;
     }
 
         m_lastOnSame = false;
     }
 

+    wxDataViewItem item = GetItemByRow(current);
+    bool ignore_other_columns =
+        ((GetOwner()->GetExpanderColumn() != col) &&
+         (model->IsContainer(item)) &&
+         (!model->HasContainerColumns(item)));
+

     if (event.LeftDClick())
     {
         if ( current == m_lineLastClicked )
         {
     if (event.LeftDClick())
     {
         if ( current == m_lineLastClicked )
         {

-            if (cell->GetMode() == wxDATAVIEW_CELL_ACTIVATABLE)
+            if ((!ignore_other_columns) && (cell->GetMode() == wxDATAVIEW_CELL_ACTIVATABLE))

             {
             {

-                wxDataViewItem item = GetItemByRow(current);

                 wxVariant value;
                 model->GetValue( value, item, col->GetModelColumn() );
                 cell->SetValue( value );
                 wxVariant value;
                 model->GetValue( value, item, col->GetModelColumn() );
                 cell->SetValue( value );


@@ -3299,12 +3617,13 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
                                   col->GetWidth(), m_lineHeight );
                 cell->Activate( cell_rect, model, item, col->GetModelColumn() );
 
                                   col->GetWidth(), m_lineHeight );
                 cell->Activate( cell_rect, model, item, col->GetModelColumn() );
 

+            }
+            else
+            {

                 wxWindow *parent = GetParent();
                 wxDataViewEvent le(wxEVT_COMMAND_DATAVIEW_ITEM_ACTIVATED, parent->GetId());
                 wxWindow *parent = GetParent();
                 wxDataViewEvent le(wxEVT_COMMAND_DATAVIEW_ITEM_ACTIVATED, parent->GetId());

-
+                le.SetItem( item );

                 le.SetEventObject(parent);
                 le.SetEventObject(parent);

-                le.SetColumn(col->GetModelColumn());
-                le.SetDataViewColumn(col);

                 le.SetModel(GetOwner()->GetModel());
 
                 parent->GetEventHandler()->ProcessEvent(le);
                 le.SetModel(GetOwner()->GetModel());
 
                 parent->GetEventHandler()->ProcessEvent(le);


@@ -3330,24 +3649,26 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
 
         //Process the event of user clicking the expander
         bool expander = false;
 
         //Process the event of user clicking the expander
         bool expander = false;

-        wxDataViewTreeNode * node = GetTreeNodeByRow(current);
-        if( node!=NULL && node->HasChildren() )
+        if ((m_root) && (GetOwner()->GetExpanderColumn() == col))

         {
         {

-            int indent = node->GetIndentLevel();
-            indent = GetOwner()->GetIndent()*indent;
-            wxRect rect( xpos + indent + EXPANDER_MARGIN, current * m_lineHeight + EXPANDER_MARGIN, m_lineHeight-2*EXPANDER_MARGIN,m_lineHeight-2*EXPANDER_MARGIN);
-            if( rect.Contains( x, y) )
+            wxDataViewTreeNode * node = GetTreeNodeByRow(current);
+            if( node!=NULL && node->HasChildren() )

             {
             {

-                expander = true;
-                if( node->IsOpen() )
-                    OnCollapsing(current);
-                else
-                    OnExpanding( current );
+                int indent = node->GetIndentLevel();
+                indent = GetOwner()->GetIndent()*indent;
+                wxRect rect( xpos + indent + EXPANDER_MARGIN, current * m_lineHeight + EXPANDER_MARGIN, m_lineHeight-2*EXPANDER_MARGIN,m_lineHeight-2*EXPANDER_MARGIN);
+                if( rect.Contains( x, y) )
+                {
+                    expander = true;
+                    if( node->IsOpen() )
+                        OnCollapsing(current);
+                    else
+                        OnExpanding( current );
+                }

             }
         }
             }
         }

-

         //If the user click the expander, we do not do editing even if the column with expander are editable
         //If the user click the expander, we do not do editing even if the column with expander are editable

-        if (m_lastOnSame && !expander )
+        if (m_lastOnSame && !expander && !ignore_other_columns)

         {
             if ((col == m_currentCol) && (current == m_currentRow) &&
                 (cell->GetMode() == wxDATAVIEW_CELL_EDITABLE) )
         {
             if ((col == m_currentCol) && (current == m_currentRow) &&
                 (cell->GetMode() == wxDATAVIEW_CELL_EDITABLE) )


@@ -3380,13 +3701,26 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
             SelectAllRows(false);
             ChangeCurrentRow(current);
             SelectRow(m_currentRow,true);
             SelectAllRows(false);
             ChangeCurrentRow(current);
             SelectRow(m_currentRow,true);

+            SendSelectionChangedEvent(GetItemByRow( m_currentRow ) );

         }
 
         // notify cell about right click
         }
 
         // notify cell about right click

-        // cell->...
-
-        // Allow generation of context menu event
-        event.Skip();
+        wxVariant value;
+        model->GetValue( value, item, col->GetModelColumn() );
+        cell->SetValue( value );
+        wxRect cell_rect( xpos, current * m_lineHeight,
+                          col->GetWidth(), m_lineHeight );
+        if (!cell->RightClick( event.GetPosition(), cell_rect, model, item, col->GetModelColumn()))
+        {
+            wxWindow *parent = GetParent();
+            wxDataViewEvent le(wxEVT_COMMAND_DATAVIEW_ITEM_CONTEXT_MENU, parent->GetId());
+            le.SetItem( item );
+            le.SetEventObject(parent);
+            le.SetModel(GetOwner()->GetModel());
+            le.SetValue(value);
+
+            parent->GetEventHandler()->ProcessEvent(le);
+        }

     }
     else if (event.MiddleDown())
     {
     }
     else if (event.MiddleDown())
     {


@@ -3395,9 +3729,7 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
     }
     if (event.LeftDown() || forceClick)
     {
     }
     if (event.LeftDown() || forceClick)
     {

-#ifdef __WXMSW__

         SetFocus();
         SetFocus();

-#endif

 
         m_lineBeforeLastClicked = m_lineLastClicked;
         m_lineLastClicked = current;
 
         m_lineBeforeLastClicked = m_lineLastClicked;
         m_lineLastClicked = current;


@@ -3411,10 +3743,9 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
             if ( IsSingleSel() || !IsRowSelected(current) )
             {
                 SelectAllRows( false );
             if ( IsSingleSel() || !IsRowSelected(current) )
             {
                 SelectAllRows( false );

-

                 ChangeCurrentRow(current);
                 ChangeCurrentRow(current);

-

                 SelectRow(m_currentRow,true);
                 SelectRow(m_currentRow,true);

+                SendSelectionChangedEvent(GetItemByRow( m_currentRow ) );

             }
             else // multi sel & current is highlighted & no mod keys
             {
             }
             else // multi sel & current is highlighted & no mod keys
             {


@@ -3427,8 +3758,8 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
             if (cmdModifierDown)
             {
                 ChangeCurrentRow(current);
             if (cmdModifierDown)
             {
                 ChangeCurrentRow(current);

-

                 ReverseRowSelection(m_currentRow);
                 ReverseRowSelection(m_currentRow);

+                SendSelectionChangedEvent(GetItemByRow(m_selection[0]) );

             }
             else if (event.ShiftDown())
             {
             }
             else if (event.ShiftDown())
             {


@@ -3444,6 +3775,7 @@ void wxDataViewMainWindow::OnMouse( wxMouseEvent &event )
                 }
 
                 SelectRows(lineFrom, lineTo, true);
                 }
 
                 SelectRows(lineFrom, lineTo, true);

+                SendSelectionChangedEvent(GetItemByRow(m_selection[0]) );

             }
             else // !ctrl, !shift
             {
             }
             else // !ctrl, !shift
             {


@@ -3496,6 +3828,7 @@ wxDataViewItem wxDataViewMainWindow::GetSelection() const
 //-----------------------------------------------------------------------------
 // wxDataViewCtrl
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 // wxDataViewCtrl
 //-----------------------------------------------------------------------------

+WX_DEFINE_LIST(wxDataViewColumnList)

 
 IMPLEMENT_DYNAMIC_CLASS(wxDataViewCtrl, wxDataViewCtrlBase)
 
 
 IMPLEMENT_DYNAMIC_CLASS(wxDataViewCtrl, wxDataViewCtrlBase)
 


@@ -3518,10 +3851,15 @@ bool wxDataViewCtrl::Create(wxWindow *parent, wxWindowID id,
            const wxPoint& pos, const wxSize& size,
            long style, const wxValidator& validator )
 {
            const wxPoint& pos, const wxSize& size,
            long style, const wxValidator& validator )
 {

+    if ( (style & wxBORDER_MASK) == 0)
+        style |= wxBORDER_SUNKEN;
+    

     if (!wxControl::Create( parent, id, pos, size,
     if (!wxControl::Create( parent, id, pos, size,

-                            style | wxScrolledWindowStyle|wxSUNKEN_BORDER, validator))
+                            style | wxScrolledWindowStyle, validator))

         return false;
 
         return false;
 

+    SetInitialSize(size);
+

     Init();
 
 #ifdef __WXMAC__
     Init();
 
 #ifdef __WXMAC__


@@ -3588,6 +3926,8 @@ bool wxDataViewCtrl::AssociateModel( wxDataViewModel *model )
 
     model->AddNotifier( m_notifier );
 
 
     model->AddNotifier( m_notifier );
 

+    m_clientArea->DestroyTree();
+

     m_clientArea->BuildTree(model);
 
     m_clientArea->UpdateDisplay();
     m_clientArea->BuildTree(model);
 
     m_clientArea->UpdateDisplay();


@@ -3600,6 +3940,17 @@ bool wxDataViewCtrl::AppendColumn( wxDataViewColumn *col )
     if (!wxDataViewCtrlBase::AppendColumn(col))
         return false;
 
     if (!wxDataViewCtrlBase::AppendColumn(col))
         return false;
 

+    m_cols.Append( col );
+    OnColumnChange();
+    return true;
+}
+
+bool wxDataViewCtrl::PrependColumn( wxDataViewColumn *col )
+{
+    if (!wxDataViewCtrlBase::PrependColumn(col))
+        return false;
+
+    m_cols.Insert( col );

     OnColumnChange();
     return true;
 }
     OnColumnChange();
     return true;
 }


@@ -3622,6 +3973,80 @@ void wxDataViewCtrl::DoSetIndent()
     m_clientArea->UpdateDisplay();
 }
 
     m_clientArea->UpdateDisplay();
 }
 

+unsigned int wxDataViewCtrl::GetColumnCount() const
+{
+    return m_cols.GetCount();
+}
+
+wxDataViewColumn* wxDataViewCtrl::GetColumn( unsigned int pos ) const
+{
+    wxDataViewColumnList::const_iterator iter;
+    unsigned int i = 0;
+    for (iter = m_cols.begin(); iter!=m_cols.end(); iter++)
+    {
+        if (i == pos)
+            return *iter;
+
+        if ((*iter)->IsHidden())
+            continue;
+        i ++;
+    }
+    return NULL;
+}
+
+void wxDataViewCtrl::ColumnMoved( wxDataViewColumn* col, unsigned int new_pos )
+{
+    if (new_pos > m_cols.GetCount()) return;
+    m_cols.DeleteObject( col );
+    m_cols.Insert( new_pos, col );
+
+    m_clientArea->UpdateDisplay();
+}
+
+bool wxDataViewCtrl::DeleteColumn( wxDataViewColumn *column )
+{
+    wxDataViewColumnList::compatibility_iterator  ret = m_cols.Find( column );
+    if (!ret)
+        return false;
+
+    m_cols.Erase(ret);
+    delete column;
+    OnColumnChange();
+
+    return true;
+}
+
+bool wxDataViewCtrl::ClearColumns()
+{
+    m_cols.clear();
+    OnColumnChange();
+    return true;
+}
+
+int wxDataViewCtrl::GetColumnPosition( const wxDataViewColumn *column ) const
+{
+    int ret = 0, dead = 0;
+    int len = GetColumnCount();
+    for (int i=0; i<len; i++)
+    {
+        wxDataViewColumn * col = GetColumn(i);
+        if (col->IsHidden())
+            continue;
+        ret += col->GetWidth();
+        if (column==col)
+        {
+            CalcScrolledPosition( ret, dead, &ret, &dead );
+            break;
+        }
+    }
+    return ret;
+}
+
+wxDataViewColumn *wxDataViewCtrl::GetSortingColumn() const
+{
+    return NULL;
+}
+

 //Selection code with wxDataViewItem as parameters
 wxDataViewItem wxDataViewCtrl::GetSelection() const
 {
 //Selection code with wxDataViewItem as parameters
 wxDataViewItem wxDataViewCtrl::GetSelection() const
 {


@@ -3658,7 +4083,12 @@ void wxDataViewCtrl::Select( const wxDataViewItem & item )
 {
     int row = m_clientArea->GetRowByItem( item );
     if( row >= 0 )
 {
     int row = m_clientArea->GetRowByItem( item );
     if( row >= 0 )

+    {
+        //Unselect all rows before select another in the single select mode
+        if (m_clientArea->IsSingleSel())
+            m_clientArea->SelectAllRows(false);

         m_clientArea->SelectRow(row, true);
         m_clientArea->SelectRow(row, true);

+    }

 }
 
 void wxDataViewCtrl::Unselect( const wxDataViewItem & item )
 }
 
 void wxDataViewCtrl::Unselect( const wxDataViewItem & item )


@@ -3708,7 +4138,11 @@ void wxDataViewCtrl::SetSelections( const wxArrayInt & sel )
 void wxDataViewCtrl::Select( int row )
 {
     if( row >= 0 )
 void wxDataViewCtrl::Select( int row )
 {
     if( row >= 0 )

+    {
+        if (m_clientArea->IsSingleSel())
+            m_clientArea->SelectAllRows(false);

         m_clientArea->SelectRow( row, true );
         m_clientArea->SelectRow( row, true );

+    }

 }
 
 void wxDataViewCtrl::Unselect( int row )
 }
 
 void wxDataViewCtrl::Unselect( int row )


@@ -3726,7 +4160,7 @@ bool wxDataViewCtrl::IsSelected( int row ) const
 
 void wxDataViewCtrl::SelectRange( int from, int to )
 {
 
 void wxDataViewCtrl::SelectRange( int from, int to )
 {

-    wxArrayInt sel; 
+    wxArrayInt sel;

     for( int i = from; i < to; i ++ )
         sel.Add( i );
     m_clientArea->Select(sel);
     for( int i = from; i < to; i ++ )
         sel.Add( i );
     m_clientArea->Select(sel);


@@ -3755,7 +4189,7 @@ void wxDataViewCtrl::EnsureVisible( int row, int column )
 {
     if( row < 0 )
         row = 0;
 {
     if( row < 0 )
         row = 0;

-    if( row > m_clientArea->GetRowCount() )
+    if( row > (int) m_clientArea->GetRowCount() )

         row = m_clientArea->GetRowCount();
 
     int first = m_clientArea->GetFirstVisibleRow();
         row = m_clientArea->GetRowCount();
 
     int first = m_clientArea->GetFirstVisibleRow();


@@ -3774,9 +4208,9 @@ void wxDataViewCtrl::EnsureVisible( const wxDataViewItem & item, const wxDataVie
     if( row >= 0 )
     {
         if( column == NULL )
     if( row >= 0 )
     {
         if( column == NULL )

-            return EnsureVisible(row, -1);
+            EnsureVisible(row, -1);

         else
         else

-        {  
+        {

             int col = 0;
             int len = GetColumnCount();
             for( int i = 0; i < len; i ++ )
             int col = 0;
             int len = GetColumnCount();
             for( int i = 0; i < len; i ++ )


@@ -3788,10 +4222,10 @@ void wxDataViewCtrl::EnsureVisible( const wxDataViewItem & item, const wxDataVie
             EnsureVisible( row, col );
         }
     }
             EnsureVisible( row, col );
         }
     }

-        
+

 }
 
 }
 

-void wxDataViewCtrl::HitTest( const wxPoint & point, wxDataViewItem & item, wxDataViewColumn* column ) const
+void wxDataViewCtrl::HitTest( const wxPoint & point, wxDataViewItem & item, wxDataViewColumn* &column ) const

 {
     m_clientArea->HitTest(point, item, column);
 }
 {
     m_clientArea->HitTest(point, item, column);
 }


@@ -3811,6 +4245,20 @@ int wxDataViewCtrl::GetRowByItem( const wxDataViewItem & item ) const
     return m_clientArea->GetRowByItem( item );
 }
 
     return m_clientArea->GetRowByItem( item );
 }
 

+void wxDataViewCtrl::Expand( const wxDataViewItem & item )
+{
+    int row = m_clientArea->GetRowByItem( item );
+    if (row != -1)
+        m_clientArea->Expand(row);
+}
+
+void wxDataViewCtrl::Collapse( const wxDataViewItem & item )
+{
+    int row = m_clientArea->GetRowByItem( item );
+    if (row != -1)
+        m_clientArea->Collapse(row);
+}
+

  #endif
     // !wxUSE_GENERICDATAVIEWCTRL
 
  #endif
     // !wxUSE_GENERICDATAVIEWCTRL