blind fix for wxGIFDecoder::ReadGIF

[wxWidgets.git] / src / common / config.cpp

diff --git a/src/common/config.cpp b/src/common/config.cpp
index feccd99ab00c66508a97aac4ce8a70e376d6098a..05ca5af209b99fccdf4516182e5c91e6a0894ca3 100644 (file)
--- a/src/common/config.cpp
+++ b/src/common/config.cpp
@@ -27,18 +27,17 @@
     #define wxUSE_CONFIG_NATIVE 1
 #endif
 
     #define wxUSE_CONFIG_NATIVE 1
 #endif
 

+#include "wx/config.h"
+#include "wx/intl.h"
+#include "wx/log.h"
+

 #if wxUSE_CONFIG && ((wxUSE_FILE && wxUSE_TEXTFILE) || wxUSE_CONFIG_NATIVE)
 
 #include "wx/app.h"
 #include "wx/file.h"
 #if wxUSE_CONFIG && ((wxUSE_FILE && wxUSE_TEXTFILE) || wxUSE_CONFIG_NATIVE)
 
 #include "wx/app.h"
 #include "wx/file.h"

-#include "wx/log.h"

 #include "wx/textfile.h"
 #include "wx/utils.h"
 #include "wx/textfile.h"
 #include "wx/utils.h"

-#include "wx/log.h"

 #include "wx/utils.h"
 #include "wx/utils.h"

-#include "wx/intl.h"
-
-#include "wx/config.h"

 
 #include <stdlib.h>
 #include <math.h>
 
 #include <stdlib.h>
 #include <math.h>


@@ -132,10 +131,9 @@ bool wxConfigBase::Read(const wxString& key, long *pl, long defVal) const
 bool wxConfigBase::Read(const wxString& key, double* val) const
 {
     wxString str;
 bool wxConfigBase::Read(const wxString& key, double* val) const
 {
     wxString str;

-    if (Read(key, & str))
+    if ( Read(key, &str) )

     {
     {

-        *val = wxAtof(str);
-        return TRUE;
+        return str.ToDouble(val);

     }
 
     return FALSE;
     }
 
     return FALSE;


@@ -190,28 +188,29 @@ bool wxConfigBase::Read(const wxString& key, int *pi, int defVal) const
 {
     long l;
     bool ret = Read(key, &l, (long) defVal);
 {
     long l;
     bool ret = Read(key, &l, (long) defVal);

-    *pi = (int) l;
+    if (ret)
+        *pi = (int) l;

     return ret;
 }
 
 bool wxConfigBase::Write(const wxString& key, double val)
 {
     wxString str;
     return ret;
 }
 
 bool wxConfigBase::Write(const wxString& key, double val)
 {
     wxString str;

-    str.Printf(wxT("%f"), val);
+    str.Printf(wxT("%g"), val);

     return Write(key, str);
 }
 
 bool wxConfigBase::Write(const wxString& key, bool value)
 {
     return Write(key, str);
 }
 
 bool wxConfigBase::Write(const wxString& key, bool value)
 {

-    long l = (value ? 1 : 0);
-    return Write(key, l);
+    return Write(key, value ? 1l : 0l);

 }
 
 }
 

-bool wxConfigBase::Write( const wxString &key, const wxChar *text )
+bool wxConfigBase::Write(const wxString& key, const wxChar *value)

 {
 {

-       wxString str( text ) ;
-       return Write( key, str ) ;
+    // explicit cast needed, otherwise value would have been converted to bool
+    return Write(key, wxString(value));

 }
 }

+

 wxString wxConfigBase::ExpandEnvVars(const wxString& str) const
 {
     wxString tmp; // Required for BC++
 wxString wxConfigBase::ExpandEnvVars(const wxString& str) const
 {
     wxString tmp; // Required for BC++


@@ -246,7 +245,9 @@ wxConfigPathChanger::wxConfigPathChanger(const wxConfigBase *pContainer,
     m_bChanged = TRUE;
     m_strName = strEntry.AfterLast(wxCONFIG_PATH_SEPARATOR);
     m_strOldPath = m_pContainer->GetPath();
     m_bChanged = TRUE;
     m_strName = strEntry.AfterLast(wxCONFIG_PATH_SEPARATOR);
     m_strOldPath = m_pContainer->GetPath();

-    m_strOldPath += wxCONFIG_PATH_SEPARATOR;
+    if ( m_strOldPath.Len() == 0 || 
+         m_strOldPath.Last() != wxCONFIG_PATH_SEPARATOR )
+        m_strOldPath += wxCONFIG_PATH_SEPARATOR;

     m_pContainer->SetPath(strPath);
   }
   else {
     m_pContainer->SetPath(strPath);
   }
   else {


@@ -264,6 +265,8 @@ wxConfigPathChanger::~wxConfigPathChanger()
   }
 }
 
   }
 }
 

+#endif // wxUSE_CONFIG
+

 // ----------------------------------------------------------------------------
 // static & global functions
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // static & global functions
 // ----------------------------------------------------------------------------


@@ -379,6 +382,8 @@ wxString wxExpandEnvVars(const wxString& str)
 }
 
 // this function is used to properly interpret '..' in path
 }
 
 // this function is used to properly interpret '..' in path

+/// separates group and entry names (probably shouldn't be changed)
+

 void wxSplitPath(wxArrayString& aParts, const wxChar *sz)
 {
   aParts.Empty();
 void wxSplitPath(wxArrayString& aParts, const wxChar *sz)
 {
   aParts.Empty();


@@ -416,5 +421,4 @@ void wxSplitPath(wxArrayString& aParts, const wxChar *sz)
   }
 }
 
   }
 }
 

-#endif // wxUSE_CONFIG