added a check which should prevent the crash of bug 555111

[wxWidgets.git] / src / gtk / slider.cpp

diff --git a/src/gtk/slider.cpp b/src/gtk/slider.cpp
index d1532a77026410976aaa003e4f8a197aaeb26146..a5fbd38b54b15b55c334525d4c95d87bb539d4e3 100644 (file)
--- a/src/gtk/slider.cpp
+++ b/src/gtk/slider.cpp
@@ -1,10 +1,10 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        slider.cpp
+// Name:        gtk/slider.cpp

 // Purpose:
 // Author:      Robert Roebling
 // Id:          $Id$
 // Copyright:   (c) 1998 Robert Roebling
 // Purpose:
 // Author:      Robert Roebling
 // Id:          $Id$
 // Copyright:   (c) 1998 Robert Roebling

-// Licence:    wxWindows licence
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 #ifdef __GNUG__
 /////////////////////////////////////////////////////////////////////////////
 
 #ifdef __GNUG__


@@ -12,50 +12,64 @@
 #endif
 
 #include "wx/slider.h"
 #endif
 
 #include "wx/slider.h"

+
+#if wxUSE_SLIDER
+

 #include "wx/utils.h"
 #include "wx/utils.h"

+

 #include <math.h>
 
 #include <math.h>
 

+#include "wx/gtk/private.h"
+
+//-----------------------------------------------------------------------------
+// idle system
+//-----------------------------------------------------------------------------
+
+extern void wxapp_install_idle_handler();
+extern bool g_isIdle;
+

 //-----------------------------------------------------------------------------
 // data
 //-----------------------------------------------------------------------------
 
 //-----------------------------------------------------------------------------
 // data
 //-----------------------------------------------------------------------------
 

-extern bool   g_blockEventsOnDrag;
+extern bool g_blockEventsOnDrag;
+
+static const float sensitivity = 0.02;

 
 //-----------------------------------------------------------------------------
 // "value_changed"
 //-----------------------------------------------------------------------------
 
 
 //-----------------------------------------------------------------------------
 // "value_changed"
 //-----------------------------------------------------------------------------
 

-static void gtk_slider_callback( GtkWidget *WXUNUSED(widget), wxSlider *win )
-{ 
-  if (!win->HasVMT()) return;
-  if (g_blockEventsOnDrag) return;
-    
-  float diff = win->m_adjust->value - win->m_oldPos;
-  if (fabs(diff) < 0.2) return;
-  
-  wxEventType command = wxEVT_NULL;
-  
-  float line_step = win->m_adjust->step_increment;
-  float page_step = win->m_adjust->page_increment;
-  
-  if (fabs(diff-line_step) < 0.2) command = wxEVT_SCROLL_LINEDOWN;
-  else if (fabs(diff+line_step) < 0.2) command = wxEVT_SCROLL_LINEUP;
-  else if (fabs(diff-page_step) < 0.2) command = wxEVT_SCROLL_PAGEDOWN;
-  else if (fabs(diff+page_step) < 0.2) command = wxEVT_SCROLL_PAGEUP;
-  else command = wxEVT_SCROLL_THUMBTRACK;
-
-  int value = (int)(win->m_adjust->value+0.5);
-      
-  int orient = wxHORIZONTAL;
-  if (win->GetWindowStyleFlag() & wxSB_VERTICAL == wxSB_VERTICAL) orient = wxVERTICAL;
-  
-  wxScrollEvent event( command, win->GetId(), value, orient );
-  event.SetEventObject( win );
-  win->ProcessEvent( event );
-  
-  wxCommandEvent cevent( wxEVT_COMMAND_SLIDER_UPDATED, win->GetId() );
-  cevent.SetEventObject( win );
-  win->ProcessEvent( cevent );
+static void gtk_slider_callback( GtkAdjustment *adjust,
+                                 SCROLLBAR_CBACK_ARG
+                                 wxSlider *win )
+{
+    if (g_isIdle) wxapp_install_idle_handler();
+
+    if (!win->m_hasVMT) return;
+    if (g_blockEventsOnDrag) return;
+
+    float diff = adjust->value - win->m_oldPos;
+    if (fabs(diff) < sensitivity) return;
+
+    win->m_oldPos = adjust->value;
+
+    wxEventType command = GtkScrollTypeToWx(GET_SCROLL_TYPE(win->m_widget));
+
+    double dvalue = adjust->value;
+    int value = (int)(dvalue < 0 ? dvalue - 0.5 : dvalue + 0.5);
+
+    int orient = win->GetWindowStyleFlag() & wxSL_VERTICAL ? wxVERTICAL
+                                                           : wxHORIZONTAL;
+
+    wxScrollEvent event( command, win->GetId(), value, orient );
+    event.SetEventObject( win );
+    win->GetEventHandler()->ProcessEvent( event );
+
+    wxCommandEvent cevent( wxEVT_COMMAND_SLIDER_UPDATED, win->GetId() );
+    cevent.SetEventObject( win );
+    cevent.SetInt( value );
+    win->GetEventHandler()->ProcessEvent( cevent );

 }
 
 //-----------------------------------------------------------------------------
 }
 
 //-----------------------------------------------------------------------------


@@ -64,182 +78,184 @@ static void gtk_slider_callback( GtkWidget *WXUNUSED(widget), wxSlider *win )
 
 IMPLEMENT_DYNAMIC_CLASS(wxSlider,wxControl)
 
 
 IMPLEMENT_DYNAMIC_CLASS(wxSlider,wxControl)
 

-wxSlider::wxSlider(void)
-{
-}
-
-wxSlider::~wxSlider(void)
-{
-}
-

 bool wxSlider::Create(wxWindow *parent, wxWindowID id,
         int value, int minValue, int maxValue,
         const wxPoint& pos, const wxSize& size,
         long style, const wxValidator& validator, const wxString& name )
 {
 bool wxSlider::Create(wxWindow *parent, wxWindowID id,
         int value, int minValue, int maxValue,
         const wxPoint& pos, const wxSize& size,
         long style, const wxValidator& validator, const wxString& name )
 {

-  m_needParent = TRUE;
-  
-  PreCreation( parent, id, pos, size, style, name );
-  
-  SetValidator( validator );
-
-  m_oldPos = 0.0;
-
-  if (style & wxSL_VERTICAL == wxSL_VERTICAL)
-    m_widget = gtk_hscale_new( (GtkAdjustment *) NULL );
-  else
-    m_widget = gtk_vscale_new( (GtkAdjustment *) NULL );
-    
-  gtk_scale_set_draw_value( GTK_SCALE( m_widget ), FALSE );
-  
-  m_adjust = gtk_range_get_adjustment( GTK_RANGE(m_widget) );
-  
-  gtk_signal_connect (GTK_OBJECT (m_adjust), "value_changed",
-                     (GtkSignalFunc) gtk_slider_callback, (gpointer) this );
-  SetRange( minValue, maxValue );
-  SetValue( value );
-  
-  m_parent->AddChild( this );
-
-  (m_parent->m_insertCallback)( m_parent, this );
-  
-  PostCreation();
-  
-  SetBackgroundColour( parent->GetBackgroundColour() );
-
-  Show( TRUE );
-    
-  return TRUE;
+    m_acceptsFocus = TRUE;
+    m_needParent = TRUE;
+
+    if (!PreCreation( parent, pos, size ) ||
+        !CreateBase( parent, id, pos, size, style, validator, name ))
+    {
+        wxFAIL_MSG( wxT("wxSlider creation failed") );
+        return FALSE;
+    }
+
+    m_oldPos = 0.0;
+
+    if (style & wxSL_VERTICAL)
+        m_widget = gtk_vscale_new( (GtkAdjustment *) NULL );
+    else
+        m_widget = gtk_hscale_new( (GtkAdjustment *) NULL );
+
+    if (style & wxSL_LABELS)
+    {
+        gtk_scale_set_draw_value( GTK_SCALE( m_widget ), TRUE );
+        gtk_scale_set_digits( GTK_SCALE( m_widget ), 0 );
+
+        /* labels need more space and too small window will
+           cause junk to appear on the dialog */
+        if (style & wxSL_VERTICAL)
+        {
+            wxSize sz( size );
+            if (sz.x < 35)
+            {
+                sz.x = 35;
+                SetSize( sz );
+            }
+        }
+        else
+        {
+            wxSize sz( size );
+            if (sz.y < 35)
+            {
+                sz.y = 35;
+                SetSize( sz );
+            }
+        }
+    }
+    else
+        gtk_scale_set_draw_value( GTK_SCALE( m_widget ), FALSE );
+
+    m_adjust = gtk_range_get_adjustment( GTK_RANGE(m_widget) );
+
+    gtk_signal_connect( GTK_OBJECT(m_adjust),
+                        "value_changed",
+                        (GtkSignalFunc) gtk_slider_callback,
+                        (gpointer) this );
+
+    SetRange( minValue, maxValue );
+    SetValue( value );
+
+    m_parent->DoAddChild( this );
+
+    PostCreation();
+
+    SetBackgroundColour( parent->GetBackgroundColour() );
+
+    Show( TRUE );
+
+    return TRUE;

 }
 
 }
 

-int wxSlider::GetValue(void) const
+int wxSlider::GetValue() const

 {
 {

-  return (int)(m_adjust->value+0.5);
+    // we want to round to the nearest integer, i.e. 0.9 is rounded to 1 and
+    // -0.9 is rounded to -1
+    double val = m_adjust->value;
+    return (int)(val < 0 ? val - 0.5 : val + 0.5);

 }
 
 void wxSlider::SetValue( int value )
 {
 }
 
 void wxSlider::SetValue( int value )
 {

-  float fpos = (float)value;
-  m_oldPos = fpos;
-  if (fabs(fpos-m_adjust->value) < 0.2) return;
-  m_adjust->value = fpos;
-  
-  gtk_signal_emit_by_name( GTK_OBJECT(m_adjust), "value_changed" );
-}
+    float fpos = (float)value;
+    m_oldPos = fpos;
+    if (fabs(fpos-m_adjust->value) < 0.2) return;

 
 

-void wxSlider::SetRange( int minValue, int maxValue )
-{
-  float fmin = (float)minValue;
-  float fmax = (float)maxValue;
-      
-  if ((fabs(fmin-m_adjust->lower) < 0.2) &&
-      (fabs(fmax-m_adjust->upper) < 0.2))
-      return;
-      
-  m_adjust->lower = fmin;
-  m_adjust->upper = fmax;
-
-  gtk_signal_emit_by_name( GTK_OBJECT(m_adjust), "changed" );
-}
+    m_adjust->value = fpos;

 
 

-int wxSlider::GetMin(void) const
-{
-  return (int)(m_adjust->lower+0.5);
+    gtk_signal_emit_by_name( GTK_OBJECT(m_adjust), "value_changed" );

 }
 
 }
 

-int wxSlider::GetMax(void) const
+void wxSlider::SetRange( int minValue, int maxValue )

 {
 {

-  return (int)(m_adjust->upper+0.5);
-}
+    float fmin = (float)minValue;
+    float fmax = (float)maxValue;

 
 

-void wxSlider::SetPageSize( int pageSize )
-{
-  float fpage = (float)pageSize;
-      
-  if (fabs(fpage-m_adjust->page_increment) < 0.2) return;
-      
-  m_adjust->page_increment = fpage;
+    if ((fabs(fmin-m_adjust->lower) < 0.2) &&
+        (fabs(fmax-m_adjust->upper) < 0.2))
+    {
+        return;
+    }

 
 

-  gtk_signal_emit_by_name( GTK_OBJECT(m_adjust), "changed" );
-}
+    m_adjust->lower = fmin;
+    m_adjust->upper = fmax;
+    m_adjust->step_increment = 1.0;
+    m_adjust->page_increment = ceil((fmax-fmin) / 10.0);

 
 

-int wxSlider::GetPageSize(void) const
-{
-  return (int)(m_adjust->page_increment+0.5);
+    gtk_signal_emit_by_name( GTK_OBJECT(m_adjust), "changed" );

 }
 
 }
 

-void wxSlider::SetThumbLength( int len )
+int wxSlider::GetMin() const

 {
 {

-  float flen = (float)len;
-      
-  if (fabs(flen-m_adjust->page_size) < 0.2) return;
-      
-  m_adjust->page_size = flen;
-
-  gtk_signal_emit_by_name( GTK_OBJECT(m_adjust), "changed" );
+    return (int)ceil(m_adjust->lower);

 }
 
 }
 

-int wxSlider::GetThumbLength(void) const
+int wxSlider::GetMax() const

 {
 {

-  return (int)(m_adjust->page_size+0.5);
+    return (int)ceil(m_adjust->upper);

 }
 
 }
 

-void wxSlider::SetLineSize( int WXUNUSED(lineSize) )
+void wxSlider::SetPageSize( int pageSize )

 {
 {

-}
+    float fpage = (float)pageSize;

 
 

-int wxSlider::GetLineSize(void) const
-{
-  return 0;
-}
+    if (fabs(fpage-m_adjust->page_increment) < 0.2) return;

 
 

-void wxSlider::SetTick( int WXUNUSED(tickPos) )
-{
-}
+    m_adjust->page_increment = fpage;

 
 

-void wxSlider::SetTickFreq( int WXUNUSED(n), int WXUNUSED(pos) )
-{
+    gtk_signal_emit_by_name( GTK_OBJECT(m_adjust), "changed" );

 }
 
 }
 

-int wxSlider::GetTickFreq(void) const
+int wxSlider::GetPageSize() const

 {
 {

-  return 0;
+    return (int)ceil(m_adjust->page_increment);

 }
 
 }
 

-void wxSlider::ClearTicks(void)
+void wxSlider::SetThumbLength( int len )

 {
 {

-}
+    float flen = (float)len;

 
 

-void wxSlider::SetSelection( int WXUNUSED(minPos), int WXUNUSED(maxPos) )
-{
+    if (fabs(flen-m_adjust->page_size) < 0.2) return;
+
+    m_adjust->page_size = flen;
+
+    gtk_signal_emit_by_name( GTK_OBJECT(m_adjust), "changed" );

 }
 
 }
 

-int wxSlider::GetSelEnd(void) const
+int wxSlider::GetThumbLength() const

 {
 {

-  return 0;
+    return (int)ceil(m_adjust->page_size);

 }
 
 }
 

-int wxSlider::GetSelStart(void) const
+void wxSlider::SetLineSize( int WXUNUSED(lineSize) )

 {
 {

-  return 0;

 }
 
 }
 

-void wxSlider::ClearSel(void)
+int wxSlider::GetLineSize() const

 {
 {

+    return 0;

 }
 
 bool wxSlider::IsOwnGtkWindow( GdkWindow *window )
 {
 }
 
 bool wxSlider::IsOwnGtkWindow( GdkWindow *window )
 {

-  GtkRange *range = GTK_RANGE(m_widget);
-  return ( (window == GTK_WIDGET(range)->window) ||
-           (window == range->trough) ||
-          (window == range->slider) ||
-          (window == range->step_forw) ||
-          (window == range->step_back) );
+    GtkRange *range = GTK_RANGE(m_widget);
+    return ( (window == GTK_WIDGET(range)->window)
+#ifndef __WXGTK20__
+                || (window == range->trough)
+                || (window == range->slider)
+                || (window == range->step_forw)
+                || (window == range->step_back)
+#endif // GTK+ 1.x
+           );

 }
 
 void wxSlider::ApplyWidgetStyle()
 {
 }
 
 void wxSlider::ApplyWidgetStyle()
 {

-  SetWidgetStyle();
-  gtk_widget_set_style( m_widget, m_widgetStyle );
+    SetWidgetStyle();
+    gtk_widget_set_style( m_widget, m_widgetStyle );

 }
 }

+
+#endif