Second try to get wxDataViewChoiceByIndex and its name right, hopefully fixes #11970...

[wxWidgets.git] / include / wx / choice.h

diff --git a/include/wx/choice.h b/include/wx/choice.h
index d0ec9403a6ed916a6626490794da31693ea4aa2c..6f3c75563c29a2b4760df9f6af2d1235d6be4131 100644 (file)
--- a/include/wx/choice.h
+++ b/include/wx/choice.h
@@ -16,9 +16,7 @@
 // headers
 // ----------------------------------------------------------------------------
 
 // headers
 // ----------------------------------------------------------------------------
 

-#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
-    #pragma interface "choicebase.h"
-#endif
+#include "wx/defs.h"

 
 #if wxUSE_CHOICE
 
 
 #if wxUSE_CHOICE
 


@@ -28,26 +26,26 @@
 // global data
 // ----------------------------------------------------------------------------
 
 // global data
 // ----------------------------------------------------------------------------
 

-WXDLLEXPORT_DATA(extern const wxChar*) wxChoiceNameStr;
+extern WXDLLIMPEXP_DATA_CORE(const char) wxChoiceNameStr[];

 
 // ----------------------------------------------------------------------------
 // wxChoice allows to select one of a non-modifiable list of strings
 // ----------------------------------------------------------------------------
 
 
 // ----------------------------------------------------------------------------
 // wxChoice allows to select one of a non-modifiable list of strings
 // ----------------------------------------------------------------------------
 

-class WXDLLEXPORT wxChoiceBase : public wxControlWithItems
+class WXDLLIMPEXP_CORE wxChoiceBase : public wxControlWithItems

 {
 public:
     wxChoiceBase() { }
 {
 public:
     wxChoiceBase() { }

-    virtual ~wxChoiceBase(){};
+    virtual ~wxChoiceBase();

 
     // all generic methods are in wxControlWithItems
 
 
     // all generic methods are in wxControlWithItems
 

-    // single selection logic
-    virtual void SetSelection(int n) = 0;
-    virtual bool SetStringSelection(const wxString& s);
-
-    // don't override this
-    virtual void Select(int n) { SetSelection(n); }
+    // get the current selection: this can only be different from the normal
+    // selection if the popup items list is currently opened and the user
+    // selected some item in it but didn't close the list yet; otherwise (and
+    // currently always on platforms other than MSW) this is the same as
+    // GetSelection()
+    virtual int GetCurrentSelection() const { return GetSelection(); }

 
     // set/get the number of columns in the control (as they're not supported on
     // most platforms, they do nothing by default)
 
     // set/get the number of columns in the control (as they're not supported on
     // most platforms, they do nothing by default)


@@ -57,8 +55,11 @@ public:
     // emulate selecting the item event.GetInt()
     void Command(wxCommandEvent& event);
 
     // emulate selecting the item event.GetInt()
     void Command(wxCommandEvent& event);
 

+    // override wxItemContainer::IsSorted
+    virtual bool IsSorted() const { return HasFlag(wxCB_SORT); }
+

 private:
 private:

-    DECLARE_NO_COPY_CLASS(wxChoiceBase)
+    wxDECLARE_NO_COPY_CLASS(wxChoiceBase);

 };
 
 // ----------------------------------------------------------------------------
 };
 
 // ----------------------------------------------------------------------------


@@ -73,17 +74,20 @@ private:
     #include "wx/msw/choice.h"
 #elif defined(__WXMOTIF__)
     #include "wx/motif/choice.h"
     #include "wx/msw/choice.h"
 #elif defined(__WXMOTIF__)
     #include "wx/motif/choice.h"

-#elif defined(__WXGTK__)
+#elif defined(__WXGTK20__)

     #include "wx/gtk/choice.h"
     #include "wx/gtk/choice.h"

+#elif defined(__WXGTK__)
+    #include "wx/gtk1/choice.h"

 #elif defined(__WXMAC__)
 #elif defined(__WXMAC__)

-    #include "wx/mac/choice.h"
+    #include "wx/osx/choice.h"

 #elif defined(__WXCOCOA__)
     #include "wx/cocoa/choice.h"
 #elif defined(__WXPM__)
     #include "wx/os2/choice.h"
 #elif defined(__WXCOCOA__)
     #include "wx/cocoa/choice.h"
 #elif defined(__WXPM__)
     #include "wx/os2/choice.h"

+#elif defined(__WXPALMOS__)
+    #include "wx/palmos/choice.h"

 #endif
 
 #endif // wxUSE_CHOICE
 
 #endif
 
 #endif // wxUSE_CHOICE
 

-#endif
-    // _WX_CHOICE_H_BASE_
+#endif // _WX_CHOICE_H_BASE_