check that file was closed successfully in wxCopyFile (bug 414987 )

[wxWidgets.git] / src / common / zstream.cpp

diff --git a/src/common/zstream.cpp b/src/common/zstream.cpp
index 8bb5c54c4bf3b566580814d631f153de8a205e5e..5142f077b660439ed35a150452ccc7ef0ddde860 100644 (file)
--- a/src/common/zstream.cpp
+++ b/src/common/zstream.cpp
@@ -27,14 +27,16 @@
 #include "wx/intl.h"
 #include "wx/log.h"
 
 #include "wx/intl.h"
 #include "wx/log.h"
 

-// When using configure, the path must be "zlib.h" I don't know
-// what other ports (wxMac, wxMotif without configure) need here.
-// If we are building with configure (defines __WX_SETUP_H__), 
-// we trust the zlib path is given as a -I option.
-#if defined(__WXMSW__) && !defined(__WX_SETUP_H__)
-   #include "..\zlib\zlib.h"
+// normally, the compiler options should contain -I../zlib, but it is
+// apparently not the case for all MSW makefiles and so, unless we use
+// configure (which defines __WX_SETUP_H__) or it is explicitly overridden by
+// the user (who can define wxUSE_ZLIB_H_IN_PATH), we hardcode the path here
+#if defined(__WXMSW__) && !defined(__WX_SETUP_H__) && !defined(wxUSE_ZLIB_H_IN_PATH)
+   #include "../zlib/zlib.h"
+#elif defined(__WXMAC__) && defined(__UNIX__)
+   #include <Kernel/net/zlib.h>

 #else
 #else

-   #include "zlib.h"
+   #include <zlib.h>

 #endif
 
 #define ZSTREAM_BUFFER_SIZE 1024
 #endif
 
 #define ZSTREAM_BUFFER_SIZE 1024


@@ -46,8 +48,6 @@
 wxZlibInputStream::wxZlibInputStream(wxInputStream& stream)
   : wxFilterInputStream(stream)
 {
 wxZlibInputStream::wxZlibInputStream(wxInputStream& stream)
   : wxFilterInputStream(stream)
 {

-  int err;
-

   // I need a private stream buffer.
   m_inflate = new z_stream_s;
 
   // I need a private stream buffer.
   m_inflate = new z_stream_s;
 


@@ -55,7 +55,7 @@ wxZlibInputStream::wxZlibInputStream(wxInputStream& stream)
   m_inflate->zfree = (free_func)0;
   m_inflate->opaque = (voidpf)0;
 
   m_inflate->zfree = (free_func)0;
   m_inflate->opaque = (voidpf)0;
 

-  err = inflateInit(m_inflate);
+  int err = inflateInit(m_inflate);

   if (err != Z_OK) {
     inflateEnd(m_inflate);
     delete m_inflate;
   if (err != Z_OK) {
     inflateEnd(m_inflate);
     delete m_inflate;


@@ -73,6 +73,8 @@ wxZlibInputStream::~wxZlibInputStream()
 {
   inflateEnd(m_inflate);
   delete m_inflate;
 {
   inflateEnd(m_inflate);
   delete m_inflate;

+
+  delete [] m_z_buffer;

 }
 
 size_t wxZlibInputStream::OnSysRead(void *buffer, size_t size)
 }
 
 size_t wxZlibInputStream::OnSysRead(void *buffer, size_t size)


@@ -85,26 +87,37 @@ size_t wxZlibInputStream::OnSysRead(void *buffer, size_t size)
   while (m_inflate->avail_out > 0) {
     if (m_inflate->avail_in == 0) {
 
   while (m_inflate->avail_out > 0) {
     if (m_inflate->avail_in == 0) {
 

-      m_parent_i_stream->Read(m_z_buffer, m_z_size);
+      m_parent_i_stream->Read(m_z_buffer, wxMin(m_z_size, size));

       m_inflate->next_in = m_z_buffer;
       m_inflate->avail_in = m_parent_i_stream->LastRead();
 
       m_inflate->next_in = m_z_buffer;
       m_inflate->avail_in = m_parent_i_stream->LastRead();
 

-      if (m_parent_i_stream->LastError() != wxStream_NOERROR)
-        return (size - m_inflate->avail_in);
+      if (m_parent_i_stream->LastError() != wxStream_NOERROR &&
+          m_parent_i_stream->LastError() != wxStream_EOF)
+      { 
+        m_lasterror = m_parent_i_stream->LastError();
+        return 0; // failed to read anything
+      }
+
+      if ( m_inflate->avail_in == 0 )
+      {
+          // EOF
+          m_lasterror = wxStream_EOF;
+          break;
+      }

     }
     err = inflate(m_inflate, Z_FINISH);
     if (err == Z_STREAM_END)
     }
     err = inflate(m_inflate, Z_FINISH);
     if (err == Z_STREAM_END)

-      return (size - m_inflate->avail_in);
+      return (size - m_inflate->avail_out);

   }
 
   }
 

-  return size-m_inflate->avail_in;
+  return size-m_inflate->avail_out;

 }
 
 //////////////////////
 // wxZlibOutputStream
 //////////////////////
 
 }
 
 //////////////////////
 // wxZlibOutputStream
 //////////////////////
 

-wxZlibOutputStream::wxZlibOutputStream(wxOutputStream& stream)
+wxZlibOutputStream::wxZlibOutputStream(wxOutputStream& stream, int level)

  : wxFilterOutputStream(stream)
 {
   int err;
  : wxFilterOutputStream(stream)
 {
   int err;


@@ -115,7 +128,10 @@ wxZlibOutputStream::wxZlibOutputStream(wxOutputStream& stream)
   m_deflate->zfree = (free_func)0;
   m_deflate->opaque = (voidpf)0;
 
   m_deflate->zfree = (free_func)0;
   m_deflate->opaque = (voidpf)0;
 

-  err = deflateInit(m_deflate, Z_DEFAULT_COMPRESSION);
+  if (level == -1) level = Z_DEFAULT_COMPRESSION;
+  wxASSERT_MSG(level >= 0 && level <= 9, wxT("wxZlibOutputStream compression level must be between 0 and 9!"));
+
+  err = deflateInit(m_deflate, level);

   if (err != Z_OK) {
     deflateEnd(m_deflate);
     return;
   if (err != Z_OK) {
     deflateEnd(m_deflate);
     return;


@@ -138,11 +154,12 @@ wxZlibOutputStream::~wxZlibOutputStream()
   err = deflate(m_deflate, Z_FINISH);
   if (err != Z_STREAM_END) 
   {
   err = deflate(m_deflate, Z_FINISH);
   if (err != Z_STREAM_END) 
   {

-    wxLogDebug( T("wxZlibOutputStream: an error occured while closing the stream.\n") );
+    wxLogDebug( wxT("wxZlibOutputStream: an error occured while closing the stream.\n") );

     return;
   }
 
   deflateEnd(m_deflate);
     return;
   }
 
   deflateEnd(m_deflate);

+  delete m_deflate;

 
   delete[] m_z_buffer;
 }
 
   delete[] m_z_buffer;
 }