- SetName(name);
- SetValidator(validator);
-
- if (parent) parent->AddChild(this);
-
- SetBackgroundColour(parent->GetBackgroundColour());
- SetForegroundColour(parent->GetForegroundColour());
-
- if ( id == -1 )
- m_windowId = (int)NewControlId();
- else
- m_windowId = id;
-
- int x = pos.x;
- int y = pos.y;
- int width = size.x;
- int height = size.y;
-
- m_windowStyle = style ;
-
- long groupStyle = 0;
- if (m_windowStyle & wxRB_GROUP)
- groupStyle = WS_GROUP;
+ if ( !CreateControl(parent, id, pos, size, style, validator, name) )
+ return FALSE;
+
+ long msStyle = WS_TABSTOP;
+ if ( HasFlag(wxRB_GROUP) )
+ msStyle |= WS_GROUP;
+
+ /*
+ wxRB_SINGLE is a temporary workaround for the following problem: if you
+ have 2 radiobuttons in the same group but which are not consecutive in
+ the dialog, Windows can enter an infinite loop! The simplest way to
+ reproduce it is to create radio button, then a panel and then another
+ radio button: then checking the last button hangs the app.
+
+ Ideally, we'd detect (and avoid) such situation automatically but for
+ now, as I don't know how to do it, just allow the user to create
+ BS_RADIOBUTTON buttons for such situations.
+ */
+ msStyle |= HasFlag(wxRB_SINGLE) ? BS_RADIOBUTTON : BS_AUTORADIOBUTTON;
+
+ if ( HasFlag(wxCLIP_SIBLINGS) )
+ msStyle |= WS_CLIPSIBLINGS;
+
+ if ( !MSWCreateControl(_T("BUTTON"), msStyle, pos, size, label, 0) )
+ return FALSE;
+
+ // for compatibility with wxGTK, the first radio button in a group is
+ // always checked (this makes sense anyhow as you need to ensure that at
+ // least one button in the group is checked and this is the simlpest way to
+ // do it)
+ if ( HasFlag(wxRB_GROUP) )
+ SetValue(TRUE);