fix wxTimeSpan::Format() for negative spans with 0 hour component (#10055)

[wxWidgets.git] / src / common / colourcmn.cpp

diff --git a/src/common/colourcmn.cpp b/src/common/colourcmn.cpp
index 2edc343a4725513c9052f29461c5ec872afeaf77..a03efa79426b683672767b3b882c14d009c49498 100644 (file)
--- a/src/common/colourcmn.cpp
+++ b/src/common/colourcmn.cpp
@@ -39,25 +39,40 @@ bool wxColourBase::FromString(const wxString& str)
     if ( str.empty() )
         return false;       // invalid or empty string
 
     if ( str.empty() )
         return false;       // invalid or empty string
 

-    if ( wxStrncmp(str, wxT("RGB"), 3) == 0 ||
-         wxStrncmp(str, wxT("rgb"), 3) == 0 )
+    if ( wxStrnicmp(str, wxT("RGB"), 3) == 0 )

     {
         // CSS-like RGB specification
     {
         // CSS-like RGB specification

-        // according to http://www.w3.org/TR/REC-CSS2/syndata.html#color-units
+        // according to http://www.w3.org/TR/css3-color/#colorunits

         // values outside 0-255 range are allowed but should be clipped
         // values outside 0-255 range are allowed but should be clipped

-        int red, green, blue;
-        if (wxSscanf(str.substr(3), wxT("(%d, %d, %d)"), &red, &green, &blue) != 3)
-            return false;
-
-        Set((unsigned char)wxClip(red,0,255),
-            (unsigned char)wxClip(green,0,255),
-            (unsigned char)wxClip(blue,0,255));
+        int red, green, blue,
+            alpha = wxALPHA_OPAQUE;
+        if ( str.length() > 3 && (str[3] == wxT('a') || str[3] == wxT('A')) )
+        {
+            float a;
+            // TODO: use locale-independent function
+            if ( wxSscanf(str.wx_str() + 4, wxT("( %d , %d , %d , %f )"),
+                                                &red, &green, &blue, &a) != 4 )
+                return false;
+
+            alpha = wxRound(a * 255);
+        }
+        else // no 'a' following "rgb"
+        {
+            if ( wxSscanf(str.wx_str() + 3, wxT("( %d , %d , %d )"),
+                                                &red, &green, &blue) != 3 )
+                return false;
+        }
+
+        Set((unsigned char)wxClip(red, 0, 255),
+            (unsigned char)wxClip(green, 0, 255),
+            (unsigned char)wxClip(blue, 0, 255),
+            (unsigned char)wxClip(alpha, 0, 255));

     }
     else if ( str[0] == wxT('#') && wxStrlen(str) == 7 )
     {
         // hexadecimal prefixed with # (HTML syntax)
         unsigned long tmp;
     }
     else if ( str[0] == wxT('#') && wxStrlen(str) == 7 )
     {
         // hexadecimal prefixed with # (HTML syntax)
         unsigned long tmp;

-        if (wxSscanf(str.substr(1), wxT("%lx"), &tmp) != 1)
+        if (wxSscanf(str.wx_str() + 1, wxT("%lx"), &tmp) != 1)

             return false;
 
         Set((unsigned char)(tmp >> 16),
             return false;
 
         Set((unsigned char)(tmp >> 16),


@@ -88,23 +103,46 @@ wxString wxColourBase::GetAsString(long flags) const
 {
     wxString colName;
 
 {
     wxString colName;
 

-    if (flags & wxC2S_NAME)
-        colName = wxTheColourDatabase->FindName((const wxColour &)(*this)).MakeLower();
+    const bool isOpaque = Alpha() == wxALPHA_OPAQUE;

 
 

-    if ( colName.empty() && (flags & wxC2S_CSS_SYNTAX) )
+    // we can't use the name format if the colour is not opaque as the alpha
+    // information would be lost
+    if ( (flags & wxC2S_NAME) && isOpaque )

     {
     {

-        // no name for this colour; return it in CSS syntax
-        colName.Printf(wxT("rgb(%d, %d, %d)"),
-                       Red(), Green(), Blue());
+        colName = wxTheColourDatabase->FindName(
+                    static_cast<const wxColour &>(*this)).MakeLower();

     }
     }

-    else if ( colName.empty() && (flags & wxC2S_HTML_SYNTAX) )
+
+    if ( colName.empty() )

     {
     {

-        // no name for this colour; return it in HTML syntax
-        colName.Printf(wxT("#%02X%02X%02X"),
-                       Red(), Green(), Blue());
+        const int red = Red(),
+                  blue = Blue(),
+                  green = Green();
+
+        if ( flags & wxC2S_CSS_SYNTAX )
+        {
+            // no name for this colour; return it in CSS syntax
+            if ( isOpaque )
+            {
+                colName.Printf(wxT("rgb(%d, %d, %d)"), red, green, blue);
+            }
+            else // use rgba() form
+            {
+                // TODO: use locale-independent function
+                colName.Printf(wxT("rgba(%d, %d, %d, %.3f)"),
+                               red, green, blue, Alpha() / 255.);
+            }
+        }
+        else if ( flags & wxC2S_HTML_SYNTAX )
+        {
+            wxASSERT_MSG( isOpaque, "alpha is lost in HTML syntax" );
+
+            // no name for this colour; return it in HTML syntax
+            colName.Printf(wxT("#%02X%02X%02X"), red, green, blue);
+        }

     }
 
     }
 

-    // this function always returns a non-empty string
+    // this function should alway returns a non-empty string

     wxASSERT_MSG(!colName.empty(),
                  wxT("Invalid wxColour -> wxString conversion flags"));
 
     wxASSERT_MSG(!colName.empty(),
                  wxT("Invalid wxColour -> wxString conversion flags"));
 


@@ -125,3 +163,25 @@ void wxColourBase::InitFromName(const wxString& col)
 }
 
 #endif // WXWIN_COMPATIBILITY_2_6
 }
 
 #endif // WXWIN_COMPATIBILITY_2_6

+
+// wxColour <-> wxString utilities, used by wxConfig
+wxString wxToString(const wxColourBase& col)
+{
+    return col.IsOk() ? col.GetAsString(wxC2S_CSS_SYNTAX)
+                      : wxString();
+}
+
+bool wxFromString(const wxString& str, wxColourBase *col)
+{
+    wxCHECK_MSG( col, false, _T("NULL output parameter") );
+
+    if ( str.empty() )
+    {
+        *col = wxNullColour;
+        return true;
+    }
+
+    return col->Set(str);
+}
+
+