no real change; just add the standard separator where it's missing

[wxWidgets.git] / src / generic / dragimgg.cpp

diff --git a/src/generic/dragimgg.cpp b/src/generic/dragimgg.cpp
index cb744af382b1e99e7cba57b9be91b9ee7cd2acb3..31dcc04f7a051620446b53eddea702dd796e2961 100644 (file)
--- a/src/generic/dragimgg.cpp
+++ b/src/generic/dragimgg.cpp
@@ -69,13 +69,13 @@ void wxGenericDragImage::Init()
 {
     m_isDirty = false;
     m_isShown = false;
 {
     m_isDirty = false;
     m_isShown = false;

-    m_windowDC = (wxDC*) NULL;
-    m_window = (wxWindow*) NULL;
+    m_windowDC = NULL;
+    m_window = NULL;

     m_fullScreen = false;
     m_fullScreen = false;

-#if defined(wxMAC_USE_CORE_GRAPHICS) && wxMAC_USE_CORE_GRAPHICS
+#ifdef wxHAS_NATIVE_OVERLAY

     m_dcOverlay = NULL;
 #else
     m_dcOverlay = NULL;
 #else

-    m_pBackingBitmap = (wxBitmap*) NULL;
+    m_pBackingBitmap = NULL;

 #endif
 }
 
 #endif
 }
 


@@ -172,7 +172,7 @@ bool wxGenericDragImage::Create(const wxString& str, const wxCursor& cursor)
 {
     wxFont font(wxSystemSettings::GetFont(wxSYS_DEFAULT_GUI_FONT));
 
 {
     wxFont font(wxSystemSettings::GetFont(wxSYS_DEFAULT_GUI_FONT));
 

-    long w = 0, h = 0;
+    wxCoord w = 0, h = 0;

     wxScreenDC dc;
     dc.SetFont(font);
     dc.GetTextExtent(str, & w, & h);
     wxScreenDC dc;
     dc.SetFont(font);
     dc.GetTextExtent(str, & w, & h);


@@ -187,7 +187,7 @@ bool wxGenericDragImage::Create(const wxString& str, const wxCursor& cursor)
     dc2.SetFont(font);
     dc2.SetBackground(* wxWHITE_BRUSH);
     dc2.Clear();
     dc2.SetFont(font);
     dc2.SetBackground(* wxWHITE_BRUSH);
     dc2.Clear();

-    dc2.SetBackgroundMode(wxTRANSPARENT);
+    dc2.SetBackgroundMode(wxBRUSHSTYLE_TRANSPARENT);

     dc2.SetTextForeground(* wxLIGHT_GREY);
     dc2.DrawText(str, 0, 0);
     dc2.DrawText(str, 1, 0);
     dc2.SetTextForeground(* wxLIGHT_GREY);
     dc2.DrawText(str, 0, 0);
     dc2.DrawText(str, 1, 0);


@@ -236,7 +236,7 @@ bool wxGenericDragImage::BeginDrag(const wxPoint& hotspot,
                                    bool fullScreen,
                                    wxRect* rect)
 {
                                    bool fullScreen,
                                    wxRect* rect)
 {

-    wxASSERT_MSG( (window != 0), wxT("Window must not be null in BeginDrag."));
+    wxCHECK_MSG( window, false, wxT("Window must not be null in BeginDrag."));

 
     // The image should be offset by this amount
     m_offset = hotspot;
 
     // The image should be offset by this amount
     m_offset = hotspot;


@@ -249,17 +249,14 @@ bool wxGenericDragImage::BeginDrag(const wxPoint& hotspot,
     m_isDirty = false;
     m_isDirty = false;
 
     m_isDirty = false;
     m_isDirty = false;
 

-    if (window)
+    if (m_cursor.Ok())

     {
     {

-        window->CaptureMouse();
-
-        if (m_cursor.Ok())
-        {
-            m_oldCursor = window->GetCursor();
-            window->SetCursor(m_cursor);
-        }
+        m_oldCursor = window->GetCursor();
+        window->SetCursor(m_cursor);

     }
 
     }
 

+    window->CaptureMouse();
+

     // Make a copy of the window so we can repair damage done as the image is
     // dragged.
 
     // Make a copy of the window so we can repair damage done as the image is
     // dragged.
 


@@ -288,14 +285,12 @@ bool wxGenericDragImage::BeginDrag(const wxPoint& hotspot,
         }
     }
 
         }
     }
 

-#if defined(wxMAC_USE_CORE_GRAPHICS) && wxMAC_USE_CORE_GRAPHICS
-    // nothing to setup here
-#else
+#ifndef wxHAS_NATIVE_OVERLAY

     wxBitmap* backing = (m_pBackingBitmap ? m_pBackingBitmap : (wxBitmap*) & m_backingBitmap);
 
     if (!backing->Ok() || (backing->GetWidth() < clientSize.x || backing->GetHeight() < clientSize.y))
         (*backing) = wxBitmap(clientSize.x, clientSize.y);
     wxBitmap* backing = (m_pBackingBitmap ? m_pBackingBitmap : (wxBitmap*) & m_backingBitmap);
 
     if (!backing->Ok() || (backing->GetWidth() < clientSize.x || backing->GetHeight() < clientSize.y))
         (*backing) = wxBitmap(clientSize.x, clientSize.y);

-#endif
+#endif // !wxHAS_NATIVE_OVERLAY

 
     if (!m_fullScreen)
     {
 
     if (!m_fullScreen)
     {


@@ -358,18 +353,16 @@ bool wxGenericDragImage::EndDrag()
 
     if (m_windowDC)
     {
 
     if (m_windowDC)
     {

-#if defined(wxMAC_USE_CORE_GRAPHICS) && wxMAC_USE_CORE_GRAPHICS
+#ifdef wxHAS_NATIVE_OVERLAY

         m_overlay.Reset();
 #else
         m_windowDC->DestroyClippingRegion();
 #endif
         delete m_windowDC;
         m_overlay.Reset();
 #else
         m_windowDC->DestroyClippingRegion();
 #endif
         delete m_windowDC;

-        m_windowDC = (wxDC*) NULL;
+        m_windowDC = NULL;

     }
 
     }
 

-#if defined(wxMAC_USE_CORE_GRAPHICS) && wxMAC_USE_CORE_GRAPHICS
-    // nothing to do for overlays
-#else
+#ifndef wxHAS_NATIVE_OVERLAY

     m_repairBitmap = wxNullBitmap;
 #endif
 
     m_repairBitmap = wxNullBitmap;
 #endif
 


@@ -380,7 +373,7 @@ bool wxGenericDragImage::EndDrag()
 // is non-NULL, or in screen coordinates if NULL.
 bool wxGenericDragImage::Move(const wxPoint& pt)
 {
 // is non-NULL, or in screen coordinates if NULL.
 bool wxGenericDragImage::Move(const wxPoint& pt)
 {

-    wxASSERT_MSG( (m_windowDC != (wxDC*) NULL), wxT("No window DC in wxGenericDragImage::Move()") );
+    wxASSERT_MSG( (m_windowDC != NULL), wxT("No window DC in wxGenericDragImage::Move()") );

 
     wxPoint pt2(pt);
     if (m_fullScreen)
 
     wxPoint pt2(pt);
     if (m_fullScreen)


@@ -404,7 +397,7 @@ bool wxGenericDragImage::Move(const wxPoint& pt)
 
 bool wxGenericDragImage::Show()
 {
 
 bool wxGenericDragImage::Show()
 {

-    wxASSERT_MSG( (m_windowDC != (wxDC*) NULL), wxT("No window DC in wxGenericDragImage::Show()") );
+    wxASSERT_MSG( (m_windowDC != NULL), wxT("No window DC in wxGenericDragImage::Show()") );

 
     // Show at the current position
 
 
     // Show at the current position
 


@@ -413,9 +406,7 @@ bool wxGenericDragImage::Show()
         // This is where we restore the backing bitmap, in case
         // something has changed on the window.
 
         // This is where we restore the backing bitmap, in case
         // something has changed on the window.
 

-#if defined(wxMAC_USE_CORE_GRAPHICS) && wxMAC_USE_CORE_GRAPHICS
-        // overlay will be set up in the drawing routine
-#else
+#ifndef wxHAS_NATIVE_OVERLAY

         wxBitmap* backing = (m_pBackingBitmap ? m_pBackingBitmap : (wxBitmap*) & m_backingBitmap);
         wxMemoryDC memDC;
         memDC.SelectObject(* backing);
         wxBitmap* backing = (m_pBackingBitmap ? m_pBackingBitmap : (wxBitmap*) & m_backingBitmap);
         wxMemoryDC memDC;
         memDC.SelectObject(* backing);


@@ -424,7 +415,7 @@ bool wxGenericDragImage::Show()
 
         //memDC.Blit(0, 0, m_boundingRect.width, m_boundingRect.height, m_windowDC, m_boundingRect.x, m_boundingRect.y);
         memDC.SelectObject(wxNullBitmap);
 
         //memDC.Blit(0, 0, m_boundingRect.width, m_boundingRect.height, m_windowDC, m_boundingRect.x, m_boundingRect.y);
         memDC.SelectObject(wxNullBitmap);

-#endif
+#endif // !wxHAS_NATIVE_OVERLAY

 
         RedrawImage(m_position - m_offset, m_position - m_offset, false, true);
     }
 
         RedrawImage(m_position - m_offset, m_position - m_offset, false, true);
     }


@@ -444,7 +435,7 @@ bool wxGenericDragImage::UpdateBackingFromWindow(wxDC& windowDC, wxMemoryDC& des
 
 bool wxGenericDragImage::Hide()
 {
 
 bool wxGenericDragImage::Hide()
 {

-    wxASSERT_MSG( (m_windowDC != (wxDC*) NULL), wxT("No window DC in wxGenericDragImage::Hide()") );
+    wxASSERT_MSG( (m_windowDC != NULL), wxT("No window DC in wxGenericDragImage::Hide()") );

 
     // Repair the old position
 
 
     // Repair the old position
 


@@ -460,19 +451,22 @@ bool wxGenericDragImage::Hide()
 }
 
 // More efficient: erase and redraw simultaneously if possible
 }
 
 // More efficient: erase and redraw simultaneously if possible

-bool wxGenericDragImage::RedrawImage(const wxPoint& oldPos, const wxPoint& newPos,
+bool wxGenericDragImage::RedrawImage(const wxPoint& oldPos,
+                                     const wxPoint& newPos,

                                      bool eraseOld, bool drawNew)
 {
     if (!m_windowDC)
         return false;
 
                                      bool eraseOld, bool drawNew)
 {
     if (!m_windowDC)
         return false;
 

-#if defined(wxMAC_USE_CORE_GRAPHICS) && wxMAC_USE_CORE_GRAPHICS
+#ifdef wxHAS_NATIVE_OVERLAY
+    wxUnusedVar(oldPos);
+

     wxDCOverlay dcoverlay( m_overlay, (wxWindowDC*) m_windowDC ) ;
     if ( eraseOld )
         dcoverlay.Clear() ;
     if (drawNew)
         DoDrawImage(*m_windowDC, newPos);
     wxDCOverlay dcoverlay( m_overlay, (wxWindowDC*) m_windowDC ) ;
     if ( eraseOld )
         dcoverlay.Clear() ;
     if (drawNew)
         DoDrawImage(*m_windowDC, newPos);

-#else
+#else // !wxHAS_NATIVE_OVERLAY

     wxBitmap* backing = (m_pBackingBitmap ? m_pBackingBitmap : (wxBitmap*) & m_backingBitmap);
     if (!backing->Ok())
         return false;
     wxBitmap* backing = (m_pBackingBitmap ? m_pBackingBitmap : (wxBitmap*) & m_backingBitmap);
     if (!backing->Ok())
         return false;


@@ -538,7 +532,8 @@ bool wxGenericDragImage::RedrawImage(const wxPoint& oldPos, const wxPoint& newPo
 
     memDCTemp.SelectObject(wxNullBitmap);
     memDC.SelectObject(wxNullBitmap);
 
     memDCTemp.SelectObject(wxNullBitmap);
     memDC.SelectObject(wxNullBitmap);

-#endif
+#endif // wxHAS_NATIVE_OVERLAY/!wxHAS_NATIVE_OVERLAY
+

     return true;
 }
 
     return true;
 }